[GitHub] [airflow] yash64 commented on issue #9328: unable to install papermill provider

2020-06-17 Thread GitBox
yash64 commented on issue #9328: URL: https://github.com/apache/airflow/issues/9328#issuecomment-645791237 Thanks @mik-laj This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] mik-laj commented on a change in pull request #9170: Read only endpoint for XCom #8134

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9170: URL: https://github.com/apache/airflow/pull/9170#discussion_r441955670 ## File path: tests/api_connexion/endpoints/test_xcom_endpoint.py ## @@ -15,62 +15,254 @@ # specific language governing permissions and limitations #

[GitHub] [airflow] mik-laj commented on a change in pull request #9170: Read only endpoint for XCom #8134

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9170: URL: https://github.com/apache/airflow/pull/9170#discussion_r441954783 ## File path: tests/api_connexion/endpoints/test_xcom_endpoint.py ## @@ -18,59 +18,153 @@ import pytest +from airflow.models import DagRun as DR,

[GitHub] [airflow] mik-laj commented on a change in pull request #9170: Read only endpoint for XCom #8134

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9170: URL: https://github.com/apache/airflow/pull/9170#discussion_r441954880 ## File path: tests/api_connexion/endpoints/test_xcom_endpoint.py ## @@ -15,62 +15,254 @@ # specific language governing permissions and limitations #

[GitHub] [airflow] mik-laj commented on a change in pull request #9170: Read only endpoint for XCom #8134

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9170: URL: https://github.com/apache/airflow/pull/9170#discussion_r441954535 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -26,18 +33,41 @@ def delete_xcom_entry(): raise NotImplementedError("Not

[GitHub] [airflow] mik-laj commented on a change in pull request #9170: Read only endpoint for XCom #8134

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9170: URL: https://github.com/apache/airflow/pull/9170#discussion_r441954292 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -26,18 +33,41 @@ def delete_xcom_entry(): raise NotImplementedError("Not

[GitHub] [airflow] mik-laj commented on a change in pull request #9170: Read only endpoint for XCom #8134

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9170: URL: https://github.com/apache/airflow/pull/9170#discussion_r441954103 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -26,18 +32,35 @@ def delete_xcom_entry(): raise NotImplementedError("Not

[GitHub] [airflow] bhavaniravi opened a new issue #9367: Fetching logs of tasks which are not currently executed with DAGS

2020-06-17 Thread GitBox
bhavaniravi opened a new issue #9367: URL: https://github.com/apache/airflow/issues/9367 **Description** Need a way to access logs of tasks that are executed at a particular instance of time but are not currently a part of the DAG. **Use case / motivation** I have a

[airflow] branch master updated (d8d48c2 -> e2b2198)

2020-06-17 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from d8d48c2 Use more effective count queries in API endpoints (#9361) add e2b2198 implement API v1 for

[GitHub] [airflow] mik-laj closed issue #8133: API Endpoints - Read-only - Variable

2020-06-17 Thread GitBox
mik-laj closed issue #8133: URL: https://github.com/apache/airflow/issues/8133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] mik-laj closed issue #9115: API Endpoint - CRUD - Variable

2020-06-17 Thread GitBox
mik-laj closed issue #9115: URL: https://github.com/apache/airflow/issues/9115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] mik-laj merged pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
mik-laj merged pull request #9273: URL: https://github.com/apache/airflow/pull/9273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] tag nightly-master updated (bbdbe81 -> d8d48c2)

2020-06-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from bbdbe81 (commit) to d8d48c2 (commit) from

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-17 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r441930394 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -15,12 +15,102 @@ # specific language governing permissions and limitations #

[GitHub] [airflow] houqp commented on pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
houqp commented on pull request #9273: URL: https://github.com/apache/airflow/pull/9273#issuecomment-645722927 @mik-laj updated and ready for another round of review This is an automated message from the Apache Git Service.

[GitHub] [airflow] houqp removed a comment on pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
houqp removed a comment on pull request #9273: URL: https://github.com/apache/airflow/pull/9273#issuecomment-645722927 @mik-laj updated and ready for another round of review This is an automated message from the Apache Git

[airflow] branch master updated (8c9a7b2 -> d8d48c2)

2020-06-17 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8c9a7b2 Remove redundant count query in BaseOperator.clear() (#9362) add d8d48c2 Use more effective

[GitHub] [airflow] mik-laj merged pull request #9361: Use more effective count queries in API endpoints

2020-06-17 Thread GitBox
mik-laj merged pull request #9361: URL: https://github.com/apache/airflow/pull/9361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] mik-laj commented on pull request #9365: Use strict API schemas

2020-06-17 Thread GitBox
mik-laj commented on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645722005 @ephraimbuddy Good point. I will do. This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] mik-laj opened a new pull request #9366: Force order in list API endpoints

2020-06-17 Thread GitBox
mik-laj opened a new pull request #9366: URL: https://github.com/apache/airflow/pull/9366 The order of the elements is not guaranteed when the request is not ORDER BY, which may break pagination. --- Make sure to mark the boxes below before creating PR: [x] - [X]

[GitHub] [airflow] ephraimbuddy commented on pull request #9365: Use strict API schemas

2020-06-17 Thread GitBox
ephraimbuddy commented on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645721692 I also suggest we enable strict validation here: airflow/www/extensions/init_views.py. It's currently disabled `specification='v1.yaml', base_path='/api/v1',

[GitHub] [airflow] ephraimbuddy commented on pull request #9338: Get API request limit and offset from parameters.py

2020-06-17 Thread GitBox
ephraimbuddy commented on pull request #9338: URL: https://github.com/apache/airflow/pull/9338#issuecomment-645717641 I didn't have any issue when I added maximum. You should add it immediately after minimum. See https://swagger.io/docs/specification/data-models/data-types/

[GitHub] [airflow] ephraimbuddy commented on pull request #9338: Get API request limit and offset from parameters.py

2020-06-17 Thread GitBox
ephraimbuddy commented on pull request #9338: URL: https://github.com/apache/airflow/pull/9338#issuecomment-645715798 The 400 for the limit=0 LGTM. I will investigate now for the maximum This is an automated message from the

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r441918574 ## File path: airflow/api_connexion/endpoints/variable_endpoint.py ## @@ -14,41 +14,83 @@ # KIND, either express or implied. See the License for the #

[GitHub] [airflow] ephraimbuddy commented on pull request #9365: Use strict API schemas

2020-06-17 Thread GitBox
ephraimbuddy commented on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645713975 Nice! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r441916241 ## File path: airflow/www/extensions/init_views.py ## @@ -92,15 +93,16 @@ def init_error_handlers(app: Flask): app.register_error_handler(404,

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r441915601 ## File path: tests/api_connexion/endpoints/test_variable_endpoint.py ## @@ -29,38 +31,142 @@ def setUpClass(cls) -> None: def setUp(self) ->

[GitHub] [airflow] mik-laj opened a new pull request #9365: Use strict API schemas

2020-06-17 Thread GitBox
mik-laj opened a new pull request #9365: URL: https://github.com/apache/airflow/pull/9365 The rules are already verified by connexion, but it's still worth forcing some unexpected errors to not be accidentally ignored. ``` :param bool strict: If `True`, raise errors if

[GitHub] [airflow] FlavSF opened a new pull request #9364: Add option for Vault token to automatically be renewed

2020-06-17 Thread GitBox
FlavSF opened a new pull request #9364: URL: https://github.com/apache/airflow/pull/9364 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9364: Add option for Vault token to automatically be renewed

2020-06-17 Thread GitBox
boring-cyborg[bot] commented on pull request #9364: URL: https://github.com/apache/airflow/pull/9364#issuecomment-645703994 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] samuelkhtu commented on issue #9339: get_sqlalchemy_engine from MsSqlHook return engine with pyodbc by default

2020-06-17 Thread GitBox
samuelkhtu commented on issue #9339: URL: https://github.com/apache/airflow/issues/9339#issuecomment-645702808 Since the mssql hook will be deprecated in Airflow 2.0, maybe you want to give the ODBC hook a try? The pyodbc is part of the import. airflow/providers/odbc/hooks/odbc.py

[GitHub] [airflow] kanga333 commented on a change in pull request #9350: Add deletion by prefix to S3DeleteObjectsOperator

2020-06-17 Thread GitBox
kanga333 commented on a change in pull request #9350: URL: https://github.com/apache/airflow/pull/9350#discussion_r441908403 ## File path: airflow/providers/amazon/aws/operators/s3_delete_objects.py ## @@ -56,22 +59,34 @@ class S3DeleteObjectsOperator(BaseOperator): :type

[airflow] branch v1-10-test updated (5e16a12 -> 2d83e77)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. from 5e16a12 Fix KubernetesPodOperator pod name length validation (#8829) new a5434ba Fix awkward log info

[airflow] 04/04: Fix migration message (#8988)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 2d83e7734f4f550592a7f84e252610ce7fcecf65 Author: larluo AuthorDate: Sun May 24 03:21:08 2020 +0800 Fix

[airflow] 02/04: Fix performance degradation when updating dagrun state (#8435)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 354b58eb025673da1a15f429813d6721e534ca7b Author: Daniel Frank AuthorDate: Sat Apr 18 11:58:37 2020 -0700

[airflow] 03/04: Correctly deserialize dagrun_timeout field on DAGs (#8735)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit ddbb15d80c61486b450a51263b67c0c4413251c0 Author: Ash Berlin-Taylor AuthorDate: Wed May 6 18:33:06 2020 +0100

[airflow] 01/04: Fix awkward log info in dbapi_hook (#8482)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit a5434ba42e93b579d5ea9b9e59b3744bfaadf97c Author: Hao Liang AuthorDate: Tue Apr 21 19:50:25 2020 +0800 Fix

[airflow] branch master updated: Remove redundant count query in BaseOperator.clear() (#9362)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 8c9a7b2 Remove redundant count query in

[GitHub] [airflow] casassg commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-06-17 Thread GitBox
casassg commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r441908260 ## File path: docs/concepts.rst ## @@ -116,6 +116,46 @@ DAGs can be used as context managers to automatically assign new operators to th op.dag

[GitHub] [airflow] kaxil merged pull request #9362: Remove redundant count query in BaseOperator.clear()

2020-06-17 Thread GitBox
kaxil merged pull request #9362: URL: https://github.com/apache/airflow/pull/9362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kanga333 commented on a change in pull request #9350: Add deletion by prefix to S3DeleteObjectsOperator

2020-06-17 Thread GitBox
kanga333 commented on a change in pull request #9350: URL: https://github.com/apache/airflow/pull/9350#discussion_r441908023 ## File path: airflow/providers/amazon/aws/operators/s3_delete_objects.py ## @@ -56,22 +59,34 @@ class S3DeleteObjectsOperator(BaseOperator): :type

[GitHub] [airflow] kanga333 commented on a change in pull request #9350: Add deletion by prefix to S3DeleteObjectsOperator

2020-06-17 Thread GitBox
kanga333 commented on a change in pull request #9350: URL: https://github.com/apache/airflow/pull/9350#discussion_r441907977 ## File path: airflow/providers/amazon/aws/operators/s3_delete_objects.py ## @@ -56,22 +59,34 @@ class S3DeleteObjectsOperator(BaseOperator): :type

[GitHub] [airflow] kaxil opened a new pull request #9363: Use 'airflow.task' Logger for LocalTaskJob

2020-06-17 Thread GitBox
kaxil opened a new pull request #9363: URL: https://github.com/apache/airflow/pull/9363 This is to fix duplicate log lines in Task logs: Previous: ``` [2020-06-17 13:45:03,708] {taskinstance.py:1115} INFO - Marking task as SUCCESS.dag_id=example_bash_operator, task_id=runme_2,

[GitHub] [airflow] kaxil opened a new pull request #9362: Remove redundant count query in BaseOperator.clear()

2020-06-17 Thread GitBox
kaxil opened a new pull request #9362: URL: https://github.com/apache/airflow/pull/9362 We already fetch the results using `qry.all()` so running `qry.count()` is just redundant. --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides

[GitHub] [airflow] houqp commented on a change in pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
houqp commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r441892187 ## File path: tests/api_connexion/endpoints/test_variable_endpoint.py ## @@ -29,38 +31,142 @@ def setUpClass(cls) -> None: def setUp(self) -> None:

[GitHub] [airflow] kaxil merged pull request #9360: Fix Airflow Stable version in README.md

2020-06-17 Thread GitBox
kaxil merged pull request #9360: URL: https://github.com/apache/airflow/pull/9360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated (ba9007e -> 8622c13)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from ba9007e Add 'helm-chart' label for PRs touching Airflow Helm Chart (#9359) add 8622c13 Fix Airflow

[airflow] branch master updated (281095e -> ba9007e)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 281095e Fix failing tests from #9124 (#9356) add ba9007e Add 'helm-chart' label for PRs touching Airflow

[GitHub] [airflow] kaxil merged pull request #9359: Add 'helm-chart' label for PRs touching Airflow Helm Chart

2020-06-17 Thread GitBox
kaxil merged pull request #9359: URL: https://github.com/apache/airflow/pull/9359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil opened a new pull request #9360: Fix Airflow Stable version in README.md

2020-06-17 Thread GitBox
kaxil opened a new pull request #9360: URL: https://github.com/apache/airflow/pull/9360 The current stable version is 1.10.10 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage

[GitHub] [airflow] mik-laj opened a new pull request #9361: Use more effective count queries in API endpoints

2020-06-17 Thread GitBox
mik-laj opened a new pull request #9361: URL: https://github.com/apache/airflow/pull/9361 --- Make sure to mark the boxes below before creating PR: [x] - [X] Description above provides context of the change - [X] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] kaxil opened a new pull request #9359: Add 'helm-chart' label for PRs touching Airflow Helm Chart

2020-06-17 Thread GitBox
kaxil opened a new pull request #9359: URL: https://github.com/apache/airflow/pull/9359 Add 'helm-chart' label for PRs touching Airflow Helm Chart --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x]

[GitHub] [airflow] mik-laj closed issue #9251: DAG run with {"\"": ""} configuration breaks tree view

2020-06-17 Thread GitBox
mik-laj closed issue #9251: URL: https://github.com/apache/airflow/issues/9251 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] mik-laj commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-17 Thread GitBox
mik-laj commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645673472 @ivan-afonichkin Fix has been merged to master. Can you do a rebase? This is an automated message from the

[GitHub] [airflow] marclamberti commented on pull request #8777: Add Production Helm chart support

2020-06-17 Thread GitBox
marclamberti commented on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645671363 Awesome! Time to use the official chart  This is an automated message from the Apache Git Service. To

[airflow] branch master updated (66e7382 -> 281095e)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 66e7382 Add Production Helm chart support (#8777) add 281095e Fix failing tests from #9124 (#9356) No

[GitHub] [airflow] kaxil merged pull request #9356: Fix failing tests from #9124

2020-06-17 Thread GitBox
kaxil merged pull request #9356: URL: https://github.com/apache/airflow/pull/9356 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] Udit107710 opened a new pull request #9358: Tests for AWS Athena

2020-06-17 Thread GitBox
Udit107710 opened a new pull request #9358: URL: https://github.com/apache/airflow/pull/9358 This was created to address one of the files mentioned by #8278. --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change

[GitHub] [airflow] svetli-n commented on pull request #9338: Get API request limit and offset from parameters.py

2020-06-17 Thread GitBox
svetli-n commented on pull request #9338: URL: https://github.com/apache/airflow/pull/9338#issuecomment-645665732 @mik-laj @ephraimbuddy setting `maximum: 100` for `PageLimit` results in validation error and `response.status_code == 400` when `/api/v1/connections?limit=150` and

[GitHub] [airflow] kaxil commented on pull request #8777: Add Production Helm chart support

2020-06-17 Thread GitBox
kaxil commented on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645665693 Big thanks to @schnie  This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil edited a comment on pull request #8777: Add Production Helm chart support

2020-06-17 Thread GitBox
kaxil edited a comment on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645662773 Thank you all for the comments and discussions. PRs are now welcome to make any changes to existing code or add new features.

[GitHub] [airflow] kaxil commented on pull request #8777: Add Production Helm chart support

2020-06-17 Thread GitBox
kaxil commented on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645662773 Thank you all for the comments and discussions. PRs are now welcome to make any changes to existing code that were suggested or add new features.

[airflow] branch master updated (6a9c436 -> 66e7382)

2020-06-17 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6a9c436 Move out metastore_browser from airflow.contrib (#9341) add 66e7382 Add Production Helm chart

[GitHub] [airflow] kaxil merged pull request #8777: Add Production Helm chart support

2020-06-17 Thread GitBox
kaxil merged pull request #8777: URL: https://github.com/apache/airflow/pull/8777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] Udit107710 closed pull request #9357: Improve code coverage by adding tests for AWS Athena Hook

2020-06-17 Thread GitBox
Udit107710 closed pull request #9357: URL: https://github.com/apache/airflow/pull/9357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] mik-laj commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-17 Thread GitBox
mik-laj commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645656570 @kaxil you self-requested a review 3 days ago. Would you like to add something here? This is an automated

[GitHub] [airflow] Udit107710 opened a new pull request #9357: Improve code coverage by adding tests for AWS Athena Hook

2020-06-17 Thread GitBox
Udit107710 opened a new pull request #9357: URL: https://github.com/apache/airflow/pull/9357 Addresses one of the files in issue #8278 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests

[GitHub] [airflow] Udit107710 closed pull request #9353: Improve code coverage by adding tests for AWS Athena Hook

2020-06-17 Thread GitBox
Udit107710 closed pull request #9353: URL: https://github.com/apache/airflow/pull/9353 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] mik-laj opened a new pull request #9356: Fxi failing from #9124

2020-06-17 Thread GitBox
mik-laj opened a new pull request #9356: URL: https://github.com/apache/airflow/pull/9356 The #9124 has failing tests ``` FAILED tests/test_core_to_contrib.py::TestMovingCoreToContrib::test_is_class_deprecated_100_airflow_operators_check_operator_CheckOperator FAILED

[GitHub] [airflow] leahecole commented on issue #9351: Consider renaming master branch to something less offensive

2020-06-17 Thread GitBox
leahecole commented on issue #9351: URL: https://github.com/apache/airflow/issues/9351#issuecomment-645652241 develop or main seem great to me, and if develop makes more sense with Airflow, seems like a great idea to me :)

[GitHub] [airflow] mdediana commented on a change in pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox
mdediana commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441859257 ## File path: airflow/www/views.py ## @@ -1363,6 +1374,14 @@ def success(self): confirmed, upstream,

[GitHub] [airflow] mik-laj commented on pull request #9124: Merging multiple sql operators

2020-06-17 Thread GitBox
mik-laj commented on pull request #9124: URL: https://github.com/apache/airflow/pull/9124#issuecomment-645648971 @kaxil I working on it now. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mdediana commented on a change in pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox
mdediana commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441857809 ## File path: airflow/utils/log/logging_mixin.py ## @@ -58,6 +58,20 @@ def _set_context(self, context): set_context(self.log, context)

[GitHub] [airflow] kaxil commented on pull request #9124: Merging multiple sql operators

2020-06-17 Thread GitBox
kaxil commented on pull request #9124: URL: https://github.com/apache/airflow/pull/9124#issuecomment-645647842 ``` FAILED tests/test_core_to_contrib.py::TestMovingCoreToContrib::test_is_class_deprecated_100_airflow_operators_check_operator_CheckOperator FAILED

[GitHub] [airflow] kaxil commented on pull request #9124: Merging multiple sql operators

2020-06-17 Thread GitBox
kaxil commented on pull request #9124: URL: https://github.com/apache/airflow/pull/9124#issuecomment-645647182 This PR has failing tests This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] mik-laj opened a new pull request #9355: Move out sendgrid email from airflow.contrib

2020-06-17 Thread GitBox
mik-laj opened a new pull request #9355: URL: https://github.com/apache/airflow/pull/9355 --- Make sure to mark the boxes below before creating PR: [x] - [X] Description above provides context of the change - [X] Unit tests coverage for changes (not needed for documentation

[GitHub] [airflow] mik-laj commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-17 Thread GitBox
mik-laj commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645646207 @ivan-afonichkin It looks like one of the changes that I merged had a defect. I'm already looking at it. This

[GitHub] [airflow] prinkov commented on issue #9339: get_sqlalchemy_engine from MsSqlHook return engine with pyodbc by default

2020-06-17 Thread GitBox
prinkov commented on issue #9339: URL: https://github.com/apache/airflow/issues/9339#issuecomment-645645641 > I thought pyodbc is part of Airflow's requirements? pyodbc should already be installed right? As I understand it, in SQLAlchemy it is by default.

[GitHub] [airflow] prinkov edited a comment on issue #9339: get_sqlalchemy_engine from MsSqlHook return engine with pyodbc by default

2020-06-17 Thread GitBox
prinkov edited a comment on issue #9339: URL: https://github.com/apache/airflow/issues/9339#issuecomment-645645641 > If I understand correctly, pymssql is going away and no longer supported. That's why the operator is switched to pyodbc. As I understand it, in SQLAlchemy it is by

[GitHub] [airflow] mik-laj commented on pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox
mik-laj commented on pull request #9354: URL: https://github.com/apache/airflow/pull/9354#issuecomment-645643685 Thank you very much. A very useful change. I look forward to further work results. This is an automated

[GitHub] [airflow] samuelkhtu commented on issue #9339: get_sqlalchemy_engine from MsSqlHook return engine with pyodbc by default

2020-06-17 Thread GitBox
samuelkhtu commented on issue #9339: URL: https://github.com/apache/airflow/issues/9339#issuecomment-645643634 If I understand correctly, pymssql is going away and no longer supported. That's why the operator is switched to pyodbc.

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441851779 ## File path: airflow/www/views.py ## @@ -1363,6 +1374,14 @@ def success(self): confirmed, upstream,

[GitHub] [airflow] ivan-afonichkin commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-17 Thread GitBox
ivan-afonichkin commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645641041 Hey @mik-laj, `CI Build / Build docs` has finally passed, but some databases checks failed with no apparent reason to me, any idea what could be wrong there?

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441850813 ## File path: airflow/www/templates/airflow/dag.html ## @@ -366,9 +366,9 @@ var task_id = ''; var execution_date = ''; var subdag_id =

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441850197 ## File path: airflow/utils/log/logging_mixin.py ## @@ -58,6 +58,20 @@ def _set_context(self, context): set_context(self.log, context)

[GitHub] [airflow] mik-laj commented on a change in pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9354: URL: https://github.com/apache/airflow/pull/9354#discussion_r441849111 ## File path: airflow/utils/log/logging_mixin.py ## @@ -58,6 +58,20 @@ def _set_context(self, context): set_context(self.log, context)

[GitHub] [airflow] prinkov commented on issue #9339: get_sqlalchemy_engine from MsSqlHook return engine with pyodbc by default

2020-06-17 Thread GitBox
prinkov commented on issue #9339: URL: https://github.com/apache/airflow/issues/9339#issuecomment-645638008 > I thought pyodbc is part of Airflow's requirements? pyodbc should already be installed right? > https://github.com/apache/airflow/tree/master/requirements Hmm, if I

[GitHub] [airflow] samuelkhtu commented on issue #9339: get_sqlalchemy_engine from MsSqlHook return engine with pyodbc by default

2020-06-17 Thread GitBox
samuelkhtu commented on issue #9339: URL: https://github.com/apache/airflow/issues/9339#issuecomment-645628588 I thought pyodbc is part of Airflow's requirements? pyodbc should already be installed right? https://github.com/apache/airflow/tree/master/requirements

[GitHub] [airflow] mik-laj commented on pull request #9338: Get API request limit and offset from parameters.py

2020-06-17 Thread GitBox
mik-laj commented on pull request #9338: URL: https://github.com/apache/airflow/pull/9338#issuecomment-645624171 > Is it something worth considering? I think that in the first version of the API we can choose the simplest solution - offset and limit. I analyzed different solutions,

[GitHub] [airflow] mdediana commented on pull request #9125: Add tests for Elasticsearch logs

2020-06-17 Thread GitBox
mdediana commented on pull request #9125: URL: https://github.com/apache/airflow/pull/9125#issuecomment-645622555 PR #9354 replaces this one. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mdediana closed pull request #9125: Add tests for Elasticsearch logs

2020-06-17 Thread GitBox
mdediana closed pull request #9125: URL: https://github.com/apache/airflow/pull/9125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] mdediana opened a new pull request #9354: Task logging handlers can provide custom log links

2020-06-17 Thread GitBox
mdediana opened a new pull request #9354: URL: https://github.com/apache/airflow/pull/9354 Airflow provides logging handlers that send logs to external services (Elasticsearch, StackDriver, etc). At the moment, if Elasticsearch is in use, links to its logs show up in the UI. This PR

[GitHub] [airflow] ephraimbuddy commented on pull request #9295: added mssql to oracle transfer operator

2020-06-17 Thread GitBox
ephraimbuddy commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-645617767 Check other operators in provider package and see how they are named, just remove the transfer appended to it. I suggest to put the operator in

[GitHub] [airflow] svetli-n commented on pull request #9338: Get API request limit and offset from parameters.py

2020-06-17 Thread GitBox
svetli-n commented on pull request #9338: URL: https://github.com/apache/airflow/pull/9338#issuecomment-645615589 There are also other pagination options: https://nordicapis.com/everything-you-need-to-know-about-api-pagination Is it something worth considering?

[GitHub] [airflow] svetli-n commented on pull request #9338: Get API request limit and offset from parameters.py

2020-06-17 Thread GitBox
svetli-n commented on pull request #9338: URL: https://github.com/apache/airflow/pull/9338#issuecomment-645614757 If you are interested in supporting fetching large number of results, may be we can get inspiration from

[GitHub] [airflow] svetli-n commented on pull request #9338: Get API request limit and offset from parameters.py

2020-06-17 Thread GitBox
svetli-n commented on pull request #9338: URL: https://github.com/apache/airflow/pull/9338#issuecomment-645613404 Yes, those were my thoughts as well (and DOS happens also often by mistake, e.g. typo or bug). I could set max 100 in v1.yaml to avoid all that if no one objects.

[GitHub] [airflow] Udit107710 opened a new pull request #9353: Improve code coverage by adding tests for AWS Athena Hook

2020-06-17 Thread GitBox
Udit107710 opened a new pull request #9353: URL: https://github.com/apache/airflow/pull/9353 Addresses one of the files in issue #8278 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests

[GitHub] [airflow] ephraimbuddy commented on pull request #9295: added mssql to oracle transfer operator

2020-06-17 Thread GitBox
ephraimbuddy commented on pull request #9295: URL: https://github.com/apache/airflow/pull/9295#issuecomment-645605008 Hi @jkbngl. Sorry, I didn't notice the location of your operator before now. We no longer have operator in `contrib` package. Please check the `providers` package and

[GitHub] [airflow] mik-laj commented on a change in pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9290: URL: https://github.com/apache/airflow/pull/9290#discussion_r441810628 ## File path: docs/build ## @@ -127,6 +129,88 @@ def display_errors_summary() -> None: print("=" * 50) +def

[jira] [Commented] (AIRFLOW-6251) add config for max tasks per dag to prevent scheduler denial of service

2020-06-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17138774#comment-17138774 ] ASF GitHub Bot commented on AIRFLOW-6251: - tooptoop4 commented on pull request #7157: URL:

  1   2   3   >