[GitHub] [airflow] prinkov commented on issue #9339: get_sqlalchemy_engine from MsSqlHook return engine with pyodbc by default

2020-06-18 Thread GitBox
prinkov commented on issue #9339: URL: https://github.com/apache/airflow/issues/9339#issuecomment-645824878 > Since the mssql hook will be deprecated in Airflow 2.0, maybe you want to give the ODBC hook a try? The pyodbc is part of the import. > > airflow/providers/odbc/hooks/odbc.py

[GitHub] [airflow] potiuk opened a new pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk opened a new pull request #9368: URL: https://github.com/apache/airflow/pull/9368 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation chang

[GitHub] [airflow] potiuk commented on pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk commented on pull request #9368: URL: https://github.com/apache/airflow/pull/9368#issuecomment-645833163 @ashb and @kaxil - I'd love to get that one and the #8974 to be included in the first release of backports. I implemented the GCP Secret Manager Hook following what we agreed wi

[GitHub] [airflow] OmairK commented on a change in pull request #9329: Pool CRUD Endpoints

2020-06-18 Thread GitBox
OmairK commented on a change in pull request #9329: URL: https://github.com/apache/airflow/pull/9329#discussion_r442027426 ## File path: airflow/api_connexion/endpoints/pool_endpoint.py ## @@ -14,20 +14,28 @@ # KIND, either express or implied. See the License for the # speci

[GitHub] [airflow] turbaszek commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
turbaszek commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442028203 ## File path: tests/providers/google/cloud/_internal_client/tests_secret_manager_client.py ## @@ -0,0 +1,99 @@ +# pylint: disable=no-member +# Licensed

[GitHub] [airflow] turbaszek commented on a change in pull request #8962: [AIRFLOW-8057] [AIP-31] Add @task decorator

2020-06-18 Thread GitBox
turbaszek commented on a change in pull request #8962: URL: https://github.com/apache/airflow/pull/8962#discussion_r442038382 ## File path: docs/concepts.rst ## @@ -116,6 +116,46 @@ DAGs can be used as context managers to automatically assign new operators to th op.dag

[GitHub] [airflow] ivan-afonichkin commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-18 Thread GitBox
ivan-afonichkin commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645849474 Hey @mik-laj it seems all checks have passed, thanks for your change! :) Can we merge this PR? This i

[GitHub] [airflow] turbaszek commented on pull request #9369: Add info about BaseOperatorMeta to UPDATING.md

2020-06-18 Thread GitBox
turbaszek commented on pull request #9369: URL: https://github.com/apache/airflow/pull/9369#issuecomment-645853294 This should be part of #8805 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] turbaszek opened a new pull request #9369: Add info about BaseOperatorMeta to UPDATING.md

2020-06-18 Thread GitBox
turbaszek opened a new pull request #9369: URL: https://github.com/apache/airflow/pull/9369 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation ch

[GitHub] [airflow] potiuk opened a new pull request #9370: Prepare backport release candidate for 2020.06.23rc1

2020-06-18 Thread GitBox
potiuk opened a new pull request #9370: URL: https://github.com/apache/airflow/pull/9370 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation chang

[GitHub] [airflow] aneesh-joseph opened a new pull request #9371: Add git sync option to the Helm chart

2020-06-18 Thread GitBox
aneesh-joseph opened a new pull request #9371: URL: https://github.com/apache/airflow/pull/9371 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentatio

[GitHub] [airflow] turbaszek commented on a change in pull request #9370: Prepare backport release candidate for 2020.6.23rc1

2020-06-18 Thread GitBox
turbaszek commented on a change in pull request #9370: URL: https://github.com/apache/airflow/pull/9370#discussion_r442071534 ## File path: airflow/providers/amazon/README.md ## @@ -95,7 +95,7 @@ pip install apache-airflow-backport-providers-amazon[apache.hive] | [apache-air

[GitHub] [airflow] turbaszek commented on a change in pull request #9370: Prepare backport release candidate for 2020.6.23rc1

2020-06-18 Thread GitBox
turbaszek commented on a change in pull request #9370: URL: https://github.com/apache/airflow/pull/9370#discussion_r442071534 ## File path: airflow/providers/amazon/README.md ## @@ -95,7 +95,7 @@ pip install apache-airflow-backport-providers-amazon[apache.hive] | [apache-air

[GitHub] [airflow] potiuk commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442071856 ## File path: tests/providers/google/cloud/_internal_client/tests_secret_manager_client.py ## @@ -0,0 +1,99 @@ +# pylint: disable=no-member +# Licensed to

[GitHub] [airflow] ashb commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
ashb commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442076538 ## File path: airflow/providers/google/cloud/secrets/secret_manager.py ## @@ -134,23 +131,12 @@ def get_variable(self, key: str) -> Optional[str]: def

[GitHub] [airflow] mikaelfr commented on a change in pull request #9204: Add filtering tasks/task instances by tags

2020-06-18 Thread GitBox
mikaelfr commented on a change in pull request #9204: URL: https://github.com/apache/airflow/pull/9204#discussion_r442088796 ## File path: airflow/models/baseoperator.py ## @@ -243,6 +243,8 @@ class derived from this one results in the creation of a task object, :param do

[GitHub] [airflow] potiuk commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442091612 ## File path: airflow/providers/google/PROVIDERS_CHANGES_2020.05.20.md ## @@ -87,7 +87,7 @@ | [01f99426f](https://github.com/apache/airflow/commit/01f994

[GitHub] [airflow] potiuk commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442092323 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -172,3 +173,29 @@ def grant_bucket_access(cls, bucket: str, account_email: str):

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-18 Thread GitBox
boring-cyborg[bot] commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645902207 Awesome work, congrats on your first merged pull request! This is an automated message from the A

[GitHub] [airflow] mik-laj merged pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-18 Thread GitBox
mik-laj merged pull request #9290: URL: https://github.com/apache/airflow/pull/9290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated (e2b2198 -> 40bf8f2)

2020-06-18 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e2b2198 implement API v1 for variables (#9273) add 40bf8f2 Detect automatically the lack of reference t

[airflow] branch master updated (e2b2198 -> 40bf8f2)

2020-06-18 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e2b2198 implement API v1 for variables (#9273) add 40bf8f2 Detect automatically the lack of reference t

[GitHub] [airflow] ashb commented on pull request #9358: Tests for AWS Athena

2020-06-18 Thread GitBox
ashb commented on pull request #9358: URL: https://github.com/apache/airflow/pull/9358#issuecomment-645904767 This would run the tests against an actual Athena instance, which isn't what we want in our unit tests. Please look at https://github.com/spulec/moto (already used in other t

[GitHub] [airflow] ashb edited a comment on pull request #9358: Tests for AWS Athena

2020-06-18 Thread GitBox
ashb edited a comment on pull request #9358: URL: https://github.com/apache/airflow/pull/9358#issuecomment-645904767 This would run the tests against an actual Athena instance, which isn't what we want in our unit tests. Please look at https://github.com/spulec/moto (already used in

[GitHub] [airflow] mikaelfr commented on a change in pull request #9204: Add filtering tasks/task instances by tags

2020-06-18 Thread GitBox
mikaelfr commented on a change in pull request #9204: URL: https://github.com/apache/airflow/pull/9204#discussion_r442101482 ## File path: airflow/example_dags/example_task_tags.py ## @@ -0,0 +1,63 @@ +# Review comment: Fixed in 8c67348 ## File path: docs/howto

[airflow] branch master updated (40bf8f2 -> c3a6684)

2020-06-18 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 40bf8f2 Detect automatically the lack of reference to the guide in the operator descriptions (#9290) ad

[GitHub] [airflow] mik-laj merged pull request #9366: Force order in list API endpoints

2020-06-18 Thread GitBox
mik-laj merged pull request #9366: URL: https://github.com/apache/airflow/pull/9366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] mik-laj commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-18 Thread GitBox
mik-laj commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645913488 @ivan-afonichkin Thank you for a great contribution. This will make our work much easier, because documentation reviews will be easier. What are your plans for the next change?

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442110256 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -14,13 +14,99 @@ # KIND, either express or implied. See the License for the #

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442112186 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -15,12 +15,102 @@ # specific language governing permissions and limitations # u

[GitHub] [airflow] ivan-afonichkin commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-18 Thread GitBox
ivan-afonichkin commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645917765 @mik-laj Thanks a lot, very glad it was merged, and thanks a lot for all the help and support! Regarding the next change, I didn't choose an issue yet, but maybe you

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442115447 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -15,12 +15,102 @@ # specific language governing permissions and limitations # u

[GitHub] [airflow] prinkov closed issue #9339: get_sqlalchemy_engine from MsSqlHook return engine with pyodbc by default

2020-06-18 Thread GitBox
prinkov closed issue #9339: URL: https://github.com/apache/airflow/issues/9339 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442118043 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -15,12 +15,102 @@ # specific language governing permissions and limitations # u

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442118043 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -15,12 +15,102 @@ # specific language governing permissions and limitations # u

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442118043 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -15,12 +15,102 @@ # specific language governing permissions and limitations # u

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442118043 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -15,12 +15,102 @@ # specific language governing permissions and limitations # u

[GitHub] [airflow] Marloxo opened a new issue #9372: Extend Default Sensitive Variable Fields

2020-06-18 Thread GitBox
Marloxo opened a new issue #9372: URL: https://github.com/apache/airflow/issues/9372 **Description** Sensitive variable fields list [here](https://github.com/apache/airflow/blob/master/airflow/www/utils.py#L42) could be extended to be more flexible to include more options.

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9372: Extend Default Sensitive Variable Fields

2020-06-18 Thread GitBox
boring-cyborg[bot] commented on issue #9372: URL: https://github.com/apache/airflow/issues/9372#issuecomment-645927175 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] mik-laj closed issue #9202: `sudo kill` called with invalid signal

2020-06-18 Thread GitBox
mik-laj closed issue #9202: URL: https://github.com/apache/airflow/issues/9202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442125343 ## File path: airflow/api_connexion/endpoints/log_endpoint.py ## @@ -15,12 +15,102 @@ # specific language governing permissions and limitations # u

[GitHub] [airflow] mik-laj commented on pull request #9290: Detect automatically the lack of reference to the guide in the operator descriptions

2020-06-18 Thread GitBox
mik-laj commented on pull request #9290: URL: https://github.com/apache/airflow/pull/9290#issuecomment-645928949 @mik-laj Your experience with AST would probably be helpful with this ticket, but we still need to do a few things before we can implement it. https://github.com/apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #9370: Prepare backport release candidate for 2020.6.23rc1

2020-06-18 Thread GitBox
potiuk commented on a change in pull request #9370: URL: https://github.com/apache/airflow/pull/9370#discussion_r442126446 ## File path: airflow/providers/amazon/README.md ## @@ -95,7 +95,7 @@ pip install apache-airflow-backport-providers-amazon[apache.hive] | [apache-airflo

[GitHub] [airflow] potiuk commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442128527 ## File path: airflow/providers/google/PROVIDERS_CHANGES_2020.05.20.md ## @@ -87,7 +87,7 @@ | [01f99426f](https://github.com/apache/airflow/commit/01f994

[jira] [Commented] (AIRFLOW-6648) Timeout Feature - Provided statistical solution to long running/stuck jobs and take appropriate actions

2020-06-18 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139294#comment-17139294 ] Kamil Bregula commented on AIRFLOW-6648: Only people with write access to the r

[GitHub] [airflow] mik-laj commented on a change in pull request #9322: DAG Source endpoint

2020-06-18 Thread GitBox
mik-laj commented on a change in pull request #9322: URL: https://github.com/apache/airflow/pull/9322#discussion_r442133045 ## File path: airflow/api_connexion/endpoints/dag_source_endpoint.py ## @@ -14,13 +14,35 @@ # KIND, either express or implied. See the License for the

[GitHub] [airflow] potiuk commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442133536 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -172,3 +173,29 @@ def grant_bucket_access(cls, bucket: str, account_email: str):

[GitHub] [airflow] mik-laj commented on a change in pull request #9322: DAG Source endpoint

2020-06-18 Thread GitBox
mik-laj commented on a change in pull request #9322: URL: https://github.com/apache/airflow/pull/9322#discussion_r442133742 ## File path: airflow/api_connexion/endpoints/dag_source_endpoint.py ## @@ -14,13 +14,35 @@ # KIND, either express or implied. See the License for the

[GitHub] [airflow] potiuk commented on pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk commented on pull request #9368: URL: https://github.com/apache/airflow/pull/9368#issuecomment-645935758 All fixed @ashb This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] mik-laj commented on a change in pull request #9322: DAG Source endpoint

2020-06-18 Thread GitBox
mik-laj commented on a change in pull request #9322: URL: https://github.com/apache/airflow/pull/9322#discussion_r442133559 ## File path: airflow/api_connexion/endpoints/dag_source_endpoint.py ## @@ -14,13 +14,35 @@ # KIND, either express or implied. See the License for the

[jira] [Resolved] (AIRFLOW-7028) Remove java from inside CI image

2020-06-18 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-7028. Resolution: Fixed Done now. > Remove java from inside CI image > ---

[jira] [Closed] (AIRFLOW-5719) Adding Knative Executor support to Airflow

2020-06-18 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-5719. -- Resolution: Won't Fix Decided agsinst Knative as it's not a good fit for Airflow's lo

[GitHub] [airflow] mik-laj commented on a change in pull request #9322: DAG Source endpoint

2020-06-18 Thread GitBox
mik-laj commented on a change in pull request #9322: URL: https://github.com/apache/airflow/pull/9322#discussion_r442134378 ## File path: tests/api_connexion/endpoints/test_dag_source_endpoint.py ## @@ -40,7 +49,43 @@ def setUpClass(cls) -> None: def setUp(self) -> None:

[GitHub] [airflow] ashb commented on issue #8972: Some task log lines are "decorated" twice

2020-06-18 Thread GitBox
ashb commented on issue #8972: URL: https://github.com/apache/airflow/issues/8972#issuecomment-645936631 Long standing issue, migrating here from AIRFLOW-4990 This is an automated message from the Apache Git Service. To respo

[jira] [Closed] (AIRFLOW-4990) Logs from tasks get "wrapped" twice

2020-06-18 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-4990. -- Resolution: Auto Closed Moved to https://github.com/apache/airflow/issues/8972 > Log

[GitHub] [airflow] mik-laj commented on issue #9372: Extend Default Sensitive Variable Fields

2020-06-18 Thread GitBox
mik-laj commented on issue #9372: URL: https://github.com/apache/airflow/issues/9372#issuecomment-645937700 It will not be difficult to add support for additional labels from the configuration. Would you like to contribute? Before you contribute, you should read https://github.com/apa

[GitHub] [airflow] ashb commented on pull request #9363: Use 'airflow.task' Logger for LocalTaskJob

2020-06-18 Thread GitBox
ashb commented on pull request #9363: URL: https://github.com/apache/airflow/pull/9363#issuecomment-645942703 Related or fixes? This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [airflow] ashb commented on issue #8972: Some task log lines are "decorated" twice

2020-06-18 Thread GitBox
ashb commented on issue #8972: URL: https://github.com/apache/airflow/issues/8972#issuecomment-645943479 Might this also fix the issue where some logs are disappearing? This is an automated message from the Apache Git Service

[GitHub] [airflow] ashb edited a comment on issue #8972: Some task log lines are "decorated" twice

2020-06-18 Thread GitBox
ashb edited a comment on issue #8972: URL: https://github.com/apache/airflow/issues/8972#issuecomment-645943479 Might this also fix the issue where some logs are disappearing? #8484 This is an automated message from the Apach

[GitHub] [airflow] potiuk commented on pull request #8777: Add Production Helm chart support

2020-06-18 Thread GitBox
potiuk commented on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645943721 Fantastic! :rocket: :rocket: . I am going to switch to the helm chart for our Kubernetes tests soon and iterate on the prod image @dima-asana @schnie -> I guess I am free to do s

[GitHub] [airflow] ashb removed a comment on issue #8972: Some task log lines are "decorated" twice

2020-06-18 Thread GitBox
ashb removed a comment on issue #8972: URL: https://github.com/apache/airflow/issues/8972#issuecomment-645943479 Might this also fix the issue where some logs are disappearing? #8484 This is an automated message from the Apac

[GitHub] [airflow] potiuk edited a comment on pull request #8777: Add Production Helm chart support

2020-06-18 Thread GitBox
potiuk edited a comment on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645943721 Fantastic! :rocket: :rocket: . I am going to switch to the helm chart for our Kubernetes tests soon and iterate on the prod image @dimberman @schnie @kaxil @ashb -> I gu

[GitHub] [airflow] ashb commented on pull request #9363: Use 'airflow.task' Logger for LocalTaskJob

2020-06-18 Thread GitBox
ashb commented on pull request #9363: URL: https://github.com/apache/airflow/pull/9363#issuecomment-645943964 Might this also fix the issue where some logs are disappearing? #8484 This is an automated message from the Apache

[GitHub] [airflow] Marloxo commented on issue #9372: Extend Default Sensitive Variable Fields

2020-06-18 Thread GitBox
Marloxo commented on issue #9372: URL: https://github.com/apache/airflow/issues/9372#issuecomment-645950567 yeah sure, I will send a PR in awhile 👍 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] Siddharthk commented on pull request #8777: Add Production Helm chart support

2020-06-18 Thread GitBox
Siddharthk commented on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645952392 Thanks for this. Was waiting for this eagerly. I tested it out quickly and I am getting below error using helm 2. Am I doing something wrong? ``` $ helm template --value

[GitHub] [airflow] ToxaZ opened a new issue #9373: path to file as sql parameter in PostgresOperator not working anymore

2020-06-18 Thread GitBox
ToxaZ opened a new issue #9373: URL: https://github.com/apache/airflow/issues/9373 **Apache Airflow version**: 1.10.10 **What happened**: ```python maintenance_operator = PostgresOperator( task_id='get_tables_size', postgres_conn_id='pentaho',

[GitHub] [airflow] feluelle opened a new pull request #9375: Remove redundant code from breeze initialization

2020-06-18 Thread GitBox
feluelle opened a new pull request #9375: URL: https://github.com/apache/airflow/pull/9375 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation cha

[GitHub] [airflow] KIRY4 opened a new issue #9374: AIRFLOW__KUBERNETES__AFFINITY AIRFLOW__KUBERNETES__TOLERATIONS how to use?

2020-06-18 Thread GitBox
KIRY4 opened a new issue #9374: URL: https://github.com/apache/airflow/issues/9374 Hello Everyone! I need some help with KubernetesExecutor. Anybody knows how exactly use these two values AIRFLOW__KUBERNETES__AFFINITY AIRFLOW__KUBERNETES__TOLERATIONS. Link from documentation is broken: ht

[GitHub] [airflow] boring-cyborg[bot] commented on issue #9374: AIRFLOW__KUBERNETES__AFFINITY AIRFLOW__KUBERNETES__TOLERATIONS how to use?

2020-06-18 Thread GitBox
boring-cyborg[bot] commented on issue #9374: URL: https://github.com/apache/airflow/issues/9374#issuecomment-645962282 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automated

[GitHub] [airflow] Siddharthk edited a comment on pull request #8777: Add Production Helm chart support

2020-06-18 Thread GitBox
Siddharthk edited a comment on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645952392 Thanks for this. Was waiting for this eagerly. I tested it out quickly and I am getting below error using helm 2. Am I doing something wrong? I just want to get the ya

[GitHub] [airflow] ashb commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
ashb commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442165228 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -172,3 +173,29 @@ def grant_bucket_access(cls, bucket: str, account_email: str):

[GitHub] [airflow] kaxil commented on pull request #8777: Add Production Helm chart support

2020-06-18 Thread GitBox
kaxil commented on pull request #8777: URL: https://github.com/apache/airflow/pull/8777#issuecomment-645963698 > Thanks for this. Was waiting for this eagerly. I tested it out quickly and I am getting below error using helm 2. Am I doing something wrong? I just want to get the yaml files a

[GitHub] [airflow] turbaszek merged pull request #9369: Add info about BaseOperatorMeta to UPDATING.md

2020-06-18 Thread GitBox
turbaszek merged pull request #9369: URL: https://github.com/apache/airflow/pull/9369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[airflow] branch master updated: Add info about BaseOperatorMeta to UPDATING.md (#9369)

2020-06-18 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new a19ff15 Add info about BaseOperatorMeta to

[GitHub] [airflow] mik-laj commented on pull request #9365: Use strict API schemas

2020-06-18 Thread GitBox
mik-laj commented on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645967108 @kaxil No. This has only changed in 3.0. We use marshmallow 2.*. https://marshmallow.readthedocs.io/en/stable/upgrading.html#schemas-are-always-strict However, we will wa

[GitHub] [airflow] potiuk commented on a change in pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk commented on a change in pull request #9368: URL: https://github.com/apache/airflow/pull/9368#discussion_r442169817 ## File path: tests/test_utils/gcp_system_helpers.py ## @@ -172,3 +173,29 @@ def grant_bucket_access(cls, bucket: str, account_email: str):

[GitHub] [airflow] kaxil commented on pull request #9365: Use strict API schemas

2020-06-18 Thread GitBox
kaxil commented on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645969223 How about using something like since we would always want the `strict=True`: ```python class Schema(marshmallow.Schema): def __init__(self, strict=True, **kwargs):

[GitHub] [airflow] kaxil edited a comment on pull request #9365: Use strict API schemas

2020-06-18 Thread GitBox
kaxil edited a comment on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645969223 How about using something like since we would always want the `strict=True`: ```python class Schema(marshmallow.Schema): def __init__(self, strict=True, **kw

[GitHub] [airflow] kaxil commented on a change in pull request #9273: implement api v1 for variables

2020-06-18 Thread GitBox
kaxil commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r442174818 ## File path: tests/api_connexion/endpoints/test_variable_endpoint.py ## @@ -29,38 +31,142 @@ def setUpClass(cls) -> None: def setUp(self) -> None:

[GitHub] [airflow] mik-laj commented on pull request #9365: Use strict API schemas

2020-06-18 Thread GitBox
mik-laj commented on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645972468 @kaxil This will complicate reviews because we will have to check imports. I do not see the problem that the code is repeated, because it is only one option. > Explicit

[GitHub] [airflow] ephraimbuddy commented on pull request #9365: Use strict API schemas

2020-06-18 Thread GitBox
ephraimbuddy commented on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645972701 Some Schemas uses SQLALchemySchema from marshmallow_sqlalchemy This is an automated message from the Apache

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9331: add log endpoint

2020-06-18 Thread GitBox
ephraimbuddy commented on a change in pull request #9331: URL: https://github.com/apache/airflow/pull/9331#discussion_r442178632 ## File path: airflow/api_connexion/schemas/log_schema.py ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

[GitHub] [airflow] kaxil commented on pull request #9365: Use strict API schemas

2020-06-18 Thread GitBox
kaxil commented on pull request #9365: URL: https://github.com/apache/airflow/pull/9365#issuecomment-645979068 > @kaxil This will complicate reviews because we will have to check imports. I do not see the problem that the code is repeated, because it is only one option. > > > Explic

[GitHub] [airflow] mik-laj merged pull request #9365: Use strict API schemas

2020-06-18 Thread GitBox
mik-laj merged pull request #9365: URL: https://github.com/apache/airflow/pull/9365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated: Use strict API schemas (#9365)

2020-06-18 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 880b65a Use strict API schemas (#9365)

[GitHub] [airflow] potiuk opened a new pull request #9376: Fix in-breeze CLI tools to work also on Linux

2020-06-18 Thread GitBox
potiuk opened a new pull request #9376: URL: https://github.com/apache/airflow/pull/9376 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation chang

[GitHub] [airflow] mik-laj commented on a change in pull request #9376: Fix in-breeze CLI tools to work also on Linux

2020-06-18 Thread GitBox
mik-laj commented on a change in pull request #9376: URL: https://github.com/apache/airflow/pull/9376#discussion_r442202789 ## File path: scripts/ci/run_cli_tool.sh ## @@ -157,12 +157,8 @@ RES=$? # Set file permissions to the host user if [[ "${HOST_OS}" == "Linux" ]]; then

[GitHub] [airflow] buxizhizhoum opened a new pull request #9377: Fix Connection reset by peer when there is no log for a long time

2020-06-18 Thread GitBox
buxizhizhoum opened a new pull request #9377: URL: https://github.com/apache/airflow/pull/9377 Fix Connection reset by peer when there is no log for a long time by catch the related PortalError. If not, there will be a log like line below: [2020-06-17 15:04:53,084] {connectionpool.py:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9377: Fix Connection reset by peer when there is no log for a long time

2020-06-18 Thread GitBox
boring-cyborg[bot] commented on pull request #9377: URL: https://github.com/apache/airflow/pull/9377#issuecomment-645998776 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contr

[GitHub] [airflow] potiuk opened a new pull request #9378: Fixed crashing webserver after /tmp is mounted from the host

2020-06-18 Thread GitBox
potiuk opened a new pull request #9378: URL: https://github.com/apache/airflow/pull/9378 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed for documentation chang

[GitHub] [airflow] feluelle commented on a change in pull request #9378: Fixed crashing webserver after /tmp is mounted from the host

2020-06-18 Thread GitBox
feluelle commented on a change in pull request #9378: URL: https://github.com/apache/airflow/pull/9378#discussion_r442212373 ## File path: Dockerfile.ci ## @@ -315,6 +315,9 @@ WORKDIR ${AIRFLOW_SOURCES} ENV PATH="${HOME}:${PATH}" +# Needed to stop Gunicorn from crashing wh

[GitHub] [airflow] potiuk merged pull request #9368: Adds GCP Secret Manager Hook

2020-06-18 Thread GitBox
potiuk merged pull request #9368: URL: https://github.com/apache/airflow/pull/9368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[airflow] branch master updated (880b65a -> 4e09c64)

2020-06-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 880b65a Use strict API schemas (#9365) add 4e09c64 Adds GCP Secret Manager Hook (#9368) No new revisions we

[GitHub] [airflow] potiuk commented on a change in pull request #9378: Fixed crashing webserver after /tmp is mounted from the host

2020-06-18 Thread GitBox
potiuk commented on a change in pull request #9378: URL: https://github.com/apache/airflow/pull/9378#discussion_r442214812 ## File path: Dockerfile.ci ## @@ -315,6 +315,9 @@ WORKDIR ${AIRFLOW_SOURCES} ENV PATH="${HOME}:${PATH}" +# Needed to stop Gunicorn from crashing when

[GitHub] [airflow] feluelle commented on a change in pull request #9378: Fixed crashing webserver after /tmp is mounted from the host

2020-06-18 Thread GitBox
feluelle commented on a change in pull request #9378: URL: https://github.com/apache/airflow/pull/9378#discussion_r442214500 ## File path: Dockerfile.ci ## @@ -315,6 +315,9 @@ WORKDIR ${AIRFLOW_SOURCES} ENV PATH="${HOME}:${PATH}" +# Needed to stop Gunicorn from crashing wh

[GitHub] [airflow] feluelle commented on a change in pull request #9378: Fixed crashing webserver after /tmp is mounted from the host

2020-06-18 Thread GitBox
feluelle commented on a change in pull request #9378: URL: https://github.com/apache/airflow/pull/9378#discussion_r442216176 ## File path: Dockerfile.ci ## @@ -315,6 +315,9 @@ WORKDIR ${AIRFLOW_SOURCES} ENV PATH="${HOME}:${PATH}" +# Needed to stop Gunicorn from crashing wh

[GitHub] [airflow] mik-laj commented on pull request #9377: Fix Connection reset by peer when there is no log for a long time

2020-06-18 Thread GitBox
mik-laj commented on pull request #9377: URL: https://github.com/apache/airflow/pull/9377#issuecomment-646012220 @mbohlool @roycaihw Can you look at it? I wonder if this is something we should fix on our side, or should we fix it in kubernetes-client/python ---

[GitHub] [airflow] ashb commented on a change in pull request #9378: Fixed crashing webserver after /tmp is mounted from the host

2020-06-18 Thread GitBox
ashb commented on a change in pull request #9378: URL: https://github.com/apache/airflow/pull/9378#discussion_r442227174 ## File path: Dockerfile.ci ## @@ -315,6 +315,9 @@ WORKDIR ${AIRFLOW_SOURCES} ENV PATH="${HOME}:${PATH}" +# Needed to stop Gunicorn from crashing when /

[GitHub] [airflow] ashb commented on pull request #9378: Fixed crashing webserver after /tmp is mounted from the host

2020-06-18 Thread GitBox
ashb commented on pull request #9378: URL: https://github.com/apache/airflow/pull/9378#issuecomment-646019785 @potiuk As a general request when fixing bugs: please could you link to the original PR that this is fixing for in the PR body? ---

[GitHub] [airflow] ashb commented on a change in pull request #9378: Fixed crashing webserver after /tmp is mounted from the host

2020-06-18 Thread GitBox
ashb commented on a change in pull request #9378: URL: https://github.com/apache/airflow/pull/9378#discussion_r442231439 ## File path: Dockerfile.ci ## @@ -315,6 +315,9 @@ WORKDIR ${AIRFLOW_SOURCES} ENV PATH="${HOME}:${PATH}" +# Needed to stop Gunicorn from crashing when /

  1   2   3   >