[GitHub] [airflow] turbaszek commented on pull request #9631: Add function to get current context

turbaszek commented on pull request #9631: URL: https://github.com/apache/airflow/pull/9631#issuecomment-653486696 @casassg @jonathanshir would you mind taking a look? This is an automated message from the Apache Git

[GitHub] [airflow] turbaszek commented on a change in pull request #9639: Add secrets backend for microsoft azure key vault

turbaszek commented on a change in pull request #9639: URL: https://github.com/apache/airflow/pull/9639#discussion_r449519179 ## File path: airflow/providers/microsoft/azure/secrets/azure_key_vault.py ## @@ -0,0 +1,107 @@ +""" +This module contains a secrets backend for Azure

[GitHub] [airflow] turbaszek commented on pull request #9482: Add CRUD endpoint for XCom

turbaszek commented on pull request #9482: URL: https://github.com/apache/airflow/pull/9482#issuecomment-653484017 > We should allow setting TaskInstance state as we do allow that in the Webserver True, I forgot about this. But still, this is very limited update option.

[GitHub] [airflow] elwinarens commented on issue #9583: Attach roles to AD groups - Azure OAuth

elwinarens commented on issue #9583: URL: https://github.com/apache/airflow/issues/9583#issuecomment-653483659 @sk2991 Would you mind sharing your Azure OAuth implementation? This is an automated message from the Apache Git

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9639: Add secrets backend for microsoft azure key vault

boring-cyborg[bot] commented on pull request #9639: URL: https://github.com/apache/airflow/pull/9639#issuecomment-653479886 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] elwinarens opened a new pull request #9639: Add secrets backend for microsoft azure key vault

elwinarens opened a new pull request #9639: URL: https://github.com/apache/airflow/pull/9639 Add secrets backend for microsoft azure key vault. Related issue https://github.com/apache/airflow/issues/8258. --- Make sure to mark the boxes below before creating PR: [x] - [x]

[GitHub] [airflow] davido912 opened a new issue #9638: Airflow Logging Sensitive Information

davido912 opened a new issue #9638: URL: https://github.com/apache/airflow/issues/9638 The Snowflake hook (and more accurately the dbapihook) logs sensitive information that is retrieved from the Airflow connections metadata. This happens by both the logger and the logging that comes with

[GitHub] [airflow] kaxil commented on pull request #9482: Add CRUD endpoint for XCom

kaxil commented on pull request #9482: URL: https://github.com/apache/airflow/pull/9482#issuecomment-653468787 We should allow setting TaskInstance state as we do allow that in the Webserver This is an automated message

[GitHub] [airflow] turbaszek commented on pull request #9482: Add CRUD endpoint for XCom

turbaszek commented on pull request #9482: URL: https://github.com/apache/airflow/pull/9482#issuecomment-653465013 > I have doubts whether we should allow third-party systems to create and update, delete entries. I don't think this is expected because **we store metadata** from the

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #9637: breeze Dockerfile.ci gcc ver

boring-cyborg[bot] commented on pull request #9637: URL: https://github.com/apache/airflow/pull/9637#issuecomment-653458789 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] xwydq opened a new pull request #9637: breeze Dockerfile.ci gcc ver

xwydq opened a new pull request #9637: URL: https://github.com/apache/airflow/pull/9637 The following packages have unmet dependencies: libc6-dev : Breaks: libgcc-8-dev (< 8.4.0-2~) but 8.3.0-6 is to be installed E: Error, pkgProblemResolver::Resolve generated breaks, this may be

[GitHub] [airflow] mik-laj edited a comment on pull request #9482: Add CRUD endpoint for XCom

mik-laj edited a comment on pull request #9482: URL: https://github.com/apache/airflow/pull/9482#issuecomment-653440785 @feluelle These API will not address this problem. I want to build an API for third systems, not an internal API. In my opinion, API for third-party systems should

[GitHub] [airflow] mik-laj commented on pull request #9482: Add CRUD endpoint for XCom

mik-laj commented on pull request #9482: URL: https://github.com/apache/airflow/pull/9482#issuecomment-653440785 @feluelle These API will not address this problem. I want to build an API for third systems, not an internal API. API for third-party systems should maintain backward

[GitHub] [airflow] feluelle commented on pull request #9482: Add CRUD endpoint for XCom

feluelle commented on pull request #9482: URL: https://github.com/apache/airflow/pull/9482#issuecomment-653435834 @mik-laj I understand you point. Hm.. I could imagine having multiple airflow instances which might want to share those xcom values with each other. WDYT?

[GitHub] [airflow] mik-laj commented on pull request #9482: Add CRUD endpoint for XCom

mik-laj commented on pull request #9482: URL: https://github.com/apache/airflow/pull/9482#issuecomment-653434020 @turbaszek @feluelle @ephraimbuddy I have doubts whether we should allow third-party systems to create and update, delete entries. I don't think this is expected because we

[GitHub] [airflow] feluelle commented on a change in pull request #9482: Add CRUD endpoint for XCom

feluelle commented on a change in pull request #9482: URL: https://github.com/apache/airflow/pull/9482#discussion_r449463417 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -89,15 +111,78 @@ def get_xcom_entry( return

[GitHub] [airflow] feluelle commented on a change in pull request #9482: Add CRUD endpoint for XCom

feluelle commented on a change in pull request #9482: URL: https://github.com/apache/airflow/pull/9482#discussion_r449462456 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -89,15 +111,78 @@ def get_xcom_entry( return

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9482: Add CRUD endpoint for XCom

ephraimbuddy commented on a change in pull request #9482: URL: https://github.com/apache/airflow/pull/9482#discussion_r449460858 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -89,15 +111,78 @@ def get_xcom_entry( return

[GitHub] [airflow] turbaszek commented on a change in pull request #9482: Add CRUD endpoint for XCom

turbaszek commented on a change in pull request #9482: URL: https://github.com/apache/airflow/pull/9482#discussion_r449455360 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -89,15 +111,78 @@ def get_xcom_entry( return

[GitHub] [airflow] potiuk closed issue #9634: Cannot update XCOMs via RBAC UI

potiuk closed issue #9634: URL: https://github.com/apache/airflow/issues/9634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on issue #9634: Cannot update XCOMs via RBAC UI

potiuk commented on issue #9634: URL: https://github.com/apache/airflow/issues/9634#issuecomment-653426323 XCom editing is removed completely in 1.10.11 https://github.com/apache/airflow/commit/b8f2cd329e9d97a319dc6eb26992e1f19a467551 - so this issue is not valid any more.

[GitHub] [airflow] turbaszek commented on a change in pull request #9482: Add CRUD endpoint for XCom

turbaszek commented on a change in pull request #9482: URL: https://github.com/apache/airflow/pull/9482#discussion_r449454085 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -89,15 +111,78 @@ def get_xcom_entry( return

[GitHub] [airflow] turbaszek commented on a change in pull request #9482: Add CRUD endpoint for XCom

turbaszek commented on a change in pull request #9482: URL: https://github.com/apache/airflow/pull/9482#discussion_r449453250 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -89,15 +111,78 @@ def get_xcom_entry( return

[GitHub] [airflow] turbaszek commented on a change in pull request #9482: Add CRUD endpoint for XCom

turbaszek commented on a change in pull request #9482: URL: https://github.com/apache/airflow/pull/9482#discussion_r449452345 ## File path: airflow/api_connexion/endpoints/xcom_endpoint.py ## @@ -89,15 +111,78 @@ def get_xcom_entry( return

[GitHub] [airflow] feluelle commented on a change in pull request #9394: Fix PythonVirtualenvOperator not working with Airflow context

feluelle commented on a change in pull request #9394: URL: https://github.com/apache/airflow/pull/9394#discussion_r449451590 ## File path: airflow/utils/python_virtualenv.py ## @@ -69,3 +72,23 @@ def prepare_virtualenv( execute_in_subprocess(pip_cmd) return

[GitHub] [airflow] feluelle commented on a change in pull request #9394: Fix PythonVirtualenvOperator not working with Airflow context

feluelle commented on a change in pull request #9394: URL: https://github.com/apache/airflow/pull/9394#discussion_r449449791 ## File path: airflow/operators/python.py ## @@ -412,140 +427,113 @@ def __init__( # pylint: disable=too-many-arguments

[GitHub] [airflow] feluelle commented on a change in pull request #9594: Adding new SageMaker operator for ProcessingJobs

feluelle commented on a change in pull request #9594: URL: https://github.com/apache/airflow/pull/9594#discussion_r449436572 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -786,6 +825,48 @@ def list_training_jobs( ) return results +

[GitHub] [airflow] mik-laj commented on pull request #9079: WIP: [8970] Improve KubernetesPodOperator guide

mik-laj commented on pull request #9079: URL: https://github.com/apache/airflow/pull/9079#issuecomment-653418928 @tanjinP Have you encountered any difficulties? Can I help you? This is an automated message from the Apache

[airflow] branch master updated: Customizable page size limit in API (#9431)

This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new fddc572 Customizable page size limit in

[GitHub] [airflow] mik-laj merged pull request #9431: Move API page limit and offset parameters to views as kwargs Arguments

mik-laj merged pull request #9431: URL: https://github.com/apache/airflow/pull/9431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on a change in pull request #9502: generate go client from openapi spec

potiuk commented on a change in pull request #9502: URL: https://github.com/apache/airflow/pull/9502#discussion_r449436047 ## File path: .github/workflows/ci.yml ## @@ -170,6 +170,33 @@ jobs: '\.py$|.github/workflows/|^Dockerfile|^scripts' echo

[GitHub] [airflow] potiuk commented on a change in pull request #9502: generate go client from openapi spec

potiuk commented on a change in pull request #9502: URL: https://github.com/apache/airflow/pull/9502#discussion_r449435833 ## File path: .github/workflows/ci.yml ## @@ -170,6 +170,33 @@ jobs: '\.py$|.github/workflows/|^Dockerfile|^scripts' echo

[GitHub] [airflow] potiuk commented on a change in pull request #9502: generate go client from openapi spec

potiuk commented on a change in pull request #9502: URL: https://github.com/apache/airflow/pull/9502#discussion_r449435833 ## File path: .github/workflows/ci.yml ## @@ -170,6 +170,33 @@ jobs: '\.py$|.github/workflows/|^Dockerfile|^scripts' echo

[GitHub] [airflow] Fokko commented on pull request #4320: [AIRFLOW-3515] Remove the run_duration option

Fokko commented on pull request #4320: URL: https://github.com/apache/airflow/pull/4320#issuecomment-653407133 @shargal Restarting the scheduler isn't really a proper solution, right? Feels a bit like; have you tried turning it off and on again. Would be cool if we could isolate the

[GitHub] [airflow-client-go] turbaszek commented on a change in pull request #1: Add generated go client

turbaszek commented on a change in pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#discussion_r449420010 ## File path: .github/workflows/ci.yml ## @@ -0,0 +1,36 @@ +name: CI Review comment: Let's add license here and move on 

[GitHub] [airflow] turbaszek commented on a change in pull request #9531: Support .airflowignore for plugins

turbaszek commented on a change in pull request #9531: URL: https://github.com/apache/airflow/pull/9531#discussion_r449419305 ## File path: tests/plugins/test_ignore/subdir1/test_load_sub1.py ## @@ -0,0 +1,35 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] turbaszek commented on a change in pull request #9531: Support .airflowignore for plugins

turbaszek commented on a change in pull request #9531: URL: https://github.com/apache/airflow/pull/9531#discussion_r449419305 ## File path: tests/plugins/test_ignore/subdir1/test_load_sub1.py ## @@ -0,0 +1,35 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #9624: Move StackdriverTaskHandler to the provider package

ephraimbuddy commented on a change in pull request #9624: URL: https://github.com/apache/airflow/pull/9624#discussion_r449419069 ## File path: airflow/utils/log/stackdriver_task_handler.py ## @@ -15,281 +15,14 @@ # specific language governing permissions and limitations #

[GitHub] [airflow] Fokko commented on a change in pull request #9394: Fix PythonVirtualenvOperator not working with Airflow context

Fokko commented on a change in pull request #9394: URL: https://github.com/apache/airflow/pull/9394#discussion_r449418614 ## File path: airflow/operators/python.py ## @@ -412,140 +427,113 @@ def __init__( # pylint: disable=too-many-arguments

[GitHub] [airflow] turbaszek commented on a change in pull request #9531: Support .airflowignore for plugins

turbaszek commented on a change in pull request #9531: URL: https://github.com/apache/airflow/pull/9531#discussion_r449418389 ## File path: tests/plugins/test_plugin_ignore.py ## @@ -0,0 +1,89 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] turbaszek commented on a change in pull request #9531: Support .airflowignore for plugins

turbaszek commented on a change in pull request #9531: URL: https://github.com/apache/airflow/pull/9531#discussion_r449417007 ## File path: tests/plugins/test_plugin_ignore.py ## @@ -0,0 +1,89 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] turbaszek commented on a change in pull request #9593: Improve handling Dataproc cluster creation with ERROR state

turbaszek commented on a change in pull request #9593: URL: https://github.com/apache/airflow/pull/9593#discussion_r449416095 ## File path: airflow/providers/google/cloud/operators/dataproc.py ## @@ -502,32 +506,79 @@ def __init__(self, self.timeout = timeout

[GitHub] [airflow] turbaszek commented on a change in pull request #9593: Improve handling Dataproc cluster creation with ERROR state

turbaszek commented on a change in pull request #9593: URL: https://github.com/apache/airflow/pull/9593#discussion_r449415934 ## File path: airflow/providers/google/cloud/operators/dataproc.py ## @@ -502,32 +506,79 @@ def __init__(self, self.timeout = timeout

[GitHub] [airflow-client-go] houqp commented on pull request #1: Add generated go client

houqp commented on pull request #1: URL: https://github.com/apache/airflow-client-go/pull/1#issuecomment-653391019 @mik-laj @turbaszek added pre-commit check in CI and license header to all auto-generated readme docs. This

[GitHub] [airflow] houqp commented on pull request #9502: generate go client from openapi spec

houqp commented on pull request #9502: URL: https://github.com/apache/airflow/pull/9502#issuecomment-653381463 @potiuk @mik-laj @feluelle updated add pre-commit as dependency to code gen script and use it to prepend headers, ready for another round of review.

[GitHub] [airflow] humbledude commented on issue #8495: Allow configuration of args vs command to support container entrypoint in kubernetes executor

humbledude commented on issue #8495: URL: https://github.com/apache/airflow/issues/8495#issuecomment-653378740 https://github.com/apache/airflow/blob/72d5a58fd734cf4a02e351210b7db5ae2fae7e4e/airflow/executors/kubernetes_executor.py#L470 this could be "args"...

[GitHub] [airflow] j-y-matsubara commented on pull request #9531: Support .airflowignore for plugins

j-y-matsubara commented on pull request #9531: URL: https://github.com/apache/airflow/pull/9531#issuecomment-653371144 The same k8s error that has nothing to do with this PR as last time. This is an automated message from

[GitHub] [airflow] turbaszek commented on a change in pull request #9624: Move StackdriverTaskHandler to the provider package

turbaszek commented on a change in pull request #9624: URL: https://github.com/apache/airflow/pull/9624#discussion_r449392964 ## File path: airflow/utils/log/stackdriver_task_handler.py ## @@ -15,281 +15,14 @@ # specific language governing permissions and limitations # under

[GitHub] [airflow] turbaszek commented on a change in pull request #9472: Add drop_partition functionality for HiveMetastoreHook

turbaszek commented on a change in pull request #9472: URL: https://github.com/apache/airflow/pull/9472#discussion_r449392019 ## File path: tests/providers/apache/hive/hooks/test_hive.py ## @@ -383,6 +383,10 @@ def test_table_exists(self):

[GitHub] [airflow] turbaszek commented on a change in pull request #9604: Move CloudwatchTaskHandler to the provider package

turbaszek commented on a change in pull request #9604: URL: https://github.com/apache/airflow/pull/9604#discussion_r449391557 ## File path: airflow/utils/log/cloudwatch_task_handler.py ## @@ -15,101 +15,15 @@ # KIND, either express or implied. See the License for the #

<    1   2