mik-laj commented on a change in pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#discussion_r449981095
##
File path: tests/providers/yandex/hooks/test_yandex.py
##
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
mik-laj merged pull request #9676:
URL: https://github.com/apache/airflow/pull/9676
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from ac12401 Fix tests: Add Default Conns back only when needed (#9679)
add 263ff26 Simplify DagBag -
dimberman commented on a change in pull request #9079:
URL: https://github.com/apache/airflow/pull/9079#discussion_r449967800
##
File path: docs/howto/operator/kubernetes.rst
##
@@ -25,180 +25,90 @@ KubernetesPodOperator
The
wolvery closed pull request #9678:
URL: https://github.com/apache/airflow/pull/9678
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to tag nightly-master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
*** WARNING: tag nightly-master was modified! ***
from 5670e6f (commit)
to ac12401 (commit)
from
ghostbody commented on issue #8521:
URL: https://github.com/apache/airflow/issues/8521#issuecomment-653985052
Same problem +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on
j-y-matsubara commented on issue #9413:
URL: https://github.com/apache/airflow/issues/9413#issuecomment-653979555
I'm sorry. I had failed to link to pull reqest.
This issue have already fixed.
This is an automated
wolvery opened a new issue #9683:
URL: https://github.com/apache/airflow/issues/9683
**Description**
Transfer to scan files from sftp source path and upload them to Azure Blob
Storage
**Use case / motivation**
* Scan a source path and upload files using a wildcard or
boring-cyborg[bot] commented on issue #9683:
URL: https://github.com/apache/airflow/issues/9683#issuecomment-653962976
Thanks for opening your first issue here! Be sure to follow the issue
template!
This is an automated
kaxil commented on a change in pull request #9670:
URL: https://github.com/apache/airflow/pull/9670#discussion_r449937226
##
File path: airflow/migrations/env.py
##
@@ -21,7 +21,7 @@
from alembic import context
from airflow import models, settings
-from
kaxil opened a new pull request #9682:
URL: https://github.com/apache/airflow/pull/9682
`genereate` -> `generate`
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes
kaxil opened a new pull request #9681:
URL: https://github.com/apache/airflow/pull/9681
Many of the pre-commits don't require `require_serial: true`. This PR
removes those to use the default of `require_serial: false`
---
Make sure to mark the boxes below before creating PR: [x]
mik-laj opened a new pull request #9680:
URL: https://github.com/apache/airflow/pull/9680
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation
prithvisathiya edited a comment on issue #8212:
URL: https://github.com/apache/airflow/issues/8212#issuecomment-653952342
Im also experiencing the exact same issue when I upgraded to `1.10.9`, but
Im still using `LocalExecutor`. I can clearly see from the S3 console that the
logs are
kaxil commented on pull request #9676:
URL: https://github.com/apache/airflow/pull/9676#issuecomment-653953271
@mik-laj Can you please rebase on latest master
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new ac12401 Fix tests: Add Default Conns back
kaxil merged pull request #9679:
URL: https://github.com/apache/airflow/pull/9679
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
prithvisathiya commented on issue #8212:
URL: https://github.com/apache/airflow/issues/8212#issuecomment-653952342
Im also experiencing the exact same issue when I upgraded to `1.10.9`, but
Im still using `LocalExecutor`. I can clearly see from the S3 console that the
logs are getting
kaxil opened a new pull request #9679:
URL: https://github.com/apache/airflow/pull/9679
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation
ephraimbuddy commented on a change in pull request #9604:
URL: https://github.com/apache/airflow/pull/9604#discussion_r449929959
##
File path: airflow/providers/google/cloud/log/stackdriver_task_handler.py
##
@@ -0,0 +1,295 @@
+# Licensed to the Apache Software Foundation
wolvery opened a new pull request #9678:
URL: https://github.com/apache/airflow/pull/9678
sftp_transfer provides mechanism to extract file from a sftp path or files
using a wildcard.
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above
boring-cyborg[bot] commented on pull request #9677:
URL: https://github.com/apache/airflow/pull/9677#issuecomment-653949526
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our
wolvery opened a new pull request #9677:
URL: https://github.com/apache/airflow/pull/9677
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation
ephraimbuddy commented on a change in pull request #9604:
URL: https://github.com/apache/airflow/pull/9604#discussion_r449927679
##
File path: airflow/providers/google/cloud/log/stackdriver_task_handler.py
##
@@ -0,0 +1,295 @@
+# Licensed to the Apache Software Foundation
ephraimbuddy commented on a change in pull request #9604:
URL: https://github.com/apache/airflow/pull/9604#discussion_r449927732
##
File path: airflow/providers/google/cloud/log/stackdriver_task_handler.py
##
@@ -0,0 +1,295 @@
+# Licensed to the Apache Software Foundation
ephraimbuddy closed pull request #9623:
URL: https://github.com/apache/airflow/pull/9623
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ephraimbuddy commented on pull request #9623:
URL: https://github.com/apache/airflow/pull/9623#issuecomment-653948106
These changes have been move to #9604
This is an automated message from the Apache Git Service.
To respond
ephraimbuddy commented on pull request #9624:
URL: https://github.com/apache/airflow/pull/9624#issuecomment-653948081
These changes have been move to #9604
This is an automated message from the Apache Git Service.
To respond
ephraimbuddy closed pull request #9624:
URL: https://github.com/apache/airflow/pull/9624
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
marclamberti commented on pull request #9371:
URL: https://github.com/apache/airflow/pull/9371#issuecomment-653947686
@friedhardware, this chart is only available from this repo for now and it
is the official one, not related to the current one on Helm.sh
dimberman commented on pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#issuecomment-653947335
This... feels off to me.
Why are we maintaining images for external libraries? If those projects and
images have proper licences why would we want to take on that
friedhardware commented on pull request #9371:
URL: https://github.com/apache/airflow/pull/9371#issuecomment-653947272
Where is this chart hosted? Is it related to
https://hub.helm.sh/charts/stable/airflow?
This is an
dimberman commented on pull request #9663:
URL: https://github.com/apache/airflow/pull/9663#issuecomment-653947116
Ahh ok I see where you're coming from. Since this isn't taking in any code
changes and is instead just running against the most recent release... Though
that raises the
stale[bot] commented on pull request #8960:
URL: https://github.com/apache/airflow/pull/8960#issuecomment-653946663
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you for
your contributions.
stale[bot] commented on pull request #8961:
URL: https://github.com/apache/airflow/pull/8961#issuecomment-653946664
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you for
your contributions.
mik-laj commented on a change in pull request #9676:
URL: https://github.com/apache/airflow/pull/9676#discussion_r449924335
##
File path: airflow/models/dagbag.py
##
@@ -107,7 +107,7 @@ def size(self):
@property
def dag_ids(self) -> List[str]:
-return
mik-laj opened a new pull request #9676:
URL: https://github.com/apache/airflow/pull/9676
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation
kaxil merged pull request #9675:
URL: https://github.com/apache/airflow/pull/9675
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new bb19b91 Remove side effects from tests
peter-volkov commented on a change in pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#discussion_r449922283
##
File path: tests/providers/yandex/hooks/test_yandex.py
##
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
kaxil commented on a change in pull request #9674:
URL: https://github.com/apache/airflow/pull/9674#discussion_r449922077
##
File path: airflow/models/taskinstance.py
##
@@ -972,7 +1022,7 @@ def _run_raw_task(
context = {} # type: Dict
actual_start_date =
kaxil merged pull request #9666:
URL: https://github.com/apache/airflow/pull/9666
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 01044ff Fix use of GCP credentials in StackdriverTaskHandler (#9668)
add 444051d Fix pylint issues in
kaxil opened a new pull request #9675:
URL: https://github.com/apache/airflow/pull/9675
Add setUp and tearDown methods to clear tabels
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests
mik-laj edited a comment on pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#issuecomment-653941575
> @potiuk what list are you talking about?
https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L45
More info:
mik-laj edited a comment on pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#issuecomment-653941575
> @potiuk what list are you talking about?
https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L45
> what can I do to improve the
mik-laj commented on pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#issuecomment-653941575
> @potiuk what list are you talking about?
https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L45
> what can I do to improve the tests?
mik-laj commented on a change in pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#discussion_r449920521
##
File path: tests/providers/yandex/hooks/test_yandex.py
##
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
ephraimbuddy commented on a change in pull request #9648:
URL: https://github.com/apache/airflow/pull/9648#discussion_r449919858
##
File path: setup.py
##
@@ -215,7 +215,8 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
peter-volkov commented on pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#issuecomment-653940478
@potiuk what list are you talking about?
@mik-laj looks good
what can I do to improve the tests?
ephraimbuddy commented on a change in pull request #9648:
URL: https://github.com/apache/airflow/pull/9648#discussion_r449919671
##
File path: setup.py
##
@@ -216,6 +216,7 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
]
dask = [
ephraimbuddy commented on a change in pull request #9648:
URL: https://github.com/apache/airflow/pull/9648#discussion_r449918064
##
File path: setup.py
##
@@ -215,7 +215,7 @@ def write_version(filename: str = os.path.join(*[my_dir,
"airflow", "git_version
potiuk commented on pull request #9663:
URL: https://github.com/apache/airflow/pull/9663#issuecomment-653937962
We already rin similar tests for backport packages for example - we take the
latest released airflow and we test if all the 'latest' backport packages can
be installed with it.
ephraimbuddy commented on a change in pull request #9648:
URL: https://github.com/apache/airflow/pull/9648#discussion_r449917608
##
File path: requirements/requirements-python3.7.txt
##
@@ -90,7 +90,7 @@ chardet==3.0.4
click==6.7
clickclick==1.2.2
cloudant==2.13.0
ephraimbuddy commented on a change in pull request #9648:
URL: https://github.com/apache/airflow/pull/9648#discussion_r449917659
##
File path: requirements/requirements-python3.8.txt
##
@@ -90,7 +90,7 @@ chardet==3.0.4
click==6.7
clickclick==1.2.2
cloudant==2.13.0
potiuk commented on pull request #9663:
URL: https://github.com/apache/airflow/pull/9663#issuecomment-653937712
> @potiuk would this run on every master PR? Seems like it might make sense
on pushes to 1-10-test but not on master.
It also makes sense on master. I think we are going
ephraimbuddy commented on a change in pull request #9648:
URL: https://github.com/apache/airflow/pull/9648#discussion_r449917563
##
File path: requirements/requirements-python3.6.txt
##
@@ -90,7 +90,7 @@ chardet==3.0.4
click==6.7
clickclick==1.2.2
cloudant==2.13.0
potiuk commented on a change in pull request #9674:
URL: https://github.com/apache/airflow/pull/9674#discussion_r449916739
##
File path: airflow/models/taskinstance.py
##
@@ -483,6 +502,8 @@ def refresh_from_db(self, session=None,
lock_for_update=False) -> None:
potiuk commented on a change in pull request #9674:
URL: https://github.com/apache/airflow/pull/9674#discussion_r449916627
##
File path: airflow/models/taskinstance.py
##
@@ -181,6 +181,7 @@ class TaskInstance(Base, LoggingMixin):
)
def __init__(self, task,
dimberman commented on pull request #9663:
URL: https://github.com/apache/airflow/pull/9663#issuecomment-653936271
@potiuk would this run on every master PR? Seems like it might make sense on
pushes to 1-10-test but not on master.
kaxil opened a new pull request #9674:
URL: https://github.com/apache/airflow/pull/9674
Make airflow/models/taskinstance.py Pylint Compatible
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit
mik-laj commented on pull request #9604:
URL: https://github.com/apache/airflow/pull/9604#issuecomment-653932731
@ephraimbuddy +1 That shouldn't be a problem for us.
This is an automated message from the Apache Git Service.
mik-laj commented on pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#issuecomment-653932479
@peter-volkov Can you look at it?
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from d93555b Add git sync option and unit tests for the Helm chart (#9371)
add 01044ff Fix use of GCP
mik-laj merged pull request #9668:
URL: https://github.com/apache/airflow/pull/9668
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mik-laj commented on issue #9134:
URL: https://github.com/apache/airflow/issues/9134#issuecomment-653931976
@subkanthi I assigned you to this ticket.
This is an automated message from the Apache Git Service.
To respond to
dimberman merged pull request #9371:
URL: https://github.com/apache/airflow/pull/9371
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
dimberman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 7a32866 The fix_ownership works independently of backend choice
(#9664)
add d93555b Add git sync option
potiuk commented on pull request #9665:
URL: https://github.com/apache/airflow/pull/9665#issuecomment-653931518
Looks good! But I think you need to remove the yandex from list of those
files without tests :)
This is an
subkanthi commented on issue #8540:
URL: https://github.com/apache/airflow/issues/8540#issuecomment-653931012
Hi @turbaszek , @felipemoz , Is this something I can tackle, please let me
know.
This is an automated message
potiuk commented on pull request #9667:
URL: https://github.com/apache/airflow/pull/9667#issuecomment-653931093
Nice! But We need a unit test for that. I belive gcs_to_gcs already have
quite comprehensive unit tests, so it will be easy to extend them.
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 7a32866 The fix_ownership works independently
potiuk merged pull request #9664:
URL: https://github.com/apache/airflow/pull/9664
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk commented on a change in pull request #9670:
URL: https://github.com/apache/airflow/pull/9670#discussion_r449911768
##
File path: airflow/migrations/env.py
##
@@ -21,7 +21,7 @@
from alembic import context
from airflow import models, settings
-from
potiuk commented on a change in pull request #9670:
URL: https://github.com/apache/airflow/pull/9670#discussion_r449911543
##
File path: airflow/migrations/env.py
##
@@ -21,7 +21,7 @@
from alembic import context
from airflow import models, settings
-from
kaxil merged pull request #9672:
URL: https://github.com/apache/airflow/pull/9672
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from e4529d1 Make airflow/models/kubernetes.py Pylint Compatible (#9673)
add 78d0287 Make
houqp commented on pull request #9660:
URL: https://github.com/apache/airflow/pull/9660#issuecomment-653929985
@kaxil thanks for taking care of this!
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 5c89515 Make airflow/models/xcom.py Pylint Compatible (#9658)
add e4529d1 Make
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 5c89515 Make airflow/models/xcom.py Pylint Compatible (#9658)
add e4529d1 Make
kaxil merged pull request #9673:
URL: https://github.com/apache/airflow/pull/9673
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mdediana commented on pull request #9668:
URL: https://github.com/apache/airflow/pull/9668#issuecomment-653927061
I put the mocks back. One small problem is that I had to add
`mock_get_creds_and_project_id.return_value = ('creds', 'project_id')` to every
test, otherwise the line
kaxil opened a new pull request #9673:
URL: https://github.com/apache/airflow/pull/9673
Make airflow/models/kubernetes.py Pylint Compatible
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit
sk2991 commented on issue #9583:
URL: https://github.com/apache/airflow/issues/9583#issuecomment-653924470
@mik-laj It does help to some extent. Is there anyway to extend this?
Instead of declaring "AUTH_USER_REGISTRATION_ROLE_JMESPATH =
"contains(['al...@example.com',
kaxil opened a new pull request #9672:
URL: https://github.com/apache/airflow/pull/9672
Make airflow/logging_config.py Pylint Compatible
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests
mdediana edited a comment on pull request #9668:
URL: https://github.com/apache/airflow/pull/9668#issuecomment-653923273
> Without this the test does not pass because we do not have GCP credentials
on CI.
My bad, it just worked on my local because by chance I had credentials set.
mdediana commented on pull request #9668:
URL: https://github.com/apache/airflow/pull/9668#issuecomment-653923273
> Without this the test does not pass because we do not have GCP credentials
on CI.
My bad, it just worked on my local because by chance I had credentials set.
Let me fix
kaxil commented on pull request #9671:
URL: https://github.com/apache/airflow/pull/9671#issuecomment-653922263
> Very large people browse the logs just in search of SQL statement.
Knowledge of the query is crucial to diagnose problems with SQL. I think we
should look for a better
kaxil commented on pull request #9671:
URL: https://github.com/apache/airflow/pull/9671#issuecomment-653922167
> @mik-laj an idea from the top of my head could be adding a parameter that
could allow for regex pattern removal/hashing of string parts of the sql
statement which could then be
davido912 commented on pull request #9671:
URL: https://github.com/apache/airflow/pull/9671#issuecomment-653922034
@mik-laj an idea from the top of my head could be adding a parameter that
could allow for regex pattern removal/hashing of string parts of the sql
statement which could then
mik-laj commented on pull request #9668:
URL: https://github.com/apache/airflow/pull/9668#issuecomment-653921785
> Besides this fix, mocks that were declared but not used were removed from
tests.
Without this the test does not pass because we do not have GCP credentials
on CI.
mik-laj commented on pull request #9671:
URL: https://github.com/apache/airflow/pull/9671#issuecomment-653921348
Very large people browse the logs just in search of SQL statement.
Knowledge of the query is crucial to diagnose problems with SQL. I think we
should look for a better
sk2991 commented on issue #9583:
URL: https://github.com/apache/airflow/issues/9583#issuecomment-653920847
@elwinarens @rafaelpierre - I have used this
[link](https://github.com/dpgaspar/Flask-AppBuilder/blob/master/examples/oauth/config.py)
to configure Azure OAuth.
Other useful
mik-laj closed issue #8206:
URL: https://github.com/apache/airflow/issues/8206
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tanjinP commented on issue #8206:
URL: https://github.com/apache/airflow/issues/8206#issuecomment-653919863
@mik-laj should this issue be closed?
This is an automated message from the Apache Git Service.
To respond to the
kaxil commented on pull request #9671:
URL: https://github.com/apache/airflow/pull/9671#issuecomment-653918160
cc @davido912
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kaxil opened a new pull request #9671:
URL: https://github.com/apache/airflow/pull/9671
closes https://github.com/apache/airflow/issues/9638
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit
kaxil commented on a change in pull request #9670:
URL: https://github.com/apache/airflow/pull/9670#discussion_r449901292
##
File path: airflow/migrations/env.py
##
@@ -21,7 +21,7 @@
from alembic import context
from airflow import models, settings
-from
kaxil opened a new pull request #9670:
URL: https://github.com/apache/airflow/pull/9670
Make airflow/migrations/env.py Pylint Compatible
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests
1 - 100 of 157 matches
Mail list logo
