[GitHub] [airflow] a-poptsov commented on pull request #11369: Users can specify sub-secrets and paths k8spodop

2020-10-10 Thread GitBox
a-poptsov commented on pull request #11369: URL: https://github.com/apache/airflow/pull/11369#issuecomment-706656170 @dimberman having it in 1.10.13 will be really nice. For now I have to apply some dirty hacks to have the same ability. Migration to 2.0 will be really nice but it will take

[GitHub] [airflow] ktrueda commented on issue #10742: Enable More PyDocStyle Checks

2020-10-10 Thread GitBox
ktrueda commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-706654118 I started to fix D205 (1 blank line required between summary line and description). It's difficult because a lot of docs has not summary line. For example, https://git

[GitHub] [airflow] potiuk commented on pull request #11413: Adds missing schema for kerberos sidecar configuration

2020-10-10 Thread GitBox
potiuk commented on pull request #11413: URL: https://github.com/apache/airflow/pull/11413#issuecomment-706651659 cc: @jaketf This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk opened a new pull request #11413: Adds missing schema for kerberos sidecar configuration

2020-10-10 Thread GitBox
potiuk opened a new pull request #11413: URL: https://github.com/apache/airflow/pull/11413 The kerberos support added in #11130 did not have schema added to the values.yml. This PR fixes it. Co-authored-by: Jacob Ferriero --- **^ Add meaningful description above*

[GitHub] [airflow] dimberman commented on pull request #11369: Users can specify sub-secrets and paths k8spodop

2020-10-10 Thread GitBox
dimberman commented on pull request #11369: URL: https://github.com/apache/airflow/pull/11369#issuecomment-706650599 @a-poptsov Tbh probably not :/ (though if you want to handle the backporting we could potentially squeeze it). That said 1.10.13 will have the ability to use pod_template_fi

[GitHub] [airflow] potiuk commented on a change in pull request #11384: Mutual SSL added in PGBouncer configuration in the Chart

2020-10-10 Thread GitBox
potiuk commented on a change in pull request #11384: URL: https://github.com/apache/airflow/pull/11384#discussion_r502865530 ## File path: chart/templates/_helpers.yaml ## @@ -262,6 +266,13 @@ max_client_conn = {{ .Values.pgbouncer.maxClientConn }} verbose = {{ .Values.pgbounc

[GitHub] [airflow] a-poptsov commented on issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume

2020-10-10 Thread GitBox
a-poptsov commented on issue #10777: URL: https://github.com/apache/airflow/issues/10777#issuecomment-706649877 I suggest to add items by default in the case that was specified in prev. comment This is an automated message

[GitHub] [airflow] a-poptsov commented on pull request #11369: Users can specify sub-secrets and paths k8spodop

2020-10-10 Thread GitBox
a-poptsov commented on pull request #11369: URL: https://github.com/apache/airflow/pull/11369#issuecomment-706649581 @dimberman Great job. Is it possible to make it available for v1.X users? This is an automated message fro

[GitHub] [airflow] a-poptsov commented on issue #10777: KubernetesPodOperator Secret doesn't use key property when attaching to pod as volume

2020-10-10 Thread GitBox
a-poptsov commented on issue #10777: URL: https://github.com/apache/airflow/issues/10777#issuecomment-706649463 @dimberman Sorry for late response. Thanks for a great job with adding items field. But I think it is partial fix. Secret contains all required information already even without

[airflow] branch master updated (45d33db -> 9416bed)

2020-10-10 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 45d33db Add capability of customising PyPI sources (#11385) add 9416bed Moving the test to quarantine. (#1

[GitHub] [airflow] dimberman merged pull request #11405: Moving the test to quarantine.

2020-10-10 Thread GitBox
dimberman merged pull request #11405: URL: https://github.com/apache/airflow/pull/11405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated (f9dddd5 -> 45d33db)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from f95 Workarounds "unknown blob" issue by introducing retries (#11411) add 45d33db Add capability of custo

[airflow] branch master updated (f9dddd5 -> 45d33db)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from f95 Workarounds "unknown blob" issue by introducing retries (#11411) add 45d33db Add capability of custo

[GitHub] [airflow] potiuk merged pull request #11385: Add capability of customising PyPI sources

2020-10-10 Thread GitBox
potiuk merged pull request #11385: URL: https://github.com/apache/airflow/pull/11385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk opened a new pull request #11412: Fix constraints generation script

2020-10-10 Thread GitBox
potiuk opened a new pull request #11412: URL: https://github.com/apache/airflow/pull/11412 Constraints generation script was broken by recent changes in naming of constraints URL variables and moving generation of the link to the Dockerfile This change restores the script's beha

[airflow] branch master updated (7959df9 -> f9dddd5)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 7959df9 Fix spelling (#11404) add f95 Workarounds "unknown blob" issue by introducing retries (#11411)

[airflow] branch master updated: Workarounds "unknown blob" issue by introducing retries (#11411)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new f95 Workarounds "unknown blob" issue by in

[GitHub] [airflow] potiuk merged pull request #11411: Workarounds "unknown blob" issue by introducing retries

2020-10-10 Thread GitBox
potiuk merged pull request #11411: URL: https://github.com/apache/airflow/pull/11411 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk opened a new pull request #11411: Workarounds "unknown blob" issue by introducing retries

2020-10-10 Thread GitBox
potiuk opened a new pull request #11411: URL: https://github.com/apache/airflow/pull/11411 We have started to experience "unknown_blob" errors intermittently recently with GitHub Docker registry. We might eventually need to migrate to GCR (which eventually is going to replace the Do

[GitHub] [airflow] jmcarp opened a new pull request #11410: Optionally use iam role for redshift unload to s3.

2020-10-10 Thread GitBox
jmcarp opened a new pull request #11410: URL: https://github.com/apache/airflow/pull/11410 Redshift `unload` allows authentication to s3 using an access key and secret or using an iam role that the redshift user is allowed to use. This patch adds support for iam role authentication and upd

[GitHub] [airflow] jmcarp commented on pull request #11409: Optionally set null marker in csv exports.

2020-10-10 Thread GitBox
jmcarp commented on pull request #11409: URL: https://github.com/apache/airflow/pull/11409#issuecomment-706616440 There's one failing test in one build, but I'm guessing it's unrelated. This is an automated message from the A

[GitHub] [airflow] pcandoalmeida commented on issue #11039: Create UsingSQLFromBaseHookRule to ease upgrade to Airflow 2.0

2020-10-10 Thread GitBox
pcandoalmeida commented on issue #11039: URL: https://github.com/apache/airflow/issues/11039#issuecomment-706615955 Hi @turbaszek 👋🏼 I wanted to check that I'm understanding this rule correctly. Here, no configuration is set; either, users will be extending the `BaseHook` class or using th

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #11265: Add TaskHandlersMovedRule in upgrade check command

2020-10-10 Thread GitBox
ephraimbuddy commented on a change in pull request #11265: URL: https://github.com/apache/airflow/pull/11265#discussion_r502830002 ## File path: airflow/upgrade/rules/task_handlers_moved.py ## @@ -0,0 +1,74 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] jmcarp opened a new pull request #11409: Optionally set null marker in csv exports.

2020-10-10 Thread GitBox
jmcarp opened a new pull request #11409: URL: https://github.com/apache/airflow/pull/11409 --- When exporting mysql/postgres/etc to csv for import into bigquery, it can be useful to set a null marker to distinguish between null and empty values. This patch adds a `null_marker` o

[GitHub] [airflow] ephraimbuddy commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template

2020-10-10 Thread GitBox
ephraimbuddy commented on pull request #11261: URL: https://github.com/apache/airflow/pull/11261#issuecomment-706608125 Hi @mik-laj, any ideas why this is failing on query count? What should I do to fix it? This is an automa

[GitHub] [airflow] ephraimbuddy opened a new pull request #11408: Fix incorrect typing, remove hardcoded argument values and improve code in AzureContainerInstancesOperator

2020-10-10 Thread GitBox
ephraimbuddy opened a new pull request #11408: URL: https://github.com/apache/airflow/pull/11408 This PR addresses a few things. 1) Incorrect type for command argument: The correct type is List[str] and is now updated 2) I added os_type and restart_policy arguments so that it's not ha

[GitHub] [airflow] dimberman closed issue #11347: Branching doesn't work as expected

2020-10-10 Thread GitBox
dimberman closed issue #11347: URL: https://github.com/apache/airflow/issues/11347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] dimberman commented on pull request #11406: Add option to enable TCP keepalive for communication with Kubernetes API

2020-10-10 Thread GitBox
dimberman commented on pull request #11406: URL: https://github.com/apache/airflow/pull/11406#issuecomment-706605122 Yeah that's fine. Maybe just add a comment saying "please ping @michalmisiewicz or @dimberman if you want to modify this function" -

[GitHub] [airflow] dimberman edited a comment on pull request #11406: Add option to enable TCP keepalive for communication with Kubernetes API

2020-10-10 Thread GitBox
dimberman edited a comment on pull request #11406: URL: https://github.com/apache/airflow/pull/11406#issuecomment-706605122 Yeah that's fine. Maybe just add a comment saying "please ping @michalmisiewicz or @dimberman in the PR if you want to modify this function"

[GitHub] [airflow] jbampton opened a new pull request #11407: Fix spelling

2020-10-10 Thread GitBox
jbampton opened a new pull request #11407: URL: https://github.com/apache/airflow/pull/11407 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] github-actions[bot] commented on pull request #11406: Add option to enable TCP keepalive for communication with Kubernetes API

2020-10-10 Thread GitBox
github-actions[bot] commented on pull request #11406: URL: https://github.com/apache/airflow/pull/11406#issuecomment-706595031 [The Workflow run](https://github.com/apache/airflow/actions/runs/299514753) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[airflow] branch master updated (0620aaa -> 7959df9)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 0620aaa Fix spelling (#11401) add 7959df9 Fix spelling (#11404) No new revisions were added by this update.

[airflow] branch master updated (0620aaa -> 7959df9)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 0620aaa Fix spelling (#11401) add 7959df9 Fix spelling (#11404) No new revisions were added by this update.

[GitHub] [airflow] potiuk commented on pull request #11384: Mutual SSL added in PGBouncer configuration in the Chart

2020-10-10 Thread GitBox
potiuk commented on pull request #11384: URL: https://github.com/apache/airflow/pull/11384#issuecomment-706594794 Seems like all the tests are passing :) and we tested it with the customer project. This is an automated messa

[GitHub] [airflow] github-actions[bot] commented on pull request #11406: Add option to enable TCP keepalive for communication with Kubernetes API

2020-10-10 Thread GitBox
github-actions[bot] commented on pull request #11406: URL: https://github.com/apache/airflow/pull/11406#issuecomment-706594621 [The Workflow run](https://github.com/apache/airflow/actions/runs/299511673) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] potiuk merged pull request #11404: Fix spelling

2020-10-10 Thread GitBox
potiuk merged pull request #11404: URL: https://github.com/apache/airflow/pull/11404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #11406: Add option to enable TCP keepalive for communication with Kubernetes API

2020-10-10 Thread GitBox
potiuk commented on pull request #11406: URL: https://github.com/apache/airflow/pull/11406#issuecomment-706594523 Yeah. I'd imagine it's difficult to test - but there are some static check problems. @michalmisiewicz - I recommend to install pre-commits :) (described in STATIC_CHECKS.rst)

[GitHub] [airflow] michalmisiewicz commented on pull request #11406: Add option to enable TCP keepalive for communication with Kubernetes API

2020-10-10 Thread GitBox
michalmisiewicz commented on pull request #11406: URL: https://github.com/apache/airflow/pull/11406#issuecomment-706592193 @dimberman This problem is hard to recreate without real infrastructure. Do you have idea how it can be tested ? -

[GitHub] [airflow] dimberman commented on pull request #11406: Add option to enable TCP keepalive for communication with Kubernetes API

2020-10-10 Thread GitBox
dimberman commented on pull request #11406: URL: https://github.com/apache/airflow/pull/11406#issuecomment-706590962 coool!! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] michalmisiewicz commented on pull request #11406: Add option to enable TCP keepalive for communication with Kubernetes API

2020-10-10 Thread GitBox
michalmisiewicz commented on pull request #11406: URL: https://github.com/apache/airflow/pull/11406#issuecomment-706590835 @dimberman @turbaszek This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] michalmisiewicz opened a new pull request #11406: Add option to enable TCP keepalive mechanism for communication with Kubernetes API

2020-10-10 Thread GitBox
michalmisiewicz opened a new pull request #11406: URL: https://github.com/apache/airflow/pull/11406 When running Airflow on Cloud Kubernetes Services like Azure Kubernetes Service, KubernetesExecutor can hangs indefinitely on pod submission due to idle connection time-out. For example in

[GitHub] [airflow] dimberman commented on a change in pull request #11385: Add capability of customising PyPI sources

2020-10-10 Thread GitBox
dimberman commented on a change in pull request #11385: URL: https://github.com/apache/airflow/pull/11385#discussion_r502816373 ## File path: docs/production-deployment.rst ## @@ -262,6 +262,14 @@ You can combine both - customizing & extending the image. You can build the imag

[GitHub] [airflow] potiuk commented on pull request #11385: Add capability of customising PyPI sources

2020-10-10 Thread GitBox
potiuk commented on pull request #11385: URL: https://github.com/apache/airflow/pull/11385#issuecomment-706589227 Would love review on that one . It's rather small :) This is an automated message from the Apache Git Service.

[GitHub] [airflow] potiuk opened a new pull request #11405: Moving the test to quarantine.

2020-10-10 Thread GitBox
potiuk opened a new pull request #11405: URL: https://github.com/apache/airflow/pull/11405 I've seen the test being flaky and failing intermittently several times. Moving it to quarantine for now. --- **^ Add meaningful description above** Read the **[Pull Req

[GitHub] [airflow] michalmisiewicz commented on issue #10636: Kubernetes executors hangs on pod submission

2020-10-10 Thread GitBox
michalmisiewicz commented on issue #10636: URL: https://github.com/apache/airflow/issues/10636#issuecomment-706587853 @dimberman Requests were hanging due to idle connection time-out on Azure Firewall. Timeout is set to [4 minutes](https://docs.microsoft.com/en-us/azure/firewall/firewall-f

[GitHub] [airflow] potiuk commented on pull request #11398: Fix case of GitHub

2020-10-10 Thread GitBox
potiuk commented on pull request #11398: URL: https://github.com/apache/airflow/pull/11398#issuecomment-706587249 We had a temporary issue with cancelling too many jobs. Can you please rebase to latest master? It should be fixed now. ---

[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
potiuk commented on pull request #11403: URL: https://github.com/apache/airflow/pull/11403#issuecomment-706586814 Yeah. It's highly and easily customisable which is good but also "move fast and break things" Here I keep track of all the issues with GitHub Actionns I opened "Apache E

[GitHub] [airflow] jbampton opened a new pull request #11404: Fix spelling

2020-10-10 Thread GitBox
jbampton opened a new pull request #11404: URL: https://github.com/apache/airflow/pull/11404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] dimberman commented on pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
dimberman commented on pull request #11403: URL: https://github.com/apache/airflow/pull/11403#issuecomment-706577850 My pleasure! Ugh between this and the fact we need to restart all jobs for single failures, github actions is becoming a "lesser of evils" rather than an optimal prod

[airflow] branch master updated: Fix spelling (#11401)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 0620aaa Fix spelling (#11401) 0620aaa is descr

[GitHub] [airflow] potiuk merged pull request #11401: Fix spelling

2020-10-10 Thread GitBox
potiuk merged pull request #11401: URL: https://github.com/apache/airflow/pull/11401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] ktrueda commented on issue #10742: Enable More PyDocStyle Checks

2020-10-10 Thread GitBox
ktrueda commented on issue #10742: URL: https://github.com/apache/airflow/issues/10742#issuecomment-706576781 Hi I wanna try D205. Can I try this ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
potiuk commented on pull request #11403: URL: https://github.com/apache/airflow/pull/11403#issuecomment-706576575 Issue opened to GitHub support to change this behaviour. It is really annoying and it has bitten me too many times already . --

[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
potiuk commented on pull request #11403: URL: https://github.com/apache/airflow/pull/11403#issuecomment-706575956 Basically it's how GA handles mistakes in task names - rather than failing, they replace it with "" ... and in this case that resulted with "Cancel any job that has any name ma

[airflow] branch master updated (a34f5ee -> 076fe88)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from a34f5ee Fixes automated upgrade to latest constraints. (#11399) add 076fe88 Fixes cancelling of too many work

[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
potiuk commented on pull request #11403: URL: https://github.com/apache/airflow/pull/11403#issuecomment-706575721 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[airflow] branch master updated: Fixes cancelling of too many workflows. (#11403)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 076fe88 Fixes cancelling of too many workflows

[GitHub] [airflow] potiuk merged pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
potiuk merged pull request #11403: URL: https://github.com/apache/airflow/pull/11403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] dimberman commented on pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
dimberman commented on pull request #11403: URL: https://github.com/apache/airflow/pull/11403#issuecomment-706575511 @potiuk I'm around. Glad to reveiw. This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk commented on pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
potiuk commented on pull request #11403: URL: https://github.com/apache/airflow/pull/11403#issuecomment-706575378 This one is pretty urgent :(. I made a mistake and now any new build image will cancel all the other ones :(.

[GitHub] [airflow] potiuk opened a new pull request #11403: Fixes cancelling of too many workflows.

2020-10-10 Thread GitBox
potiuk opened a new pull request #11403: URL: https://github.com/apache/airflow/pull/11403 A problem was introduced in #11397 where a bit too many "Build Image" jobs is being cancelled by subsequent Build Image run. For now it cancels all the Build Image jobs that are running :(.

[GitHub] [airflow] dimberman removed a comment on pull request #8009: Airflow kubernetes cli command for generating pod templates

2020-10-10 Thread GitBox
dimberman removed a comment on pull request #8009: URL: https://github.com/apache/airflow/pull/8009#issuecomment-706574271 @turbaszek @Javier162380 I'm a bit confused, how is this different from `airflow kubernetes generate-dag-yaml`? ``` (airflow) new-features (scheduler-ha-helm

[GitHub] [airflow] dimberman commented on a change in pull request #8009: Airflow kubernetes cli command for generating pod templates

2020-10-10 Thread GitBox
dimberman commented on a change in pull request #8009: URL: https://github.com/apache/airflow/pull/8009#discussion_r502807166 ## File path: airflow/cli/cli_parser.py ## @@ -1026,6 +1026,14 @@ class GroupCommand(NamedTuple): args=(ARG_ROLES,), ), ) +KUBERNETES_COM

[GitHub] [airflow] dimberman commented on pull request #8009: Airflow kubernetes cli command for generating pod templates

2020-10-10 Thread GitBox
dimberman commented on pull request #8009: URL: https://github.com/apache/airflow/pull/8009#issuecomment-706574271 @turbaszek @Javier162380 I'm a bit confused, how is this different from this command? ``` (airflow) new-features (scheduler-ha-helm-master) (⎈ |kind-airflow-python

[GitHub] [airflow] dimberman edited a comment on pull request #8009: Airflow kubernetes cli command for generating pod templates

2020-10-10 Thread GitBox
dimberman edited a comment on pull request #8009: URL: https://github.com/apache/airflow/pull/8009#issuecomment-706574271 @turbaszek @Javier162380 I'm a bit confused, how is this different from `airflow kubernetes generate-dag-yaml`? ``` (airflow) new-features (scheduler-ha-helm-

[GitHub] [airflow] github-actions[bot] commented on pull request #11402: Split tests to more sub-types

2020-10-10 Thread GitBox
github-actions[bot] commented on pull request #11402: URL: https://github.com/apache/airflow/pull/11402#issuecomment-706573197 [The Workflow run](https://github.com/apache/airflow/actions/runs/299356179) is cancelling this PR. Building image for the PR has been cancelled -

[GitHub] [airflow] potiuk commented on pull request #11402: Split tests to more sub-types

2020-10-10 Thread GitBox
potiuk commented on pull request #11402: URL: https://github.com/apache/airflow/pull/11402#issuecomment-706573098 This is an attempt to improve stability in our tests. I am still trying it - it will likely fail (I had to move tests from "tests" to "core" directory and it likely will cause

[GitHub] [airflow] michalmisiewicz commented on a change in pull request #11395: Pass SQLAlchemy engine options to FAB based UI

2020-10-10 Thread GitBox
michalmisiewicz commented on a change in pull request #11395: URL: https://github.com/apache/airflow/pull/11395#discussion_r502805930 ## File path: airflow/settings.py ## @@ -158,8 +158,30 @@ def configure_orm(disable_connection_pool=False): log.debug("Setting up DB connec

[GitHub] [airflow] potiuk opened a new pull request #11402: Split tests to more sub-types

2020-10-10 Thread GitBox
potiuk opened a new pull request #11402: URL: https://github.com/apache/airflow/pull/11402 We seem to have a problem with running all tests at once - most likely due to some resource problems in our CI, therefore it makes sense to split the tests into more batches. This is not yet full

[GitHub] [airflow] jbampton opened a new pull request #11401: Fix spelling

2020-10-10 Thread GitBox
jbampton opened a new pull request #11401: URL: https://github.com/apache/airflow/pull/11401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] github-actions[bot] commented on pull request #11400: Wrong SHA was used for cancel-workflow-action in #11397

2020-10-10 Thread GitBox
github-actions[bot] commented on pull request #11400: URL: https://github.com/apache/airflow/pull/11400#issuecomment-706560152 [The Workflow run](https://github.com/apache/airflow/actions/runs/299199113) is cancelling this PR. Building image for the PR has been cancelled -

[GitHub] [airflow] github-actions[bot] commented on pull request #11400: Wrong SHA was used for cancel-workflow-action in #11397

2020-10-10 Thread GitBox
github-actions[bot] commented on pull request #11400: URL: https://github.com/apache/airflow/pull/11400#issuecomment-706550246 [The Workflow run](https://github.com/apache/airflow/actions/runs/299199113) is cancelling this PR. Building image for the PR has been cancelled -

[GitHub] [airflow] potiuk opened a new pull request #11400: Wrong SHA was used for cancel-workflow-action in #11397

2020-10-10 Thread GitBox
potiuk opened a new pull request #11400: URL: https://github.com/apache/airflow/pull/11400 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more in

[GitHub] [airflow] mcepok commented on a change in pull request #11219: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader

2020-10-10 Thread GitBox
mcepok commented on a change in pull request #11219: URL: https://github.com/apache/airflow/pull/11219#discussion_r502790203 ## File path: tests/kubernetes/test_refresh_config.py ## @@ -0,0 +1,31 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader

2020-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211703#comment-17211703 ] ASF GitHub Bot commented on AIRFLOW-6585: - mcepok commented on a change in pull

[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader

2020-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211702#comment-17211702 ] ASF GitHub Bot commented on AIRFLOW-6585: - mcepok commented on a change in pull

[GitHub] [airflow] mcepok commented on a change in pull request #11219: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader

2020-10-10 Thread GitBox
mcepok commented on a change in pull request #11219: URL: https://github.com/apache/airflow/pull/11219#discussion_r502790183 ## File path: airflow/kubernetes/refresh_config.py ## @@ -24,15 +24,22 @@ import logging import os import time -from datetime import datetime from ty

[airflow] branch master updated (7507183 -> a34f5ee)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 7507183 Remove redundant parentheses from Python files (#10967) add a34f5ee Fixes automated upgrade to latest

[airflow] branch master updated (7507183 -> a34f5ee)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 7507183 Remove redundant parentheses from Python files (#10967) add a34f5ee Fixes automated upgrade to latest

[airflow] branch master updated (401a579 -> 7507183)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 401a579 Push and schedule duplicates are not cancelled. (#11397) add 7507183 Remove redundant parentheses fro

[airflow] branch master updated (401a579 -> 7507183)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 401a579 Push and schedule duplicates are not cancelled. (#11397) add 7507183 Remove redundant parentheses fro

[GitHub] [airflow] github-actions[bot] commented on pull request #10162: Add Airflow UI site_title configuration option

2020-10-10 Thread GitBox
github-actions[bot] commented on pull request #10162: URL: https://github.com/apache/airflow/pull/10162#issuecomment-706547003 [The Workflow run](https://github.com/apache/airflow/actions/runs/299172344) is cancelling this PR. Building image for the PR has been cancelled -

[GitHub] [airflow] potiuk merged pull request #10967: Remove redundant parentheses from Python files

2020-10-10 Thread GitBox
potiuk merged pull request #10967: URL: https://github.com/apache/airflow/pull/10967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk merged pull request #11399: Fixes automated upgrade to latest constraints.

2020-10-10 Thread GitBox
potiuk merged pull request #11399: URL: https://github.com/apache/airflow/pull/11399 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #10967: Remove redundant parentheses from Python files

2020-10-10 Thread GitBox
potiuk commented on pull request #10967: URL: https://github.com/apache/airflow/pull/10967#issuecomment-706546881 Thanks @jbampton ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] github-actions[bot] commented on pull request #11396: Add creating_job_id to DagRun table

2020-10-10 Thread GitBox
github-actions[bot] commented on pull request #11396: URL: https://github.com/apache/airflow/pull/11396#issuecomment-706545954 [The Workflow run](https://github.com/apache/airflow/actions/runs/299170220) is cancelling this PR. Building image for the PR has been cancelled -

[GitHub] [airflow] pcandoalmeida commented on a change in pull request #10162: Add Airflow UI site_title configuration option

2020-10-10 Thread GitBox
pcandoalmeida commented on a change in pull request #10162: URL: https://github.com/apache/airflow/pull/10162#discussion_r502785541 ## File path: scripts/ci/static_checks/ci_pylint_tests.sh ## @@ -0,0 +1,57 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (

[GitHub] [airflow] turbaszek commented on pull request #10151: Acquire lock on db for the time of migration

2020-10-10 Thread GitBox
turbaszek commented on pull request #10151: URL: https://github.com/apache/airflow/pull/10151#issuecomment-706540657 @anitakar can you rebase the PR? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] turbaszek commented on a change in pull request #10162: Add Airflow UI site_title configuration option

2020-10-10 Thread GitBox
turbaszek commented on a change in pull request #10162: URL: https://github.com/apache/airflow/pull/10162#discussion_r502784694 ## File path: scripts/ci/static_checks/ci_pylint_tests.sh ## @@ -0,0 +1,57 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] turbaszek commented on a change in pull request #10162: Add Airflow UI site_title configuration option

2020-10-10 Thread GitBox
turbaszek commented on a change in pull request #10162: URL: https://github.com/apache/airflow/pull/10162#discussion_r502784694 ## File path: scripts/ci/static_checks/ci_pylint_tests.sh ## @@ -0,0 +1,57 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (AIRFLOW-6829) Auto apply apply_default decorator to all sub-classess

2020-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211688#comment-17211688 ] ASF GitHub Bot commented on AIRFLOW-6829: - ashb commented on pull request #7450

[GitHub] [airflow] ashb commented on pull request #7450: [AIRFLOW-6829][WIP] Auto-apply apply_default

2020-10-10 Thread GitBox
ashb commented on pull request #7450: URL: https://github.com/apache/airflow/pull/7450#issuecomment-706540220 Yeah I agree - missing this out was a common mistske! This is an automated message from the Apache Git Service. To

[GitHub] [airflow] turbaszek commented on pull request #8009: Airflow kubernetes cli command for generating pod templates

2020-10-10 Thread GitBox
turbaszek commented on pull request #8009: URL: https://github.com/apache/airflow/pull/8009#issuecomment-706539917 @dimberman is this something that may help us for migration to Airflow 2.0? This is an automated message from

[jira] [Commented] (AIRFLOW-6829) Auto apply apply_default decorator to all sub-classess

2020-10-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211683#comment-17211683 ] ASF GitHub Bot commented on AIRFLOW-6829: - turbaszek commented on pull request

[GitHub] [airflow] turbaszek commented on pull request #7450: [AIRFLOW-6829][WIP] Auto-apply apply_default

2020-10-10 Thread GitBox
turbaszek commented on pull request #7450: URL: https://github.com/apache/airflow/pull/7450#issuecomment-706539768 @mik-laj I think it would be awesome to have this in Airflow 2.0. @ashb @potiuk @kaxil WDYT? This is an autom

[GitHub] [airflow] potiuk opened a new pull request #11399: Fixes automated upgrade to latest constraints.

2020-10-10 Thread GitBox
potiuk opened a new pull request #11399: URL: https://github.com/apache/airflow/pull/11399 Wrong if query in the GitHub action caused upgrade to latest constraints did not work for a while. --- **^ Add meaningful description above** Read the **[Pull Request Guideline

[GitHub] [airflow] turbaszek commented on a change in pull request #11395: Pass SQLAlchemy engine options to FAB based UI

2020-10-10 Thread GitBox
turbaszek commented on a change in pull request #11395: URL: https://github.com/apache/airflow/pull/11395#discussion_r502783659 ## File path: airflow/settings.py ## @@ -158,8 +158,30 @@ def configure_orm(disable_connection_pool=False): log.debug("Setting up DB connection p

[GitHub] [airflow] turbaszek commented on pull request #11396: Add supervising_job_id to DagRun table

2020-10-10 Thread GitBox
turbaszek commented on pull request #11396: URL: https://github.com/apache/airflow/pull/11396#issuecomment-706538104 > One comment - calling it supervising job id isn't right for non Backfill jobs - each TI could be created and supervised by a different SchedulerJob That's true. How

[airflow] branch master updated: Push and schedule duplicates are not cancelled. (#11397)

2020-10-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 401a579 Push and schedule duplicates are not c

[GitHub] [airflow] potiuk merged pull request #11397: Push and schedule duplicates are not cancelled.

2020-10-10 Thread GitBox
potiuk merged pull request #11397: URL: https://github.com/apache/airflow/pull/11397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   >