[GitHub] [airflow] github-actions[bot] commented on pull request #17247: Fixed SlackAPIFileOperator to upload file and file content

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #17247: URL: https://github.com/apache/airflow/pull/17247#issuecomment-889667579 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] sudipto9 commented on issue #17120: [Scheduler error] psycopg2.OperationalError: SSL SYSCALL error: Socket operation on non-socket

2021-07-29 Thread GitBox
sudipto9 commented on issue #17120: URL: https://github.com/apache/airflow/issues/17120#issuecomment-889663324 @potiuk I have copied the code in the external Libraries's dist-packages/airflow/cli/commands folder. After that Iran below commands to start airflow again. airflow db init

[GitHub] [airflow] uranusjr commented on a change in pull request #17247: Fixed SlackAPIFileOperator to upload file and file content

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #17247: URL: https://github.com/apache/airflow/pull/17247#discussion_r679680023 ## File path: airflow/providers/slack/operators/slack.py ## @@ -161,16 +161,26 @@ class SlackAPIFileOperator(SlackAPIOperator): .. code-block::

[GitHub] [airflow] github-actions[bot] commented on pull request #17331: refactor: fixed type annotation for 'sql' param in PostgresOperator

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #17331: URL: https://github.com/apache/airflow/pull/17331#issuecomment-889660405 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] uranusjr commented on a change in pull request #16860: Support DAGS folder being in different location on scheduler and runners

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #16860: URL: https://github.com/apache/airflow/pull/16860#discussion_r679677448 ## File path: airflow/models/dag.py ## @@ -235,13 +236,21 @@ class DAG(LoggingMixin): 'parent_dag', 'start_date', 'schedule_

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17331: refactor: fixed type annotation for 'sql' param in PostgresOperator

2021-07-29 Thread GitBox
boring-cyborg[bot] commented on pull request #17331: URL: https://github.com/apache/airflow/pull/17331#issuecomment-889659167 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] shadrus opened a new pull request #17331: refactor: fixed type annotation for 'sql' param in PostgresOperator

2021-07-29 Thread GitBox
shadrus opened a new pull request #17331: URL: https://github.com/apache/airflow/pull/17331 According to the documentation sql param of PostgresOperator can receive a str representing a sql statement,a list of str (sql statements), or reference to a template file. But type annotatio

[GitHub] [airflow] uranusjr commented on issue #17310: Got `subprocess.TimeoutExpired` when run `./breeze --python 3.8 buildl-docs` on Apple M1 chip

2021-07-29 Thread GitBox
uranusjr commented on issue #17310: URL: https://github.com/apache/airflow/issues/17310#issuecomment-889653748 Looks like the doc just builds to slowly on the machine. I don’t think there’s much we can do here (except increasing the timeout, which is probably not that meaningful…) -- Th

[GitHub] [airflow] uranusjr commented on a change in pull request #17284: Add support of `path` parameter for GCloud Storage Transfer Service operators

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #17284: URL: https://github.com/apache/airflow/pull/17284#discussion_r679671144 ## File path: airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py ## @@ -861,6 +867,10 @@ def __init__( def _validate_inpu

[GitHub] [airflow] mgorsk1 commented on pull request #16945: Enable using custom pod launcher in Kubernetes Pod Operator

2021-07-29 Thread GitBox
mgorsk1 commented on pull request #16945: URL: https://github.com/apache/airflow/pull/16945#issuecomment-889648833 any chance this could land in 2.1.3 @potiuk? 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] github-actions[bot] commented on pull request #17269: Handle connection parameters added to Extra and custom fields

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #17269: URL: https://github.com/apache/airflow/pull/17269#issuecomment-889647566 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] CreedsCode commented on issue #17307: Trigger Config, Trigger Config Template

2021-07-29 Thread GitBox
CreedsCode commented on issue #17307: URL: https://github.com/apache/airflow/issues/17307#issuecomment-889637533 Yes! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [airflow] uranusjr opened a new pull request #17330: Fix isort error

2021-07-29 Thread GitBox
uranusjr opened a new pull request #17330: URL: https://github.com/apache/airflow/pull/17330 Seems like a linter error slipped into main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [airflow] uranusjr commented on a change in pull request #17324: Improve `dag_maker` fixture

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #17324: URL: https://github.com/apache/airflow/pull/17324#discussion_r679648318 ## File path: tests/conftest.py ## @@ -444,33 +445,44 @@ def __exit__(self, type, value, traceback): dag.__exit__(type, value, traceback)

[GitHub] [airflow] uranusjr commented on issue #13750: Support Standard SQL in BigQuery Sensor

2021-07-29 Thread GitBox
uranusjr commented on issue #13750: URL: https://github.com/apache/airflow/issues/13750#issuecomment-889624601 We should probably support passing arguments from a sensor to the underlying hook. Something like this? ```python sense_data = SqlSensor( task_id="sense_data",

[GitHub] [airflow] flolas opened a new pull request #17329: Split sql statements in DbApi run

2021-07-29 Thread GitBox
flolas opened a new pull request #17329: URL: https://github.com/apache/airflow/pull/17329 Split sql statements in dbapi hook using sqlparse. closes: #16979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] uranusjr closed pull request #17280: Opmitise LoggingMixin.log

2021-07-29 Thread GitBox
uranusjr closed pull request #17280: URL: https://github.com/apache/airflow/pull/17280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] uranusjr commented on pull request #17278: Fix `airflow celery stop` to accept the pid file.

2021-07-29 Thread GitBox
uranusjr commented on pull request #17278: URL: https://github.com/apache/airflow/pull/17278#issuecomment-889622219 This bot makes me happy every time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[airflow] branch main updated: Fix `airflow celery stop` to accept the pid file. (#17278)

2021-07-29 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b814a58 Fix `airflow celery stop` to accept the

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17278: Fix `airflow celery stop` to accept the pid file.

2021-07-29 Thread GitBox
boring-cyborg[bot] commented on pull request #17278: URL: https://github.com/apache/airflow/pull/17278#issuecomment-889621916 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] uranusjr merged pull request #17278: Fix `airflow celery stop` to accept the pid file.

2021-07-29 Thread GitBox
uranusjr merged pull request #17278: URL: https://github.com/apache/airflow/pull/17278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] uranusjr commented on a change in pull request #17322: Added print statements for clarity in provider yaml checks

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #17322: URL: https://github.com/apache/airflow/pull/17322#discussion_r679640450 ## File path: scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py ## @@ -119,13 +119,13 @@ def assert_sets_equal(set1, set2): lines =

[GitHub] [airflow] uranusjr commented on issue #16372: Update template context to deprecate `execution_date` and add new "interval" properties

2021-07-29 Thread GitBox
uranusjr commented on issue #16372: URL: https://github.com/apache/airflow/issues/16372#issuecomment-889619393 Figured it out in #16352. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [airflow] uranusjr commented on pull request #16666: Replace execution_date with run_id in airflow tasks run command

2021-07-29 Thread GitBox
uranusjr commented on pull request #1: URL: https://github.com/apache/airflow/pull/1#issuecomment-889618901 We need to do #17046 first then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[airflow] branch main updated: Fix typo in build_images (#17327)

2021-07-29 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 78506e3 Fix typo in build_images (#17327) 78506e

[GitHub] [airflow] uranusjr merged pull request #17327: Fix typo in build_images

2021-07-29 Thread GitBox
uranusjr merged pull request #17327: URL: https://github.com/apache/airflow/pull/17327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] sudipto9 edited a comment on issue #17120: [Scheduler error] psycopg2.OperationalError: SSL SYSCALL error: Socket operation on non-socket

2021-07-29 Thread GitBox
sudipto9 edited a comment on issue #17120: URL: https://github.com/apache/airflow/issues/17120#issuecomment-889114171 @potiuk is this fix in production? I am having postgres as database. I am using below version packages. Airflow - 2.1.2 sqlalchemy=1.3.24 psycopg2=2.9.1 G

[GitHub] [airflow] uranusjr commented on a change in pull request #17319: Suggest to use secrets backend for variable when it contains sensitive data

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #17319: URL: https://github.com/apache/airflow/pull/17319#discussion_r679636042 ## File path: docs/apache-airflow/best-practices.rst ## @@ -109,8 +112,12 @@ or if you need to deserialize a json object from the variable : {{

[GitHub] [airflow] sighingnow closed issue #17073: Support defining pre/post hook for operators in a DAG at the DAG level

2021-07-29 Thread GitBox
sighingnow closed issue #17073: URL: https://github.com/apache/airflow/issues/17073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] sighingnow commented on issue #17073: Support defining pre/post hook for operators in a DAG at the DAG level

2021-07-29 Thread GitBox
sighingnow commented on issue #17073: URL: https://github.com/apache/airflow/issues/17073#issuecomment-889609376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [airflow] uranusjr commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r679621592 ## File path: airflow/models/taskinstance.py ## @@ -1670,37 +1667,97 @@ def get( except AirflowNotFoundException:

[GitHub] [airflow] uranusjr commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r679620955 ## File path: airflow/timetables/base.py ## @@ -79,6 +74,18 @@ def interval(cls, start: DateTime, end: DateTime) -> "DagRunInfo": """

[GitHub] [airflow] sudipto9 commented on issue #17120: [Scheduler error] psycopg2.OperationalError: SSL SYSCALL error: Socket operation on non-socket

2021-07-29 Thread GitBox
sudipto9 commented on issue #17120: URL: https://github.com/apache/airflow/issues/17120#issuecomment-889600308 Thank you @potiuk for quick reply. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] uranusjr commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r679620135 ## File path: airflow/models/taskinstance.py ## @@ -1670,37 +1667,97 @@ def get( except AirflowNotFoundException:

[GitHub] [airflow] uranusjr commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r679619712 ## File path: airflow/models/taskinstance.py ## @@ -1530,21 +1532,25 @@ def get_template_context(self, session=None) -> Context: integrate_mac

[GitHub] [airflow] uranusjr commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r679619000 ## File path: airflow/jobs/backfill_job.py ## @@ -755,8 +759,13 @@ def _execute(self, session=None): start_date = self.bf_start_date -

[GitHub] [airflow] uranusjr commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-07-29 Thread GitBox
uranusjr commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r679613989 ## File path: airflow/models/dag.py ## @@ -596,23 +649,17 @@ def get_run_dates(self, start_date, end_date=None, *, align: bool = True): :retu

[GitHub] [airflow] ChaiZhi commented on issue #15978: DAG getting stuck in "running" state indefinitely

2021-07-29 Thread GitBox
ChaiZhi commented on issue #15978: URL: https://github.com/apache/airflow/issues/15978#issuecomment-889590282 @daoudjahdou Are you using the `SequentialExecutor` with `sqlite`? I have the same issue with sqlite, I think it may cause by the: ``` Because we cannot use more th

[GitHub] [airflow] github-actions[bot] commented on pull request #17327: Fix typo in build_images

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #17327: URL: https://github.com/apache/airflow/pull/17327#issuecomment-889572893 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] Dr-Denzy removed a comment on issue #17046: Ensure all tests that create TaskInstances in DB also create DagRuns

2021-07-29 Thread GitBox
Dr-Denzy removed a comment on issue #17046: URL: https://github.com/apache/airflow/issues/17046#issuecomment-889554725 Test comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [airflow] Dr-Denzy commented on issue #17046: Ensure all tests that create TaskInstances in DB also create DagRuns

2021-07-29 Thread GitBox
Dr-Denzy commented on issue #17046: URL: https://github.com/apache/airflow/issues/17046#issuecomment-889554725 Test comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] kaxil commented on issue #16703: Workers silently crash after memory build up

2021-07-29 Thread GitBox
kaxil commented on issue #16703: URL: https://github.com/apache/airflow/issues/16703#issuecomment-889550833 Yes please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [airflow] kaxil commented on a change in pull request #17100: WIP: Advanced Params using json-schema

2021-07-29 Thread GitBox
kaxil commented on a change in pull request #17100: URL: https://github.com/apache/airflow/pull/17100#discussion_r679573636 ## File path: airflow/models/dag.py ## @@ -1976,7 +1981,7 @@ def create_dagrun( run_id: Optional[str] = None, start_date: Optional[datet

[GitHub] [airflow] kaxil commented on pull request #17121: [WIP] Deactivating DAGs which have been removed from files

2021-07-29 Thread GitBox
kaxil commented on pull request #17121: URL: https://github.com/apache/airflow/pull/17121#issuecomment-889549280 Can you rebase on latest main please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] kaxil commented on issue #15670: Pod overrides not working

2021-07-29 Thread GitBox
kaxil commented on issue #15670: URL: https://github.com/apache/airflow/issues/15670#issuecomment-889548384 Yup you are right @Jaxing , use the following that should work both in 1.10.15 and 2.*. It will help in migrations, once you upgrade to Airflow 2.0+, you can then change to using pod

[GitHub] [airflow] kaxil edited a comment on issue #17257: Extend SubDagOperator, alert dag seems to be missing

2021-07-29 Thread GitBox
kaxil edited a comment on issue #17257: URL: https://github.com/apache/airflow/issues/17257#issuecomment-889546308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [airflow] kaxil commented on issue #17257: Extend SubDagOperator, alert dag seems to be missing

2021-07-29 Thread GitBox
kaxil commented on issue #17257: URL: https://github.com/apache/airflow/issues/17257#issuecomment-889546308 `(isinstance(current_task, SubDagOperator)` should return true if you extend SubDagOperator, example: ``` In [1]: from airflow.operators.subdag import SubDagOperator

[GitHub] [airflow] Dr-Denzy removed a comment on issue #16303: Replace `execution_date` in `TI.generate_command` to send run_id instead

2021-07-29 Thread GitBox
Dr-Denzy removed a comment on issue #16303: URL: https://github.com/apache/airflow/issues/16303#issuecomment-889545508 Another test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] Dr-Denzy commented on issue #16303: Replace `execution_date` in `TI.generate_command` to send run_id instead

2021-07-29 Thread GitBox
Dr-Denzy commented on issue #16303: URL: https://github.com/apache/airflow/issues/16303#issuecomment-889545508 Another test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] Dr-Denzy removed a comment on issue #16372: Update template context to deprecate `execution_date` and add new "interval" properties

2021-07-29 Thread GitBox
Dr-Denzy removed a comment on issue #16372: URL: https://github.com/apache/airflow/issues/16372#issuecomment-889543762 This is a test comment to test my code. To be deleted soon after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] kaxil commented on a change in pull request #17201: [AIRFLOW-17200] Add Alibaba Cloud OSS support

2021-07-29 Thread GitBox
kaxil commented on a change in pull request #17201: URL: https://github.com/apache/airflow/pull/17201#discussion_r679568071 ## File path: CONTRIBUTING.rst ## @@ -654,6 +654,7 @@ Here is the list of packages and their extras: PackageExtras =

[GitHub] [airflow] Dr-Denzy commented on issue #16372: Update template context to deprecate `execution_date` and add new "interval" properties

2021-07-29 Thread GitBox
Dr-Denzy commented on issue #16372: URL: https://github.com/apache/airflow/issues/16372#issuecomment-889543762 This is a test comment to test my code. To be deleted soon after. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] kaxil commented on a change in pull request #16681: Introduce RESTARTING state

2021-07-29 Thread GitBox
kaxil commented on a change in pull request #16681: URL: https://github.com/apache/airflow/pull/16681#discussion_r679567231 ## File path: UPDATING.md ## @@ -127,6 +127,10 @@ If you are using DAGs Details API endpoint, use `max_active_tasks` instead of `c When marking a task

[GitHub] [airflow] kaxil commented on a change in pull request #16681: Introduce RESTARTING state

2021-07-29 Thread GitBox
kaxil commented on a change in pull request #16681: URL: https://github.com/apache/airflow/pull/16681#discussion_r679566959 ## File path: airflow/www/static/css/tree.css ## @@ -67,6 +67,10 @@ rect.shutdown { fill: blue; } +rect.restarting { + fill: violet; Review commen

[GitHub] [airflow] kaxil commented on a change in pull request #16003: Fixed Discord Webhook endpoint

2021-07-29 Thread GitBox
kaxil commented on a change in pull request #16003: URL: https://github.com/apache/airflow/pull/16003#discussion_r679566340 ## File path: airflow/providers/discord/hooks/discord_webhook.py ## @@ -101,7 +101,7 @@ def _get_webhook_endpoint(self, http_conn_id: Optional[str], webh

[GitHub] [airflow] kaxil commented on issue #15607: airflow throws error: airflow.exceptions.SerializedDagNotFound: DAG 'dns-basic-1min' not found in serialized_dag table

2021-07-29 Thread GitBox
kaxil commented on issue #15607: URL: https://github.com/apache/airflow/issues/15607#issuecomment-889541719 @neilharia7 The problem for you seems like `cross-sell-v3-new` DAG does not exist when Airflow parses it sometimes, which is why Airflow removes it from the `serialized_dag` table. I

[GitHub] [airflow] kaxil commented on a change in pull request #16352: AIP-39: ``DagRun.data_interval_start`` and ``data_interval_end``

2021-07-29 Thread GitBox
kaxil commented on a change in pull request #16352: URL: https://github.com/apache/airflow/pull/16352#discussion_r679537509 ## File path: airflow/models/dag.py ## @@ -596,23 +649,17 @@ def get_run_dates(self, start_date, end_date=None, *, align: bool = True): :return:

[GitHub] [airflow] github-actions[bot] closed issue #15340: helm install airflow in namespace get error: File "", line 32, in TimeoutError: There are still unapplied migrations after

2021-07-29 Thread GitBox
github-actions[bot] closed issue #15340: URL: https://github.com/apache/airflow/issues/15340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [airflow] github-actions[bot] commented on issue #15340: helm install airflow in namespace get error: File "", line 32, in TimeoutError: There are still unapplied migrations

2021-07-29 Thread GitBox
github-actions[bot] commented on issue #15340: URL: https://github.com/apache/airflow/issues/15340#issuecomment-889535624 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed pull request #16161: Ensure datasetReference key exists in BigQueryHook.create_empty_dataset

2021-07-29 Thread GitBox
github-actions[bot] closed pull request #16161: URL: https://github.com/apache/airflow/pull/16161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #15409: Support regex pattern in SFTPHOOK

2021-07-29 Thread GitBox
github-actions[bot] closed pull request #15409: URL: https://github.com/apache/airflow/pull/15409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #15419: Subtract file log reader into separate functions

2021-07-29 Thread GitBox
github-actions[bot] closed pull request #15419: URL: https://github.com/apache/airflow/pull/15419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #15429: Add support for Hyperparameter Tuning on Google Cloud AI Platform

2021-07-29 Thread GitBox
github-actions[bot] closed pull request #15429: URL: https://github.com/apache/airflow/pull/15429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj commented on issue #17307: Trigger Config, Trigger Config Template

2021-07-29 Thread GitBox
mik-laj commented on issue #17307: URL: https://github.com/apache/airflow/issues/17307#issuecomment-889534585 It is related? https://github.com/apache/airflow/pull/17100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. The causes of this issue are still not clearly identified, or confirmed. > Docker-Compose of Airlow is not producti

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. The causes of this issue are still not clearly identified, or confirmed. > Docker-Compose of Airlow is not producti

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. The causes of this issue are still not clearly identified, or confirmed. > Docker-Compose of Airlow is not producti

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. The causes of this issue are still not clearly identified, or confirmed. > Docker-Compose of Airlow is not producti

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. > Docker-Compose of Airlow is not production ready. You should use it only for development and testing I am

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. > Docker-Compose of Airlow is not production ready. You should use it only for development and testing I am

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. > Docker-Compose of Airlow is not production ready. You should use it only for development and testing I am

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. > Docker-Compose of Airlow is not production ready. You should use it only for development and testing I am

[GitHub] [airflow] ImadYIdrissi edited a comment on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi edited a comment on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. > Docker-Compose of Airlow is not production ready. You should use it only for development and testing I am

[GitHub] [airflow] ImadYIdrissi commented on issue #17320: PermissionDenied : Unable to use docker-compose due to UID conflicts

2021-07-29 Thread GitBox
ImadYIdrissi commented on issue #17320: URL: https://github.com/apache/airflow/issues/17320#issuecomment-889526816 I don't understand why this thread was closed. > Docker-Compose of Airlow is not production ready. You should use it only for development and testing I am not try

[GitHub] [airflow] jedcunningham commented on issue #16895: Chart: remote_logging keeps evaluating to False

2021-07-29 Thread GitBox
jedcunningham commented on issue #16895: URL: https://github.com/apache/airflow/issues/16895#issuecomment-889524824 With Airflow config, the first one wins out of: env var, config file, commands, secrets, default config Env var still seems like the most likely cause. Config file seem

[GitHub] [airflow] fatmumuhomer commented on pull request #17236: [Airflow 16364] Add conn_timeout and cmd_timeout params to SSHOperator; add conn_timeout param to SSHHook

2021-07-29 Thread GitBox
fatmumuhomer commented on pull request #17236: URL: https://github.com/apache/airflow/pull/17236#issuecomment-889513134 @uranusjr Thanks. What happens next? How do these changes get merged into the main project? -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [airflow] jedcunningham opened a new pull request #17327: Fix typo in build_images

2021-07-29 Thread GitBox
jedcunningham opened a new pull request #17327: URL: https://github.com/apache/airflow/pull/17327 Ran across a typo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[airflow] branch main updated: GCP Secret Manager error handling for missing credentials (#17264)

2021-07-29 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c384f9b GCP Secret Manager error handling for m

[GitHub] [airflow] kaxil merged pull request #17264: GCP Secret Manager Error Handling for Missings Credentials

2021-07-29 Thread GitBox
kaxil merged pull request #17264: URL: https://github.com/apache/airflow/pull/17264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] kaxil commented on a change in pull request #17273: Switch to 'smbprotocol' library

2021-07-29 Thread GitBox
kaxil commented on a change in pull request #17273: URL: https://github.com/apache/airflow/pull/17273#discussion_r679524213 ## File path: CHANGELOG.txt ## @@ -1,3 +1,10 @@ +Improvements + + +- The Samba hook now uses the `smbprotocol` library, exposing a much + big

[GitHub] [airflow] kaxil closed pull request #17264: GCP Secret Manager Error Handling for Missings Credentials

2021-07-29 Thread GitBox
kaxil closed pull request #17264: URL: https://github.com/apache/airflow/pull/17264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] jedcunningham opened a new issue #17326: `TestLocalTaskJob.test_mark_success_no_kill` fails consistently on MSSQL

2021-07-29 Thread GitBox
jedcunningham opened a new issue #17326: URL: https://github.com/apache/airflow/issues/17326 **Apache Airflow version**: main **Environment**: CI **What happened**: The `TestLocalTaskJob.test_mark_success_no_kill` no longer passes on MSSQL. I initially thought it was a

[GitHub] [airflow] dinigo commented on issue #13750: Support Standard SQL in BigQuery Sensor

2021-07-29 Thread GitBox
dinigo commented on issue #13750: URL: https://github.com/apache/airflow/issues/13750#issuecomment-889471613 In cae someone comes around looking for a solution for this. I solved it with this quick fix ```python class BigQuerySqlSensor(SqlSensor): """ Overwrites the use_leg

[GitHub] [airflow] dinigo commented on issue #17315: SqlSensor with Standard SQL BigQuery dialect (allow to pass config to injected (DI) hooks)

2021-07-29 Thread GitBox
dinigo commented on issue #17315: URL: https://github.com/apache/airflow/issues/17315#issuecomment-889466240 You are right! I was naively thinking that maybe the rest of `DbApiHook`s would be using "magic" constants. But not. Only Google does this sort of stuff. I'll close the issue and, i

[GitHub] [airflow] dlampa commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

2021-07-29 Thread GitBox
dlampa commented on pull request #17298: URL: https://github.com/apache/airflow/pull/17298#issuecomment-889456928 @XD-DENG Thank you, definitely looking forward to contributing more to this amazing project in the future! -- This is an automated message from the Apache Git Service. To res

[GitHub] [airflow] potiuk closed issue #17299: Airflow 2.1.2 not working with VPN (browser extension) on Ubuntu

2021-07-29 Thread GitBox
potiuk closed issue #17299: URL: https://github.com/apache/airflow/issues/17299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk commented on issue #17299: Airflow 2.1.2 not working with VPN (browser extension) on Ubuntu

2021-07-29 Thread GitBox
potiuk commented on issue #17299: URL: https://github.com/apache/airflow/issues/17299#issuecomment-889454636 This is a problem with your VPN, not airflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on pull request #17322: Added print statements for clarity in provider yaml checks

2021-07-29 Thread GitBox
potiuk commented on pull request #17322: URL: https://github.com/apache/airflow/pull/17322#issuecomment-889452202 some static (ups!) checks fail :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] github-actions[bot] commented on pull request #17322: Added print statements for clarity in provider yaml checks

2021-07-29 Thread GitBox
github-actions[bot] commented on pull request #17322: URL: https://github.com/apache/airflow/pull/17322#issuecomment-889451476 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] baryluk opened a new pull request #17325: s3 unify_bucket_name_and_key simplify

2021-07-29 Thread GitBox
baryluk opened a new pull request #17325: URL: https://github.com/apache/airflow/pull/17325 This `if key_name ...` part was doing nothing. `key_name` in previous code was always a one of two thing. Never empty, None, etc. (the typing annotation was wrong) So` if key_name` always

[GitHub] [airflow] ephraimbuddy opened a new pull request #17324: Improve `dag_maker` fixture

2021-07-29 Thread GitBox
ephraimbuddy opened a new pull request #17324: URL: https://github.com/apache/airflow/pull/17324 This PR improves the dag_maker fixture to enable creation of dagrun, dag and dag_model separately --- **^ Add meaningful description above** Read the **[Pull Request Guidelines

[GitHub] [airflow] peter-volkov commented on pull request #17033: Add autoscaling subcluster support and remove defaults

2021-07-29 Thread GitBox
peter-volkov commented on pull request #17033: URL: https://github.com/apache/airflow/pull/17033#issuecomment-889433645 @potiuk is main branch supposed to be green now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] XD-DENG commented on issue #16013: CLI 'kubernetes cleanup-pods' fails on invalid label key

2021-07-29 Thread GitBox
XD-DENG commented on issue #16013: URL: https://github.com/apache/airflow/issues/16013#issuecomment-889432742 Hi all, thanks to @dlampa , we have a fix for this issue now (https://github.com/apache/airflow/pull/17298). The fix is merged into `main` branch now. I have marked it for mi

[GitHub] [airflow] XD-DENG commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

2021-07-29 Thread GitBox
XD-DENG commented on pull request #17298: URL: https://github.com/apache/airflow/pull/17298#issuecomment-889431421 @dlampa , Congrats on your first PR merged in Airflow project ;-) Really appreciate your help fixing this issue, and thanks for your interest contributing to Airflow. Lo

[GitHub] [airflow] XD-DENG commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

2021-07-29 Thread GitBox
XD-DENG commented on pull request #17298: URL: https://github.com/apache/airflow/pull/17298#issuecomment-889430633 Merged. One test was failing but irrelevant to me and should be a flaky test. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] XD-DENG merged pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

2021-07-29 Thread GitBox
XD-DENG merged pull request #17298: URL: https://github.com/apache/airflow/pull/17298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[airflow] branch main updated: Fix CLI 'kubernetes cleanup-pods' which fails on invalid label key (#17298)

2021-07-29 Thread xddeng
This is an automated email from the ASF dual-hosted git repository. xddeng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 36bdfe8 Fix CLI 'kubernetes cleanup-pods' which fa

[GitHub] [airflow] XD-DENG closed issue #16013: CLI 'kubernetes cleanup-pods' fails on invalid label key

2021-07-29 Thread GitBox
XD-DENG closed issue #16013: URL: https://github.com/apache/airflow/issues/16013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17298: Fix for #16013 - CLI 'kubernetes cleanup-pods' fails on invalid label key

2021-07-29 Thread GitBox
boring-cyborg[bot] commented on pull request #17298: URL: https://github.com/apache/airflow/pull/17298#issuecomment-889430312 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[airflow] branch main updated: docs: fix inconsistencies in configuration docs (#17317)

2021-07-29 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2020a54 docs: fix inconsistencies in config

  1   2   3   >