[GitHub] [airflow] RickRen7575 commented on pull request #18615: fix template string passed to env_vars when using render_template_as_native_obj for Kubernetes Pod Operator and add Tests

RickRen7575 commented on pull request #18615: URL: https://github.com/apache/airflow/pull/18615#issuecomment-936168221 > My main concern here is that `env_vars` intentionally takes `List[V1EnvVar]` - taking a `dict` is currently for backward compatibility only at this point. It's not that

[GitHub] [airflow] RickRen7575 edited a comment on pull request #18615: fix template string passed to env_vars when using render_template_as_native_obj for Kubernetes Pod Operator and add Tests

RickRen7575 edited a comment on pull request #18615: URL: https://github.com/apache/airflow/pull/18615#issuecomment-936168221 > My main concern here is that `env_vars` intentionally takes `List[V1EnvVar]` - taking a `dict` is currently for backward compatibility only at this point. It's

[GitHub] [airflow] ashb commented on pull request #18772: Don't bake ENV and _cmd into tmp config for non-sudo

ashb commented on pull request #18772: URL: https://github.com/apache/airflow/pull/18772#issuecomment-936153337 /cc @khalidmammadov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] ashb opened a new pull request #18772: Don't bake ENV and _cmd into tmp config for non-sudo

ashb opened a new pull request #18772: URL: https://github.com/apache/airflow/pull/18772 If we are running tasks via sudo then AIRFLOW__ config env vars won't be visible anymore (without them showing up in `ps`) and we likely might not have permission to run the _cmd's specified to find

[GitHub] [airflow] ambeshsingh commented on issue #12103: Tasks can be stuck in running state indefinitely

ambeshsingh commented on issue #12103: URL: https://github.com/apache/airflow/issues/12103#issuecomment-936138592 > This issue is reported against old version of Airflow that reached end of life. If the issue is reproducible on latest Airflow version please let us know @eladkal yes,

[GitHub] [airflow] JavierLopezT commented on a change in pull request #17937: Enable FTPToS3Operator to transfer several files

JavierLopezT commented on a change in pull request #17937: URL: https://github.com/apache/airflow/pull/17937#discussion_r723149385 ## File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py ## @@ -53,52 +64,89 @@ class FTPToS3Operator(BaseOperator): :type

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723183980 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723183980 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723183980 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] ashb commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

ashb commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723175547 ## File path: airflow/providers/amazon/aws/secrets/secrets_manager.py ## @@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,

[GitHub] [airflow] JavierLopezT commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

JavierLopezT commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723174073 ## File path: airflow/providers/amazon/aws/secrets/secrets_manager.py ## @@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,

[GitHub] [airflow] JavierLopezT commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

JavierLopezT commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723174073 ## File path: airflow/providers/amazon/aws/secrets/secrets_manager.py ## @@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,

[GitHub] [airflow] kaxil edited a comment on pull request #18759: Movin trigger dag to operations folder

kaxil edited a comment on pull request #18759: URL: https://github.com/apache/airflow/pull/18759#issuecomment-935745429 Let's wait on merging this -- we can include it in 2.2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[airflow] branch main updated (c9bf5f3 -> cf27419)

This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from c9bf5f3 Coerce datetime to pendulum for timetable (#18522) add cf27419 Fix Pendulum 1.x references in

[GitHub] [airflow] ashb closed issue #17853: Macros reference point to outdated pendulum information

ashb closed issue #17853: URL: https://github.com/apache/airflow/issues/17853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ashb merged pull request #18766: Fix Pendulum 1.x references in documentation

ashb merged pull request #18766: URL: https://github.com/apache/airflow/pull/18766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ashb commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

ashb commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723171088 ## File path: docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst ## @@ -78,6 +79,7 @@ Verify that you can get the secret:

[GitHub] [airflow] ashb commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

ashb commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723170620 ## File path: airflow/providers/amazon/aws/secrets/secrets_manager.py ## @@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,

[GitHub] [airflow] GuidoTournois opened a new issue #18771: Current implementation of PagerdutyHook requires integration key to be present twice in connection

GuidoTournois opened a new issue #18771: URL: https://github.com/apache/airflow/issues/18771 ### Apache Airflow Provider(s) pagerduty ### Versions of Apache Airflow Providers apache-airflow-providers-pagerduty==2.0.1 ### Apache Airflow version 2.1.4

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

ephraimbuddy commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723153989 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] JavierLopezT commented on pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

JavierLopezT commented on pull request #18764: URL: https://github.com/apache/airflow/pull/18764#issuecomment-936060522 > I'm not convinced this is needed. > > I think the problem is that example had invalid JSON, (`{"x": True}` is not valid JSON) so as a result of this code >

[GitHub] [airflow] JavierLopezT commented on a change in pull request #17937: Enable FTPToS3Operator to transfer several files

JavierLopezT commented on a change in pull request #17937: URL: https://github.com/apache/airflow/pull/17937#discussion_r723149385 ## File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py ## @@ -53,52 +64,89 @@ class FTPToS3Operator(BaseOperator): :type

[GitHub] [airflow] josh-fell commented on a change in pull request #18760: Amazon SQS Example

josh-fell commented on a change in pull request #18760: URL: https://github.com/apache/airflow/pull/18760#discussion_r723145605 ## File path: airflow/providers/amazon/aws/example_dags/example_sqs.py ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] eladkal opened a new issue #18770: Properly handle verify parameter in TrinoHook

eladkal opened a new issue #18770: URL: https://github.com/apache/airflow/issues/18770 ### Body This task refers to comment left in the Hook: https://github.com/apache/airflow/blob/c9bf5f33e5d5bcbf7d31663a8571628434d7073f/airflow/providers/trino/hooks/trino.py#L96-L100

[GitHub] [airflow] josh-fell commented on a change in pull request #18760: Amazon SQS Example

josh-fell commented on a change in pull request #18760: URL: https://github.com/apache/airflow/pull/18760#discussion_r723141935 ## File path: airflow/providers/amazon/aws/example_dags/example_sqs.py ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] ashb commented on a change in pull request #18767: Update ftp.py

ashb commented on a change in pull request #18767: URL: https://github.com/apache/airflow/pull/18767#discussion_r723140771 ## File path: airflow/providers/ftp/hooks/ftp.py ## @@ -60,6 +60,10 @@ def get_conn(self) -> ftplib.FTP: if self.conn is None:

[GitHub] [airflow] ashb commented on pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

ashb commented on pull request #18764: URL: https://github.com/apache/airflow/pull/18764#issuecomment-935999358 I see there is one tiny change in here, but the rest of the changes need reverting. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ashb closed pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

ashb closed pull request #18764: URL: https://github.com/apache/airflow/pull/18764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ashb commented on a change in pull request #17937: Enable FTPToS3Operator to transfer several files

ashb commented on a change in pull request #17937: URL: https://github.com/apache/airflow/pull/17937#discussion_r723132242 ## File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py ## @@ -53,52 +64,89 @@ class FTPToS3Operator(BaseOperator): :type acl_policy: str

[GitHub] [airflow] ashb commented on a change in pull request #17937: Enable FTPToS3Operator to transfer several files

ashb commented on a change in pull request #17937: URL: https://github.com/apache/airflow/pull/17937#discussion_r723131359 ## File path: airflow/providers/amazon/aws/transfers/ftp_to_s3.py ## @@ -53,52 +64,89 @@ class FTPToS3Operator(BaseOperator): :type acl_policy: str

[GitHub] [airflow] ashb commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

ashb commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723130861 ## File path: docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst ## @@ -27,7 +27,7 @@ Here is a sample configuration:

[GitHub] [airflow] ashb commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

ashb commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723129199 ## File path: docs/apache-airflow-providers-amazon/secrets-backends/aws-secrets-manager.rst ## @@ -27,7 +27,7 @@ Here is a sample configuration:

[GitHub] [airflow] ashb commented on a change in pull request #18742: Always run at least one backfill from BackfillJob

ashb commented on a change in pull request #18742: URL: https://github.com/apache/airflow/pull/18742#discussion_r723122515 ## File path: tests/cli/commands/test_dag_command.py ## @@ -543,6 +544,7 @@ def test_dag_test_show_dag(self, mock_get_dag, mock_executor,

[GitHub] [airflow] ashb edited a comment on pull request #18745: Don't install SQLAlchemy/Pendulum adapters for other DBs

ashb edited a comment on pull request #18745: URL: https://github.com/apache/airflow/pull/18745#issuecomment-935958530 The same problem people are reporting in that thread is happening in this CI build now, and also for me locally ``` _

[GitHub] [airflow] ashb commented on pull request #18745: Don't install SQLAlchemy/Pendulum adapters for other DBs

ashb commented on pull request #18745: URL: https://github.com/apache/airflow/pull/18745#issuecomment-935958530 The same problem people are reporting in that thread is happening in this CI build now, and also for me locally ``` -- This is an automated message from the Apache Git

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723114533 ## File path: tests/api_connexion/endpoints/test_user_endpoint.py ## @@ -472,6 +472,45 @@ def test_change_with_update_maek(self, autoclean_username,

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723114533 ## File path: tests/api_connexion/endpoints/test_user_endpoint.py ## @@ -472,6 +472,45 @@ def test_change_with_update_maek(self, autoclean_username,

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

ephraimbuddy commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723108726 ## File path: airflow/api_connexion/schemas/user_schema.py ## @@ -33,11 +33,11 @@ class Meta: model = User dateformat = "iso"

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723113723 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18767: Update ftp.py

boring-cyborg[bot] commented on pull request #18767: URL: https://github.com/apache/airflow/pull/18767#issuecomment-935932214 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] rentom opened a new pull request #18767: Update ftp.py

rentom opened a new pull request #18767: URL: https://github.com/apache/airflow/pull/18767 FTPHook did not use specified FTP Connection port. Looks like FTPSHook do, so I've added pretty much the same line here. First time for me, trying to contribute someting here. So I might not

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

ephraimbuddy commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723102202 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723091557 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] eladkal edited a comment on issue #18664: [Oracle] Oracle Hook - make it possible to define a schema in the connection parameters

eladkal edited a comment on issue #18664: URL: https://github.com/apache/airflow/issues/18664#issuecomment-935698467 We probably also need to customize the connection fields in the UI and set Service Name with explanation to avoid confusion. Similar to what was done for Salesforce

[GitHub] [airflow] eladkal edited a comment on issue #18664: [Oracle] Oracle Hook - make it possible to define a schema in the connection parameters

eladkal edited a comment on issue #18664: URL: https://github.com/apache/airflow/issues/18664#issuecomment-935698467 I can understand the source of the confusion. We probably need to customize the connection fields in the UI and set Service Name & DB Schema with explanation to avoid

[GitHub] [airflow] eladkal closed issue #17180: dag example doesn't work for DataflowJobStatusSensor

eladkal closed issue #17180: URL: https://github.com/apache/airflow/issues/17180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] khalidmammadov commented on pull request #18690: Fixing tests that leave traces (users)

khalidmammadov commented on pull request #18690: URL: https://github.com/apache/airflow/pull/18690#issuecomment-935846752 @potiuk @uranusjr Can you please review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] lwyszomi commented on a change in pull request #18699: Dataflow Operators - use project and location from job in on_kill method.

lwyszomi commented on a change in pull request #18699: URL: https://github.com/apache/airflow/pull/18699#discussion_r723062024 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -761,15 +775,23 @@ def start_flex_template(

[GitHub] [airflow] ephraimbuddy commented on pull request #18739: Move docker decorator example dag to docker provider

ephraimbuddy commented on pull request #18739: URL: https://github.com/apache/airflow/pull/18739#issuecomment-935838384 Hi @potiuk , this failure seems related to DockerDecorator not usable in airflow versions less than 2.2. It is failing at `import_all_provider_classes` on airflow 2.1

[GitHub] [airflow] lwyszomi commented on issue #17180: dag example doesn't work for DataflowJobStatusSensor

lwyszomi commented on issue #17180: URL: https://github.com/apache/airflow/issues/17180#issuecomment-935836076 This was fixed when @mnojek worked on the system tests for the google provider: https://github.com/apache/airflow/pull/18494 Documentation have a new example dag with

[GitHub] [airflow] kaxil edited a comment on issue #18541: Error when running dag & something to do with parsing the start date

kaxil edited a comment on issue #18541: URL: https://github.com/apache/airflow/issues/18541#issuecomment-935831242 That will be only available in soon to be released 2.2.0 -- until then you will have to manually apply patch in https://github.com/apache/airflow/pull/18315 -- This is an

[GitHub] [airflow] kaxil commented on issue #18541: Error when running dag & something to do with parsing the start date

kaxil commented on issue #18541: URL: https://github.com/apache/airflow/issues/18541#issuecomment-935831242 That will be only available in soon to be released 2.2.0 -- until then you will have to manually apply patch in https://github.com/apache/airflow/pull/17732 -- This is an

[GitHub] [airflow] kaxil closed issue #18541: Error when running dag & something to do with parsing the start date

kaxil closed issue #18541: URL: https://github.com/apache/airflow/issues/18541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #18766: Fix Pendulum 1.x references in documentation

github-actions[bot] commented on pull request #18766: URL: https://github.com/apache/airflow/pull/18766#issuecomment-935829555 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] Mavtti commented on issue #18746: dagrun_time doesn't trigger on_failure_callback

Mavtti commented on issue #18746: URL: https://github.com/apache/airflow/issues/18746#issuecomment-935823102 > I thin you should pass it directly as constructor parameter of DAG. See also #18721 Already tried but it doesn't change the outcome. -- This is an automated message from

[GitHub] [airflow] uranusjr opened a new pull request #18766: Fix Pendulum 1.x references in documentation

uranusjr opened a new pull request #18766: URL: https://github.com/apache/airflow/pull/18766 Because no-one else seems to care enough 路 Close #17853. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] eladkal commented on a change in pull request #18699: Dataflow Operators - use project and location from job in on_kill method.

eladkal commented on a change in pull request #18699: URL: https://github.com/apache/airflow/pull/18699#discussion_r723034695 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -761,15 +775,23 @@ def start_flex_template(

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

ephraimbuddy commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723029378 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] eladkal commented on issue #12103: Tasks can be stuck in running state indefinitely

eladkal commented on issue #12103: URL: https://github.com/apache/airflow/issues/12103#issuecomment-935781841 This issue is reported against old version of Airflow that reached end of life. If the issue is reproducible on latest Airflow version please let us know -- This is an

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r723022857 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] kaxil merged pull request #18522: Coerce datetime to pendulum for timetable

kaxil merged pull request #18522: URL: https://github.com/apache/airflow/pull/18522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (2a6cadb -> c9bf5f3)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 2a6cadb Small improvements for Airflow UI (#18715) add c9bf5f3 Coerce datetime to pendulum for timetable

[GitHub] [airflow] BasPH commented on issue #18582: Allow Pools to be set via ENV

BasPH commented on issue #18582: URL: https://github.com/apache/airflow/issues/18582#issuecomment-935766452 Yes; I always liked this hot reload functionality of Prometheus: https://prometheus.io/docs/prometheus/latest/configuration/configuration/. +1 for rewriting the configuration, it

[GitHub] [airflow] uranusjr commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

uranusjr commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723016863 ## File path: airflow/providers/amazon/aws/secrets/secrets_manager.py ## @@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,

[GitHub] [airflow] JavierLopezT commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

JavierLopezT commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723014871 ## File path: airflow/providers/amazon/aws/secrets/secrets_manager.py ## @@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,

[GitHub] [airflow] uranusjr commented on a change in pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

uranusjr commented on a change in pull request #18764: URL: https://github.com/apache/airflow/pull/18764#discussion_r723012643 ## File path: airflow/providers/amazon/aws/secrets/secrets_manager.py ## @@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,

[GitHub] [airflow] kaxil commented on pull request #18759: Movin trigger dag to operations folder

kaxil commented on pull request #18759: URL: https://github.com/apache/airflow/pull/18759#issuecomment-935745429 Let's wait on merging this -- we can include it in 2.1.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[airflow] branch main updated (767a4f5 -> 2a6cadb)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 767a4f5 ECSOperator: airflow exception on edge case when cloudwatch log stream is not found (#18733) add

[GitHub] [airflow] kaxil merged pull request #18715: Small improvements for Airflow UI

kaxil merged pull request #18715: URL: https://github.com/apache/airflow/pull/18715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil edited a comment on pull request #13893: Fix race condition when using Dynamic DAGs

kaxil edited a comment on pull request #13893: URL: https://github.com/apache/airflow/pull/13893#issuecomment-935740190 @AramisN There are many reasons for getting "not found in serialized_dag table" -- you might be facing a different error. The PR fixed breaking the scheduler, and from

[GitHub] [airflow] kaxil edited a comment on pull request #13893: Fix race condition when using Dynamic DAGs

kaxil edited a comment on pull request #13893: URL: https://github.com/apache/airflow/pull/13893#issuecomment-935740190 @AramisN There are many reasons for getting "not found in serialized_dag table" -- you might be facing a different error. The PR fixed breaking the scheduler, and from

[GitHub] [airflow] kaxil commented on pull request #13893: Fix race condition when using Dynamic DAGs

kaxil commented on pull request #13893: URL: https://github.com/apache/airflow/pull/13893#issuecomment-935740190 @AramisN There are many reasons for getting "not found in serialized_dag table" -- you might be facing a different error. The PR fixed breaking the scheduler, and from the

[GitHub] [airflow] potiuk commented on pull request #13541: added support for device_requests in DockerOperator

potiuk commented on pull request #13541: URL: https://github.com/apache/airflow/pull/13541#issuecomment-935722042 If you want to take over and submit it and lead to completion - feel free :). Create a new PR please -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] lwyszomi opened a new issue #18765: Access Denied when access to profile page

lwyszomi opened a new issue #18765: URL: https://github.com/apache/airflow/issues/18765 ### Apache Airflow version 2.1.4 (latest released) ### Operating System Debian GNU/Linux rodete rodete (x86-64) ### Versions of Apache Airflow Providers _No response_

[GitHub] [airflow] boring-cyborg[bot] commented on issue #18765: Access Denied when access to profile page

boring-cyborg[bot] commented on issue #18765: URL: https://github.com/apache/airflow/issues/18765#issuecomment-935721554 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

github-actions[bot] commented on pull request #18764: URL: https://github.com/apache/airflow/pull/18764#issuecomment-935720784 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] potiuk commented on pull request #18761: Fix missing permissions for LDAP Auth (add can create)

potiuk commented on pull request #18761: URL: https://github.com/apache/airflow/pull/18761#issuecomment-935708550 I think we need to decide first what we want to do. There is a new discussion https://github.com/apache/airflow/pull/18670 related to that (API doing the same thing) and my

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

ephraimbuddy commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r722983609 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] eladkal commented on issue #18664: [Oracle] Oracle Hook - make it possible to define a schema in the connection parameters

eladkal commented on issue #18664: URL: https://github.com/apache/airflow/issues/18664#issuecomment-935698467 I can understand the source of the confusion. We probably need to customize the connection fields in the UI and set Service Name & DB Schema with explanation to avoid confusion.

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

ephraimbuddy commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r722983033 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] AramisN commented on pull request #13893: Fix race condition when using Dynamic DAGs

AramisN commented on pull request #13893: URL: https://github.com/apache/airflow/pull/13893#issuecomment-935694176 Said its been fixed in 2.0.x but i see it again in 2.1.x :| Something bad has happened. Please consider letting us know by creating a bug report using GitHub.

[GitHub] [airflow] alberthier commented on pull request #13541: added support for device_requests in DockerOperator

alberthier commented on pull request #13541: URL: https://github.com/apache/airflow/pull/13541#issuecomment-935688549 The proposed PR has been closed as there was no activity on it but the code works properly and fixes this issue. Airflow now depends on docker 5.0.2 so the

[GitHub] [airflow] JavierLopezT opened a new pull request #18764: Enable AWS Secrets Manager backend to retrieve conns using different fields

JavierLopezT opened a new pull request #18764: URL: https://github.com/apache/airflow/pull/18764 Fixing bugs for rc2 release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

uranusjr commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r722968549 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18757: Make REST API patch user endpoint work the same way as the UI

ephraimbuddy commented on a change in pull request #18757: URL: https://github.com/apache/airflow/pull/18757#discussion_r722966808 ## File path: airflow/api_connexion/endpoints/user_endpoint.py ## @@ -124,9 +124,21 @@ def patch_user(username, update_mask=None): if user is

[GitHub] [airflow] eladkal commented on a change in pull request #18755: Support mysql to s3 in parquet format

eladkal commented on a change in pull request #18755: URL: https://github.com/apache/airflow/pull/18755#discussion_r722946136 ## File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py ## @@ -54,12 +59,17 @@ class MySQLToS3Operator(BaseOperator): You

[GitHub] [airflow] GuidoTournois commented on a change in pull request #18763: Add standard hook fields to pagerdutyHook to make hook show up in UI

GuidoTournois commented on a change in pull request #18763: URL: https://github.com/apache/airflow/pull/18763#discussion_r722946720 ## File path: airflow/providers/pagerduty/provider.yaml ## @@ -37,6 +37,13 @@ integrations: tags: [service] +hook-class-names: #

[GitHub] [airflow] JavierLopezT removed a comment on pull request #17448: Aws secrets manager backend

JavierLopezT removed a comment on pull request #17448: URL: https://github.com/apache/airflow/pull/17448#issuecomment-933282983 Hello, this might sound ridiculous but I am trying to test this MR for https://github.com/apache/airflow/issues/18638#issuecomment-932991258 and I am unable to

[GitHub] [airflow] uranusjr commented on a change in pull request #18763: Add standard hook fields to pagerdutyHook to make hook show up in UI

uranusjr commented on a change in pull request #18763: URL: https://github.com/apache/airflow/pull/18763#discussion_r722943801 ## File path: airflow/providers/pagerduty/provider.yaml ## @@ -37,6 +37,13 @@ integrations: tags: [service] +hook-class-names: # deprecated -

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18763: Add standard hook fields to pagerdutyHook to make hook show up in UI

boring-cyborg[bot] commented on pull request #18763: URL: https://github.com/apache/airflow/pull/18763#issuecomment-935614072 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] GuidoTournois opened a new pull request #18763: Add standard hook fields to pagerdutyHook to make hook show up in UI

GuidoTournois opened a new pull request #18763: URL: https://github.com/apache/airflow/pull/18763 Pagerduty is not shown as a Connection type in the Connection view. That is because of two reasons: 1. The PagerdutyHook class is not added in the provider.yaml, nor in the field

[GitHub] [airflow] pawsok commented on pull request #18761: Fix missing permissions for LDAP Auth (add can create)

pawsok commented on pull request #18761: URL: https://github.com/apache/airflow/pull/18761#issuecomment-935599833 > I think this needs a test. I was not able to find any existing tests for LDAP auth. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mehmax commented on issue #18664: [Oracle] Oracle Hook - make it possible to define a schema in the connection parameters

mehmax commented on issue #18664: URL: https://github.com/apache/airflow/issues/18664#issuecomment-935595790 @nikochiko In oracle, schema is something different to service_name. I dont know why is was coded like this. service name is needed to connect to the database I am no

[GitHub] [airflow] uranusjr commented on a change in pull request #18755: Support mysql to s3 in parquet format

uranusjr commented on a change in pull request #18755: URL: https://github.com/apache/airflow/pull/18755#discussion_r722926861 ## File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py ## @@ -92,15 +108,27 @@ def __init__( self.aws_conn_id = aws_conn_id

[GitHub] [airflow] mnojek commented on a change in pull request #18715: Small improvements for Airflow UI

mnojek commented on a change in pull request #18715: URL: https://github.com/apache/airflow/pull/18715#discussion_r722925502 ## File path: airflow/www/templates/airflow/confirm.html ## @@ -21,7 +21,7 @@ {% block content %} {{ super() }} - Wait a minute. + Wait a minute

[GitHub] [airflow] uranusjr commented on pull request #18761: Fix missing permissions for LDAP Auth (add can create)

uranusjr commented on pull request #18761: URL: https://github.com/apache/airflow/pull/18761#issuecomment-935570942 I think this needs a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #18761: Fix missing permissions for LDAP Auth (add can create) #18545

boring-cyborg[bot] commented on pull request #18761: URL: https://github.com/apache/airflow/pull/18761#issuecomment-935541991 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] pawsok opened a new pull request #18761: Fix missing permissions for LDAP Auth (add can create) #18545

pawsok opened a new pull request #18761: URL: https://github.com/apache/airflow/pull/18761 Hi, This is to add an option to add new users from UsersVeiw if LDAP auth is enabled (if you simply do not want automated user registration with LDAP). The whole discussion can be found

[GitHub] [airflow] uranusjr closed issue #18669: Failed to record duration of externally triggered DAGs

uranusjr closed issue #18669: URL: https://github.com/apache/airflow/issues/18669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    1   2   3