[GitHub] [airflow] bhirsz commented on a change in pull request #22311: New design of system tests

2022-03-20 Thread GitBox
bhirsz commented on a change in pull request #22311: URL: https://github.com/apache/airflow/pull/22311#discussion_r830795321 ## File path: tests/system/conftest.py ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22393: Update redis_pub_sub.py

2022-03-20 Thread GitBox
boring-cyborg[bot] commented on pull request #22393: URL: https://github.com/apache/airflow/pull/22393#issuecomment-1073526969 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Co

[GitHub] [airflow] pfldy2850 opened a new pull request #22393: Update redis_pub_sub.py

2022-03-20 Thread GitBox
pfldy2850 opened a new pull request #22393: URL: https://github.com/apache/airflow/pull/22393 The pubsub message has data of type bytes, which is broken in JSON serialization. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://g

[GitHub] [airflow] harishkrao commented on a change in pull request #22213: Issue 20453 google common cloud fixes part 1

2022-03-20 Thread GitBox
harishkrao commented on a change in pull request #22213: URL: https://github.com/apache/airflow/pull/22213#discussion_r83047 ## File path: tests/providers/google/cloud/hooks/test_pubsub.py ## @@ -371,7 +371,9 @@ def test_publish(self, mock_service): mock.call(t

[GitHub] [airflow] harishkrao commented on a change in pull request #22213: Issue 20453 google common cloud fixes part 1

2022-03-20 Thread GitBox
harishkrao commented on a change in pull request #22213: URL: https://github.com/apache/airflow/pull/22213#discussion_r830777402 ## File path: tests/providers/google/cloud/hooks/test_dataproc.py ## @@ -474,7 +474,7 @@ def test_wait_for_job(self, mock_get_job): mock

[GitHub] [airflow] github-actions[bot] commented on pull request #22260: Add map_index to TaskFail

2022-03-20 Thread GitBox
github-actions[bot] commented on pull request #22260: URL: https://github.com/apache/airflow/pull/22260#issuecomment-1073492359 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] MatrixManAtYrService opened a new issue #22392: Unknown connection types fail in cryptic ways

2022-03-20 Thread GitBox
MatrixManAtYrService opened a new issue #22392: URL: https://github.com/apache/airflow/issues/22392 ### Apache Airflow version 2.2.4 (latest released) ### What happened I created a connection like: ``` airflow connections add fsconn --conn-host /tmp --conn-type Fil

[airflow] branch main updated (3182ba2 -> 71c980a)

2022-03-20 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3182ba2 Add map_index support to all task instance-related views (#22272) add 71c980a Add fk between xcom an

[GitHub] [airflow] uranusjr merged pull request #22334: Add fk between xcom and task instance

2022-03-20 Thread GitBox
uranusjr merged pull request #22334: URL: https://github.com/apache/airflow/pull/22334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[airflow] branch constraints-main updated: Updating constraints. Build id:2013821751

2022-03-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e320863 Updating const

[GitHub] [airflow] github-actions[bot] commented on pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()

2022-03-20 Thread GitBox
github-actions[bot] commented on pull request #22386: URL: https://github.com/apache/airflow/pull/22386#issuecomment-1073449652 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()

2022-03-20 Thread GitBox
uranusjr commented on a change in pull request #22386: URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593 ## File path: docs/apache-airflow/concepts/smart-sensors.rst ## @@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need

[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()

2022-03-20 Thread GitBox
uranusjr commented on a change in pull request #22386: URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593 ## File path: docs/apache-airflow/concepts/smart-sensors.rst ## @@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need

[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()

2022-03-20 Thread GitBox
uranusjr commented on a change in pull request #22386: URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593 ## File path: docs/apache-airflow/concepts/smart-sensors.rst ## @@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need

[GitHub] [airflow] uranusjr commented on a change in pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()

2022-03-20 Thread GitBox
uranusjr commented on a change in pull request #22386: URL: https://github.com/apache/airflow/pull/22386#discussion_r830732593 ## File path: docs/apache-airflow/concepts/smart-sensors.rst ## @@ -85,6 +85,8 @@ It is transparent to the individual users. Existing DAGs don't need

[GitHub] [airflow] uranusjr commented on a change in pull request #22385: Fix cncf.kubernetes provider compatibility with Airflow 2.1

2022-03-20 Thread GitBox
uranusjr commented on a change in pull request #22385: URL: https://github.com/apache/airflow/pull/22385#discussion_r830730423 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -283,7 +283,7 @@ def _get_ti_pod_labels(context: Optional[dict] = Non

[GitHub] [airflow] uranusjr commented on a change in pull request #21077: Kubernetes decorator

2022-03-20 Thread GitBox
uranusjr commented on a change in pull request #21077: URL: https://github.com/apache/airflow/pull/21077#discussion_r830729052 ## File path: airflow/providers/cncf/kubernetes/decorators/kubernetes.py ## @@ -0,0 +1,148 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] pohek321 commented on pull request #22391: Update the redshift sql operator to accept multiple sql statements

2022-03-20 Thread GitBox
pohek321 commented on pull request #22391: URL: https://github.com/apache/airflow/pull/22391#issuecomment-1073441317 @uranusjr can you elaborate on what you mean by static checks? I'm a newbie and not quite sure what that means. I've also added `sqlparse` to the `setup.py` file (which is w

[GitHub] [airflow] uranusjr commented on a change in pull request #21077: Kubernetes decorator

2022-03-20 Thread GitBox
uranusjr commented on a change in pull request #21077: URL: https://github.com/apache/airflow/pull/21077#discussion_r830728403 ## File path: airflow/decorators/__init__.pyi ## @@ -251,5 +251,120 @@ class TaskDecoratorCollection: :param cap_add: Include container capabi

[GitHub] [airflow] uranusjr commented on pull request #22389: make operator's execution_timeout configurable

2022-03-20 Thread GitBox
uranusjr commented on pull request #22389: URL: https://github.com/apache/airflow/pull/22389#issuecomment-1073437849 Since it is possible to provide a *None* `execution_timeout`, the config format also need to support that. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] uranusjr commented on pull request #22391: Update the redshift sql operator to accept multiple sql statements

2022-03-20 Thread GitBox
uranusjr commented on pull request #22391: URL: https://github.com/apache/airflow/pull/22391#issuecomment-1073433313 Pleas fix the static checks. Also, you need to add `sqlparse` to the requirements; search for `sqlparse` in the code base to find where you need to add it (it’s currently us

[GitHub] [airflow] uranusjr edited a comment on pull request #22391: Update the redshift sql operator to accept multiple sql statements

2022-03-20 Thread GitBox
uranusjr edited a comment on pull request #22391: URL: https://github.com/apache/airflow/pull/22391#issuecomment-1073433313 Pleas fix the static checks. Also, you need to add `sqlparse` to the requirements; search for `sqlparse` in the code base to find where you need to add it (it’s curre

[GitHub] [airflow] pohek321 commented on issue #22390: RedshiftSQLOperator is limited to executing one sql statement

2022-03-20 Thread GitBox
pohek321 commented on issue #22390: URL: https://github.com/apache/airflow/issues/22390#issuecomment-1073432244 Opened [PR 22391](https://github.com/apache/airflow/pull/22391) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [airflow] pohek321 opened a new pull request #22391: Update the redshift sql operator to accept multiple sql statements

2022-03-20 Thread GitBox
pohek321 opened a new pull request #22391: URL: https://github.com/apache/airflow/pull/22391 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more in

[airflow] branch main updated (76d6089 -> 3182ba2)

2022-03-20 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 76d6089 Fix python 3.10 support in vendored in cgroupspy (#22208) add 3182ba2 Add map_index support to all ta

[GitHub] [airflow] uranusjr merged pull request #22272: Add map_index support to all task instance-related views

2022-03-20 Thread GitBox
uranusjr merged pull request #22272: URL: https://github.com/apache/airflow/pull/22272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] pohek321 opened a new issue #22390: RedshiftSQLOperator is limited to executing one sql statement

2022-03-20 Thread GitBox
pohek321 opened a new issue #22390: URL: https://github.com/apache/airflow/issues/22390 ### Apache Airflow Provider(s) amazon ### Versions of Apache Airflow Providers apache-airflow-providers-amazon==3.0.0 ### Apache Airflow version 2.2.4 (latest released)

[airflow-ci-infra] branch main updated: Add support for building image using ARM hardware

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git The following commit(s) were added to refs/heads/main by this push: new c392c13 Add support for building image us

[GitHub] [airflow] github-actions[bot] commented on pull request #19640: clear task's next_method and next_kwargs when clear the task

2022-03-20 Thread GitBox
github-actions[bot] commented on pull request #19640: URL: https://github.com/apache/airflow/pull/19640#issuecomment-1073379888 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] sagmansercan opened a new pull request #22389: make operator's execution_timeout configurable

2022-03-20 Thread GitBox
sagmansercan opened a new pull request #22389: URL: https://github.com/apache/airflow/pull/22389 This PR aims to make the execution_timeout attribute to be configurable globally via airflow.cfg. * The default value is still `None`. Users are expected to define a positive integer v

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22389: make operator's execution_timeout configurable

2022-03-20 Thread GitBox
boring-cyborg[bot] commented on pull request #22389: URL: https://github.com/apache/airflow/pull/22389#issuecomment-1073377613 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Co

[GitHub] [airflow] edithturn edited a comment on pull request #22327: Rewrite Selective Check in Python

2022-03-20 Thread GitBox
edithturn edited a comment on pull request #22327: URL: https://github.com/apache/airflow/pull/22327#issuecomment-1073353362 Thanks, @potiuk. I am retrieving all the files that are modified in the PR. Let me know now if the statement bellow is in the right way. Process: Steps 1, 2

[airflow] branch optimize-multiplatform-builds updated (1bd3f3f -> 1c325e7)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 1bd3f3f Optimize Multiplatform cache builds add 1c325e7 Optimize Multiplatform cache b

[GitHub] [airflow] subkanthi opened a new pull request #22388: WIP - Helm support local kubernetes executor

2022-03-20 Thread GitBox
subkanthi opened a new pull request #22388: URL: https://github.com/apache/airflow/pull/22388 Helm changes to support LocalKubernetesExecutor Airflow Docker images dont have the https://github.com/apache/airflow/pull/19729 changes yet. --- **^ Add meaningful descrip

[GitHub] [airflow] edithturn commented on pull request #22327: Rewrite Selective Check in Python

2022-03-20 Thread GitBox
edithturn commented on pull request #22327: URL: https://github.com/apache/airflow/pull/22327#issuecomment-1073353362 Thanks, @potiuk. I am retrieving all the files that are modified in the PR. Let me know now if the statement bellow is in the right way. Process: Steps 1, 2, and 3

[airflow] branch optimize-multiplatform-builds updated (de72ef2 -> 1bd3f3f)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard de72ef2 Optimize Multiplatform cache builds add 1bd3f3f Optimize Multiplatform cache b

[airflow] branch optimize-multiplatform-builds updated (301fc51 -> de72ef2)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 301fc51 Optimize Multiplatform cache builds add de72ef2 Optimize Multiplatform cache b

[airflow] branch optimize-multiplatform-builds updated (133f0a7 -> 301fc51)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 133f0a7 fixup! Optimize Multiplatform cache builds discard d8009e5 Optimize Multiplatform

[GitHub] [airflow] eladkal edited a comment on pull request #22123: Add details drawer to Grid View

2022-03-20 Thread GitBox
eladkal edited a comment on pull request #22123: URL: https://github.com/apache/airflow/pull/22123#issuecomment-1073341799 Played with it a bit in local env this is **really really good!** Have a few suggestions/bugs **all are minor**: 1. [Suggestion] Can we have the ability to

[GitHub] [airflow] eladkal edited a comment on pull request #22123: Add details drawer to Grid View

2022-03-20 Thread GitBox
eladkal edited a comment on pull request #22123: URL: https://github.com/apache/airflow/pull/22123#issuecomment-1073341799 Played with it a bit in local env this is **really really good!** Have a few suggestions/bugs **all are minor**: 1. [Suggestion] Can we have the ability to

[GitHub] [airflow] eladkal edited a comment on pull request #22123: Add details drawer to Grid View

2022-03-20 Thread GitBox
eladkal edited a comment on pull request #22123: URL: https://github.com/apache/airflow/pull/22123#issuecomment-1073341799 Played with it a bit in local env this is **really really good!** Have a few suggestions/bugs **all are minor**: 1. [Suggestion] Can we have the ability to

[GitHub] [airflow] eladkal edited a comment on pull request #22123: Add details drawer to Grid View

2022-03-20 Thread GitBox
eladkal edited a comment on pull request #22123: URL: https://github.com/apache/airflow/pull/22123#issuecomment-1073341799 Played with it a bit in local env this is **really really good!** Have a few suggestions/bugs **all are minor**: 1. [Suggestion] Can we have the ability to

[GitHub] [airflow] eladkal commented on pull request #22123: Add details drawer to Grid View

2022-03-20 Thread GitBox
eladkal commented on pull request #22123: URL: https://github.com/apache/airflow/pull/22123#issuecomment-1073341799 Played with it a bit in local env this is **really really good!** Have a few suggestions/bugs **all are minor**: 1. [Suggestion] Can we have the ability to easily

[airflow] branch optimize-multiplatform-builds updated (7b0a85b -> 133f0a7)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 7b0a85b fixup! Optimize Multiplatform cache builds add 133f0a7 fixup! Optimize Multipl

[GitHub] [airflow] subkanthi commented on pull request #21077: Kubernetes decorator

2022-03-20 Thread GitBox
subkanthi commented on pull request #21077: URL: https://github.com/apache/airflow/pull/21077#issuecomment-1073334586 Thanks @josh-fell , updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch optimize-multiplatform-builds updated (90c5af1 -> 7b0a85b)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 90c5af1 fixup! Optimize Multiplatform cache builds add 7b0a85b fixup! Optimize Multipl

[GitHub] [airflow] potiuk commented on pull request #22385: Fix cncf.kubernetes provider compatibility with Airflow 2.1

2022-03-20 Thread GitBox
potiuk commented on pull request #22385: URL: https://github.com/apache/airflow/pull/22385#issuecomment-1073315864 Looks like it works :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[airflow] branch optimize-multiplatform-builds updated (967690b -> 90c5af1)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 967690b fixup! Optimize Multiplatform cache builds add 90c5af1 fixup! Optimize Multipl

[airflow] branch optimize-multiplatform-builds updated (c782683 -> 967690b)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard c782683 fixup! Optimize Multiplatform cache builds add 967690b fixup! Optimize Multipl

[airflow] branch optimize-multiplatform-builds updated (5738416 -> c782683)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 5738416 fixup! Optimize Multiplatform cache builds add c782683 fixup! Optimize Multipl

[GitHub] [airflow] eladkal edited a comment on pull request #21974: Expose device_requests to DockerOperator - Enable GPU support

2022-03-20 Thread GitBox
eladkal edited a comment on pull request #21974: URL: https://github.com/apache/airflow/pull/21974#issuecomment-1073309467 Also if possible to add a unit test / add coverage for this change in an existed test. Maybe https://github.com/apache/airflow/blob/76d6089887919765c1d431c07e53a33f

[GitHub] [airflow] eladkal commented on pull request #21974: Expose device_requests to DockerOperator - Enable GPU support

2022-03-20 Thread GitBox
eladkal commented on pull request #21974: URL: https://github.com/apache/airflow/pull/21974#issuecomment-1073309467 Also if possible to add a unit test / add coverage for this change in an existed test. Mayve https://github.com/apache/airflow/blob/76d6089887919765c1d431c07e53a33f2c16de0

[GitHub] [airflow] eladkal commented on issue #9492: DockerOperator support for Nvidia-Docker

2022-03-20 Thread GitBox
eladkal commented on issue #9492: URL: https://github.com/apache/airflow/issues/9492#issuecomment-1073309196 According to https://github.com/docker/docker-py/issues/2395#issuecomment-907243275 ``` device_requests=[ docker.types.DeviceRequest(count=-1, capabilities=[['gpu']]

[GitHub] [airflow] eladkal edited a comment on issue #9492: DockerOperator support for Nvidia-Docker

2022-03-20 Thread GitBox
eladkal edited a comment on issue #9492: URL: https://github.com/apache/airflow/issues/9492#issuecomment-1073309196 According to https://github.com/docker/docker-py/issues/2395#issuecomment-907243275 ``` device_requests=[ docker.types.DeviceRequest(count=-1, capabilities=[[

[airflow-ci-infra] branch main updated: Remove mistakenly added sessionmanager

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git The following commit(s) were added to refs/heads/main by this push: new 5571d29 Remove mistakenly added sessionma

[airflow] branch optimize-multiplatform-builds updated (4ee6399 -> 5738416)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 4ee6399 fixup! Optimize Multiplatform cache builds add 5738416 fixup! Optimize Multipl

[GitHub] [airflow] okayhooni opened a new pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()

2022-03-20 Thread GitBox
okayhooni opened a new pull request #22386: URL: https://github.com/apache/airflow/pull/22386 Even though smart sensor feature was deprecated and planned to be removed on version 2.4, the fact that sensor tasks with any callback arguments are not compatible with smart sensor, has to be not

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22386: update smart sensor docs and minor fix on is_smart_sensor_compatible()

2022-03-20 Thread GitBox
boring-cyborg[bot] commented on pull request #22386: URL: https://github.com/apache/airflow/pull/22386#issuecomment-1073303680 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Co

[airflow] branch optimize-multiplatform-builds updated (b42d8cb -> 4ee6399)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard b42d8cb fixup! Optimize Multiplatform cache builds add 4ee6399 fixup! Optimize Multipl

[airflow] branch optimize-multiplatform-builds updated (22e8022 -> b42d8cb)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 22e8022 fixup! Optimize Multiplatform cache builds add b42d8cb fixup! Optimize Multipl

[airflow] branch optimize-multiplatform-builds updated (191b06e -> 22e8022)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch optimize-multiplatform-builds in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 191b06e fixup! Optimize Multiplatform cache builds omit ad4e939 Optimize Multiplatform

[GitHub] [airflow] rafalh commented on a change in pull request #22071: Bug-fix GCSToS3Operator

2022-03-20 Thread GitBox
rafalh commented on a change in pull request #22071: URL: https://github.com/apache/airflow/pull/22071#discussion_r830650965 ## File path: airflow/providers/amazon/aws/transfers/gcs_to_s3.py ## @@ -147,6 +152,9 @@ def execute(self, context: 'Context') -> List[str]:

[GitHub] [airflow] TediPapajorgji commented on pull request #21974: Expose device_requests to DockerOperator - Enable GPU support

2022-03-20 Thread GitBox
TediPapajorgji commented on pull request #21974: URL: https://github.com/apache/airflow/pull/21974#issuecomment-1073293914 > @wcwt this PR wasn't merged it. > > @TediPapajorgji can you revert changes to `CHANGELOG.rst` and `provider.yml`? Yep I'll do it today. -- This is a

[GitHub] [airflow] potiuk commented on a change in pull request #22383: Prepare fix wave of providers to release

2022-03-20 Thread GitBox
potiuk commented on a change in pull request #22383: URL: https://github.com/apache/airflow/pull/22383#discussion_r830643901 ## File path: dev/provider_packages/SETUP_TEMPLATE.cfg.jinja2 ## @@ -67,9 +67,6 @@ python_requires = ~=3.7 packages = find: setup_requires = {{ SETUP_R

[GitHub] [airflow] potiuk commented on pull request #22209: Switched cgroupspy to vendored version

2022-03-20 Thread GitBox
potiuk commented on pull request #22209: URL: https://github.com/apache/airflow/pull/22209#issuecomment-1073289792 This is the last-but-one to make Airflow Python 3.10 compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[airflow] branch main updated: Fix python 3.10 support in vendored in cgroupspy (#22208)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 76d6089 Fix python 3.10 support in vendored in cgr

[GitHub] [airflow] potiuk merged pull request #22208: Fix python 3.10 support in vendored in cgroupspy

2022-03-20 Thread GitBox
potiuk merged pull request #22208: URL: https://github.com/apache/airflow/pull/22208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk edited a comment on pull request #22385: Fix cncf.kubernetes provider compatibility with Airflow 2.1

2022-03-20 Thread GitBox
potiuk edited a comment on pull request #22385: URL: https://github.com/apache/airflow/pull/22385#issuecomment-1073289406 I need to re-release the providers due to bug in install_requires found (#22380 ) but before that, I would like to also get that one fixed (it was raised by one of the

[GitHub] [airflow] potiuk commented on pull request #22385: Fix cncf.kubernetes provider compatibility with Airflow 2.1

2022-03-20 Thread GitBox
potiuk commented on pull request #22385: URL: https://github.com/apache/airflow/pull/22385#issuecomment-1073289406 I need to re-release the providers due to bug in install_requires found (#22380 ) but before that, I would like to also get that one fixed (it was rasied by one of the users i

[GitHub] [airflow] potiuk commented on a change in pull request #22385: Fix cncf.kubernetes provider compatibility with Airflow 2.1

2022-03-20 Thread GitBox
potiuk commented on a change in pull request #22385: URL: https://github.com/apache/airflow/pull/22385#discussion_r830643282 ## File path: airflow/models/xcom.py ## @@ -162,7 +162,10 @@ def set( from airflow.models.dagrun import DagRun if not exactly_one(exe

[GitHub] [airflow] potiuk opened a new pull request #22385: Fix cncf.kubernetes provider compatibility with Airflow 2.1

2022-03-20 Thread GitBox
potiuk opened a new pull request #22385: URL: https://github.com/apache/airflow/pull/22385 The execution_date -> run_id change (#21960) attempted to make it Airflow 2.1 backwards-compatible, but the problem is that in Airflo2 2.1 retrieving `run_id` attribute of TaskInstance throws

[GitHub] [airflow] potiuk commented on a change in pull request #22383: Prepare fix wave of providers to release

2022-03-20 Thread GitBox
potiuk commented on a change in pull request #22383: URL: https://github.com/apache/airflow/pull/22383#discussion_r830622260 ## File path: dev/provider_packages/SETUP_TEMPLATE.cfg.jinja2 ## @@ -67,9 +67,6 @@ python_requires = ~=3.7 packages = find: setup_requires = {{ SETUP_R

[GitHub] [airflow] potiuk commented on a change in pull request #22383: Prepare fix wave of providers to release

2022-03-20 Thread GitBox
potiuk commented on a change in pull request #22383: URL: https://github.com/apache/airflow/pull/22383#discussion_r830622162 ## File path: airflow/providers/dbt/cloud/CHANGELOG.rst ## @@ -19,7 +19,15 @@ Changelog - -1.0.0 +1.0.2 +. + +Bug Fixes +~ + +* `

[GitHub] [airflow] potiuk closed issue #22264: Status of testing Providers that were prepared on March 15, 2022

2022-03-20 Thread GitBox
potiuk closed issue #22264: URL: https://github.com/apache/airflow/issues/22264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk commented on issue #22264: Status of testing Providers that were prepared on March 15, 2022

2022-03-20 Thread GitBox
potiuk commented on issue #22264: URL: https://github.com/apache/airflow/issues/22264#issuecomment-1073259484 Thanks for all the testing. We will have to release a new wave, as there was a general issue found in #22380 (but there will be just a few new changes to vote). -- This is an au

[GitHub] [airflow] github-actions[bot] commented on pull request #22383: Prepare fix wave of providers to release

2022-03-20 Thread GitBox
github-actions[bot] commented on pull request #22383: URL: https://github.com/apache/airflow/pull/22383#issuecomment-1073253599 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] eladkal commented on a change in pull request #22383: Prepare fix wave of providers to release

2022-03-20 Thread GitBox
eladkal commented on a change in pull request #22383: URL: https://github.com/apache/airflow/pull/22383#discussion_r830617760 ## File path: dev/provider_packages/SETUP_TEMPLATE.cfg.jinja2 ## @@ -67,9 +67,6 @@ python_requires = ~=3.7 packages = find: setup_requires = {{ SETUP_

[GitHub] [airflow] potiuk opened a new pull request #22383: Prepare fix wave of providers to release

2022-03-20 Thread GitBox
potiuk opened a new pull request #22383: URL: https://github.com/apache/airflow/pull/22383 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more info

[airflow] branch main updated: Fix mistakenly added install_requires for all providers (#22382)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ab4ba6f Fix mistakenly added install_requires for

[GitHub] [airflow] potiuk merged pull request #22382: Fix mistakenly added install_requires for all providers

2022-03-20 Thread GitBox
potiuk merged pull request #22382: URL: https://github.com/apache/airflow/pull/22382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk closed issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`

2022-03-20 Thread GitBox
potiuk closed issue #22380: URL: https://github.com/apache/airflow/issues/22380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] github-actions[bot] commented on pull request #22382: Fix mistakenly added install_requires for all providers

2022-03-20 Thread GitBox
github-actions[bot] commented on pull request #22382: URL: https://github.com/apache/airflow/pull/22382#issuecomment-1073238199 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk commented on pull request #22382: Fix mistakenly added install_requires for all providers

2022-03-20 Thread GitBox
potiuk commented on pull request #22382: URL: https://github.com/apache/airflow/pull/22382#issuecomment-1073237398 I will re-release all providers (and yank all providers) after this oine is merged. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [airflow] potiuk opened a new pull request #22382: Fix mistakenly added install_requires for all providers

2022-03-20 Thread GitBox
potiuk opened a new pull request #22382: URL: https://github.com/apache/airflow/pull/22382 The TroveClassifiers change #6 - by mistake - added the gitpython and wheel for all providers. This could have been avoided (and noticed) if we split the change from doc generation. So

[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`

2022-03-20 Thread GitBox
potiuk commented on issue #22380: URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073237237 BTW. Learning for myself - DO split changes and semi-automated documentation generation. This way the change could have been detected at code review time. The #6 change was far

[GitHub] [airflow] github-actions[bot] commented on pull request #22208: Fix python 3.10 support in vendored in cgroupspy

2022-03-20 Thread GitBox
github-actions[bot] commented on pull request #22208: URL: https://github.com/apache/airflow/pull/22208#issuecomment-1073237007 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] eladkal commented on pull request #22202: Added autodetect arg to Create External Table Operator

2022-03-20 Thread GitBox
eladkal commented on pull request #22202: URL: https://github.com/apache/airflow/pull/22202#issuecomment-1073236805 @shahkshitij15 can you please fix failing test? https://github.com/apache/airflow/runs/5612449295?check_suite_focus=true#step:9:3155 ```

[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`

2022-03-20 Thread GitBox
potiuk commented on issue #22380: URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073236767 > Sorry that it's going to be a bit of work for you, though. Thanks for taking care of it! No - no worries at all - thanks for reporting it so quickly @xylar actually. It sl

[GitHub] [airflow] xylar commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`

2022-03-20 Thread GitBox
xylar commented on issue #22380: URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073235830 @potiuk, no worries on my side. I know I sounded pretty annoyed above. But this was the excuse I needed to automate my update process on conda-forge. Sorry that it's going t

[GitHub] [airflow] Bowrna commented on pull request #21956: prod image build changes

2022-03-20 Thread GitBox
Bowrna commented on pull request #21956: URL: https://github.com/apache/airflow/pull/21956#issuecomment-1073235230 I see @potiuk thank you. I could better understand the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [airflow] eladkal commented on pull request #22219: Gdrive upload operator

2022-03-20 Thread GitBox
eladkal commented on pull request #22219: URL: https://github.com/apache/airflow/pull/22219#issuecomment-1073234215 CI indeed help us :) example dag is missing for this operator https://github.com/apache/airflow/runs/5617058321?check_suite_focus=true#step:8:892 ``` wi

[GitHub] [airflow] potiuk commented on issue #22380: Newest providers incorrectly include `gitpython` and `wheel` in `install_requires`

2022-03-20 Thread GitBox
potiuk commented on issue #22380: URL: https://github.com/apache/airflow/issues/22380#issuecomment-1073231426 Yep. This is my mistake indeed. I will have to rerelease all of the providers and yank all of them I am afraid -- This is an automated message from the Apache Git Service. To res

[GitHub] [airflow] eladkal commented on a change in pull request #22219: Gdrive upload operator

2022-03-20 Thread GitBox
eladkal commented on a change in pull request #22219: URL: https://github.com/apache/airflow/pull/22219#discussion_r830601510 ## File path: airflow/providers/google/suite/transfers/local_to_drive.py ## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] eladkal commented on a change in pull request #22219: Gdrive upload operator

2022-03-20 Thread GitBox
eladkal commented on a change in pull request #22219: URL: https://github.com/apache/airflow/pull/22219#discussion_r830601617 ## File path: airflow/providers/google/suite/transfers/local_to_drive.py ## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] eladkal commented on a change in pull request #22219: Gdrive upload operator

2022-03-20 Thread GitBox
eladkal commented on a change in pull request #22219: URL: https://github.com/apache/airflow/pull/22219#discussion_r830601510 ## File path: airflow/providers/google/suite/transfers/local_to_drive.py ## @@ -0,0 +1,128 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] potiuk commented on pull request #22208: Fix python 3.10 support in vendored in cgroupspy

2022-03-20 Thread GitBox
potiuk commented on pull request #22208: URL: https://github.com/apache/airflow/pull/22208#issuecomment-1073229265 This is the next one for Python 3.10 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[airflow] branch main updated (a3ffbee -> 172df9e)

2022-03-20 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a3ffbee Fix skipping non-GCS located jars (#22302) add 172df9e Apply import fixes to vendored cgroupspy library

[GitHub] [airflow] potiuk merged pull request #22207: Fix imports of vendored cgroupspy

2022-03-20 Thread GitBox
potiuk merged pull request #22207: URL: https://github.com/apache/airflow/pull/22207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk commented on issue #22381: AthenaOperator retries max_tries mix-up

2022-03-20 Thread GitBox
potiuk commented on issue #22381: URL: https://github.com/apache/airflow/issues/22381#issuecomment-1073228758 Would you like to fix the problem maybe by creating a PR @vladyslavnsa ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on pull request #22162: Remove pandas upper limit now that SQLA is 1.4+

2022-03-20 Thread GitBox
potiuk commented on pull request #22162: URL: https://github.com/apache/airflow/pull/22162#issuecomment-1073228147 Reopened to rebuild and check for 3.8/3.9 pandas upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   >