[GitHub] [airflow] stamixthereal commented on a diff in pull request #28675: MongoHook optimization

2023-01-05 Thread GitBox
stamixthereal commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1063212936 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -90,15 +85,25 @@ def get_conn(self) -> MongoClient: options.update({"ssl_cert_reqs": CERT_NONE})

[GitHub] [airflow] stamixthereal commented on a diff in pull request #28675: MongoHook optimization

2023-01-05 Thread GitBox
stamixthereal commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1063211122 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -90,15 +85,25 @@ def get_conn(self) -> MongoClient: options.update({"ssl_cert_reqs": CERT_NONE})

[GitHub] [airflow] potiuk commented on a diff in pull request #28528: Fixes to how DebugExecutor handles sensors

2023-01-05 Thread GitBox
potiuk commented on code in PR #28528: URL: https://github.com/apache/airflow/pull/28528#discussion_r1063210989 ## airflow/ti_deps/deps/ready_to_reschedule.py: ## @@ -44,7 +45,8 @@ def _get_dep_statuses(self, ti, session, dep_context): from airflow.models.mappedoperator

[GitHub] [airflow] potiuk commented on issue #28761: CVE-2022-24439 & CVE-2022-23491

2023-01-05 Thread GitBox
potiuk commented on issue #28761: URL: https://github.com/apache/airflow/issues/28761#issuecomment-1373283998 BTW. I clarify the process for anyone who would have similar expectations as you had in this PR https://github.com/apache/airflow/pull/28762 - this will be merged and released in u

[GitHub] [airflow] potiuk opened a new pull request, #28762: Clarify that versioned constraints are fixed at release time

2023-01-05 Thread GitBox
potiuk opened a new pull request, #28762: URL: https://github.com/apache/airflow/pull/28762 We received a number of requests to upgrade individual dependencies in the constraint files (mostly due to those dependencies releasing version with vulnerabilities fixed). This is not how our constr

[GitHub] [airflow] uranusjr commented on a diff in pull request #28675: MongoHook optimization

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1063201208 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -90,15 +85,25 @@ def get_conn(self) -> MongoClient: options.update({"ssl_cert_reqs": CERT_NONE})

[GitHub] [airflow] uranusjr commented on issue #28756: All Airflow Configurations set via Environment Variable are masked when `expose_config` is set as `non-sensitive-only`

2023-01-05 Thread GitBox
uranusjr commented on issue #28756: URL: https://github.com/apache/airflow/issues/28756#issuecomment-1373251278 I searched for `as_dict` usages and this is the only place where `display_sensitive` is False, so I think we should simply incorporate `SENSITIVE_CONFIG_VALUES` as Ephraim said. O

[GitHub] [airflow] ephraimbuddy commented on issue #28756: All Airflow Configurations set via Environment Variable are masked when `expose_config` is set as `non-sensitive-only`

2023-01-05 Thread GitBox
ephraimbuddy commented on issue #28756: URL: https://github.com/apache/airflow/issues/28756#issuecomment-1373246327 I think we should hide this in `_include_envs` so it's same as `_include_cmds` & `_include_secrets`: ```diff diff --git a/airflow/configuration.py b/airflow/configura

[GitHub] [airflow] stamixthereal commented on a diff in pull request #28675: MongoHook optimization

2023-01-05 Thread GitBox
stamixthereal commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1063191447 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -90,15 +85,25 @@ def get_conn(self) -> MongoClient: options.update({"ssl_cert_reqs": CERT_NONE})

[GitHub] [airflow] potiuk closed issue #28761: CVE-2022-24439 & CVE-2022-23491

2023-01-05 Thread GitBox
potiuk closed issue #28761: CVE-2022-24439 & CVE-2022-23491 URL: https://github.com/apache/airflow/issues/28761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] potiuk commented on issue #28761: CVE-2022-24439 & CVE-2022-23491

2023-01-05 Thread GitBox
potiuk commented on issue #28761: URL: https://github.com/apache/airflow/issues/28761#issuecomment-1373225954 We are not going to do anything about it for 2.5.0. This is not how Airflow constraints work. The constraints are frozen at the moment of release. If you wish to upgrade to n

[GitHub] [airflow] stamixthereal commented on a diff in pull request #28675: MongoHook optimization

2023-01-05 Thread GitBox
stamixthereal commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1063190941 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -90,15 +85,25 @@ def get_conn(self) -> MongoClient: options.update({"ssl_cert_reqs": CERT_NONE})

[GitHub] [airflow] potiuk commented on issue #28756: All Airflow Configurations set via Environment Variable are masked when `expose_config` is set as `non-sensitive-only`

2023-01-05 Thread GitBox
potiuk commented on issue #28756: URL: https://github.com/apache/airflow/issues/28756#issuecomment-1373217271 Would you like to take a stab on it @wolfier ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] uranusjr commented on a diff in pull request #28724: Use dagrun instead of DagFileProcessor in backfill_job test

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28724: URL: https://github.com/apache/airflow/pull/28724#discussion_r1063179968 ## tests/jobs/test_backfill_job.py: ## @@ -147,31 +147,25 @@ def test_dag_run_with_finished_tasks_set_to_success(self, dag_maker): assert State.SUCCESS =

[GitHub] [airflow] potiuk commented on issue #27285: Using .output on non-templated fields

2023-01-05 Thread GitBox
potiuk commented on issue #27285: URL: https://github.com/apache/airflow/issues/27285#issuecomment-137320 Sure. Why not. I have not seen an opposition so far, and I think it's worth doing - I also see no big drawback if it's going to be similar setting to `render_templates_as_native_obj

[GitHub] [airflow] uranusjr commented on a diff in pull request #28675: MongoHook optimization

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1063131169 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -90,15 +85,25 @@ def get_conn(self) -> MongoClient: options.update({"ssl_cert_reqs": CERT_NONE})

[GitHub] [airflow] uranusjr commented on a diff in pull request #28675: MongoHook optimization

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1063130165 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -90,15 +85,25 @@ def get_conn(self) -> MongoClient: options.update({"ssl_cert_reqs": CERT_NONE})

[GitHub] [airflow] uranusjr commented on a diff in pull request #28502: Migrate DagFileProcessor.manage_slas to Internal API

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28502: URL: https://github.com/apache/airflow/pull/28502#discussion_r1063128910 ## airflow/dag_processing/processor.py: ## @@ -365,8 +365,10 @@ def __init__(self, dag_ids: list[str] | None, dag_directory: str, log: logging.L self._dag_

[GitHub] [airflow] csm10495 commented on a diff in pull request #28752: Allow setting the name for the base container and fix longstanding bug with running quick pods

2023-01-05 Thread GitBox
csm10495 commented on code in PR #28752: URL: https://github.com/apache/airflow/pull/28752#discussion_r1063104726 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -265,7 +265,7 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->

[GitHub] [airflow] uranusjr commented on a diff in pull request #28752: Allow setting the name for the base container and fix longstanding bug with running quick pods

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28752: URL: https://github.com/apache/airflow/pull/28752#discussion_r1063100091 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -265,7 +265,7 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->

[GitHub] [airflow] uranusjr commented on a diff in pull request #28097: logging poke info when external dag is not none and task_id and task_ids are none

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28097: URL: https://github.com/apache/airflow/pull/28097#discussion_r1063093904 ## airflow/sensors/external_task.py: ## @@ -143,18 +143,27 @@ def __init__( if external_task_id is not None and external_task_ids is not None:

[GitHub] [airflow] natanweinberger commented on a diff in pull request #28738: Add --overwrite option to `connections import` CLI command

2023-01-05 Thread GitBox
natanweinberger commented on code in PR #28738: URL: https://github.com/apache/airflow/pull/28738#discussion_r1063088522 ## airflow/cli/commands/connection_command.py: ## @@ -301,20 +301,28 @@ def connections_delete(args): def connections_import(args): """Imports connectio

[GitHub] [airflow] natanweinberger commented on a diff in pull request #28738: Add --overwrite option to `connections import` CLI command

2023-01-05 Thread GitBox
natanweinberger commented on code in PR #28738: URL: https://github.com/apache/airflow/pull/28738#discussion_r1063088522 ## airflow/cli/commands/connection_command.py: ## @@ -301,20 +301,28 @@ def connections_delete(args): def connections_import(args): """Imports connectio

[GitHub] [airflow] utkarsharma2 commented on issue #27929: AIP-51 - Single Threaded Executors

2023-01-05 Thread GitBox
utkarsharma2 commented on issue #27929: URL: https://github.com/apache/airflow/issues/27929#issuecomment-1373118738 @o-nikolas I think It's a good idea to move checks to the executor. I'll try to work on this proposal this weekend. -- This is an automated message from the Apache Git Serv

[GitHub] [airflow] natanweinberger commented on a diff in pull request #28738: Add --overwrite option to `connections import` CLI command

2023-01-05 Thread GitBox
natanweinberger commented on code in PR #28738: URL: https://github.com/apache/airflow/pull/28738#discussion_r1063076159 ## airflow/cli/commands/connection_command.py: ## @@ -301,20 +301,31 @@ def connections_delete(args): def connections_import(args): """Imports connectio

[GitHub] [airflow] csm10495 commented on a diff in pull request #28752: Allow setting the name for the base container and fix longstanding bug with running quick pods

2023-01-05 Thread GitBox
csm10495 commented on code in PR #28752: URL: https://github.com/apache/airflow/pull/28752#discussion_r1063075211 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -265,7 +265,7 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->

[GitHub] [airflow] csm10495 commented on a diff in pull request #28752: Allow setting the name for the base container and fix longstanding bug with running quick pods

2023-01-05 Thread GitBox
csm10495 commented on code in PR #28752: URL: https://github.com/apache/airflow/pull/28752#discussion_r1063075211 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -265,7 +265,7 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->

[GitHub] [airflow] csm10495 commented on a diff in pull request #28752: Allow setting the name for the base container and fix longstanding bug with running quick pods

2023-01-05 Thread GitBox
csm10495 commented on code in PR #28752: URL: https://github.com/apache/airflow/pull/28752#discussion_r1063075211 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -265,7 +265,7 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->

[airflow] branch main updated (a9493c1317 -> dcfc604b28)

2023-01-05 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a9493c1317 Add waiter config params to emr.add_job_flow_steps (#28464) add dcfc604b28 Fix imap change log (#2874

[GitHub] [airflow] uranusjr merged pull request #28749: Fix imap change log

2023-01-05 Thread GitBox
uranusjr merged PR #28749: URL: https://github.com/apache/airflow/pull/28749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

[GitHub] [airflow] uranusjr commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1063074749 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.proce

[GitHub] [airflow] uranusjr commented on a diff in pull request #28738: Add --overwrite option to `connections import` CLI command

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28738: URL: https://github.com/apache/airflow/pull/28738#discussion_r1063073609 ## airflow/cli/commands/connection_command.py: ## @@ -301,20 +301,31 @@ def connections_delete(args): def connections_import(args): """Imports connections from

[GitHub] [airflow] uranusjr commented on a diff in pull request #28738: Add --overwrite option to `connections import` CLI command

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28738: URL: https://github.com/apache/airflow/pull/28738#discussion_r1063072864 ## airflow/cli/commands/connection_command.py: ## @@ -301,20 +301,31 @@ def connections_delete(args): def connections_import(args): """Imports connections from

[GitHub] [airflow] uranusjr commented on a diff in pull request #28752: Allow setting the name for the base container and fix longstanding bug with running quick pods

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28752: URL: https://github.com/apache/airflow/pull/28752#discussion_r1063069166 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -265,7 +265,7 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True) ->

[GitHub] [airflow] uranusjr commented on a diff in pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
uranusjr commented on code in PR #28755: URL: https://github.com/apache/airflow/pull/28755#discussion_r1063067666 ## airflow/providers/amazon/aws/hooks/ssm.py: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27829: Improving the release process

2023-01-05 Thread GitBox
jedcunningham commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1062907718 ## .github/workflows/ci.yml: ## @@ -747,6 +747,41 @@ jobs: run: breeze ci fix-ownership if: always() + test-airflow-release-commands: Revi

[GitHub] [airflow] o-nikolas commented on issue #27929: AIP-51 - Single Threaded Executors

2023-01-05 Thread GitBox
o-nikolas commented on issue #27929: URL: https://github.com/apache/airflow/issues/27929#issuecomment-1373002031 Hey @utkarsharma2 I have a proposal that you go ahead and write a PR to add the new singlethreaded flag/property to the base executor and write the requisite changes for

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28528: Fixes to how DebugExecutor handles sensors

2023-01-05 Thread GitBox
o-nikolas commented on code in PR #28528: URL: https://github.com/apache/airflow/pull/28528#discussion_r1062796629 ## airflow/ti_deps/deps/ready_to_reschedule.py: ## @@ -44,7 +45,8 @@ def _get_dep_statuses(self, ti, session, dep_context): from airflow.models.mappedopera

[GitHub] [airflow] ferruzzi commented on pull request #28760: add missing "words" to the dictionary

2023-01-05 Thread GitBox
ferruzzi commented on PR #28760: URL: https://github.com/apache/airflow/pull/28760#issuecomment-1372994922 Non-binding approved :P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [airflow] o-nikolas commented on pull request #27583: enable https requests with ssl verification

2023-01-05 Thread GitBox
o-nikolas commented on PR #27583: URL: https://github.com/apache/airflow/pull/27583#issuecomment-1372992578 > Hey @o-nikolas yes! I am just in a little bit hurry in another thing, but this week I will update it with the suggestion + fix tests. Thanks. Hey @viniolivieri, any update on

[GitHub] [airflow] o-nikolas commented on pull request #27185: Handle AzureBatch task result correctly

2023-01-05 Thread GitBox
o-nikolas commented on PR #27185: URL: https://github.com/apache/airflow/pull/27185#issuecomment-1372992380 > > I finally found some time to finish this @o-nikolas. Please review once more. I rebased on the updated main branch since I was running a lot of commits behind and there was a conf

[GitHub] [airflow] o-nikolas commented on pull request #28759: Fixed broken command

2023-01-05 Thread GitBox
o-nikolas commented on PR #28759: URL: https://github.com/apache/airflow/pull/28759#issuecomment-1372990959 Hey @KyleSponz Thanks for the contribution! Can I ask in what way the command was broken? I don't think we want to encourage running `docker`/`docker-compose` commands w

[GitHub] [airflow] boring-cyborg[bot] commented on issue #28761: CVE-2022-24439 & CVE-2022-23491

2023-01-05 Thread GitBox
boring-cyborg[bot] commented on issue #28761: URL: https://github.com/apache/airflow/issues/28761#issuecomment-1372989058 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] AveraqeDev opened a new issue, #28761: CVE-2022-24439 & CVE-2022-23491

2023-01-05 Thread GitBox
AveraqeDev opened a new issue, #28761: URL: https://github.com/apache/airflow/issues/28761 ### Apache Airflow version 2.5.0 ### What happened The constraints file is pointing to versions of `gitpython` and `certifi` that have CVEs attached to them. ### What you th

[GitHub] [airflow] vandonr-amz opened a new pull request, #28760: add missing "words" to the dictionary

2023-01-05 Thread GitBox
vandonr-amz opened a new pull request, #28760: URL: https://github.com/apache/airflow/pull/28760 building the doc is currently broken (at least locally) due to those 2 words, coming from https://github.com/apache/airflow/blob/5246c009c557b4f6bdf1cd62bf9b89a2da63f630/airflow/providers/am

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28759: Fixed broken command

2023-01-05 Thread GitBox
boring-cyborg[bot] commented on PR #28759: URL: https://github.com/apache/airflow/pull/28759#issuecomment-1372976825 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] KyleSponz opened a new pull request, #28759: Fixed broken command

2023-01-05 Thread GitBox
KyleSponz opened a new pull request, #28759: URL: https://github.com/apache/airflow/pull/28759 The install command was broken I fixed it to a working one Thanks all! --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://githu

[airflow] branch constraints-main updated: Updating constraints. Build id:

2023-01-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 3e3f3eb139 Updating con

[GitHub] [airflow] Taragolis opened a new pull request, #28758: Refactor BatchWaitersHook tests

2023-01-05 Thread GitBox
Taragolis opened a new pull request, #28758: URL: https://github.com/apache/airflow/pull/28758 This refactor is another attempt for get rid of x-failed test (Previous attempt is #23918). In this attempt I try to split huge test case for multiple simple tests and replace "moto infrastruct

[GitHub] [airflow] wolfier commented on issue #28756: All Airflow Configurations set via Environment Variable are masked when `expose_config` is set as `non-sensitive-only`

2023-01-05 Thread GitBox
wolfier commented on issue #28756: URL: https://github.com/apache/airflow/issues/28756#issuecomment-1372933160 I believe the issue is because when the configuration is [fetched as a dictionary](https://github.com/apache/airflow/blob/2.5.0/airflow/www/views.py#L3838-L3842), the values have a

[GitHub] [airflow] ferruzzi commented on a diff in pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
ferruzzi commented on code in PR #28755: URL: https://github.com/apache/airflow/pull/28755#discussion_r1062984408 ## airflow/providers/amazon/aws/hooks/ssm.py: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

[GitHub] [airflow] dstandish commented on pull request #28710: Apply "unify bucket and key" before "provide bucket"

2023-01-05 Thread GitBox
dstandish commented on PR #28710: URL: https://github.com/apache/airflow/pull/28710#issuecomment-1372919043 > Thanks @dstandish. I appreciate that. :) > What I actually meant is [729e275](https://github.com/apache/airflow/commit/729e27506d245002fb33078f0e1afbe30d84b6bb). Feel free to rev

[GitHub] [airflow] ferruzzi commented on a diff in pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
ferruzzi commented on code in PR #28755: URL: https://github.com/apache/airflow/pull/28755#discussion_r1062974964 ## airflow/providers/amazon/aws/hooks/ssm.py: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

[GitHub] [airflow] Taragolis commented on a diff in pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
Taragolis commented on code in PR #28755: URL: https://github.com/apache/airflow/pull/28755#discussion_r1062971436 ## airflow/providers/amazon/aws/hooks/ssm.py: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agree

[GitHub] [airflow] rkarish commented on issue #27285: Using .output on non-templated fields

2023-01-05 Thread GitBox
rkarish commented on issue #27285: URL: https://github.com/apache/airflow/issues/27285#issuecomment-1372906220 @potiuk Is this bold proposal still something you want to move forward with? I think it sounds interesting and I see how it can be useful to the Users. I can make an attempt at imp

[GitHub] [airflow] collinmcnulty opened a new pull request, #28757: Initial draft of composable timetables

2023-01-05 Thread GitBox
collinmcnulty opened a new pull request, #28757: URL: https://github.com/apache/airflow/pull/28757 Given that timetables vary across multiple dimensions, I believe they are a good candidate for composition over inheritance. For instance, the CronTriggerTimetable is great, but it's easy to i

[GitHub] [airflow] csm10495 commented on pull request #28752: Allow setting the name for the base container and fix longstanding bug with running quick pods

2023-01-05 Thread GitBox
csm10495 commented on PR #28752: URL: https://github.com/apache/airflow/pull/28752#issuecomment-1372902051 This will also now fix #26796... since i kept hitting it in my tests :) @jedcunningham can you take a look when you get a chance? -- This is an automated message from the Apache Git

[GitHub] [airflow] Taragolis merged pull request #28464: Add waiter config params to emr.add_job_flow_steps

2023-01-05 Thread GitBox
Taragolis merged PR #28464: URL: https://github.com/apache/airflow/pull/28464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[airflow] branch main updated (ce188e5093 -> a9493c1317)

2023-01-05 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ce188e5093 Refactor waiter function and improve unit tests (#28753) add a9493c1317 Add waiter config params to

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28464: Add waiter config params to emr.add_job_flow_steps

2023-01-05 Thread GitBox
boring-cyborg[bot] commented on PR #28464: URL: https://github.com/apache/airflow/pull/28464#issuecomment-1372899766 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] ferruzzi commented on a diff in pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
ferruzzi commented on code in PR #28755: URL: https://github.com/apache/airflow/pull/28755#discussion_r1062960492 ## airflow/providers/amazon/aws/hooks/ssm.py: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

[GitHub] [airflow] wolfier opened a new issue, #28756: All Airflow Configurations set via Environment Variable are masked when `expose_config` is set as `non-sensitive-only``

2023-01-05 Thread GitBox
wolfier opened a new issue, #28756: URL: https://github.com/apache/airflow/issues/28756 ### Apache Airflow version 2.5.0 ### What happened In [Airflow 2.4.0](https://github.com/apache/airflow/blob/main/RELEASE_NOTES.rst#airflow-240-2022-09-19), a new feature was added t

[GitHub] [airflow] ShelRoman commented on pull request #28464: Add waiter config params to emr.add_job_flow_steps

2023-01-05 Thread GitBox
ShelRoman commented on PR #28464: URL: https://github.com/apache/airflow/pull/28464#issuecomment-1372885098 @potiuk thanks for the clarification and the link. :) I didn't expect an immediate reaction, which might be commercial deformation kicks in, since it's my first PR in open-source.

[GitHub] [airflow-site] johnstonmatt opened a new issue, #720: Ecosystem Link in Nav goes to the wrong page.

2023-01-05 Thread GitBox
johnstonmatt opened a new issue, #720: URL: https://github.com/apache/airflow-site/issues/720 The blue "Ecosystem" button in the nav on the landing page links to: https://airflow.apache.org/docs/apache-airflow/stable/start.html instead of https://airflow.apache.org/ecosys

[GitHub] [airflow] ferruzzi commented on a diff in pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
ferruzzi commented on code in PR #28755: URL: https://github.com/apache/airflow/pull/28755#discussion_r1062952380 ## airflow/providers/amazon/aws/hooks/ssm.py: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

[GitHub] [airflow] ferruzzi commented on pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
ferruzzi commented on PR #28755: URL: https://github.com/apache/airflow/pull/28755#issuecomment-1372875398 I see some tests are failing, I've got a lot on my plate today, I'll try to get to them tomorrow. Sorry about that. -- This is an automated message from the Apache Git Service. To r

[GitHub] [airflow] potiuk commented on pull request #28464: Add waiter config params to emr.add_job_flow_steps

2023-01-05 Thread GitBox
potiuk commented on PR #28464: URL: https://github.com/apache/airflow/pull/28464#issuecomment-1372857385 > @Taragolis could you please merge this one? I don't have `write access` to do that. Just to make sure to set your own expectations. Please do not ping people like that. It's qui

[GitHub] [airflow] potiuk closed issue #28691: Fix custom waiter function in AWS provider package

2023-01-05 Thread GitBox
potiuk closed issue #28691: Fix custom waiter function in AWS provider package URL: https://github.com/apache/airflow/issues/28691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [airflow] potiuk merged pull request #28753: Refactor waiter function and improve unit tests

2023-01-05 Thread GitBox
potiuk merged PR #28753: URL: https://github.com/apache/airflow/pull/28753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated (2b92c3c74d -> ce188e5093)

2023-01-05 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2b92c3c74d Fix providers documentation formatting (#28754) add ce188e5093 Refactor waiter function and improve uni

[airflow] branch main updated (455d05d50a -> 2b92c3c74d)

2023-01-05 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 455d05d50a css, cap dropdown menu size dynamically (#28736) add 2b92c3c74d Fix providers documentation formatting

[GitHub] [airflow] potiuk merged pull request #28754: Fix providers documentation formatting

2023-01-05 Thread GitBox
potiuk merged PR #28754: URL: https://github.com/apache/airflow/pull/28754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on pull request #28747: dash in docker-compose

2023-01-05 Thread GitBox
potiuk commented on PR #28747: URL: https://github.com/apache/airflow/pull/28747#issuecomment-1372837886 Yepw @kimvanwyk - @kaxil is very right - searching for all places where `docker-compose` is used and should be replaced with `docker compose` and also applying a human knowledge to make

[airflow] branch main updated (38f08f6c37 -> 455d05d50a)

2023-01-05 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 38f08f6c37 Fix code readability, add docstrings to json_client (#28619) add 455d05d50a css, cap dropdown menu size

[GitHub] [airflow] potiuk merged pull request #28736: css, cap dropdown menu size dynamically

2023-01-05 Thread GitBox
potiuk merged PR #28736: URL: https://github.com/apache/airflow/pull/28736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on issue #28381: CVE-2019-17495 for swagger-ui

2023-01-05 Thread GitBox
potiuk commented on issue #28381: URL: https://github.com/apache/airflow/issues/28381#issuecomment-1372832405 I think this is something that the person requesting it should determine (@hughlunnon). Usually when you raise a security related issue you should raise exploitation scenario and de

[GitHub] [airflow] Taragolis commented on a diff in pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
Taragolis commented on code in PR #28755: URL: https://github.com/apache/airflow/pull/28755#discussion_r1062928452 ## airflow/providers/amazon/aws/hooks/ssm.py: ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agree

[airflow] branch main updated (aa4858d85a -> 38f08f6c37)

2023-01-05 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from aa4858d85a AIP-51 - Misc. Compatibility Checks (#28375) add 38f08f6c37 Fix code readability, add docstrings to jso

[GitHub] [airflow] potiuk merged pull request #28619: Fix code readability, add docstrings to json_client

2023-01-05 Thread GitBox
potiuk merged PR #28619: URL: https://github.com/apache/airflow/pull/28619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] RachitSharma2001 commented on a diff in pull request #28706: Update provide_bucket_name() decorator to handle new conn_type

2023-01-05 Thread GitBox
RachitSharma2001 commented on code in PR #28706: URL: https://github.com/apache/airflow/pull/28706#discussion_r1062926098 ## docs/apache-airflow-providers-amazon/connections/aws.rst: ## @@ -66,6 +66,8 @@ Extra (optional) Specify the extra parameters (as json dictionary) tha

[GitHub] [airflow] RachitSharma2001 commented on pull request #28705: Update S3ToRedshift Operator docs to indicate multiple key functionality

2023-01-05 Thread GitBox
RachitSharma2001 commented on PR #28705: URL: https://github.com/apache/airflow/pull/28705#issuecomment-1372815972 Thank you all for the suggestions for the changes. I have updated the wording of the documentation in [airflow/providers/amazon/aws/transfers/s3_to_redshift.py](https://github.

[GitHub] [airflow] ferruzzi opened a new pull request, #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-05 Thread GitBox
ferruzzi opened a new pull request, #28755: URL: https://github.com/apache/airflow/pull/28755 Adds a new hook for AWS Systems Manager (SSM), including unit tests, and incorporates it into existing system tests. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ShelRoman commented on pull request #28464: Add waiter config params to emr.add_job_flow_steps

2023-01-05 Thread GitBox
ShelRoman commented on PR #28464: URL: https://github.com/apache/airflow/pull/28464#issuecomment-1372707240 @Taragolis could you please merge this one? I don't have `write access` to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] Taragolis commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-05 Thread GitBox
Taragolis commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1062852715 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.proc

[GitHub] [airflow] Taragolis commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-05 Thread GitBox
Taragolis commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1062852715 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.proc

[GitHub] [airflow] vincbeck commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-05 Thread GitBox
vincbeck commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1062844404 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.proce

[GitHub] [airflow] Taragolis commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-05 Thread GitBox
Taragolis commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1062842165 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.proc

[GitHub] [airflow] yxiao1996 commented on a diff in pull request #28686: Update gantt chart UI to display queued state of tasks

2023-01-05 Thread GitBox
yxiao1996 commented on code in PR #28686: URL: https://github.com/apache/airflow/pull/28686#discussion_r1062839814 ## airflow/www/static/js/gantt.js: ## @@ -212,12 +229,23 @@ d3.gantt = () => { mapIndex: d.map_index, }); }) - .attr('class', (d) =>

[GitHub] [airflow] yxiao1996 commented on a diff in pull request #28686: Update gantt chart UI to display queued state of tasks

2023-01-05 Thread GitBox
yxiao1996 commented on code in PR #28686: URL: https://github.com/apache/airflow/pull/28686#discussion_r1062837601 ## airflow/www/static/js/gantt.js: ## @@ -157,9 +164,19 @@ d3.gantt = () => { if (!(a.end_date instanceof moment)) { a.end_date = moment(a.end_d

[GitHub] [airflow] Taragolis commented on a diff in pull request #28706: Update provide_bucket_name() decorator to handle new conn_type

2023-01-05 Thread GitBox
Taragolis commented on code in PR #28706: URL: https://github.com/apache/airflow/pull/28706#discussion_r1062824388 ## docs/apache-airflow-providers-amazon/connections/aws.rst: ## @@ -66,6 +66,8 @@ Extra (optional) Specify the extra parameters (as json dictionary) that can b

[airflow] branch constraints-main updated: Updating constraints. Build id:

2023-01-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 5f0810ecd5 Updating con

[GitHub] [airflow] vincbeck commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-05 Thread GitBox
vincbeck commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1062802930 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.proce

[GitHub] [airflow] csm10495 commented on pull request #28752: Allow setting the name for the base container

2023-01-05 Thread GitBox
csm10495 commented on PR #28752: URL: https://github.com/apache/airflow/pull/28752#issuecomment-1372613163 > Would be nice to have unit tests which cover new functionality for avoid regression Yep.. they're on the way :) -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] Taragolis commented on pull request #28752: Allow setting the name for the base container

2023-01-05 Thread GitBox
Taragolis commented on PR #28752: URL: https://github.com/apache/airflow/pull/28752#issuecomment-1372612235 Would be nice to have unit tests which cover new functionality for avoid regression -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [airflow] o-nikolas commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

2023-01-05 Thread GitBox
o-nikolas commented on PR #28375: URL: https://github.com/apache/airflow/pull/28375#issuecomment-1372588540 > That would be great to get another set of eyes on this. Congratulations on becoming a Committer by the way! Would love for you to do the honors on this one :smile:. Thanks @r

[GitHub] [airflow] Taragolis opened a new pull request, #28754: Fix providers documentation formatting

2023-01-05 Thread GitBox
Taragolis opened a new pull request, #28754: URL: https://github.com/apache/airflow/pull/28754 Fix some selected things in provider documentation 1. Broken formatting 2. Broken links to classes 3. Non-relevant information Examples --- Postgres Provider

[GitHub] [airflow] o-nikolas closed issue #27930: AIP-51 - Misc. Compatibility Checks

2023-01-05 Thread GitBox
o-nikolas closed issue #27930: AIP-51 - Misc. Compatibility Checks URL: https://github.com/apache/airflow/issues/27930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[airflow] branch main updated: AIP-51 - Misc. Compatibility Checks (#28375)

2023-01-05 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new aa4858d85a AIP-51 - Misc. Compatibility Checks (#

[GitHub] [airflow] o-nikolas merged pull request #28375: AIP-51 - Misc. Compatibility Checks

2023-01-05 Thread GitBox
o-nikolas merged PR #28375: URL: https://github.com/apache/airflow/pull/28375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[GitHub] [airflow] vincbeck opened a new pull request, #28753: Refactor waiter function and improve unit tests

2023-01-05 Thread GitBox
vincbeck opened a new pull request, #28753: URL: https://github.com/apache/airflow/pull/28753 Refactor the `waiter function` but more importantly, rewrite unit tests and add some cases which are not covered today Closes #28691 -- This is an automated message from the Apache Git Ser

  1   2   >