[GitHub] [airflow] potiuk commented on a diff in pull request #28846: Updated app to support configuring the caching hash method for FIPS

2023-01-10 Thread GitBox
potiuk commented on code in PR #28846: URL: https://github.com/apache/airflow/pull/28846#discussion_r1066655259 ## airflow/www/app.py: ## @@ -131,7 +132,29 @@ def create_app(config=None, testing=False): init_robots(flask_app) +# Configure caching +

[GitHub] [airflow] dstandish commented on a diff in pull request #28844: Annotate KubeExecutor pods that we don't delete

2023-01-10 Thread GitBox
dstandish commented on code in PR #28844: URL: https://github.com/apache/airflow/pull/28844#discussion_r1066657098 ## airflow/executors/kubernetes_executor.py: ## @@ -52,6 +52,7 @@ from airflow.utils.state import State ALL_NAMESPACES = "ALL_NAMESPACES" +POD_DONE_KEY =

[GitHub] [airflow] potiuk commented on a diff in pull request #28846: Updated app to support configuring the caching hash method for FIPS

2023-01-10 Thread GitBox
potiuk commented on code in PR #28846: URL: https://github.com/apache/airflow/pull/28846#discussion_r1066645340 ## airflow/models/serialized_dag.py: ## @@ -102,7 +102,7 @@ def __init__(self, dag: DAG, processor_subdir: str | None = None): dag_data =

[airflow] branch main updated (46704eed53 -> 1091b751af)

2023-01-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 46704eed53 Throttle streaming log reads (#28818) add 1091b751af Fix system test example_redshift_s3_transfers.py

[GitHub] [airflow] potiuk merged pull request #28843: Fix system test example_redshift_s3_transfers.py

2023-01-10 Thread GitBox
potiuk merged PR #28843: URL: https://github.com/apache/airflow/pull/28843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a diff in pull request #28841: AIP-44 Initialize methods map for Internal API RPC endpoint in the method

2023-01-10 Thread GitBox
uranusjr commented on code in PR #28841: URL: https://github.com/apache/airflow/pull/28841#discussion_r1066630501 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -33,11 +32,17 @@ def _build_methods_map(list) -> dict: return

[GitHub] [airflow] uranusjr commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-10 Thread GitBox
uranusjr commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066629412 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from

[GitHub] [airflow] uranusjr commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-10 Thread GitBox
uranusjr commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066629412 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from

[GitHub] [airflow] uranusjr commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-10 Thread GitBox
uranusjr commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066629079 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from

[GitHub] [airflow] uranusjr commented on pull request #28845: Email Config docs more explicit env var examples

2023-01-10 Thread GitBox
uranusjr commented on PR #28845: URL: https://github.com/apache/airflow/pull/28845#issuecomment-1378301643 Static checks are also failing, looks like trailing whitespaces? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28846: Updated app to support configuring the caching hash method for FIPS

2023-01-10 Thread GitBox
ephraimbuddy commented on code in PR #28846: URL: https://github.com/apache/airflow/pull/28846#discussion_r1066619689 ## airflow/www/app.py: ## @@ -131,7 +132,29 @@ def create_app(config=None, testing=False): init_robots(flask_app) +# Configure caching +

[airflow] branch main updated: Throttle streaming log reads (#28818)

2023-01-10 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 46704eed53 Throttle streaming log reads (#28818)

[GitHub] [airflow] uranusjr merged pull request #28818: Throttle streaming log reads

2023-01-10 Thread GitBox
uranusjr merged PR #28818: URL: https://github.com/apache/airflow/pull/28818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on a diff in pull request #28846: Updated app to support configuring the caching hash method for FIPS

2023-01-10 Thread GitBox
uranusjr commented on code in PR #28846: URL: https://github.com/apache/airflow/pull/28846#discussion_r1066606000 ## airflow/models/serialized_dag.py: ## @@ -102,7 +102,7 @@ def __init__(self, dag: DAG, processor_subdir: str | None = None): dag_data =

[GitHub] [airflow] rajaths010494 commented on pull request #28763: Add deferrable ``GCSObjectExistenceSensorAsync``

2023-01-10 Thread GitBox
rajaths010494 commented on PR #28763: URL: https://github.com/apache/airflow/pull/28763#issuecomment-1378261307 Thanks @vchiapaikeo i will look at this and check

[GitHub] [airflow] r-richmond opened a new issue, #28847: Dag UI: Add Filter Downstream & Filter DownStream & Upstream

2023-01-10 Thread GitBox
r-richmond opened a new issue, #28847: URL: https://github.com/apache/airflow/issues/28847 ### Description Currently Airflow has a `Filter Upstream` View/option inside the graph view. (As documented [here](https://docs.astronomer.io/learn/airflow-ui#graph-view) under `Filter

[GitHub] [airflow] josh-fell commented on a diff in pull request #28837: new operator to create a sagemaker experiment

2023-01-10 Thread GitBox
josh-fell commented on code in PR #28837: URL: https://github.com/apache/airflow/pull/28837#discussion_r1066521820 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -1049,3 +1050,54 @@ def execute(self, context: Context) -> dict | None:

[airflow] branch constraints-main updated: Updating constraints. Build id:

2023-01-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 84663673f7 Updating

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #28528: Fixes to how DebugExecutor handles sensors

2023-01-10 Thread GitBox
vandonr-amz commented on code in PR #28528: URL: https://github.com/apache/airflow/pull/28528#discussion_r1066495531 ## airflow/ti_deps/deps/ready_to_reschedule.py: ## @@ -44,7 +45,8 @@ def _get_dep_statuses(self, ti, session, dep_context): from

[airflow] branch main updated (44d3082ef9 -> 3baa40d72c)

2023-01-10 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 44d3082ef9 Small Typo Fixed (#28684) add 3baa40d72c Use compat for cached_property in AWS Batch modules

[GitHub] [airflow] josh-fell merged pull request #28835: Use compat for cached_property in AWS Batch modules

2023-01-10 Thread GitBox
josh-fell merged PR #28835: URL: https://github.com/apache/airflow/pull/28835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Small Typo Fixed (#28684)

2023-01-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 44d3082ef9 Small Typo Fixed (#28684) 44d3082ef9 is

[GitHub] [airflow] potiuk merged pull request #28684: Small Typo Fixed in Google Cloud Secret Manager Backend Documentation

2023-01-10 Thread GitBox
potiuk merged PR #28684: URL: https://github.com/apache/airflow/pull/28684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a diff in pull request #28845: Email Config docs more explicit env var examples

2023-01-10 Thread GitBox
potiuk commented on code in PR #28845: URL: https://github.com/apache/airflow/pull/28845#discussion_r1066481456 ## docs/apache-airflow/howto/email-config.rst: ## @@ -28,8 +28,28 @@ in the ``[email]`` section. email_backend = airflow.utils.email.send_email_smtp

[GitHub] [airflow] potiuk commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-01-10 Thread GitBox
potiuk commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1378094682 And yes I am just afraid that we **might** break things for some users - so far I understood that https://github.com/apache/airflow/issues/27545 effectively means that it was really

[GitHub] [airflow] yxiao1996 commented on pull request #28686: Update gantt chart UI to display queued state of tasks

2023-01-10 Thread GitBox
yxiao1996 commented on PR #28686: URL: https://github.com/apache/airflow/pull/28686#issuecomment-1378090326 can anyone help me approve the workflow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-01-10 Thread GitBox
potiuk commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1378085890 I think this is one of those cases that we really balloon a matrix of tests for very little reason. Seems that we alrady have a number of tests - now failing) where both are set

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28846: Updated app to support configuring the caching hash method for FIPS

2023-01-10 Thread GitBox
boring-cyborg[bot] commented on PR #28846: URL: https://github.com/apache/airflow/pull/28846#issuecomment-1378071135 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] shyft-mike opened a new pull request, #28846: Updated app to support configuring the caching hash method for FIPS

2023-01-10 Thread GitBox
shyft-mike opened a new pull request, #28846: URL: https://github.com/apache/airflow/pull/28846 This was created to address issues that occurred in a FIPS enabled environment. This allows you to set the CACHING_HASH_METHOD config value to override the default of md5. Also updates the

[GitHub] [airflow] potiuk commented on pull request #28842: Remove TYPE_CHECKING for `airflow.utils.context.Context` in providers

2023-01-10 Thread GitBox
potiuk commented on PR #28842: URL: https://github.com/apache/airflow/pull/28842#issuecomment-1378051698 Yes. you can add the same limits as for the other providers. I think common.sql was added around the same time when we added the min-version and that's why it did not have the limit

[GitHub] [airflow] jedcunningham commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

2023-01-10 Thread GitBox
jedcunningham commented on PR #28813: URL: https://github.com/apache/airflow/pull/28813#issuecomment-1378048972 Thanks @Chen-Oliver! Congrats on your first commit  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[airflow] branch main updated: Add worker service account for LocalKubernetesExecutor (#28813)

2023-01-10 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8f933c99c1 Add worker service account for

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

2023-01-10 Thread GitBox
boring-cyborg[bot] commented on PR #28813: URL: https://github.com/apache/airflow/pull/28813#issuecomment-1378048558 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] jedcunningham merged pull request #28813: Add worker service account for LocalKubernetesExecutor

2023-01-10 Thread GitBox
jedcunningham merged PR #28813: URL: https://github.com/apache/airflow/pull/28813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #28773: pre-commit check for xfail in unit tests

2023-01-10 Thread GitBox
potiuk commented on PR #28773: URL: https://github.com/apache/airflow/pull/28773#issuecomment-1378047260 BTW. it does not mean that the encouragement of getting rid of those xfals is bad idea (if done correctly). -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk closed pull request #28773: pre-commit check for xfail in unit tests

2023-01-10 Thread GitBox
potiuk closed pull request #28773: pre-commit check for xfail in unit tests URL: https://github.com/apache/airflow/pull/28773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on pull request #28773: pre-commit check for xfail in unit tests

2023-01-10 Thread GitBox
potiuk commented on PR #28773: URL: https://github.com/apache/airflow/pull/28773#issuecomment-1378044577 > This is a -0.99 from me. XFail exists for a reason, we can discourage it's use without needing to remove it. Yep. I think there are reasons why you might want to have xfail.

[GitHub] [airflow] potiuk commented on pull request #28840: Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb"

2023-01-10 Thread GitBox
potiuk commented on PR #28840: URL: https://github.com/apache/airflow/pull/28840#issuecomment-1378036683 Right my bad on approving it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated: Update CSRF token to expire with session (#28730)

2023-01-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 543e9a592e Update CSRF token to expire with

[GitHub] [airflow] potiuk closed issue #28356: CSRF token should be expire with session

2023-01-10 Thread GitBox
potiuk closed issue #28356: CSRF token should be expire with session URL: https://github.com/apache/airflow/issues/28356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk merged pull request #28730: Update CSRF token to expire with session

2023-01-10 Thread GitBox
potiuk merged PR #28730: URL: https://github.com/apache/airflow/pull/28730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-10 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1378016820 ok, made it accept a list or dict where meaningful, and added the missing file. It's also shipping a clandestine commit for now because it's stacked on top of

[GitHub] [airflow] jedcunningham commented on a diff in pull request #28844: Annotate KubeExecutor pods that we don't delete

2023-01-10 Thread GitBox
jedcunningham commented on code in PR #28844: URL: https://github.com/apache/airflow/pull/28844#discussion_r1066432769 ## airflow/executors/kubernetes_executor.py: ## @@ -52,6 +52,7 @@ from airflow.utils.state import State ALL_NAMESPACES = "ALL_NAMESPACES" +POD_DONE_KEY =

[GitHub] [airflow] curlup opened a new pull request, #28845: Email Config docs more explicit env var examples

2023-01-10 Thread GitBox
curlup opened a new pull request, #28845: URL: https://github.com/apache/airflow/pull/28845 Small improvements to the docs, because it took me couple hours to figure out that env var usage was possible for email config. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] jedcunningham commented on pull request #28822: Disable GitSync + Persistence combo in the Helm Chart

2023-01-10 Thread GitBox
jedcunningham commented on PR #28822: URL: https://github.com/apache/airflow/pull/28822#issuecomment-1377998427 I think I'd rather warn instead of block (but I'm also a bit worn down on thinking about the combo in our chart, so I certainly won't stand in the way here). -- This is an

[GitHub] [airflow] vincbeck commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-10 Thread GitBox
vincbeck commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066412297 ## airflow/api_internal/internal_api_call.py: ## @@ -94,21 +93,20 @@ def make_jsonrpc_request(method_name: str, params_json: str) -> bytes: return

[GitHub] [airflow] vincbeck commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-10 Thread GitBox
vincbeck commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066411274 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from

[airflow] branch main updated: Validate Sphinx Inventory file header (#28838)

2023-01-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 04306f18b0 Validate Sphinx Inventory file header

[GitHub] [airflow] potiuk merged pull request #28838: Validate Sphinx Inventory file header

2023-01-10 Thread GitBox
potiuk merged PR #28838: URL: https://github.com/apache/airflow/pull/28838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28827: Add option to wait for completion on the EmrCreateJobFlowOperator

2023-01-10 Thread GitBox
o-nikolas commented on code in PR #28827: URL: https://github.com/apache/airflow/pull/28827#discussion_r1066407359 ## airflow/providers/amazon/aws/utils/waiter.py: ## @@ -60,14 +60,20 @@ def waiter( break if state in failure_states: raise

[GitHub] [airflow] potiuk commented on pull request #28813: Add worker service account for LocalKubernetesExecutor

2023-01-10 Thread GitBox
potiuk commented on PR #28813: URL: https://github.com/apache/airflow/pull/28813#issuecomment-1377970719 rebased to account for doc failure fixed in main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] Almenon commented on issue #27799: First task in Quick Start fails

2023-01-10 Thread GitBox
Almenon commented on issue #27799: URL: https://github.com/apache/airflow/issues/27799#issuecomment-1377962978 I still see this, should this be working as of 2.5.0? Note that I have airflow running in another terminal tab while I execute the command. ``` ➜ ~ airflow version

[GitHub] [airflow] jedcunningham opened a new pull request, #28844: Annotate KubeExecutor pods that we don't delete

2023-01-10 Thread GitBox
jedcunningham opened a new pull request, #28844: URL: https://github.com/apache/airflow/pull/28844 We weren't keeping track of which pods we'd finished with yet, so if you had `[kubernetes_executor] delete_worker_pods` false, your KubeExecutor would adopt every single remaining pod when

[GitHub] [airflow] potiuk commented on issue #27473: Deadlock when updating DagRun last_scheduling_decision and TaskInstance state=scheduled

2023-01-10 Thread GitBox
potiuk commented on issue #27473: URL: https://github.com/apache/airflow/issues/27473#issuecomment-1377942911 > Sounds good. We do have plans to upgrade next month  Cool . Let us know what you find out. And in case you find it happening, providing logs including server-side logs

[GitHub] [airflow] vincbeck opened a new pull request, #28843: Fix system test example_redshift_s3_transfers.py

2023-01-10 Thread GitBox
vincbeck opened a new pull request, #28843: URL: https://github.com/apache/airflow/pull/28843 This [commit](https://github.com/aws-mwaa/upstream-to-airflow/commit/3a7cb66784894b414a4c8d6e5020030fe90d8384) made the system test example_redshift_s3_transfers failed. The files generated as

[GitHub] [airflow] BasPH commented on a diff in pull request #28827: Add option to wait for completion on the EmrCreateJobFlowOperator

2023-01-10 Thread GitBox
BasPH commented on code in PR #28827: URL: https://github.com/apache/airflow/pull/28827#discussion_r1066381947 ## airflow/providers/amazon/aws/utils/waiter.py: ## @@ -60,14 +60,20 @@ def waiter( break if state in failure_states: raise

[GitHub] [airflow] josh-fell commented on pull request #28842: Remove TYPE_CHECKING for `airflow.utils.context.Context` in providers

2023-01-10 Thread GitBox
josh-fell commented on PR #28842: URL: https://github.com/apache/airflow/pull/28842#issuecomment-1377908220 @potiuk I noticed that the Common SQL provider doesn't specify having a minimum Airflow version in its `provider.yaml` file, but I went ahead and pushed some updates anyway. Let me

[GitHub] [airflow] BasPH commented on a diff in pull request #28827: Add option to wait for completion on the EmrCreateJobFlowOperator

2023-01-10 Thread GitBox
BasPH commented on code in PR #28827: URL: https://github.com/apache/airflow/pull/28827#discussion_r1066367905 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -538,42 +544,76 @@ def __init__( emr_conn_id: str | None = "emr_default", job_flow_overrides:

[GitHub] [airflow] potiuk commented on pull request #28818: Throttle streaming log reads

2023-01-10 Thread GitBox
potiuk commented on PR #28818: URL: https://github.com/apache/airflow/pull/28818#issuecomment-1377894023 I think there were some weird network failures (on top of inventory files changed by Google). So it needs rebase :) -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on a diff in pull request #28838: Validate Sphinx Inventory file header

2023-01-10 Thread GitBox
potiuk commented on code in PR #28838: URL: https://github.com/apache/airflow/pull/28838#discussion_r1066360473 ## docs/exts/docs_build/fetch_inventories.py: ## @@ -47,25 +49,41 @@ def _fetch_file(session: requests.Session, package_name: str, url: str, path: str) ->

[airflow] branch main updated (46ce223385 -> e1e3a8e94d)

2023-01-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 46ce223385 Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb (#23650)" (#28840) add e1e3a8e94d

[GitHub] [airflow] potiuk merged pull request #28824: Bump swagger-ui-dist from 3.52.0 to 4.1.3 in /airflow/www

2023-01-10 Thread GitBox
potiuk merged PR #28824: URL: https://github.com/apache/airflow/pull/28824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #28824: Bump swagger-ui-dist from 3.52.0 to 4.1.3 in /airflow/www

2023-01-10 Thread GitBox
potiuk commented on PR #28824: URL: https://github.com/apache/airflow/pull/28824#issuecomment-1377881362 Ok. I tested it locally and looks like it works out-of-the box (at least few simple checks I made). Merging. Thanks for driving the whole change @JGoldman110 ! It feels good

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28827: Add option to wait for completion on the EmrCreateJobFlowOperator

2023-01-10 Thread GitBox
o-nikolas commented on code in PR #28827: URL: https://github.com/apache/airflow/pull/28827#discussion_r1066357512 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -538,42 +544,76 @@ def __init__( emr_conn_id: str | None = "emr_default",

[airflow] branch main updated (44d93bea3a -> 46ce223385)

2023-01-10 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 44d93bea3a Google have re-worked their docs site ane appear not publish objects.inv (#28834) add 46ce223385

[GitHub] [airflow] kaxil merged pull request #28840: Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb"

2023-01-10 Thread GitBox
kaxil merged PR #28840: URL: https://github.com/apache/airflow/pull/28840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #28300: Add Public Interface description to Airflow documentation

2023-01-10 Thread GitBox
potiuk commented on PR #28300: URL: https://github.com/apache/airflow/pull/28300#issuecomment-1377861970 Hey @BasPH - just to repeat it - is your "change requested" still valid? Is the current approach good enough for you or do you think there is something stil not OK with teh

[GitHub] [airflow] josh-fell opened a new pull request, #28842: Remove TYPE_CHECKING for `airflow.utils.context.Context` in providers

2023-01-10 Thread GitBox
josh-fell opened a new pull request, #28842: URL: https://github.com/apache/airflow/pull/28842 Now that all providers have a minimum Airflow version of 2.3.0, importing `airflow.utils.context.Context` no longer needs to be done behind TYPE_CHECKING. The `Context` module was made available

[GitHub] [airflow] ferruzzi commented on issue #22438: Migrate Amazon example DAGs to new design

2023-01-10 Thread GitBox
ferruzzi commented on issue #22438: URL: https://github.com/apache/airflow/issues/22438#issuecomment-1377841669 If I'm not mistaken, that would require changes tot he system test runner which I think currently triggers on the "example" prefix. This was a holdout to when they were still

[GitHub] [airflow] mhenc commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-10 Thread GitBox
mhenc commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066315168 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from

[GitHub] [airflow] mhenc commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-10 Thread GitBox
mhenc commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066315168 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from

[GitHub] [airflow] ferruzzi commented on pull request #28755: Add a new SSM hook and use it in the System Test context builder

2023-01-10 Thread GitBox
ferruzzi commented on PR #28755: URL: https://github.com/apache/airflow/pull/28755#issuecomment-1377824253 Reverting the change [here](https://github.com/apache/airflow/pull/28755/files#diff-9a10c331ad3eee9de5dde9e28f6f26b708be356b390b6e8dd74e4b2d715efca0R96) does pass tests (locally at

[airflow] branch main updated: Google have re-worked their docs site ane appear not publish objects.inv (#28834)

2023-01-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 44d93bea3a Google have re-worked their docs site

[GitHub] [airflow] potiuk commented on pull request #28834: Google have re-worked their docs site ane appear not publish objects.inv

2023-01-10 Thread GitBox
potiuk commented on PR #28834: URL: https://github.com/apache/airflow/pull/28834#issuecomment-1377820689 Merge it - it was green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk merged pull request #28834: Google have re-worked their docs site ane appear not publish objects.inv

2023-01-10 Thread GitBox
potiuk merged PR #28834: URL: https://github.com/apache/airflow/pull/28834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (284cd52989 -> 12adb5e8c0)

2023-01-10 Thread bolke
This is an automated email from the ASF dual-hosted git repository. bolke pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 284cd52989 Add deferrable ``GCSObjectExistenceSensorAsync`` (#28763) add 12adb5e8c0 Make

[GitHub] [airflow] bolkedebruin merged pull request #28829: Make allowed_deserialization_classes more intuitive

2023-01-10 Thread GitBox
bolkedebruin merged PR #28829: URL: https://github.com/apache/airflow/pull/28829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on a diff in pull request #28839: Fix taskflow.rst duplicated "or"

2023-01-10 Thread GitBox
jedcunningham commented on code in PR #28839: URL: https://github.com/apache/airflow/pull/28839#discussion_r1066275497 ## docs/apache-airflow/tutorial/taskflow.rst: ## @@ -234,8 +234,7 @@ Using the TaskFlow API with complex/conflicting Python dependencies

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28827: Add option to wait for completion on the EmrCreateJobFlowOperator

2023-01-10 Thread GitBox
o-nikolas commented on code in PR #28827: URL: https://github.com/apache/airflow/pull/28827#discussion_r1066269743 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -538,42 +544,76 @@ def __init__( emr_conn_id: str | None = "emr_default",

[GitHub] [airflow] frankcash commented on a diff in pull request #28773: pre-commit check for xfail in unit tests

2023-01-10 Thread GitBox
frankcash commented on code in PR #28773: URL: https://github.com/apache/airflow/pull/28773#discussion_r1066261644 ## .pre-commit-config.yaml: ## @@ -577,6 +577,14 @@ repos: files: \.*example_dags.*\.py$ exclude: ^airflow/_vendor/ pass_filenames: true

[GitHub] [airflow] ashb commented on pull request #28773: pre-commit check for xfail in unit tests

2023-01-10 Thread GitBox
ashb commented on PR #28773: URL: https://github.com/apache/airflow/pull/28773#issuecomment-133398 This is a -0.99 from me. XFail exists for a reason, we can discourage it's use without needing to remove it. -- This is an automated message from the Apache Git Service. To respond to

[airflow] branch revert-23650-remove_xfail_test_secrets_marker created (now a8d9d03456)

2023-01-10 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch revert-23650-remove_xfail_test_secrets_marker in repository https://gitbox.apache.org/repos/asf/airflow.git at a8d9d03456 Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb

[GitHub] [airflow] ashb opened a new pull request, #28840: Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb"

2023-01-10 Thread GitBox
ashb opened a new pull request, #28840: URL: https://github.com/apache/airflow/pull/28840 Reverts apache/airflow#23650 No no no. That was there for a reason. By making this test pass you are encoding that the _wrong_ behaviour is good. If you want to get rid of the xfail _DO

[GitHub] [airflow] potiuk commented on pull request #28834: Google have re-worked their docs site ane appear not publish objects.inv

2023-01-10 Thread GitBox
potiuk commented on PR #28834: URL: https://github.com/apache/airflow/pull/28834#issuecomment-132170 We can always simply revert it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on pull request #28834: Google have re-worked their docs site ane appear not publish objects.inv

2023-01-10 Thread GitBox
potiuk commented on PR #28834: URL: https://github.com/apache/airflow/pull/28834#issuecomment-131733 > Google are working on fixing this so we likely don't have to merge this PR I'd merge it anyway - we never know how long it will take them and whether it will be working at first

[GitHub] [airflow] potiuk commented on pull request #28834: Google have re-worked their docs site ane appear not publish objects.inv

2023-01-10 Thread GitBox
potiuk commented on PR #28834: URL: https://github.com/apache/airflow/pull/28834#issuecomment-1377768356 It's almost fixed while we wait for Google - but we need to add spellcheck exclusions: SynthesizeSpeechResponse TransferRun StartManualTransferRunsResponse TransferConfig

[GitHub] [airflow] frankcash commented on a diff in pull request #28773: pre-commit check for xfail in unit tests

2023-01-10 Thread GitBox
frankcash commented on code in PR #28773: URL: https://github.com/apache/airflow/pull/28773#discussion_r1066247422 ## .pre-commit-config.yaml: ## @@ -577,6 +577,14 @@ repos: files: \.*example_dags.*\.py$ exclude: ^airflow/_vendor/ pass_filenames: true

[GitHub] [airflow] ashb commented on pull request #28834: Google have re-worked their docs site ane appear not publish objects.inv

2023-01-10 Thread GitBox
ashb commented on PR #28834: URL: https://github.com/apache/airflow/pull/28834#issuecomment-1377765809 Google are working on fixing this so we likely don't have to merge this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] vincbeck commented on issue #28269: AIP-44 Migrate DagFileProcessor.execute_callbacks to Internal API.

2023-01-10 Thread GitBox
vincbeck commented on issue #28269: URL: https://github.com/apache/airflow/issues/28269#issuecomment-1377765140 I dont think the method `execute_callbacks` needs to be converted itself but rather the submethods `_execute_task_callbacks` and `_execute_dag_callbacks`. What do you think? The

[GitHub] [airflow] dstandish commented on a diff in pull request #28818: Throttle streaming log reads

2023-01-10 Thread GitBox
dstandish commented on code in PR #28818: URL: https://github.com/apache/airflow/pull/28818#discussion_r1066243910 ## airflow/utils/log/log_reader.py: ## @@ -77,12 +78,16 @@ def read_log_stream(self, ti: TaskInstance, try_number: int | None, metadata: di

[GitHub] [airflow] jedcunningham commented on a diff in pull request #28773: pre-commit check for xfail in unit tests

2023-01-10 Thread GitBox
jedcunningham commented on code in PR #28773: URL: https://github.com/apache/airflow/pull/28773#discussion_r1066240841 ## .pre-commit-config.yaml: ## @@ -577,6 +577,14 @@ repos: files: \.*example_dags.*\.py$ exclude: ^airflow/_vendor/ pass_filenames:

[GitHub] [airflow] ashwinshankar77 commented on issue #27473: Deadlock when updating DagRun last_scheduling_decision and TaskInstance state=scheduled

2023-01-10 Thread GitBox
ashwinshankar77 commented on issue #27473: URL: https://github.com/apache/airflow/issues/27473#issuecomment-1377758547 Hi, we are seeing this deadlock error at Slack at scale causing disruptions. Is there any fix thats been worked on? cc: @potiuk Details: Airflow version: 2.2.5,

[GitHub] [airflow] itaymaslo opened a new pull request, #28839: Fix taskflow.rst duplicated "or"

2023-01-10 Thread GitBox
itaymaslo opened a new pull request, #28839: URL: https://github.com/apache/airflow/pull/28839 "... Docker container (since version 2.2.0) **or or** ExternalPythonOperator ..." -> "... Docker container (since version 2.2.0) **or** ExternalPythonOperator ..." -- This is an automated

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28839: Fix taskflow.rst duplicated "or"

2023-01-10 Thread GitBox
boring-cyborg[bot] commented on PR #28839: URL: https://github.com/apache/airflow/pull/28839#issuecomment-1377748572 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] o-nikolas commented on issue #27957: Request wildcard prefix feature for s3 to redshift transfer operator

2023-01-10 Thread GitBox
o-nikolas commented on issue #27957: URL: https://github.com/apache/airflow/issues/27957#issuecomment-1377744459 PR #28705 has been merged, closing as completed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] o-nikolas closed issue #27957: Request wildcard prefix feature for s3 to redshift transfer operator

2023-01-10 Thread GitBox
o-nikolas closed issue #27957: Request wildcard prefix feature for s3 to redshift transfer operator URL: https://github.com/apache/airflow/issues/27957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] dstandish commented on a diff in pull request #28818: Throttle streaming log reads

2023-01-10 Thread GitBox
dstandish commented on code in PR #28818: URL: https://github.com/apache/airflow/pull/28818#discussion_r1066219687 ## airflow/utils/log/log_reader.py: ## @@ -77,12 +78,16 @@ def read_log_stream(self, ti: TaskInstance, try_number: int | None, metadata: di

[GitHub] [airflow] o-nikolas commented on issue #23666: Add transfers operator S3 to SQL / SQL to SQL

2023-01-10 Thread GitBox
o-nikolas commented on issue #23666: URL: https://github.com/apache/airflow/issues/23666#issuecomment-1377738893 @magges Are you interested in opening a PR for this issue? We can re-assign it to you since we have not heard from @thinhnd2104 in some time. -- This is an automated

[GitHub] [airflow] Taragolis opened a new pull request, #28838: Validate Sphinx Inventory file header

2023-01-10 Thread GitBox
Taragolis opened a new pull request, #28838: URL: https://github.com/apache/airflow/pull/28838 follow-up: https://github.com/apache/airflow/pull/28834 1. Before save inventory file validate headers 2. Stop processing if any error happen during fetching inventory, it could save

[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-10 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1377735626 oh so you mean we should always accept either preformated or as a dict. Yeah why not, I can do that. -- This is an automated message from the Apache Git Service. To respond to

  1   2   >