[GitHub] [airflow] potiuk opened a new pull request, #29865: Workaround documentation prooblems for Boto3

2023-03-01 Thread via GitHub
potiuk opened a new pull request, #29865: URL: https://github.com/apache/airflow/pull/29865 Boto3 interspinx repository got broken as of 2.26.81 and it is being tracked in https://github.com/boto/boto3/issues/3610 This PR fixes the version of the inventory to 2.26.80 which is the

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29756: DAG list sorting lost when switching page

2023-03-01 Thread via GitHub
amoghrajesh commented on code in PR #29756: URL: https://github.com/apache/airflow/pull/29756#discussion_r1122690163 ## airflow/www/utils.py: ## @@ -238,6 +247,8 @@ def generate_pages(current_page, num_of_pages, search=None, status=None, tags=No :param status: 'all',

[GitHub] [airflow] SamWheating commented on a diff in pull request #29850: Fixing broken filter in in /taskinstance/list view

2023-03-01 Thread via GitHub
SamWheating commented on code in PR #29850: URL: https://github.com/apache/airflow/pull/29850#discussion_r1122665539 ## airflow/models/taskinstance.py: ## @@ -139,6 +139,10 @@ from airflow.models.operator import Operator from airflow.utils.task_group import

[GitHub] [airflow] potiuk commented on pull request #29848: Fix memory exhaution in containers resulting from infinite nofile

2023-03-01 Thread via GitHub
potiuk commented on PR #29848: URL: https://github.com/apache/airflow/pull/29848#issuecomment-1451378234 Might be not needed - seems that a new version of python_daemon is coming with improved memory management in this case. See https://pagure.io/python-daemon/issue/72 -- This is an

[GitHub] [airflow] uranusjr commented on a diff in pull request #29850: Fixing broken filter in in /taskinstance/list view

2023-03-01 Thread via GitHub
uranusjr commented on code in PR #29850: URL: https://github.com/apache/airflow/pull/29850#discussion_r1122655003 ## airflow/models/taskinstance.py: ## @@ -139,6 +139,10 @@ from airflow.models.operator import Operator from airflow.utils.task_group import

[GitHub] [airflow] uranusjr commented on pull request #29842: Allow for templated args to be passed to the result_processor function in the GithubSensor fixing templated tags in GithubTagSensor

2023-03-01 Thread via GitHub
uranusjr commented on PR #29842: URL: https://github.com/apache/airflow/pull/29842#issuecomment-1451372967 What are the incompatibilities if this is enabled by default, or always enabled? Since this is from a provider, we can break backward compatibility more freely if we think the new

[GitHub] [airflow] uranusjr commented on a diff in pull request #29840: DatabricksSubmitRunOperator to support taskflow

2023-03-01 Thread via GitHub
uranusjr commented on code in PR #29840: URL: https://github.com/apache/airflow/pull/29840#discussion_r1122650972 ## airflow/providers/databricks/operators/databricks.py: ## @@ -285,12 +285,12 @@ def __init__( *, json: Any | None = None, tasks:

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29864: airflow dags list is not listing all the dags present in airflow home location

2023-03-01 Thread via GitHub
boring-cyborg[bot] commented on issue #29864: URL: https://github.com/apache/airflow/issues/29864#issuecomment-1451357666 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] MuthuVignesh91 opened a new issue, #29864: airflow dags list is not listing all the dags present in airflow home location

2023-03-01 Thread via GitHub
MuthuVignesh91 opened a new issue, #29864: URL: https://github.com/apache/airflow/issues/29864 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened v2.0.2 When trying the "airflow dags list", via the aws mwaa API, we see that the

[GitHub] [airflow] uranusjr commented on a diff in pull request #29756: DAG list sorting lost when switching page

2023-03-01 Thread via GitHub
uranusjr commented on code in PR #29756: URL: https://github.com/apache/airflow/pull/29756#discussion_r1122640728 ## airflow/www/utils.py: ## @@ -238,6 +247,8 @@ def generate_pages(current_page, num_of_pages, search=None, status=None, tags=No :param status: 'all',

[GitHub] [airflow] hterik commented on issue #29833: Celery tasks stuck in queued state after worker crash (Set changed size during iteration)

2023-03-01 Thread via GitHub
hterik commented on issue #29833: URL: https://github.com/apache/airflow/issues/29833#issuecomment-1451351005 After digging more i found following possibly related issues: https://github.com/apache/airflow/discussions/28022 https://github.com/apache/airflow/issues/28120

[GitHub] [airflow] josh-fell commented on a diff in pull request #29863: Fix Python API docs formatting for Common SQL provider

2023-03-01 Thread via GitHub
josh-fell commented on code in PR #29863: URL: https://github.com/apache/airflow/pull/29863#discussion_r1122605503 ## airflow/providers/common/sql/operators/sql.py: ## @@ -73,6 +73,8 @@ def _get_failed_checks(checks, col=None): parse_boolean = _parse_boolean """

[GitHub] [airflow] josh-fell commented on a diff in pull request #29863: Fix Python API docs formatting for Common SQL provider

2023-03-01 Thread via GitHub
josh-fell commented on code in PR #29863: URL: https://github.com/apache/airflow/pull/29863#discussion_r1122605503 ## airflow/providers/common/sql/operators/sql.py: ## @@ -73,6 +73,8 @@ def _get_failed_checks(checks, col=None): parse_boolean = _parse_boolean """

[GitHub] [airflow] josh-fell opened a new pull request, #29863: Fix Python API docs formatting for Common SQL provider

2023-03-01 Thread via GitHub
josh-fell opened a new pull request, #29863: URL: https://github.com/apache/airflow/pull/29863 There were a number of places in which poor or incorrect formatting led to illegible documentation or funky appearances. *Hooks* | Before | After | | --- | -- |

[GitHub] [airflow] uranusjr opened a new pull request, #29862: Move sqlalchemy.ext.declarative imports to orm

2023-03-01 Thread via GitHub
uranusjr opened a new pull request, #29862: URL: https://github.com/apache/airflow/pull/29862 These imports are being moved to sqlalchemy.orm, and are also available there in 1.4 (which we use), so let's move them to ease the eventual migration to 2.0. See

[GitHub] [airflow] command-z-z opened a new issue, #29861: add new provider

2023-03-01 Thread via GitHub
command-z-z opened a new issue, #29861: URL: https://github.com/apache/airflow/issues/29861 ### Description i have written a new provider,how can i contribute it? ### Use case/motivation nothing ### Related issues nothing ### Are you willing to

[GitHub] [airflow] RNHTTR commented on pull request #28943: Add handling logic on CeleryExecutor to reschedule task stuck in queued status

2023-03-01 Thread via GitHub
RNHTTR commented on PR #28943: URL: https://github.com/apache/airflow/pull/28943#issuecomment-1451216257 1. Should this instead set the task state to `FAILED` instead of `SCHEDULED` to avoid a possible infinite loop of scheduled -> queued -> scheduled -> queued? 2. Should there instead

[GitHub] [airflow] josh-fell commented on issue #29836: Restrict allowed characters in connection ids

2023-03-01 Thread via GitHub
josh-fell commented on issue #29836: URL: https://github.com/apache/airflow/issues/29836#issuecomment-1451197555 Good idea! All yours @BasPH! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] josh-fell commented on a diff in pull request #29840: DatabricksSubmitRunOperator to support taskflow

2023-03-01 Thread via GitHub
josh-fell commented on code in PR #29840: URL: https://github.com/apache/airflow/pull/29840#discussion_r1122539049 ## airflow/providers/databricks/operators/databricks.py: ## @@ -285,12 +285,12 @@ def __init__( *, json: Any | None = None, tasks:

[GitHub] [airflow] dstandish commented on issue #29324: Ensure only one setup/teardown is allowed per scope

2023-03-01 Thread via GitHub
dstandish commented on issue #29324: URL: https://github.com/apache/airflow/issues/29324#issuecomment-1451124309 ok nice, i updated description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] jedcunningham commented on pull request #29413: Add a new graph inside of the grid view

2023-03-01 Thread via GitHub
jedcunningham commented on PR #29413: URL: https://github.com/apache/airflow/pull/29413#issuecomment-1451123006 (#protm) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] dstandish commented on issue #29336: Ensure setup/teardown dependencies raise an error

2023-03-01 Thread via GitHub
dstandish commented on issue #29336: URL: https://github.com/apache/airflow/issues/29336#issuecomment-1451122639 i think you may mean, if you define an upstream / downstream relationship between normal and setup, raise? -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] dstandish commented on issue #29328: Update the DAG graph to show setup/teardown

2023-03-01 Thread via GitHub
dstandish commented on issue #29328: URL: https://github.com/apache/airflow/issues/29328#issuecomment-1451120422 probably want to also indicate that it's special with diff color or icon overlay -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] jedcunningham commented on issue #29324: Ensure only one setup/teardown is allowed per scope

2023-03-01 Thread via GitHub
jedcunningham commented on issue #29324: URL: https://github.com/apache/airflow/issues/29324#issuecomment-1451119237 I blocked nested setups, but I didn't block 2 peer setups yet :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] dstandish commented on issue #29327: Enable implicit relationships for declared setup/teardown tasks

2023-03-01 Thread via GitHub
dstandish commented on issue #29327: URL: https://github.com/apache/airflow/issues/29327#issuecomment-1451119196 @norm can you clarify what you mean by implicit relationships? i think what you mean is dependencies i.e. setup runs before normal tasks etc -- This is an automated message

[GitHub] [airflow] dstandish commented on issue #29324: Ensure only one setup/teardown is allowed per scope

2023-03-01 Thread via GitHub
dstandish commented on issue #29324: URL: https://github.com/apache/airflow/issues/29324#issuecomment-1451118159 this one appears covered by test `test_setup_block_nested` @jedcunningham -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] SamWheating opened a new pull request, #29860: Updating dag run endpoint to 404 if requested dag is inactive

2023-03-01 Thread via GitHub
SamWheating opened a new pull request, #29860: URL: https://github.com/apache/airflow/pull/29860 closes: https://github.com/apache/airflow/issues/29839 The create dagrun API endpoint wasn't properly checking that a DAG was active and thus a user could try to trigger a DAG which had

[GitHub] [airflow] okayhooni commented on pull request #29838: Remove replicas if KEDA is enabled

2023-03-01 Thread via GitHub
okayhooni commented on PR #29838: URL: https://github.com/apache/airflow/pull/29838#issuecomment-1451109195 I think current code change of this MR not considering the case that Airflow is deployed with KEDA enabled, not by GitOps tools like ArgoCD, but by Helm itself (more general case).

[GitHub] [airflow] bbovenzi closed issue #23412: Move Grid webserver endpoints to REST API

2023-03-01 Thread via GitHub
bbovenzi closed issue #23412: Move Grid webserver endpoints to REST API URL: https://github.com/apache/airflow/issues/23412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] bbovenzi commented on issue #23421: Add Run Task Instance endpoint to REST API

2023-03-01 Thread via GitHub
bbovenzi commented on issue #23421: URL: https://github.com/apache/airflow/issues/23421#issuecomment-1451103792 Closing since we got rid of the Run action from the UI in https://github.com/apache/airflow/pull/29706 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] bbovenzi closed issue #23421: Add Run Task Instance endpoint to REST API

2023-03-01 Thread via GitHub
bbovenzi closed issue #23421: Add Run Task Instance endpoint to REST API URL: https://github.com/apache/airflow/issues/23421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] bbovenzi opened a new issue, #29859: Migrate all DAG details to existing grid view dag details panel

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29859: URL: https://github.com/apache/airflow/issues/29859 - [ ] Add any important information in `/dags/{dag_id}/details` to the dag details panel in grid view (when a user doesn't have a task or run selected). - [ ] Redirect all urls - [ ] Delete old

[GitHub] [airflow] bbovenzi opened a new issue, #29858: Migrate DAG Code page to Grid Details

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29858: URL: https://github.com/apache/airflow/issues/29858 - [ ] Use REST API to render DAG Code in the grid view as a tab when a user has no runs/tasks selected - [ ] Redirect all urls to new code - [ ] delete the old code view -- This is an

[GitHub] [airflow] bbovenzi opened a new issue, #29857: Migrate DAG Dependencies view to the dataset dependencies graph

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29857: URL: https://github.com/apache/airflow/issues/29857 These two graphs have a lot of overlap and can be quite redundant. We should make the datasets view take over for the DAG Dependencies graph. - [ ] show other DAG dependencies in the datasets

[GitHub] [airflow] bbovenzi opened a new issue, #29856: Migrate Task Instance pages to grid view

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29856: URL: https://github.com/apache/airflow/issues/29856 We have had two logs pages for a while now. And a lot of the information in the Task Instances pages is now redundant with the grid view. We should make the grid view details have all the same

[GitHub] [airflow] bbovenzi opened a new issue, #29855: Improve mapped task instances auto-refresh

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29855: URL: https://github.com/apache/airflow/issues/29855 Basically, redo this PR: https://github.com/apache/airflow/pull/23805#issuecomment-1251025952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] bbovenzi opened a new issue, #29854: Improve js build file sizes

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29854: URL: https://github.com/apache/airflow/issues/29854 The build files for the new react pages are quite large and can be slow to load. We should find ways to fix this to improve page loading times. -- This is an automated message from the Apache Git

[GitHub] [airflow] bbovenzi opened a new issue, #29853: Have datasets graph use the same base as the new graph view

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29853: URL: https://github.com/apache/airflow/issues/29853 Now that https://github.com/apache/airflow/pull/29413 is merged. The dataset dependencies graph should be updated to use the same library and components. -- This is an automated message from the

[GitHub] [airflow] SamWheating commented on issue #29839: Calling endpoint dags/{dag_id}/dagRuns for removed DAG returns "500 Internal Server Error" instead of "404 Not Found"

2023-03-01 Thread via GitHub
SamWheating commented on issue #29839: URL: https://github.com/apache/airflow/issues/29839#issuecomment-1451086286 I have replicated the issue locally in breeze and I'm working on a fix  -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] bbovenzi opened a new issue, #29852: Migrate fully to new graph view

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29852: URL: https://github.com/apache/airflow/issues/29852 Now that https://github.com/apache/airflow/pull/29413 is merged. We should get that graph to fit all user needs to and migrate to it fully, removing the legacy graph view. Steps needed: - [ ]

[GitHub] [airflow] bbovenzi opened a new issue, #29851: Improve TaskInstance and DagRun actions UX

2023-03-01 Thread via GitHub
bbovenzi opened a new issue, #29851: URL: https://github.com/apache/airflow/issues/29851 Problems with current UX: - Actions and their options take up a lot of real estate on the screen - Actions use webserver endpoints and not the REST API - You can only access actions from the

[GitHub] [airflow] github-actions[bot] closed pull request #27124: create gitSync container in dag-processor pod when gitSync is enabled regardless the persistence conf

2023-03-01 Thread via GitHub
github-actions[bot] closed pull request #27124: create gitSync container in dag-processor pod when gitSync is enabled regardless the persistence conf URL: https://github.com/apache/airflow/pull/27124 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] github-actions[bot] commented on issue #28399: Dataproc Generator should allow creating spot instances

2023-03-01 Thread via GitHub
github-actions[bot] commented on issue #28399: URL: https://github.com/apache/airflow/issues/28399#issuecomment-1451076558 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed issue #28399: Dataproc Generator should allow creating spot instances

2023-03-01 Thread via GitHub
github-actions[bot] closed issue #28399: Dataproc Generator should allow creating spot instances URL: https://github.com/apache/airflow/issues/28399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch main updated (181a825259 -> 9172d56682)

2023-03-01 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 181a825259 Use waiters in ECS Operators instead of inner sensors (#29761) add 9172d56682 Add a new graph

[GitHub] [airflow] bbovenzi closed issue #29380: Task Group options in Graph view

2023-03-01 Thread via GitHub
bbovenzi closed issue #29380: Task Group options in Graph view URL: https://github.com/apache/airflow/issues/29380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] bbovenzi merged pull request #29413: Add a new graph inside of the grid view

2023-03-01 Thread via GitHub
bbovenzi merged PR #29413: URL: https://github.com/apache/airflow/pull/29413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] bbovenzi closed issue #19939: Create a new graph view in React

2023-03-01 Thread via GitHub
bbovenzi closed issue #19939: Create a new graph view in React URL: https://github.com/apache/airflow/issues/19939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] bbovenzi commented on pull request #29413: Add a new graph inside of the grid view

2023-03-01 Thread via GitHub
bbovenzi commented on PR #29413: URL: https://github.com/apache/airflow/pull/29413#issuecomment-1451065822 Failing check is not because of this PR. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] SamWheating opened a new pull request, #29850: Use hybrid_property for ti.try_number to fix broken filter in in /taskinstance/list View

2023-03-01 Thread via GitHub
SamWheating opened a new pull request, #29850: URL: https://github.com/apache/airflow/pull/29850 closes: https://github.com/apache/airflow/issues/29843 Because the column and column in the DB are both called `try_number`, flask-appbuilder ends up trying to build a filter using the

[GitHub] [airflow] ferruzzi commented on pull request #29761: Use waiters in ECS Operators instead of inner sensors

2023-03-01 Thread via GitHub
ferruzzi commented on PR #29761: URL: https://github.com/apache/airflow/pull/29761#issuecomment-1451039707 [ECS System test](https://github.com/apache/airflow/blob/main/tests/system/providers/amazon/aws/example_ecs.py) is failing after this merge, the

[GitHub] [airflow] ferruzzi commented on pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
ferruzzi commented on PR #29822: URL: https://github.com/apache/airflow/pull/29822#issuecomment-1451014690 Wow. Something blew up the AWS docs. :eyes: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] uranusjr opened a new pull request, #29849: Clear ExecutorLoader cache in tests

2023-03-01 Thread via GitHub
uranusjr opened a new pull request, #29849: URL: https://github.com/apache/airflow/pull/29849 This allows us to properly test the validator function's behavior against various executors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] bbovenzi commented on a diff in pull request #29413: Add a new graph inside of the grid view

2023-03-01 Thread via GitHub
bbovenzi commented on code in PR #29413: URL: https://github.com/apache/airflow/pull/29413#discussion_r1122384454 ## airflow/www/static/js/dag/index.tsx: ## @@ -30,13 +31,24 @@ import Main from "./Main"; // create shadowRoot const root = document.querySelector("#root");

[GitHub] [airflow] potiuk opened a new pull request, #29848: Fix infinite nofiles from containerd

2023-03-01 Thread via GitHub
potiuk opened a new pull request, #29848: URL: https://github.com/apache/airflow/pull/29848 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] uranusjr opened a new pull request, #29846: Refactor startup/teardown flag and storage

2023-03-01 Thread via GitHub
uranusjr opened a new pull request, #29846: URL: https://github.com/apache/airflow/pull/29846 A new enum is introduced so we can combine the is_setup/teardown flags into one attribute. The children/setup_children/teardown_children in TaskGroup is also refactored into one single dict that

[GitHub] [airflow] potiuk opened a new pull request, #29845: Vendor-in Python daemon package

2023-03-01 Thread via GitHub
potiuk opened a new pull request, #29845: URL: https://github.com/apache/airflow/pull/29845 This PR vendors-in 2.3.2 version of the `python-daemon` package in order to fix the #29841 issue resulting from containerd configure infinite nofile as default. --- **^ Add

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29413: Add a new graph inside of the grid view

2023-03-01 Thread via GitHub
pierrejeambrun commented on code in PR #29413: URL: https://github.com/apache/airflow/pull/29413#discussion_r1122333211 ## airflow/www/static/js/dag/index.tsx: ## @@ -30,13 +31,24 @@ import Main from "./Main"; // create shadowRoot const root = document.querySelector("#root");

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29413: Add a new graph inside of the grid view

2023-03-01 Thread via GitHub
pierrejeambrun commented on code in PR #29413: URL: https://github.com/apache/airflow/pull/29413#discussion_r1122333211 ## airflow/www/static/js/dag/index.tsx: ## @@ -30,13 +31,24 @@ import Main from "./Main"; // create shadowRoot const root = document.querySelector("#root");

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
ferruzzi commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122320795 ## tests/providers/amazon/aws/utils/test_waiter.py: ## @@ -38,6 +38,17 @@ def generate_response(state: str) -> dict[str, Any]: } +def

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29413: Add a new graph inside of the grid view

2023-03-01 Thread via GitHub
pierrejeambrun commented on code in PR #29413: URL: https://github.com/apache/airflow/pull/29413#discussion_r1122340683 ## airflow/www/static/js/utils/index.ts: ## @@ -49,6 +48,44 @@ const finalStatesMap = () => ["no_status", 0], ]); +interface GroupSummaryProps { +

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
ferruzzi commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122320795 ## tests/providers/amazon/aws/utils/test_waiter.py: ## @@ -38,6 +38,17 @@ def generate_response(state: str) -> dict[str, Any]: } +def

[GitHub] [airflow] potiuk commented on issue #29843: The "Try Number" filter under task instances search is comparing integer with non-integer object

2023-03-01 Thread via GitHub
potiuk commented on issue #29843: URL: https://github.com/apache/airflow/issues/29843#issuecomment-1450842493 Cool!. Assigned you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29821: Add a check for not templateable fields

2023-03-01 Thread via GitHub
hussein-awala commented on code in PR #29821: URL: https://github.com/apache/airflow/pull/29821#discussion_r1122294609 ## airflow/serialization/serialized_objects.py: ## @@ -770,8 +772,12 @@ def _serialize_node(cls, op: BaseOperator | MappedOperator, include_deps: bool)

[GitHub] [airflow] potiuk commented on pull request #29143: Demonstrate usage of the PythonSensor

2023-03-01 Thread via GitHub
potiuk commented on PR #29143: URL: https://github.com/apache/airflow/pull/29143#issuecomment-1450811879 @BasPH Also one more case why having example_dags as "executable" and separate python file here: https://github.com/apache/airflow/pull/28325 Our example dags are actually

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
ferruzzi commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122247015 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -191,8 +196,23 @@ def __init__( aws_conn_id: str = "aws_default", waiter_countdown: int =

[GitHub] [airflow] o-nikolas commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
o-nikolas commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122234260 ## tests/providers/amazon/aws/utils/test_waiter.py: ## @@ -38,6 +38,17 @@ def generate_response(state: str) -> dict[str, Any]: } +def

[GitHub] [airflow] pierrejeambrun commented on pull request #29580: Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters

2023-03-01 Thread via GitHub
pierrejeambrun commented on PR #29580: URL: https://github.com/apache/airflow/pull/29580#issuecomment-1450763713 Thanks @eladkal for the details, I completely missed that! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[airflow] branch main updated (5de47910f3 -> 181a825259)

2023-03-01 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 5de47910f3 Allow to specify which connection, variable or config are being looked up in the backend using

[GitHub] [airflow] o-nikolas closed issue #29556: Different AWS ECS Operators use inner Sensor and do not propagate connection arguments

2023-03-01 Thread via GitHub
o-nikolas closed issue #29556: Different AWS ECS Operators use inner Sensor and do not propagate connection arguments URL: https://github.com/apache/airflow/issues/29556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] o-nikolas merged pull request #29761: Use waiters in ECS Operators instead of inner sensors

2023-03-01 Thread via GitHub
o-nikolas merged PR #29761: URL: https://github.com/apache/airflow/pull/29761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #29830: Can I click the node in the DAG diagram?

2023-03-01 Thread via GitHub
potiuk commented on issue #29830: URL: https://github.com/apache/airflow/issues/29830#issuecomment-1450756012 You opened a discussion about that and you got some hints there. Please in the future avoid opening issues for things that are questions -- This is an automated message from the

[GitHub] [airflow] potiuk closed issue #29830: Can I click the node in the DAG diagram?

2023-03-01 Thread via GitHub
potiuk closed issue #29830: Can I click the node in the DAG diagram? URL: https://github.com/apache/airflow/issues/29830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] SamWheating commented on issue #29843: The "Try Number" filter under task instances search is comparing integer with non-integer object

2023-03-01 Thread via GitHub
SamWheating commented on issue #29843: URL: https://github.com/apache/airflow/issues/29843#issuecomment-1450747396  Hey there, I have replicated this issue in Breeze on main and am looking into a fix. -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated: Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters (#29580)

2023-03-01 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5de47910f3 Allow to specify which connection,

[GitHub] [airflow] eladkal merged pull request #29580: Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters

2023-03-01 Thread via GitHub
eladkal merged PR #29580: URL: https://github.com/apache/airflow/pull/29580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on pull request #29580: Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters

2023-03-01 Thread via GitHub
eladkal commented on PR #29580: URL: https://github.com/apache/airflow/pull/29580#issuecomment-1450738834 @dimberman I'm going to merge this PR so we can start working on providers + core release. If something else is needed we can address it in followup PR. -- This is an automated

[GitHub] [airflow] eladkal commented on pull request #29580: Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters

2023-03-01 Thread via GitHub
eladkal commented on PR #29580: URL: https://github.com/apache/airflow/pull/29580#issuecomment-1450733661 @pierrejeambrun this needs to go to 2.5.2 from core point of view this PR contains only doc so this is a doc-change only. The core logic is of providers release cycle which will

[GitHub] [airflow] pierrejeambrun commented on pull request #29580: Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters

2023-03-01 Thread via GitHub
pierrejeambrun commented on PR #29580: URL: https://github.com/apache/airflow/pull/29580#issuecomment-1450717211 @eladkal marking for 2.6.0 as this sounds more like an improvement/feature to me. Feel free to update if I missed something :) -- This is an automated message from the Apache

[GitHub] [airflow] djpalm801 opened a new issue, #29844: ComputeEngineInsertInstanceFromTemplateOperator fails to parse SEV_SNP_CAPABLE in guestOsFeatures disk field

2023-03-01 Thread via GitHub
djpalm801 opened a new issue, #29844: URL: https://github.com/apache/airflow/issues/29844 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened Getting several exceptions when trying to use the

[GitHub] [airflow] amoghrajesh commented on pull request #29756: DAG list sorting lost when switching page

2023-03-01 Thread via GitHub
amoghrajesh commented on PR #29756: URL: https://github.com/apache/airflow/pull/29756#issuecomment-1450596920 Thank you for the review @bbovenzi Trying to understand how to put the unit test in place. Will ping here if i have doubts -- This is an automated message from the Apache

[GitHub] [airflow] zachliu opened a new issue, #29843: The "Try Number" filter under task instances search is comparing integer with non-integer object

2023-03-01 Thread via GitHub
zachliu opened a new issue, #29843: URL: https://github.com/apache/airflow/issues/29843 ### Apache Airflow version 2.5.1 ### What happened The `Try Number` filter is comparing the given integer with an instance of a "property" object * screenshots

[GitHub] [airflow] Taragolis commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
Taragolis commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122106803 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -191,8 +196,23 @@ def __init__( aws_conn_id: str = "aws_default", waiter_countdown: int =

[GitHub] [airflow] Taragolis commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
Taragolis commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122101239 ## tests/providers/amazon/aws/utils/test_waiter.py: ## @@ -38,6 +38,17 @@ def generate_response(state: str) -> dict[str, Any]: } +def

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
ferruzzi commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122097976 ## tests/providers/amazon/aws/utils/test_waiter.py: ## @@ -38,6 +38,17 @@ def generate_response(state: str) -> dict[str, Any]: } +def

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
ferruzzi commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122094891 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -191,8 +196,23 @@ def __init__( aws_conn_id: str = "aws_default", waiter_countdown: int =

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
ferruzzi commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122093323 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -159,9 +160,11 @@ class EmrStartNotebookExecutionOperator(BaseOperator): group to associate with

[GitHub] [airflow] ferruzzi commented on a diff in pull request #29822: Implement custom boto waiters for some EMR operators

2023-03-01 Thread via GitHub
ferruzzi commented on code in PR #29822: URL: https://github.com/apache/airflow/pull/29822#discussion_r1122092558 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -191,8 +196,23 @@ def __init__( aws_conn_id: str = "aws_default", waiter_countdown: int =

[GitHub] [airflow] antonio-antuan commented on issue #29841: high memory leak, cannot start even webserver

2023-03-01 Thread via GitHub
antonio-antuan commented on issue #29841: URL: https://github.com/apache/airflow/issues/29841#issuecomment-1450531952 Glad to help :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on issue #29841: high memory leak, cannot start even webserver

2023-03-01 Thread via GitHub
potiuk commented on issue #29841: URL: https://github.com/apache/airflow/issues/29841#issuecomment-1450518290 Thanks for looking into it and finding out the root cause being python-daemon. So far we missed the root cause of it, but we knew the new containerd has the problem due to their

[airflow] branch main updated: Improve spacing for extra links and grid scrollbar (#29825)

2023-03-01 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5ce40ea726 Improve spacing for extra links and

[GitHub] [airflow] dimberman merged pull request #29825: Improve spacing for extra links and grid scrollbar

2023-03-01 Thread via GitHub
dimberman merged PR #29825: URL: https://github.com/apache/airflow/pull/29825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] minnieshi commented on issue #28637: version 2.4.1 migration job "run-airflow-migrations" run once only when deploy via helm or flux/kustomization

2023-03-01 Thread via GitHub
minnieshi commented on issue #28637: URL: https://github.com/apache/airflow/issues/28637#issuecomment-1450484804 how can i disable the job 'createUserjob' ? i know i can disable the DB migration job. right now the helmRelease just fails at this not needed 'createUserjob' step when helm

[GitHub] [airflow] harishkrao closed pull request #28950: Sensor for Databricks partition and table changes

2023-03-01 Thread via GitHub
harishkrao closed pull request #28950: Sensor for Databricks partition and table changes URL: https://github.com/apache/airflow/pull/28950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] bbovenzi commented on issue #24721: `default_wrap` setting for webserver is not working

2023-03-01 Thread via GitHub
bbovenzi commented on issue #24721: URL: https://github.com/apache/airflow/issues/24721#issuecomment-1450438370 If anyone else wants to pick up this issue. You will want to add a meta tag for `wrapped` to the [ti_log html

[GitHub] [airflow] antonio-antuan commented on issue #29841: high memory leak, cannot start even webserver

2023-03-01 Thread via GitHub
antonio-antuan commented on issue #29841: URL: https://github.com/apache/airflow/issues/29841#issuecomment-1450434725 created an issue for python-daemon: https://pagure.io/python-daemon/issue/72 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] harishkrao commented on pull request #28950: Sensor for Databricks partition and table changes

2023-03-01 Thread via GitHub
harishkrao commented on PR #28950: URL: https://github.com/apache/airflow/pull/28950#issuecomment-1450427673 @eladkal @o-nikolas @josh-fell @alexott thanks for taking the time to review my code and provide feedback. I appreciate it. To incorporate the changes for the 3 sensors, I will

[GitHub] [airflow] vincbeck commented on pull request #29580: Allow to specify which connection, variable or config are being looked up in the backend using *_lookup_pattern parameters

2023-03-01 Thread via GitHub
vincbeck commented on PR #29580: URL: https://github.com/apache/airflow/pull/29580#issuecomment-1450426655 @dimberman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] antonio-antuan commented on issue #29841: high memory leak, cannot start even webserver

2023-03-01 Thread via GitHub
antonio-antuan commented on issue #29841: URL: https://github.com/apache/airflow/issues/29841#issuecomment-1450419914 ok, clarified this is the place where things happens: site-packages/daemon/daemon.py:868 ``` def get_maximum_file_descriptors(): """ Get the maximum

[GitHub] [airflow] TJaniF opened a new pull request, #29842: Allow for templated args to be passed to the result_processor function in the GithubSensor fixing templated tags in GithubTagSensor

2023-03-01 Thread via GitHub
TJaniF opened a new pull request, #29842: URL: https://github.com/apache/airflow/pull/29842 When using a templated `tag_name` in the current GithubTagSensor, the templated argument will not correctly be passed to the call to the GithubSensor.poke method to be used in the `tag_checker`

  1   2   >