[GitHub] [airflow] Aakcht commented on a diff in pull request #31865: Chart: Do not propagate global security context to statsd and redis

2023-06-21 Thread via GitHub
Aakcht commented on code in PR #31865: URL: https://github.com/apache/airflow/pull/31865#discussion_r1238081514 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -89,7 +88,7 @@ spec: - name: statsd image: {{ template "statsd_image" . }} image

[GitHub] [airflow] Aakcht commented on a diff in pull request #31865: Chart: Do not propagate global security context to statsd and redis

2023-06-21 Thread via GitHub
Aakcht commented on code in PR #31865: URL: https://github.com/apache/airflow/pull/31865#discussion_r1238081019 ## tests/charts/security/test_security_context.py: ## @@ -210,6 +210,36 @@ def test_gitsync_sidecar_and_init_container(self): docs[index],

[GitHub] [airflow] Aakcht commented on a diff in pull request #31865: Chart: Do not propagate global security context to statsd and redis

2023-06-21 Thread via GitHub
Aakcht commented on code in PR #31865: URL: https://github.com/apache/airflow/pull/31865#discussion_r1238078109 ## tests/charts/security/test_security_context.py: ## @@ -210,6 +210,36 @@ def test_gitsync_sidecar_and_init_container(self): docs[index],

[GitHub] [airflow] boring-cyborg[bot] commented on issue #32069: AioRpcError in DataprocCreateBatchOperator

2023-06-21 Thread via GitHub
boring-cyborg[bot] commented on issue #32069: URL: https://github.com/apache/airflow/issues/32069#issuecomment-1602091109 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[GitHub] [airflow] HaeSe0ng opened a new issue, #32069: AioRpcError in DataprocCreateBatchOperator

2023-06-21 Thread via GitHub
HaeSe0ng opened a new issue, #32069: URL: https://github.com/apache/airflow/issues/32069 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened Airflow version: 2.3.4 (Composer 2.1.12) I've been using the DataprocCreateBatchOper

[GitHub] [airflow] haeseong-prestolabs closed issue #32068: AioRpcError in DataprocCreateBatchOperator

2023-06-21 Thread via GitHub
haeseong-prestolabs closed issue #32068: AioRpcError in DataprocCreateBatchOperator URL: https://github.com/apache/airflow/issues/32068 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [airflow] boring-cyborg[bot] commented on issue #32068: AioRpcError in DataprocCreateBatchOperator

2023-06-21 Thread via GitHub
boring-cyborg[bot] commented on issue #32068: URL: https://github.com/apache/airflow/issues/32068#issuecomment-1602087189 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[GitHub] [airflow] haeseong-prestolabs opened a new issue, #32068: AioRpcError in DataprocCreateBatchOperator

2023-06-21 Thread via GitHub
haeseong-prestolabs opened a new issue, #32068: URL: https://github.com/apache/airflow/issues/32068 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened Airflow version: 2.3.4 (Composer 2.1.12) I've been using the `DataprocCre

[GitHub] [airflow] phanikumv commented on a diff in pull request #31134: Add support to trigger Azure Functions from Airflow

2023-06-21 Thread via GitHub
phanikumv commented on code in PR #31134: URL: https://github.com/apache/airflow/pull/31134#discussion_r1238056651 ## docs/apache-airflow-providers-microsoft-azure/operators/functions.rst: ## @@ -0,0 +1,47 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +o

[GitHub] [airflow] phanikumv commented on a diff in pull request #31134: Add support to trigger Azure Functions from Airflow

2023-06-21 Thread via GitHub
phanikumv commented on code in PR #31134: URL: https://github.com/apache/airflow/pull/31134#discussion_r1238055256 ## docs/apache-airflow-providers-microsoft-azure/connections/azure_functions.rst: ## @@ -0,0 +1,60 @@ +.. Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] phanikumv commented on a diff in pull request #31134: Add support to trigger Azure Functions from Airflow

2023-06-21 Thread via GitHub
phanikumv commented on code in PR #31134: URL: https://github.com/apache/airflow/pull/31134#discussion_r1238052128 ## airflow/providers/microsoft/azure/operators/functions.py: ## @@ -0,0 +1,81 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

[GitHub] [airflow] eladkal commented on pull request #32066: GCSHook support for cacheControl typo

2023-06-21 Thread via GitHub
eladkal commented on PR #32066: URL: https://github.com/apache/airflow/pull/32066#issuecomment-1602051580 can we have a unit test to avoid regression? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] jtvmatos commented on pull request #22253: Add SparkKubernetesOperator crd implementation

2023-06-21 Thread via GitHub
jtvmatos commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1602003239 Any news regarding the status of this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] utkarsharma2 commented on issue #32048: Allow providers to add default connections

2023-06-21 Thread via GitHub
utkarsharma2 commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1601976105 How do we decide which providers would have default connections out of the box or in the past, since I don't see it for all of them? were there any criteria to be met?

[GitHub] [airflow] Owen-CH-Leung closed pull request #31920: Deprecate the 2 non-official elasticsearch libraries

2023-06-21 Thread via GitHub
Owen-CH-Leung closed pull request #31920: Deprecate the 2 non-official elasticsearch libraries URL: https://github.com/apache/airflow/pull/31920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] Aakcht commented on a diff in pull request #31865: Chart: Do not propagate global security context to statsd and redis

2023-06-21 Thread via GitHub
Aakcht commented on code in PR #31865: URL: https://github.com/apache/airflow/pull/31865#discussion_r1237918564 ## chart/templates/statsd/statsd-deployment.yaml: ## @@ -89,7 +88,7 @@ spec: - name: statsd image: {{ template "statsd_image" . }} image

[airflow] branch constraints-main updated: Updating constraints. Github run id:5340392405

2023-06-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 28d00899d9 Updating con

[GitHub] [airflow] fgalind1 commented on pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
fgalind1 commented on PR #31066: URL: https://github.com/apache/airflow/pull/31066#issuecomment-1601894847 This PR now is not that breaking change after last commit :1, with defaults (useStandardNaming=false), only 3 resources are renamed: - ConfigMap {release}-airflow-config to {release}

[GitHub] [airflow] fgalind1 commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
fgalind1 commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237879896 ## chart/INSTALL: ## Review Comment: thanks - added in https://github.com/apache/airflow/commit/d659cdb8313a6487019801b573270544edf566ae ## chart/te

[GitHub] [airflow] fgalind1 commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
fgalind1 commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237880398 ## chart/templates/_helpers.yaml: ## @@ -23,7 +23,40 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this If release name contains ch

[GitHub] [airflow] fgalind1 commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
fgalind1 commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237879872 ## chart/templates/secrets/fernetkey-secret.yaml: ## @@ -35,7 +35,7 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} annotations: -"helm.sh/hoo

[GitHub] [airflow] jedcunningham commented on pull request #31865: Chart: Do not propagate global security context to statsd and redis

2023-06-21 Thread via GitHub
jedcunningham commented on PR #31865: URL: https://github.com/apache/airflow/pull/31865#issuecomment-1601877734 > I completely excluded redis/statsd from global security context. Sounds good! > At the same time looks like simple .Values.redis.securityContexts.container/.Values.

[GitHub] [airflow] ying-w opened a new pull request, #32066: GCSHook support for cacheControl typo

2023-06-21 Thread via GitHub
ying-w opened a new pull request, #32066: URL: https://github.com/apache/airflow/pull/32066 My previous PR https://github.com/apache/airflow/issues/31337 had a typo, this fixes it. I found this while testing https://github.com/apache/airflow/issues/32030 -- This is an automated mes

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31865: Chart: Do not propagate global security context to statsd and redis

2023-06-21 Thread via GitHub
jedcunningham commented on code in PR #31865: URL: https://github.com/apache/airflow/pull/31865#discussion_r1237863627 ## tests/charts/security/test_security_context.py: ## @@ -210,6 +210,36 @@ def test_gitsync_sidecar_and_init_container(self): docs[index],

[airflow] branch main updated: Fix a couple Airflow release doc errors (#31951)

2023-06-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5a4106d96e Fix a couple Airflow release doc

[GitHub] [airflow] jedcunningham merged pull request #31951: Fix a couple Airflow release doc errors

2023-06-21 Thread via GitHub
jedcunningham merged PR #31951: URL: https://github.com/apache/airflow/pull/31951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31951: Fix a couple Airflow release doc errors

2023-06-21 Thread via GitHub
jedcunningham commented on code in PR #31951: URL: https://github.com/apache/airflow/pull/31951#discussion_r1237862135 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -583,15 +583,14 @@ Check if sources are the same as in the tag: ```bash cd X.Y.Zrc1 tar -xvzf *-source.tar.gz -pushd

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
jedcunningham commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237860928 ## chart/templates/secrets/fernetkey-secret.yaml: ## @@ -35,7 +35,7 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} annotations: -"helm.s

[GitHub] [airflow] jedcunningham commented on pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-21 Thread via GitHub
jedcunningham commented on PR #32053: URL: https://github.com/apache/airflow/pull/32053#issuecomment-1601865556 I lean toward kwarg only, more explicit. However, I'm not sure I like `as_setup` and `as_teardown` as instance methods. I guess that's more of a personal preference thing th

[GitHub] [airflow] ying-w commented on issue #32030: Status of testing Providers that were prepared on June 20, 2023

2023-06-21 Thread via GitHub
ying-w commented on issue #32030: URL: https://github.com/apache/airflow/issues/32030#issuecomment-1601863809 please remove https://github.com/apache/airflow/pull/31338 it is not working as expected -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
jedcunningham commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237853341 ## chart/templates/_helpers.yaml: ## @@ -23,7 +23,40 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this If release name contai

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
jedcunningham commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237846331 ## chart/templates/secrets/fernetkey-secret.yaml: ## @@ -35,7 +35,7 @@ metadata: {{- toYaml . | nindent 4 }} {{- end }} annotations: -"helm.s

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
jedcunningham commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237844668 ## chart/INSTALL: ## Review Comment: Sorry, I should have given you more details. You can read about how they work [here](https://github.com/apache/airfl

[GitHub] [airflow] github-actions[bot] commented on pull request #30665: Fix not terminating TaskInstances when `enable_logging=True` in DockerSwarmOperator

2023-06-21 Thread via GitHub
github-actions[bot] commented on PR #30665: URL: https://github.com/apache/airflow/pull/30665#issuecomment-1601845089 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] commented on pull request #31012: Not preload workers with reload_on_plugin_change

2023-06-21 Thread via GitHub
github-actions[bot] commented on PR #31012: URL: https://github.com/apache/airflow/pull/31012#issuecomment-1601845059 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] fgalind1 commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
fgalind1 commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237821395 ## chart/INSTALL: ## Review Comment: > newsfragment instead do you have any suggestion where this should be or what do you mean by that? :) happy to mo

[GitHub] [airflow] aamster opened a new issue, #32065: job failing with no logs

2023-06-21 Thread via GitHub
aamster opened a new issue, #32065: URL: https://github.com/apache/airflow/issues/32065 ### Apache Airflow version 2.6.2 ### What happened jobs are sporadically failing with no logs tried following https://cloud.google.com/composer/docs/how-to/using/troubleshootin

[GitHub] [airflow] aamster opened a new issue, #32064: next run before last run

2023-06-21 Thread via GitHub
aamster opened a new issue, #32064: URL: https://github.com/apache/airflow/issues/32064 ### Apache Airflow version 2.6.2 ### What happened ![Screenshot 2023-06-21 at 7 29 48 PM](https://github.com/apache/airflow/assets/5454341/a2663d60-de8d-4bbb-bd4a-ff8376784c5d)

[GitHub] [airflow] hussein-awala commented on issue #32044: Unable to read remote logs with celery executor

2023-06-21 Thread via GitHub
hussein-awala commented on issue #32044: URL: https://github.com/apache/airflow/issues/32044#issuecomment-1601783257 This might not be related to remote logging since the task fails immediately after being sent to the worker. I believe there could be an issue with the parsing of DAG files o

[GitHub] [airflow] hussein-awala commented on a diff in pull request #31951: Fix a couple Airflow release doc errors

2023-06-21 Thread via GitHub
hussein-awala commented on code in PR #31951: URL: https://github.com/apache/airflow/pull/31951#discussion_r1237788852 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -583,15 +583,14 @@ Check if sources are the same as in the tag: ```bash cd X.Y.Zrc1 tar -xvzf *-source.tar.gz -pushd

[GitHub] [airflow] hussein-awala commented on issue #32048: Allow providers to add default connections

2023-06-21 Thread via GitHub
hussein-awala commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1601764479 Yes I see that this can affect some users. > But I think we cannot (Without bumping Airflow 2 to Airflow 3) change the way "airflow db init" behaves by default (at most

[GitHub] [airflow] dstandish opened a new pull request, #32062: Call setup / teardown validation in dagbag load

2023-06-21 Thread via GitHub
dstandish opened a new pull request, #32062: URL: https://github.com/apache/airflow/pull/32062 The missing call was just an oversight -- added the method and tests but not the call. Also added a few tests as a drive by. -- This is an automated message from the Apache Git Service. T

[GitHub] [airflow] dstandish opened a new pull request, #32061: Check that chain_linear elements has len greater than 1

2023-06-21 Thread via GitHub
dstandish opened a new pull request, #32061: URL: https://github.com/apache/airflow/pull/32061 This is to help users when accidentally not expanding list e.g. `chain_linear(tasks)` instead of `chain_linear(*tasks)`. cc @ReadytoRocc -- This is an automated message from the Apache Git Ser

[GitHub] [airflow] pierrejeambrun opened a new pull request, #32060: Use re2 for matching untrusted regex

2023-06-21 Thread via GitHub
pierrejeambrun opened a new pull request, #32060: URL: https://github.com/apache/airflow/pull/32060 Use re2 for matching untrusted regex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [airflow] potiuk commented on pull request #31859: AIP-49 OTel Timers

2023-06-21 Thread via GitHub
potiuk commented on PR #31859: URL: https://github.com/apache/airflow/pull/31859#issuecomment-1601644992 nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[airflow-client-python] annotated tag 2.6.2rc2 updated (dddb7a5 -> 38cffca)

2023-06-21 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to annotated tag 2.6.2rc2 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git *** WARNING: tag 2.6.2rc2 was modified! *** from dddb7a5 (commit) to 38cffca (tag)

[GitHub] [airflow] joaopamaral commented on a diff in pull request #32051: Fix LivyHook TypeError exception: Changing the log with sessing_id param to use f-string

2023-06-21 Thread via GitHub
joaopamaral commented on code in PR #32051: URL: https://github.com/apache/airflow/pull/32051#discussion_r1237630803 ## airflow/providers/apache/livy/hooks/livy.py: ## @@ -173,7 +173,7 @@ def post_batch(self, *args: Any, **kwargs: Any) -> int: batch_id = self._parse_pos

[GitHub] [airflow] eladkal commented on a diff in pull request #32051: Fix LivyHook TypeError exception: Changing the log with sessing_id param to use f-string

2023-06-21 Thread via GitHub
eladkal commented on code in PR #32051: URL: https://github.com/apache/airflow/pull/32051#discussion_r1237623913 ## airflow/providers/apache/livy/hooks/livy.py: ## @@ -173,7 +173,7 @@ def post_batch(self, *args: Any, **kwargs: Any) -> int: batch_id = self._parse_post_re

svn commit: r62559 - /dev/airflow/clients/python/2.6.2rc2/

2023-06-21 Thread pierrejeambrun
Author: pierrejeambrun Date: Wed Jun 21 20:05:49 2023 New Revision: 62559 Log: Add artifacts for Apache Airflow Python Client 2.6.2rc2 Added: dev/airflow/clients/python/2.6.2rc2/ dev/airflow/clients/python/2.6.2rc2/apache-airflow-client-2.6.2-bin.tar.gz (with props) dev/airflow/cl

[GitHub] [airflow] hyler closed issue #32056: Installing 2.4.0 results in import error for PodOperatorHookProtocol

2023-06-21 Thread via GitHub
hyler closed issue #32056: Installing 2.4.0 results in import error for PodOperatorHookProtocol URL: https://github.com/apache/airflow/issues/32056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[airflow] branch constraints-main updated: Updating constraints. Github run id:5337981888

2023-06-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new aeb24a7028 Updating con

[airflow-client-python] branch fix-for-2.6.2rc2 deleted (was 45fe8c9)

2023-06-21 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch fix-for-2.6.2rc2 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git was 45fe8c9 Fix bug - Invalid type for variable for execution_timeout and dag_run_timeo

[airflow-client-python] branch main updated: Fix bug - Invalid type for variable for execution_timeout and dag_run_timeout (#53) (#76) (#87)

2023-06-21 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git The following commit(s) were added to refs/heads/main by this push: new dddb7a5 Fix bug - Invalid ty

[GitHub] [airflow-client-python] pierrejeambrun merged pull request #87: Fix for 2.6.2rc2

2023-06-21 Thread via GitHub
pierrejeambrun merged PR #87: URL: https://github.com/apache/airflow-client-python/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] hussein-awala commented on issue #32056: Installing 2.4.0 results in import error for PodOperatorHookProtocol

2023-06-21 Thread via GitHub
hussein-awala commented on issue #32056: URL: https://github.com/apache/airflow/issues/32056#issuecomment-1601589063 I just tested with the official docker image `apache/airflow:2.4.0` and still can't reproduce the issue: ``` airflow@5c746906a310:/opt/airflow$ pip freeze | grep apache-

[GitHub] [airflow] potiuk commented on issue #32048: Allow providers to add default connections

2023-06-21 Thread via GitHub
potiuk commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1601571872 > IMO we can just change the default value of database.load_default_connections to False, and we will stop loading them by default, and the users can still load them by setting this

[GitHub] [airflow] hussein-awala commented on issue #32056: Installing 2.4.0 results in import error for PodOperatorHookProtocol

2023-06-21 Thread via GitHub
hussein-awala commented on issue #32056: URL: https://github.com/apache/airflow/issues/32056#issuecomment-1601565395 I can't reproduce the problem with the same versions of the providers: ![image](https://github.com/apache/airflow/assets/21311487/18c34d8d-3246-4b63-b1a6-30819e082d37)

[GitHub] [airflow] hussein-awala commented on issue #32039: Failure to run all DAGs for Airflow in Kubernetes

2023-06-21 Thread via GitHub
hussein-awala commented on issue #32039: URL: https://github.com/apache/airflow/issues/32039#issuecomment-1601541708 Are you using the official helm chart or bitnami chart? Which executor are you using? is it KubernetesExecutor? Are you using remote logging? If not, do you have a shared

[GitHub] [airflow] dstandish commented on pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-21 Thread via GitHub
dstandish commented on PR #32053: URL: https://github.com/apache/airflow/pull/32053#issuecomment-1601472729 > > > This looks good but what do you think about not having `as_teardown(setuptask)`? > > > > > > What don't you like about it? > > Would you prefer kwargs only? > >

[GitHub] [airflow] hussein-awala commented on pull request #31998: Add retry functionality for handling process termination caused by database network issues#32045

2023-06-21 Thread via GitHub
hussein-awala commented on PR #31998: URL: https://github.com/apache/airflow/pull/31998#issuecomment-1601470074 Consider to read [this doc](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#static-code-checks) to activate the pre-commit and fix static checks -- This is a

[GitHub] [airflow] jedcunningham merged pull request #31859: AIP-49 OTel Timers

2023-06-21 Thread via GitHub
jedcunningham merged PR #31859: URL: https://github.com/apache/airflow/pull/31859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[airflow] branch main updated: AIP-49 OTel Timers (#31859)

2023-06-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 44c7bee37d AIP-49 OTel Timers (#31859) 44c7b

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #32055: add async wait method to the "with logging" aws utils

2023-06-21 Thread via GitHub
vandonr-amz commented on code in PR #32055: URL: https://github.com/apache/airflow/pull/32055#discussion_r1237501369 ## airflow/providers/amazon/aws/utils/waiter_with_logging.py: ## @@ -68,23 +70,81 @@ def wait( except WaiterError as error: if "terminal fai

[GitHub] [airflow] ferruzzi commented on a diff in pull request #31134: Add support to trigger Azure Functions from Airflow

2023-06-21 Thread via GitHub
ferruzzi commented on code in PR #31134: URL: https://github.com/apache/airflow/pull/31134#discussion_r1237439014 ## airflow/providers/microsoft/azure/operators/functions.py: ## @@ -0,0 +1,81 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] boring-cyborg[bot] commented on issue #32056: Installing 2.4.0 results in import error for PodOperatorHookProtocol

2023-06-21 Thread via GitHub
boring-cyborg[bot] commented on issue #32056: URL: https://github.com/apache/airflow/issues/32056#issuecomment-1601414269 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[GitHub] [airflow] hyler opened a new issue, #32056: Installing 2.4.0 results in import error for PodOperatorHookProtocol

2023-06-21 Thread via GitHub
hyler opened a new issue, #32056: URL: https://github.com/apache/airflow/issues/32056 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened We installed 2.4.0 like this: ``` apache-airflow[crypto,postgres,docker,cncf.kubern

[GitHub] [airflow] hussein-awala commented on a diff in pull request #31998: Add retry functionality for handling process termination caused by database network issues#32045

2023-06-21 Thread via GitHub
hussein-awala commented on code in PR #31998: URL: https://github.com/apache/airflow/pull/31998#discussion_r1237443057 ## airflow/executors/celery_executor_utils.py: ## @@ -249,16 +249,20 @@ def _get_many_from_kv_backend(self, async_tasks) -> Mapping[str, EventBufferValu

[GitHub] [airflow] syedahsn commented on a diff in pull request #32055: add async wait method to the "with logging" aws utils

2023-06-21 Thread via GitHub
syedahsn commented on code in PR #32055: URL: https://github.com/apache/airflow/pull/32055#discussion_r1237443400 ## airflow/providers/amazon/aws/utils/waiter_with_logging.py: ## @@ -68,23 +70,81 @@ def wait( except WaiterError as error: if "terminal failur

[GitHub] [airflow] ephraimbuddy commented on pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-21 Thread via GitHub
ephraimbuddy commented on PR #32053: URL: https://github.com/apache/airflow/pull/32053#issuecomment-1601400178 > > This looks good but what do you think about not having `as_teardown(setuptask)`? > > What don't you like about it? > > Would you prefer kwargs only? > > Or

[GitHub] [airflow] vandonr-amz opened a new pull request, #32055: add async wait method to the "with logging" aws utils

2023-06-21 Thread via GitHub
vandonr-amz opened a new pull request, #32055: URL: https://github.com/apache/airflow/pull/32055 also changed the status formatting in the logs so that it'd not be done if log level is not including INFO cc @syedahsn -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] hussein-awala commented on issue #32048: Allow providers to add default connections

2023-06-21 Thread via GitHub
hussein-awala commented on issue #32048: URL: https://github.com/apache/airflow/issues/32048#issuecomment-1601380147 I don't think we really need it, because: 1. as @potiuk mentioned above, the connections types in the webserver UI are loaded from the hooks, ensuring that the most importa

[GitHub] [airflow] dstandish commented on pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-21 Thread via GitHub
dstandish commented on PR #32053: URL: https://github.com/apache/airflow/pull/32053#issuecomment-1601363730 > This looks good but what do you think about not having `as_teardown(setuptask)`? What don't you like about it? -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] Aakcht commented on pull request #31865: Chart: Do not propagate global security context to statsd and redis

2023-06-21 Thread via GitHub
Aakcht commented on PR #31865: URL: https://github.com/apache/airflow/pull/31865#issuecomment-1601343573 @jedcunningham , please take a look. I completely excluded redis/statsd from global security context. Looks like I was wrong in my previous comment and using localContainerSecurityContex

[GitHub] [airflow-client-python] pierrejeambrun opened a new pull request, #87: Fix code for 2.6.2rc2

2023-06-21 Thread via GitHub
pierrejeambrun opened a new pull request, #87: URL: https://github.com/apache/airflow-client-python/pull/87 Time for 2.6.2rc2! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [airflow-client-python] pierrejeambrun closed issue #85: Airflow Python Client 2.6.2rc1 "get_tasks" errors out with execution_timeout cannot be None

2023-06-21 Thread via GitHub
pierrejeambrun closed issue #85: Airflow Python Client 2.6.2rc1 "get_tasks" errors out with execution_timeout cannot be None URL: https://github.com/apache/airflow-client-python/issues/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow-client-python] pierrejeambrun commented on issue #85: Airflow Python Client 2.6.2rc1 "get_tasks" errors out with execution_timeout cannot be None

2023-06-21 Thread via GitHub
pierrejeambrun commented on issue #85: URL: https://github.com/apache/airflow-client-python/issues/85#issuecomment-1601308062 Thanks guys. (I also agree that the origin of the problem seems like a bad OpenAPI spec). Closing, now that the issue is identified, and that the process has

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31066: Support naming customization on helm chart resources

2023-06-21 Thread via GitHub
jedcunningham commented on code in PR #31066: URL: https://github.com/apache/airflow/pull/31066#discussion_r1237273886 ## chart/INSTALL: ## Review Comment: This should be in a newsfragment instead. I think we can keep a note about using `useStandardNaming` in this file tho

[airflow-client-python] branch fix-for-2.6.2rc2 created (now 45fe8c9)

2023-06-21 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch fix-for-2.6.2rc2 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git at 45fe8c9 Fix bug - Invalid type for variable for execution_timeout and dag_run_timeo

[airflow-client-python] 01/01: Fix bug - Invalid type for variable for execution_timeout and dag_run_timeout (#53) (#76)

2023-06-21 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch fix-for-2.6.2rc2 in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git commit 45fe8c9de106ae271d9d71f7adf9c8d299a8fabb Author: Ephraim Anierobi AuthorDate: Thu May 4

[GitHub] [airflow] ephraimbuddy commented on pull request #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-21 Thread via GitHub
ephraimbuddy commented on PR #32053: URL: https://github.com/apache/airflow/pull/32053#issuecomment-1601303866 This looks good but what do you think about not having `as_teardown(setuptask)`? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] vandonr-amz commented on pull request #32036: Add a deferrable mode to `BatchCreateComputeEnvironmentOperator`

2023-06-21 Thread via GitHub
vandonr-amz commented on PR #32036: URL: https://github.com/apache/airflow/pull/32036#issuecomment-1601299105 > can you add documentation for the availability of deferrable param for this operator do you mean in the batch.rst file ? If so, the problem is that this relies on exa

[GitHub] [airflow] hussein-awala commented on pull request #32038: Add an option to load the dags from db for command tasks run

2023-06-21 Thread via GitHub
hussein-awala commented on PR #32038: URL: https://github.com/apache/airflow/pull/32038#issuecomment-1601285858 > @hussein-awala , even though you linked the issue you are working on in this PR, it's necessary to provide a good commit message for the PR :+1: I just added a descript

[GitHub] [airflow] hussein-awala commented on pull request #32038: Add an option to load the dags from db for command tasks run

2023-06-21 Thread via GitHub
hussein-awala commented on PR #32038: URL: https://github.com/apache/airflow/pull/32038#issuecomment-1601285031 > It will be a breaking change for those that uses run_as_user in their dags if you make this change the default. Needs investigation... @ephraimbuddy I agree, but I think w

[GitHub] [airflow] o-nikolas commented on pull request #29055: [AIP-51] Executors vending CLI commands

2023-06-21 Thread via GitHub
o-nikolas commented on PR #29055: URL: https://github.com/apache/airflow/pull/29055#issuecomment-1601281250 This is still blocked by #30727 waiting for a merge of that one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [airflow] vincbeck commented on a diff in pull request #32036: Add a deferrable mode to `BatchCreateComputeEnvironmentOperator`

2023-06-21 Thread via GitHub
vincbeck commented on code in PR #32036: URL: https://github.com/apache/airflow/pull/32036#discussion_r1237316424 ## airflow/providers/amazon/aws/operators/batch.py: ## @@ -428,31 +431,40 @@ def __init__( unmanaged_v_cpus: int | None = None, service_role: str |

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #32036: Add a deferrable mode to `BatchCreateComputeEnvironmentOperator`

2023-06-21 Thread via GitHub
vandonr-amz commented on code in PR #32036: URL: https://github.com/apache/airflow/pull/32036#discussion_r1237305526 ## airflow/providers/amazon/aws/operators/batch.py: ## @@ -428,31 +431,40 @@ def __init__( unmanaged_v_cpus: int | None = None, service_role: st

[GitHub] [airflow] phanikumv commented on issue #32030: Status of testing Providers that were prepared on June 20, 2023

2023-06-21 Thread via GitHub
phanikumv commented on issue #32030: URL: https://github.com/apache/airflow/issues/32030#issuecomment-1601168504 Tested #30279, #31685, #31081,#31317 , #31249, #31758 as part of below RC and they are working as expected. apache-airflow-providers-amazon==8.2.0rc1 pip install apache

[GitHub] [airflow] AVMusorin commented on pull request #32054: Draft: Upgrade Flask-AppBuilder

2023-06-21 Thread via GitHub
AVMusorin commented on PR #32054: URL: https://github.com/apache/airflow/pull/32054#issuecomment-1601160397 I'm going to check other changes in appbuilder since 4.3.1 and create a summary. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [airflow] AVMusorin opened a new pull request, #32054: Draft: Upgrade Flask-AppBuilder

2023-06-21 Thread via GitHub
AVMusorin opened a new pull request, #32054: URL: https://github.com/apache/airflow/pull/32054 There are some helpful fixes in the new release of Flask-appbuilder - Double escaping for next param in login with oauth https://github.com/dpgaspar/Flask-AppBuilder/pull/2053 ... TDB

[GitHub] [airflow] tanvn commented on issue #16271: MySQL Connection Warnings/Errors (Entrypoint, Celery Executor Dangling)

2023-06-21 Thread via GitHub
tanvn commented on issue #16271: URL: https://github.com/apache/airflow/issues/16271#issuecomment-1601144341 @potiuk @kaxil @ashb @eladkal @coolacid Hi, we are facing the same issue (getting many error logs about aborted connections) on Airflow 2.5.0 running on kubernetes. I think it

[GitHub] [airflow] dstandish opened a new pull request, #32053: Change `as_setup` and `as_teardown` to instance methods

2023-06-21 Thread via GitHub
dstandish opened a new pull request, #32053: URL: https://github.com/apache/airflow/pull/32053 This provides a number of benefits. One is now we can do MyTeardown(...).as_teardown(the_setup) instead of having to arrow directly these two. The other is that I think it can be cogn

[GitHub] [airflow] jedcunningham commented on pull request #31779: Supporting extraAnnotions at pgbouncer deployment level

2023-06-21 Thread via GitHub
jedcunningham commented on PR #31779: URL: https://github.com/apache/airflow/pull/31779#issuecomment-1601120281 I don't see any reason to have 2 ways to set annotations on the pod, and `podAnnotations` is how it's done elsewhere. `extraAnnotations` is just used on our services. I've

[GitHub] [airflow] jedcunningham closed pull request #31779: Supporting extraAnnotions at pgbouncer deployment level

2023-06-21 Thread via GitHub
jedcunningham closed pull request #31779: Supporting extraAnnotions at pgbouncer deployment level URL: https://github.com/apache/airflow/pull/31779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] jedcunningham closed issue #27246: Pgbouncer doesn't support extraAnnotations for deployment/pod

2023-06-21 Thread via GitHub
jedcunningham closed issue #27246: Pgbouncer doesn't support extraAnnotations for deployment/pod URL: https://github.com/apache/airflow/issues/27246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #32041: Raise error in dag trigger for paused dag

2023-06-21 Thread via GitHub
utkarsharma2 commented on code in PR #32041: URL: https://github.com/apache/airflow/pull/32041#discussion_r1237230442 ## airflow/cli/commands/dag_command.py: ## @@ -145,6 +145,11 @@ def dag_backfill(args, dag: list[DAG] | DAG | None = None) -> None: @cli_utils.action_cli def

[GitHub] [airflow] jedcunningham commented on pull request #30773: Template extra volumes in helm chart

2023-06-21 Thread via GitHub
jedcunningham commented on PR #30773: URL: https://github.com/apache/airflow/pull/30773#issuecomment-1601083578 Thanks @nirroz93! Congrats on your first commit 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] pankajastro commented on a diff in pull request #32041: Raise error in dag trigger for paused dag

2023-06-21 Thread via GitHub
pankajastro commented on code in PR #32041: URL: https://github.com/apache/airflow/pull/32041#discussion_r1237215659 ## airflow/cli/commands/dag_command.py: ## @@ -145,6 +145,11 @@ def dag_backfill(args, dag: list[DAG] | DAG | None = None) -> None: @cli_utils.action_cli def d

[airflow] branch main updated: Template extra volumes in helm chart (#30773)

2023-06-21 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2508787ea3 Template extra volumes in helm ch

[GitHub] [airflow] jedcunningham merged pull request #30773: Template extra volumes in helm chart

2023-06-21 Thread via GitHub
jedcunningham merged PR #30773: URL: https://github.com/apache/airflow/pull/30773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #31866: Decode old Xcom value from airflow 2.5.2

2023-06-21 Thread via GitHub
utkarsharma2 commented on code in PR #31866: URL: https://github.com/apache/airflow/pull/31866#discussion_r1237173782 ## airflow/serialization/serde.py: ## @@ -276,7 +276,11 @@ def deserialize(o: T | None, full=True, type_hint: Any = None) -> object: def _convert(old: dict) ->

  1   2   >