Re: [PR] feat: enable HTTPRoute for Gateway API [airflow]

2023-10-10 Thread via GitHub
Kyrremann commented on PR #34716: URL: https://github.com/apache/airflow/pull/34716#issuecomment-1754558718 Anyone have time to take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Bump azure-mgmt-containerinstance [airflow]

2023-10-10 Thread via GitHub
pankajastro merged PR #34738: URL: https://github.com/apache/airflow/pull/34738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airf

[airflow] branch main updated: Bump azure-mgmt-containerinstance (#34738)

2023-10-10 Thread pankaj
This is an automated email from the ASF dual-hosted git repository. pankaj pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9ee14a01ac Bump azure-mgmt-containerinstance (#3473

Re: [PR] AIP-58: Add Airflow VFS [airflow]

2023-10-10 Thread via GitHub
bolkedebruin commented on PR #34729: URL: https://github.com/apache/airflow/pull/34729#issuecomment-1754626593 @jens-scheffler-bosch AFS works on a fundamentally different layer than Datasets do. Datasets are currently just metadata pointing to arbitrary data and are treated as such in Airf

[PR] Corrected the user creation command CONTRIBUTORS_QUICK_START.rst [airflow]

2023-10-10 Thread via GitHub
KesharwaniArpita opened a new pull request, #34842: URL: https://github.com/apache/airflow/pull/34842 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[airflow] branch constraints-main updated: Updating constraints. Github run id:6466086407

2023-10-10 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new a329cbc70f Updating con

Re: [I] Azure Container Instance Operator uses deprecated "network profile" arg [airflow]

2023-10-10 Thread via GitHub
eladkal commented on issue #34820: URL: https://github.com/apache/airflow/issues/34820#issuecomment-1754696258 @pankajastro I assume this issue is fixed in https://github.com/apache/airflow/pull/34738 ? -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] Bump azure dependencies to newer versions [airflow]

2023-10-10 Thread via GitHub
eladkal commented on issue #30199: URL: https://github.com/apache/airflow/issues/30199#issuecomment-1754697631 All items have been addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] Bump azure dependencies to newer versions [airflow]

2023-10-10 Thread via GitHub
eladkal closed issue #30199: Bump azure dependencies to newer versions URL: https://github.com/apache/airflow/issues/30199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] openlineage, common.sql: send column lineage from SQL operators. [airflow]

2023-10-10 Thread via GitHub
JDarDagran opened a new pull request, #34843: URL: https://github.com/apache/airflow/pull/34843 This PR enables sending column lineage information retrieved from SQL parser. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] corrected typos in PYPI_README.md [airflow]

2023-10-10 Thread via GitHub
Taragolis commented on code in PR #34841: URL: https://github.com/apache/airflow/pull/34841#discussion_r1351921429 ## generated/PYPI_README.md: ## Review Comment: This file generated from [README.md](https://github.com/apache/airflow/blob/main/README.md) by pre-commit hoo

Re: [I] Upgrade the Snowflake Python Connector to version 2.7.8 or later [airflow]

2023-10-10 Thread via GitHub
eladkal commented on issue #34748: URL: https://github.com/apache/airflow/issues/34748#issuecomment-1754762195 But we are not limiting the users.. they can choose what they like. Airflow itself also recommend users to update their Airflow versions but not everyone can. Some users still us

Re: [I] AzureContainerInstancesOperator uses a deprecated authentication flow in `apache-airflow-providers-microsoft-azure` [airflow]

2023-10-10 Thread via GitHub
eladkal closed issue #34749: AzureContainerInstancesOperator uses a deprecated authentication flow in `apache-airflow-providers-microsoft-azure` URL: https://github.com/apache/airflow/issues/34749 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [I] AzureContainerInstancesOperator uses a deprecated authentication flow in `apache-airflow-providers-microsoft-azure` [airflow]

2023-10-10 Thread via GitHub
eladkal commented on issue #34749: URL: https://github.com/apache/airflow/issues/34749#issuecomment-1754773841 fixed in https://github.com/apache/airflow/pull/34738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [I] Trino SQL split trailing semi-colon [airflow]

2023-10-10 Thread via GitHub
Bisk1 commented on issue #34828: URL: https://github.com/apache/airflow/issues/34828#issuecomment-1754821636 @MikeWallis42 how about passing a list of sql commands instead? Does it address your needs? ``` SQLExecuteQueryOperator( task_id="semi_colon_test", con

Re: [PR] Extend papermill operator to support remote kernels [airflow]

2023-10-10 Thread via GitHub
Taragolis commented on code in PR #34840: URL: https://github.com/apache/airflow/pull/34840#discussion_r1352033233 ## airflow/providers/papermill/operators/__init__.py: ## @@ -15,3 +15,8 @@ # KIND, either express or implied. See the License for the # specific language governi

Re: [PR] Fix the broken file link [airflow]

2023-10-10 Thread via GitHub
Taragolis merged PR #34826: URL: https://github.com/apache/airflow/pull/34826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Fix the broken file link [airflow]

2023-10-10 Thread via GitHub
boring-cyborg[bot] commented on PR #34826: URL: https://github.com/apache/airflow/pull/34826#issuecomment-1754837726 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

[airflow] branch main updated: Fix the broken file link (#34826)

2023-10-10 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 609eed9069 Fix the broken file link (#34826) 609

Re: [I] Trino SQL split trailing semi-colon [airflow]

2023-10-10 Thread via GitHub
MikeWallis42 commented on issue #34828: URL: https://github.com/apache/airflow/issues/34828#issuecomment-1754851547 @Bisk1 I believe that would work if we pased in Python strings but I was hoping to make use of `template_searchpath` to read in SQL files so that I didn't need to maintain it

Re: [PR] Feature: Allow description to be passed in when uring variables CLI [airflow]

2023-10-10 Thread via GitHub
Taragolis commented on code in PR #34791: URL: https://github.com/apache/airflow/pull/34791#discussion_r1352055813 ## airflow/cli/cli_config.py: ## @@ -543,6 +543,15 @@ def string_lower_type(val): ARG_DEFAULT = Arg( ("-d", "--default"), metavar="VAL", default=None, help="D

Re: [PR] Use timeout when inntializing _timeout_sec of TaskStateTrigger [airflow]

2023-10-10 Thread via GitHub
utkarsharma2 commented on code in PR #34715: URL: https://github.com/apache/airflow/pull/34715#discussion_r1352086054 ## airflow/sensors/external_task.py: ## @@ -341,6 +341,7 @@ def execute(self, context: Context) -> None: states=self.allowed_states,

[I] Correct error handling in `EksCreateClusterOperator` in deferrable mode [airflow]

2023-10-10 Thread via GitHub
Taragolis opened a new issue, #34844: URL: https://github.com/apache/airflow/issues/34844 ### Body There is couple issues happen if something went wrong during cluster creation. We try to delete cluster by defer triggerer `EksDeleteClusterTrigger` to method `execute_failed`

Re: [I] Airflow UI stops refreshing the DAG status [airflow]

2023-10-10 Thread via GitHub
pavelpi commented on issue #34835: URL: https://github.com/apache/airflow/issues/34835#issuecomment-1755074051 Hello @jens-scheffler-bosch thanks for quick reply! I scaled up the environment to have 3 DAG processors, each one having 4 CPUs and 2GB memory. 70% of the time all CPUs are a

[I] Invalid stat name using opentelemetry [airflow]

2023-10-10 Thread via GitHub
alvaroserper opened a new issue, #34845: URL: https://github.com/apache/airflow/issues/34845 ### Apache Airflow version 2.7.1 ### What happened When running a dag an error ocurred. The error says that there is a metric with an invalid name. This causes that the task of t

Re: [I] Invalid stat name using opentelemetry [airflow]

2023-10-10 Thread via GitHub
boring-cyborg[bot] commented on issue #34845: URL: https://github.com/apache/airflow/issues/34845#issuecomment-1755138098 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] openlineage: adjust log levels [airflow]

2023-10-10 Thread via GitHub
kaxil commented on code in PR #34801: URL: https://github.com/apache/airflow/pull/34801#discussion_r1352313431 ## airflow/providers/openlineage/extractors/base.py: ## @@ -82,7 +82,7 @@ def extract(self) -> OperatorLineage | None: self.operator.__class__.__module__ +

Re: [PR] openlineage: adjust log levels [airflow]

2023-10-10 Thread via GitHub
JDarDagran commented on code in PR #34801: URL: https://github.com/apache/airflow/pull/34801#discussion_r1352318622 ## airflow/providers/openlineage/extractors/base.py: ## @@ -82,7 +82,7 @@ def extract(self) -> OperatorLineage | None: self.operator.__class__.__modul

Re: [PR] openlineage: adjust log levels [airflow]

2023-10-10 Thread via GitHub
JDarDagran commented on PR #34801: URL: https://github.com/apache/airflow/pull/34801#issuecomment-1755247637 Thanks @kaxil ! I've commited changes as suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[I] Task ID copy button copying wrong ID [airflow]

2023-10-10 Thread via GitHub
ByPort opened a new issue, #34846: URL: https://github.com/apache/airflow/issues/34846 ### Apache Airflow version 2.7.1 ### What happened The Task ID copy button in Grid View copies the first Task ID copied until the page refresh ### What you think should happen i

Re: [I] Status of testing of Apache Airflow 2.7.2rc1 [airflow]

2023-10-10 Thread via GitHub
ephraimbuddy commented on issue #34830: URL: https://github.com/apache/airflow/issues/34830#issuecomment-1755384233 > #34011 and #34636 both should have been skipped - providers and dev env respectively. Mistake -- This is an automated message from the Apache Git Service. To respon

Re: [I] Mapped Task details view "success" counts are off [airflow]

2023-10-10 Thread via GitHub
leodrivera commented on issue #29988: URL: https://github.com/apache/airflow/issues/29988#issuecomment-1755384792 We are using version 2.7.1 and are also being affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add k8s recommended labels [airflow]

2023-10-10 Thread via GitHub
Owen-CH-Leung commented on PR #34735: URL: https://github.com/apache/airflow/pull/34735#issuecomment-1755387465 Hi @kimminw00, thank you for your comments. I've gone through the Prometheus helm chart as you suggested. While I tried to grasp the key points, I'm keen to ensure I address your

Re: [PR] #34612 _SECRET and _CMD broker configuration changes [airflow]

2023-10-10 Thread via GitHub
JonnyWaffles commented on PR #34782: URL: https://github.com/apache/airflow/pull/34782#issuecomment-1755398945 Hi team just following up on this one. I think the existing test kit is sufficient, as I am not sure how to test the import time side effects this patch corrects. Any advice? --

Re: [PR] Add `DatabricksJobsCreateOperator` [airflow]

2023-10-10 Thread via GitHub
tatiana commented on code in PR #32221: URL: https://github.com/apache/airflow/pull/32221#discussion_r1352537223 ## airflow/providers/databricks/operators/databricks.py: ## @@ -161,6 +163,139 @@ def get_link( return XCom.get_value(key=XCOM_RUN_PAGE_URL_KEY, ti_key=ti_ke

Re: [PR] Add `DatabricksJobsCreateOperator` [airflow]

2023-10-10 Thread via GitHub
tatiana commented on PR #32221: URL: https://github.com/apache/airflow/pull/32221#issuecomment-1755439480 Hey @stikkireddy, you've come a long way on this - is there any chance you could resolve the conflicts & have the CI tests pass, it feels like we're super close to merging this feature.

[I] Add custom labels to a kubernetes pod from dag [airflow]

2023-10-10 Thread via GitHub
aru-trackunit opened a new issue, #34848: URL: https://github.com/apache/airflow/issues/34848 ### Description Hi! It would be great if I could include custom kubernetes labels/annotation within kubernetes pod template coming from dag. Meaning that if I add an argument o

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-10 Thread via GitHub
Taragolis commented on PR #34784: URL: https://github.com/apache/airflow/pull/34784#issuecomment-1755464358 In [126a1f5](https://github.com/apache/airflow/pull/34784/commits/126a1f50178f1f9d2c603a08a483952bf126520e) split logic into two classes, for reduce repeatable code in `AwsBaseOperato

Re: [I] Status of testing of Apache Airflow 2.7.2rc1 [airflow]

2023-10-10 Thread via GitHub
Calder-Ty commented on issue #34830: URL: https://github.com/apache/airflow/issues/34830#issuecomment-1755534215 #34568 Is working as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Status of testing of Apache Airflow 2.7.2rc1 [airflow]

2023-10-10 Thread via GitHub
utkarsharma2 commented on issue #34830: URL: https://github.com/apache/airflow/issues/34830#issuecomment-1755540811 Tested #34779 , working as expected. Thanks, Utkarsh Sharma On Tue, Oct 10, 2023 at 7:54 PM Tyler Calder ***@

Re: [I] Add custom labels to a kubernetes pod from dag [airflow]

2023-10-10 Thread via GitHub
Taragolis commented on issue #34848: URL: https://github.com/apache/airflow/issues/34848#issuecomment-1755591392 I think you could try to use [executor_config](https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/executor/kubernetes.html#pod-override) Operator/Task Argument +

Re: [PR] Fix handling of single quotes in RedshiftToS3Operator [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on PR #32915: URL: https://github.com/apache/airflow/pull/32915#issuecomment-1755609531 > @vincbeck I've addressed the static failures as per your suggestion. You can see the changes in the "Files changed" section of this PR. > > Could you please take a look at the

Re: [PR] Add `DatabricksJobsCreateOperator` [airflow]

2023-10-10 Thread via GitHub
josh-fell commented on code in PR #32221: URL: https://github.com/apache/airflow/pull/32221#discussion_r1352699528 ## airflow/providers/databricks/operators/databricks.py: ## @@ -161,6 +163,139 @@ def get_link( return XCom.get_value(key=XCOM_RUN_PAGE_URL_KEY, ti_key=ti_

Re: [PR] Fix AWS RDS hook's DB instance state check [airflow]

2023-10-10 Thread via GitHub
AetherUnbound commented on PR #34773: URL: https://github.com/apache/airflow/pull/34773#issuecomment-1755674768 I haven't forgotten about this, just got busy! It sounds like folks are comfortable with catching specific exceptions instead of checking error codes, which should be more robust

Re: [I] Add custom labels to a kubernetes pod from dag [airflow]

2023-10-10 Thread via GitHub
aru-trackunit closed issue #34848: Add custom labels to a kubernetes pod from dag URL: https://github.com/apache/airflow/issues/34848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [I] Add custom labels to a kubernetes pod from dag [airflow]

2023-10-10 Thread via GitHub
aru-trackunit commented on issue #34848: URL: https://github.com/apache/airflow/issues/34848#issuecomment-1755679498 Thank you @Taragolis for a suggestion it works as expected! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Glue DataBrew operator [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1352719011 ## airflow/providers/amazon/aws/hooks/glue.py: ## @@ -422,3 +422,55 @@ def create_or_update_glue_job(self) -> str | None: self.conn.create_job(**config)

Re: [PR] Use timeout when inntializing _timeout_sec of TaskStateTrigger [airflow]

2023-10-10 Thread via GitHub
Xiroo commented on code in PR #34715: URL: https://github.com/apache/airflow/pull/34715#discussion_r1352795395 ## airflow/sensors/external_task.py: ## @@ -341,6 +341,7 @@ def execute(self, context: Context) -> None: states=self.allowed_states,

Re: [PR] Use timeout when inntializing _timeout_sec of TaskStateTrigger [airflow]

2023-10-10 Thread via GitHub
Xiroo commented on code in PR #34715: URL: https://github.com/apache/airflow/pull/34715#discussion_r1352795395 ## airflow/sensors/external_task.py: ## @@ -341,6 +341,7 @@ def execute(self, context: Context) -> None: states=self.allowed_states,

Re: [I] Status of testing of Apache Airflow 2.7.2rc1 [airflow]

2023-10-10 Thread via GitHub
Xiroo commented on issue #34830: URL: https://github.com/apache/airflow/issues/34830#issuecomment-1755699208 [#34359](https://github.com/apache/airflow/pull/34359) is working as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Glue DataBrew operator [airflow]

2023-10-10 Thread via GitHub
ellisms commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1352804540 ## airflow/providers/amazon/aws/hooks/glue.py: ## @@ -422,3 +422,55 @@ def create_or_update_glue_job(self) -> str | None: self.conn.create_job(**config)

Re: [PR] Glue DataBrew operator [airflow]

2023-10-10 Thread via GitHub
ellisms commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1352807827 ## airflow/providers/amazon/aws/hooks/glue.py: ## @@ -422,3 +422,55 @@ def create_or_update_glue_job(self) -> str | None: self.conn.create_job(**config)

Re: [PR] Glue DataBrew operator [airflow]

2023-10-10 Thread via GitHub
ellisms commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1352804540 ## airflow/providers/amazon/aws/hooks/glue.py: ## @@ -422,3 +422,55 @@ def create_or_update_glue_job(self) -> str | None: self.conn.create_job(**config)

Re: [PR] Glue DataBrew operator [airflow]

2023-10-10 Thread via GitHub
ellisms commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1352815213 ## docs/apache-airflow-providers-amazon/operators/glue.rst: ## @@ -100,8 +100,18 @@ use :class:`~airflow.providers.amazon.aws.sensors.glue.GlueJobSensor` :start

Re: [PR] bump open api image to v7.0.1 [airflow]

2023-10-10 Thread via GitHub
pierrejeambrun commented on code in PR #34805: URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998 ## clients/gen/common.sh: ## @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. -OPENAPI_GENERATOR_CLI_VER=5.

Re: [PR] bump open api image to v7.0.1 [airflow]

2023-10-10 Thread via GitHub
pierrejeambrun commented on code in PR #34805: URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998 ## clients/gen/common.sh: ## @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. -OPENAPI_GENERATOR_CLI_VER=5.

Re: [PR] bump open api image to v7.0.1 [airflow]

2023-10-10 Thread via GitHub
pierrejeambrun commented on code in PR #34805: URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998 ## clients/gen/common.sh: ## @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. -OPENAPI_GENERATOR_CLI_VER=5.

Re: [PR] bump open api image to v7.0.1 [airflow]

2023-10-10 Thread via GitHub
pierrejeambrun commented on code in PR #34805: URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998 ## clients/gen/common.sh: ## @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. -OPENAPI_GENERATOR_CLI_VER=5.

Re: [PR] bump open api image to v7.0.1 [airflow]

2023-10-10 Thread via GitHub
pierrejeambrun commented on code in PR #34805: URL: https://github.com/apache/airflow/pull/34805#discussion_r1352817998 ## clients/gen/common.sh: ## @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License. -OPENAPI_GENERATOR_CLI_VER=5.

Re: [PR] Use auth manager `is_authorized_` APIs to check user permissions in Rest API [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on PR #34317: URL: https://github.com/apache/airflow/pull/34317#issuecomment-1755733216 Comments are addressed and CI is green, reviews would be appreciated :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1352830072 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.", Removed

[PR] Add subnet_ids param in AzureContainerInstancesOperator [airflow]

2023-10-10 Thread via GitHub
pankajastro opened a new pull request, #34850: URL: https://github.com/apache/airflow/pull/34850 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideli

Re: [I] Azure Container Instance Operator uses deprecated "network profile" arg [airflow]

2023-10-10 Thread via GitHub
pankajastro commented on issue #34820: URL: https://github.com/apache/airflow/issues/34820#issuecomment-1755745169 > @pankajastro I assume this issue is fixed in #34738 ? I removed network_profile in https://github.com/apache/airflow/pull/34738 but just created a separate PR https://g

Re: [I] Azure Container Instance Operator uses deprecated "network profile" arg [airflow]

2023-10-10 Thread via GitHub
jackglick commented on issue #34820: URL: https://github.com/apache/airflow/issues/34820#issuecomment-1755747546 > > @pankajastro I assume this issue is fixed in #34738 ? > > > > I removed network_profile in https://github.com/apache/airflow/pull/34738 but just created a separ

Re: [I] Azure Container Instance Operator uses deprecated "network profile" arg [airflow]

2023-10-10 Thread via GitHub
pankajastro commented on issue #34820: URL: https://github.com/apache/airflow/issues/34820#issuecomment-1755764641 > > > @pankajastro I assume this issue is fixed in #34738 ? > > > > > > I removed network_profile in #34738 but just created a separate PR #34850 to add subnet_ids

Re: [PR] Glue DataBrew operator [airflow]

2023-10-10 Thread via GitHub
ellisms commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1352852548 ## airflow/providers/amazon/aws/triggers/glue.py: ## @@ -148,3 +148,60 @@ async def run(self) -> AsyncIterator[TriggerEvent]: break

Re: [PR] Add `DatabricksJobsCreateOperator` [airflow]

2023-10-10 Thread via GitHub
josh-fell commented on code in PR #32221: URL: https://github.com/apache/airflow/pull/32221#discussion_r1352699528 ## airflow/providers/databricks/operators/databricks.py: ## @@ -161,6 +163,139 @@ def get_link( return XCom.get_value(key=XCOM_RUN_PAGE_URL_KEY, ti_key=ti_

Re: [PR] Glue DataBrew operator [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1352897728 ## airflow/providers/amazon/aws/triggers/glue.py: ## @@ -148,3 +148,60 @@ async def run(self) -> AsyncIterator[TriggerEvent]: break

Re: [PR] Feature: Allow description to be passed in when using variables CLI [airflow]

2023-10-10 Thread via GitHub
Zhenye-Na commented on code in PR #34791: URL: https://github.com/apache/airflow/pull/34791#discussion_r1352908599 ## airflow/cli/cli_config.py: ## @@ -543,6 +543,15 @@ def string_lower_type(val): ARG_DEFAULT = Arg( ("-d", "--default"), metavar="VAL", default=None, help="D

Re: [PR] Add back decorator `has_access` [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on code in PR #34786: URL: https://github.com/apache/airflow/pull/34786#discussion_r1352934435 ## airflow/www/auth.py: ## @@ -44,6 +46,27 @@ def get_access_denied_message(): return conf.get("webserver", "access_denied_message") +def has_access(permiss

Re: [PR] Add back decorator `has_access` [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on code in PR #34786: URL: https://github.com/apache/airflow/pull/34786#discussion_r1352939249 ## airflow/www/auth.py: ## @@ -44,6 +46,27 @@ def get_access_denied_message(): return conf.get("webserver", "access_denied_message") +def has_access(permiss

[PR] Make it possible to change the default cron timetable [airflow]

2023-10-10 Thread via GitHub
collinmcnulty opened a new pull request, #34851: URL: https://github.com/apache/airflow/pull/34851 Closes #34659. Adds the setting scheduler.default_cron_timetable and allows two values, CronDataIntervalTimetable or CronTriggerTimetable. --- **^ Add meani

Re: [PR] Add back decorator `has_access` [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on PR #34786: URL: https://github.com/apache/airflow/pull/34786#issuecomment-1755910306 > What I did not fully get with the new API methods are, these are specific to the UI areas. If I add a `MyPlugin` then I would need to add a `has_access_my_plugin()` decorator, the on

Re: [PR] Add subnet_ids param in AzureContainerInstancesOperator [airflow]

2023-10-10 Thread via GitHub
pankajastro merged PR #34850: URL: https://github.com/apache/airflow/pull/34850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airf

[airflow] branch main updated: Add subnet_ids param in AzureContainerInstancesOperator (#34850)

2023-10-10 Thread pankaj
This is an automated email from the ASF dual-hosted git repository. pankaj pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 434f571915 Add subnet_ids param in AzureContainerIn

Re: [PR] Add Open Search Provider [airflow]

2023-10-10 Thread via GitHub
ferruzzi commented on PR #34705: URL: https://github.com/apache/airflow/pull/34705#issuecomment-1755924053 Yeah, I saw that, but the only changes in the Amazon package were some whitespace and punctuation in a docstring. Better done separate, but I didn't think it was worth blocking over

Re: [I] Airflow UI stops refreshing the DAG status [airflow]

2023-10-10 Thread via GitHub
jens-scheffler-bosch commented on issue #34835: URL: https://github.com/apache/airflow/issues/34835#issuecomment-1755942465 Most important question: Problem gone by increasing DagProcessor resources? Otherwise this should be fixed first. Besides throwing more hardware on the problem y

Re: [PR] Corrected the user creation command CONTRIBUTORS_QUICK_START.rst [airflow]

2023-10-10 Thread via GitHub
jens-scheffler-bosch commented on code in PR #34842: URL: https://github.com/apache/airflow/pull/34842#discussion_r1353061891 ## CONTRIBUTORS_QUICK_START.rst: ## @@ -302,18 +302,28 @@ Setting up Breeze 5. When you enter Breeze environment you should see prompt similar to ``roo

Re: [PR] Add back decorator `has_access` [airflow]

2023-10-10 Thread via GitHub
jens-scheffler-bosch commented on PR #34786: URL: https://github.com/apache/airflow/pull/34786#issuecomment-1755949965 > > So besides public API would be good to add some hints into the plugin authoring docs - If you don't want to raise a PR I could if you help me in understanding. >

Re: [PR] Add Open Search Provider [airflow]

2023-10-10 Thread via GitHub
eladkal commented on PR #34705: URL: https://github.com/apache/airflow/pull/34705#issuecomment-1755950688 > Yeah, I saw that, but the only changes in the Amazon package were some whitespace and punctuation in a docstring. Better done separate, but I didn't think it was worth blocking over i

Re: [PR] Glue DataBrew operator [airflow]

2023-10-10 Thread via GitHub
ferruzzi commented on code in PR #34807: URL: https://github.com/apache/airflow/pull/34807#discussion_r1353056130 ## airflow/providers/amazon/aws/hooks/glue.py: ## @@ -422,3 +422,50 @@ def create_or_update_glue_job(self) -> str | None: self.conn.create_job(**config)

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-10 Thread via GitHub
jedcunningham commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1353074394 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.", Re

Re: [PR] Executors doc update [airflow]

2023-10-10 Thread via GitHub
o-nikolas commented on PR #34324: URL: https://github.com/apache/airflow/pull/34324#issuecomment-1756036373 This has been open for a while and the feedback has stopped trickling in. @potiuk, @vincbeck, @syedahsn, @ferruzzi I think I've addressed all your feedback. Merging this one! -- Th

Re: [PR] Add back decorator `has_access` [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on PR #34786: URL: https://github.com/apache/airflow/pull/34786#issuecomment-1756037969 @utkarsharma2, @ashb, @hussein-awala Any comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Executors doc update [airflow]

2023-10-10 Thread via GitHub
o-nikolas merged PR #34324: URL: https://github.com/apache/airflow/pull/34324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[airflow] branch main updated (434f571915 -> 8fdf3582c2)

2023-10-10 Thread onikolas
This is an automated email from the ASF dual-hosted git repository. onikolas pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 434f571915 Add subnet_ids param in AzureContainerInstancesOperator (#34850) add 8fdf3582c2 Executors doc update

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1353154858 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.", Removed

Re: [PR] Add back decorator `has_access` [airflow]

2023-10-10 Thread via GitHub
utkarsharma2 commented on PR #34786: URL: https://github.com/apache/airflow/pull/34786#issuecomment-1756075151 @vincbeck Thanks for adding it back :) changes look good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] AIP-58: Add Airflow Store (AS) [airflow]

2023-10-10 Thread via GitHub
jens-scheffler-bosch commented on code in PR #34729: URL: https://github.com/apache/airflow/pull/34729#discussion_r1353202717 ## airflow/io/fs/__init__.py: ## @@ -0,0 +1,987 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreement

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-10 Thread via GitHub
jedcunningham commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1353220178 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.", Re

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-10 Thread via GitHub
o-nikolas commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1353229032 ## airflow/providers/amazon/aws/operators/base_aws.py: ## Review Comment: > It is also might be a good idea to make this classes internal only. +1 --

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-10 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1353229086 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.", Removed

Re: [I] Airflow UI stops refreshing the DAG status [airflow]

2023-10-10 Thread via GitHub
Taragolis commented on issue #34835: URL: https://github.com/apache/airflow/issues/34835#issuecomment-1756121896 It would be nice if you could provide some DAG samples which might reproduce an issue, otherwise it is looks like more troubleshooting rather than actual issue. -- This is an

Re: [I] Airflow UI stops refreshing the DAG status [airflow]

2023-10-10 Thread via GitHub
Taragolis closed issue #34835: Airflow UI stops refreshing the DAG status URL: https://github.com/apache/airflow/issues/34835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-10 Thread via GitHub
o-nikolas commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1353234785 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,150 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lic

Re: [I] Trino SQL split trailing semi-colon [airflow]

2023-10-10 Thread via GitHub
Bisk1 commented on issue #34828: URL: https://github.com/apache/airflow/issues/34828#issuecomment-1756264489 @MikeWallis42 Airflow uses external library to split sql: https://github.com/andialbrecht/sqlparse and it doesn't support removing semicolons; maybe you should consider opening an is

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-10 Thread via GitHub
Taragolis commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1353460934 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,150 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lic

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-10 Thread via GitHub
Taragolis commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1353473369 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

[PR] Warn archived docs [airflow-site]

2023-10-10 Thread via GitHub
RNHTTR opened a new pull request, #871: URL: https://github.com/apache/airflow-site/pull/871 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Warn archived docs [airflow-site]

2023-10-10 Thread via GitHub
RNHTTR closed pull request #871: Warn archived docs URL: https://github.com/apache/airflow-site/pull/871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >