Re: [PR] Add 'uuid_column', 'tenant' params to WeaviateIngestOperator [airflow]

2023-12-22 Thread via GitHub
pankajastro commented on code in PR #36387: URL: https://github.com/apache/airflow/pull/36387#discussion_r1435520508 ## airflow/providers/weaviate/operators/weaviate.py: ## @@ -87,11 +91,16 @@ def hook(self) -> WeaviateHook: """Return an instance of the WeaviateHook."""

[PR] Add 'uuid_column', 'tenant' params to WeaviateIngestOperator [airflow]

2023-12-22 Thread via GitHub
utkarsharma2 opened a new pull request, #36387: URL: https://github.com/apache/airflow/pull/36387 Exposing 'uuid_column', and 'tenant' params in WeaviateIngestOperator and fixing the missing `insertion_errors` param issue. -- This is an automated message from the Apache Git Service. To r

Re: [PR] Add `on_skipped_callback` in to `BaseOperator` [airflow]

2023-12-22 Thread via GitHub
dirrao commented on PR #36374: URL: https://github.com/apache/airflow/pull/36374#issuecomment-1868228237 > The trigger rule dep could change the TI state to skipped without raising this exception, I wonder if we should handle that case too 🤔 > > https://github.com/apache/airflow/blob

Re: [I] Changing role name in access_control doesn't remove permission from previous role [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] commented on issue #17508: URL: https://github.com/apache/airflow/issues/17508#issuecomment-1868225272 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activit

Re: [I] Status of testing Providers that were prepared on December 23, 2023 [airflow]

2023-12-22 Thread via GitHub
utkarsharma2 commented on issue #36384: URL: https://github.com/apache/airflow/issues/36384#issuecomment-1868220019 Hey Jarek, Would it be possible to have an RC2 to include this commit for the W

(airflow) branch main updated: Add create_or_replace_document_objects method to weaviate provider (#36177)

2023-12-22 Thread utkarsharma
This is an automated email from the ASF dual-hosted git repository. utkarsharma pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 75d74b1f3a Add create_or_replace_document_obje

Re: [PR] Add create_or_replace_document_objects method to weaviate provider [airflow]

2023-12-22 Thread via GitHub
utkarsharma2 merged PR #36177: URL: https://github.com/apache/airflow/pull/36177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

Re: [I] Status of testing Providers that were prepared on December 23, 2023 [airflow]

2023-12-22 Thread via GitHub
dirrao commented on issue #36384: URL: https://github.com/apache/airflow/issues/36384#issuecomment-1868204994 I have tested the following Kubernetes provider fixes. They are working as expected. I am eagerly waiting for the release that has a critical performance bug. - Kube

Re: [I] Status of testing Providers that were prepared on December 23, 2023 [airflow]

2023-12-22 Thread via GitHub
Lee-W commented on issue #36384: URL: https://github.com/apache/airflow/issues/36384#issuecomment-1868192250 We've tested the following provider RCs with our example DAGs without encountering issues. apache-airflow-providers-microsoft-azure==8.5.0rc1 apache-airflow-providers-sftp==

Re: [PR] add missing impersonation_chain argument when calling trigger in Bigquery Operators [airflow]

2023-12-22 Thread via GitHub
Lee-W commented on code in PR #36341: URL: https://github.com/apache/airflow/pull/36341#discussion_r1435458749 ## airflow/providers/google/cloud/hooks/bigquery.py: ## @@ -3247,6 +3251,35 @@ def _format_schema_for_description(schema: dict) -> list: return description +cl

[I] AWS Provder Operators and Sensors Duplicate Code [airflow]

2023-12-22 Thread via GitHub
dirrao opened a new issue, #36386: URL: https://github.com/apache/airflow/issues/36386 ### Apache Airflow Provider(s) amazon ### Versions of Apache Airflow Providers apache-airflow-providers-amazon 8.13.0 ### Apache Airflow version 2.8.0 ### Operating

Re: [PR] handle tzinfo in S3Hook.is_keys_unchanged_async [airflow]

2023-12-22 Thread via GitHub
Lee-W commented on code in PR #36363: URL: https://github.com/apache/airflow/pull/36363#discussion_r1435444974 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -713,7 +713,9 @@ async def is_keys_unchanged_async( } if last_activity_time: -ina

[PR] Update release process for providers to include mixed RC versions [airflow]

2023-12-22 Thread via GitHub
potiuk opened a new pull request, #36385: URL: https://github.com/apache/airflow/pull/36385 This PR updates released process for providers to enable releasing providers in more regular batches. Sometimes when we exclude a provider from previous voting, we want to release RCN (2,3 etc.) cand

Re: [PR] handle tzinfo in S3Hook.is_keys_unchanged_async [airflow]

2023-12-22 Thread via GitHub
Lee-W commented on code in PR #36363: URL: https://github.com/apache/airflow/pull/36363#discussion_r143555 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -812,6 +813,30 @@ async def test_s3_key_hook_is_keys_unchanged_inactivity_error_async(self, mock_l "

Re: [PR] minor Amazon provider improvements [airflow]

2023-12-22 Thread via GitHub
Lee-W commented on code in PR #36330: URL: https://github.com/apache/airflow/pull/36330#discussion_r1435441200 ## airflow/providers/amazon/aws/operators/batch.py: ## @@ -255,11 +255,16 @@ def execute(self, context: Context): return self.job_id -def execute_compl

[I] Status of testing Providers that were prepared on December 23, 2023 [airflow]

2023-12-22 Thread via GitHub
potiuk opened a new issue, #36384: URL: https://github.com/apache/airflow/issues/36384 ### Body I have a kind request for all the contributors to the latest provider packages release. Could you please help us to test the RC versions of the providers? The guidelines on how to

(airflow) branch constraints-main updated: Updating constraints. Github run id:7305210673

2023-12-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e18d6193f3 Updating con

(airflow-site) branch add-documentation-2023-12-23 updated (661bb57432 -> 4f082eb51a)

2023-12-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-documentation-2023-12-23 in repository https://gitbox.apache.org/repos/asf/airflow-site.git omit 661bb57432 Add documentation for packages - 2023-12-23 add 4f082eb51a Add documentati

[PR] Add documentation for packages - 2023-12-23 [airflow-site]

2023-12-22 Thread via GitHub
potiuk opened a new pull request, #916: URL: https://github.com/apache/airflow-site/pull/916 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

(airflow-site) branch add-documentation-2023-12-23 created (now 661bb57432)

2023-12-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-documentation-2023-12-23 in repository https://gitbox.apache.org/repos/asf/airflow-site.git at 661bb57432 Add documentation for packages - 2023-12-23 This branch includes the following

svn commit: r66280 [1/3] - /dev/airflow/providers/

2023-12-22 Thread potiuk
Author: potiuk Date: Sat Dec 23 01:09:05 2023 New Revision: 66280 Log: Add artifacts for Airflow Providers 2023-12-23 Added: dev/airflow/providers/apache_airflow_providers_airbyte-3.5.1-py3-none-any.whl (with props) dev/airflow/providers/apache_airflow_providers_airbyte-3.5.1-py3-non

svn commit: r66280 [3/3] - /dev/airflow/providers/

2023-12-22 Thread potiuk
Added: dev/airflow/providers/apache_airflow_providers_trino-5.6.0-py3-none-any.whl.sha512 == --- dev/airflow/providers/apache_airflow_providers_trino-5.6.0-py3-none-any.whl.sha512 (added) +++ dev/airflow/providers/apach

svn commit: r66280 [2/3] - /dev/airflow/providers/

2023-12-22 Thread potiuk
Added: dev/airflow/providers/apache_airflow_providers_dbt_cloud-3.5.1-py3-none-any.whl.sha512 == --- dev/airflow/providers/apache_airflow_providers_dbt_cloud-3.5.1-py3-none-any.whl.sha512 (added) +++ dev/airflow/provide

(airflow) branch main updated: Update version and added breaking change for databricks provider (#36382)

2023-12-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 77b563bfc5 Update version and added breaking change

Re: [PR] Update version and added breaking change for databricks provider [airflow]

2023-12-22 Thread via GitHub
potiuk merged PR #36382: URL: https://github.com/apache/airflow/pull/36382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Make databricks sql hook return a namedtuple [airflow]

2023-12-22 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1868155868 https://github.com/apache/airflow/assets/595491/ef947b2d-2108-4514-b675-d99d54091344";> -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] feat(EcsRunTaskOperator): add `count` param [airflow]

2023-12-22 Thread via GitHub
boring-cyborg[bot] commented on PR #36383: URL: https://github.com/apache/airflow/pull/36383#issuecomment-1868154325 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] feat(EcsRunTaskOperator): add `count` param [airflow]

2023-12-22 Thread via GitHub
jayceslesar opened a new pull request, #36383: URL: https://github.com/apache/airflow/pull/36383 Noticed that this was missing from `EcsRunTaskOperator` as an option. Reference: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecs/client/run_task.html -- T

[PR] Update version and added breaking change for databricks provider [airflow]

2023-12-22 Thread via GitHub
potiuk opened a new pull request, #36382: URL: https://github.com/apache/airflow/pull/36382 This change had been missing from the released notes because it's been merged without squash & merge. --- **^ Add meaningful description above** Read the **[Pu

Re: [PR] Make databricks sql hook return a namedtuple [airflow]

2023-12-22 Thread via GitHub
potiuk commented on PR #36205: URL: https://github.com/apache/airflow/pull/36205#issuecomment-1868152845 Hey @bolkedebruin -> next time when you merge PR - can you please make sure you keep "squash and merge" for PRs - this one has been merged without it and it has no (#36205) in the name -

[I] Release notes issue reference does not provide link if multiple issues are present [airflow]

2023-12-22 Thread via GitHub
AetherUnbound opened a new issue, #36381: URL: https://github.com/apache/airflow/issues/36381 ### What do you see as an issue? The [release notes for Airflow 2.8.0](https://airflow.apache.org/docs/apache-airflow/stable/release_notes.html#airflow-2-8-0-2023-12-14) have several lines u

svn commit: r66278 [2/3] - /dev/airflow/providers/

2023-12-22 Thread potiuk
Added: dev/airflow/providers/apache_airflow_providers_dbt_cloud-3.5.1.tar.gz.asc == --- dev/airflow/providers/apache_airflow_providers_dbt_cloud-3.5.1.tar.gz.asc (added) +++ dev/airflow/providers/apache_airflow_providers_d

svn commit: r66278 [1/3] - /dev/airflow/providers/

2023-12-22 Thread potiuk
Author: potiuk Date: Sat Dec 23 00:28:24 2023 New Revision: 66278 Log: Add artifacts for Airflow Providers 2023-12-23 Added: dev/airflow/providers/apache_airflow_providers_airbyte-3.5.1-py3-none-any.whl (with props) dev/airflow/providers/apache_airflow_providers_airbyte-3.5.1-py3-non

svn commit: r66278 [3/3] - /dev/airflow/providers/

2023-12-22 Thread potiuk
Added: dev/airflow/providers/apache_airflow_providers_trino-5.6.0.tar.gz.asc == --- dev/airflow/providers/apache_airflow_providers_trino-5.6.0.tar.gz.asc (added) +++ dev/airflow/providers/apache_airflow_providers_trino-5.6

(airflow) branch main updated: Re-apply updated version numbers to 2nd wave of providers in December (#36380)

2023-12-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b15d5578da Re-apply updated version numbers to 2nd

Re: [PR] Re-apply updated version numbers to 2nd wave of providers in December [airflow]

2023-12-22 Thread via GitHub
potiuk merged PR #36380: URL: https://github.com/apache/airflow/pull/36380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] GlueJobSensor stuck in Running state with Verbose set to True [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] closed issue #35431: GlueJobSensor stuck in Running state with Verbose set to True URL: https://github.com/apache/airflow/issues/35431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Enable using wif for storage transfer [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] closed pull request #35292: Enable using wif for storage transfer URL: https://github.com/apache/airflow/pull/35292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Validate `dag.tasks` isn't empty when parsing [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] closed pull request #35316: Validate `dag.tasks` isn't empty when parsing URL: https://github.com/apache/airflow/pull/35316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Resolve `botocore.UNSIGNED` and `unsigned` in Amazon Provider [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] closed pull request #35305: Resolve `botocore.UNSIGNED` and `unsigned` in Amazon Provider URL: https://github.com/apache/airflow/pull/35305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] GlueJobSensor stuck in Running state with Verbose set to True [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] commented on issue #35431: URL: https://github.com/apache/airflow/issues/35431#issuecomment-1868144243 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add usage withing jinja template [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] commented on PR #35479: URL: https://github.com/apache/airflow/pull/35479#issuecomment-1868144232 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] [DOC] K8S support policy [airflow]

2023-12-22 Thread via GitHub
github-actions[bot] commented on PR #35506: URL: https://github.com/apache/airflow/pull/35506#issuecomment-1868144222 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] [WIP] Mapping tasks from ObjectStoragePath [airflow]

2023-12-22 Thread via GitHub
hussein-awala commented on PR #36319: URL: https://github.com/apache/airflow/pull/36319#issuecomment-1868138890 > Doing this on a path feels a bit wrong since a path doesn’t inheritly hold any information on the thing it points to. Bolke and I were discussing we need something on top of pat

Re: [PR] Re-apply updated version numbers to 2nd wave of providers in December [airflow]

2023-12-22 Thread via GitHub
potiuk commented on PR #36380: URL: https://github.com/apache/airflow/pull/36380#issuecomment-1868134249 I need one more update after ``` Apply template updates breeze release-management prepare-provider-documentation --include-removed-providers --reapply-templates-only

Re: [I] Commit failed: Local: No offset stored while using AwaitMessageTriggerFunctionSensor [airflow]

2023-12-22 Thread via GitHub
hussein-awala commented on issue #32585: URL: https://github.com/apache/airflow/issues/32585#issuecomment-1868133741 > Hello, I can confirm that it fixes the issue. Thanks @hussein-awala . > > I can also trigger the error again by: > > 1. reverting the fix > 2. adding `"enabl

[PR] Re-apply updated version numbers to 2nd wave of providers in December [airflow]

2023-12-22 Thread via GitHub
potiuk opened a new pull request, #36380: URL: https://github.com/apache/airflow/pull/36380 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*

Re: [PR] Prepare 2nd wave of providers in December [airflow]

2023-12-22 Thread via GitHub
potiuk merged PR #36373: URL: https://github.com/apache/airflow/pull/36373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] handle tzinfo in S3Hook.is_keys_unchanged_async [airflow]

2023-12-22 Thread via GitHub
hussein-awala commented on code in PR #36363: URL: https://github.com/apache/airflow/pull/36363#discussion_r1435386945 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -812,6 +813,30 @@ async def test_s3_key_hook_is_keys_unchanged_inactivity_error_async(self, mock_l

[PR] Fix --use-airflow-version constraints [airflow]

2023-12-22 Thread via GitHub
potiuk opened a new pull request, #36378: URL: https://github.com/apache/airflow/pull/36378 When `--use-airflow-version` is a numeric or rc version, the constraints should be specific for that version when installing airflow. For example when we install 2.7.3rc1, `constraints-2.7.3rc1` shou

Re: [PR] Making changes to priority class [airflow]

2023-12-22 Thread via GitHub
hussein-awala commented on code in PR #36365: URL: https://github.com/apache/airflow/pull/36365#discussion_r1435383000 ## helm_tests/airflow_aux/test_basic_helm_chart.py: ## @@ -644,6 +645,7 @@ def test_priority_classes_default_preemption(self): )[0] assert o

Re: [PR] fix datetime reference in DAG.is_fixed_time_schedule [airflow]

2023-12-22 Thread via GitHub
hussein-awala commented on PR #36370: URL: https://github.com/apache/airflow/pull/36370#issuecomment-1868121894 Congrats on your first commit 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

(airflow) branch main updated: fix datetime reference in DAG.is_fixed_time_schedule (#36370)

2023-12-22 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 547ddf6317 fix datetime reference in DAG.is_f

Re: [PR] fix datetime reference in DAG.is_fixed_time_schedule [airflow]

2023-12-22 Thread via GitHub
hussein-awala merged PR #36370: URL: https://github.com/apache/airflow/pull/36370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] fix datetime reference in DAG.is_fixed_time_schedule [airflow]

2023-12-22 Thread via GitHub
boring-cyborg[bot] commented on PR #36370: URL: https://github.com/apache/airflow/pull/36370#issuecomment-1868121809 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] fix datetime reference in DAG.is_fixed_time_schedule [airflow]

2023-12-22 Thread via GitHub
hussein-awala commented on PR #36370: URL: https://github.com/apache/airflow/pull/36370#issuecomment-1868121712 > @joshowen Thanks for the MR. I see this function is marked as deprecated and not being referenced anywhere in the code. Do we need to support this function? When we depre

Re: [PR] fix datetime reference in DAG.is_fixed_time_schedule [airflow]

2023-12-22 Thread via GitHub
hussein-awala commented on PR #36370: URL: https://github.com/apache/airflow/pull/36370#issuecomment-186812 related to https://github.com/apache/airflow/pull/35887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

(airflow) branch main updated: note that task instance, dag and lifecycle listeners are non-experimental (#36376)

2023-12-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0a69ba1211 note that task instance, dag and lifecyc

Re: [PR] note that task instance, dag and lifecycle listeners are non-experimental [airflow]

2023-12-22 Thread via GitHub
potiuk merged PR #36376: URL: https://github.com/apache/airflow/pull/36376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Add more info to Docs README (#36287)

2023-12-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 690d6e20eb Add more info to Docs README (#36287) 6

Re: [PR] Add more info to Docs README [airflow]

2023-12-22 Thread via GitHub
potiuk merged PR #36287: URL: https://github.com/apache/airflow/pull/36287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] add missing impersonation_chain argument when calling trigger in Bigquery Operators [airflow]

2023-12-22 Thread via GitHub
melugoyal commented on code in PR #36341: URL: https://github.com/apache/airflow/pull/36341#discussion_r1435369084 ## airflow/providers/google/cloud/hooks/bigquery.py: ## @@ -3247,6 +3251,35 @@ def _format_schema_for_description(schema: dict) -> list: return description

Re: [I] Basic authentication with Python API does not work in `main` Airflow [airflow]

2023-12-22 Thread via GitHub
potiuk commented on issue #36377: URL: https://github.com/apache/airflow/issues/36377#issuecomment-1868103154 cc: @vincbeck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[I] Basic authentication with Python API does not work in `main` Airflow [airflow]

2023-12-22 Thread via GitHub
potiuk opened a new issue, #36377: URL: https://github.com/apache/airflow/issues/36377 ### Apache Airflow version main (development) ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? Looks like API authentication does not

(airflow) branch remove-experimental-listener updated (e069ab4274 -> be957e18ff)

2023-12-22 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a change to branch remove-experimental-listener in repository https://gitbox.apache.org/repos/asf/airflow.git omit e069ab4274 Update newsfragments/1234.significant.rst omit 6db16cc01c note that task in

(airflow) branch remove-experimental-listener updated (6db16cc01c -> e069ab4274)

2023-12-22 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a change to branch remove-experimental-listener in repository https://gitbox.apache.org/repos/asf/airflow.git from 6db16cc01c note that task instance, dag and lifecycle listeners are non-experimental

Re: [PR] [WIP] Mod Test [airflow]

2023-12-22 Thread via GitHub
cabbagepatchman commented on PR #36339: URL: https://github.com/apache/airflow/pull/36339#issuecomment-1868072114 Hey Jarek, I appreciate the caution. I am a security researcher, and was testing the fork PR approval requirements, which it seems your team has thought about extensi

Re: [PR] note that task instance, dag and lifecycle listeners are non-experimental [airflow]

2023-12-22 Thread via GitHub
eladkal commented on code in PR #36376: URL: https://github.com/apache/airflow/pull/36376#discussion_r1435346880 ## newsfragments/1234.significant.rst: ## @@ -0,0 +1,18 @@ +Since Airflow 2.9.0, following Listener API methods are not considered experimental anymore: Review Comm

[PR] note that task instance, dag and lifecycle listeners are non-experimental [airflow]

2023-12-22 Thread via GitHub
mobuchowski opened a new pull request, #36376: URL: https://github.com/apache/airflow/pull/36376 Following discussion on mailing list, the task instance, dag and lifecycle listeners are non-experimental as of 2.9. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] K8S Spark Operator doesn't delete an older application with the same name anymore [airflow]

2023-12-22 Thread via GitHub
eladkal commented on issue #32363: URL: https://github.com/apache/airflow/issues/32363#issuecomment-1868065497 @JavadHosseini can you help with reviewing https://github.com/apache/airflow/pull/36268 ? does it solve your issue? -- This is an automated message from the Apache Git Service. T

Re: [PR] Prepare 2nd wave of providers in December [airflow]

2023-12-22 Thread via GitHub
potiuk commented on code in PR #36373: URL: https://github.com/apache/airflow/pull/36373#discussion_r1435344521 ## airflow/providers/plexus/CHANGELOG.rst: ## @@ -27,6 +27,17 @@ Changelog - +3.4.1 +. + Review Comment: Yep. Fixed. -- This is an automated me

Re: [I] Old DAGs are still available on airflow UI if the dag directory is changed [airflow]

2023-12-22 Thread via GitHub
potiuk closed issue #36371: Old DAGs are still available on airflow UI if the dag directory is changed URL: https://github.com/apache/airflow/issues/36371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Prepare 2nd wave of providers in December [airflow]

2023-12-22 Thread via GitHub
eladkal commented on code in PR #36373: URL: https://github.com/apache/airflow/pull/36373#discussion_r1435340526 ## airflow/providers/plexus/CHANGELOG.rst: ## @@ -27,6 +27,17 @@ Changelog - +3.4.1 +. + Review Comment: We should add note that this is the last

[PR] draft: Add on skipped callback [airflow]

2023-12-22 Thread via GitHub
romsharon98 opened a new pull request, #36374: URL: https://github.com/apache/airflow/pull/36374 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideli

[PR] Prepare 2nd wave of providers in December [airflow]

2023-12-22 Thread via GitHub
potiuk opened a new pull request, #36373: URL: https://github.com/apache/airflow/pull/36373 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*

Re: [PR] Enable native HPA for Airflow Workers [airflow]

2023-12-22 Thread via GitHub
pemiranda-clgx commented on code in PR #36174: URL: https://github.com/apache/airflow/pull/36174#discussion_r1435328214 ## chart/values.yaml: ## @@ -592,6 +592,28 @@ workers: # This configuration will be ignored if PGBouncer is not enabled usePgbouncer: true + # All

Re: [PR] Enable native HPA for Airflow Workers [airflow]

2023-12-22 Thread via GitHub
pemiranda-clgx commented on code in PR #36174: URL: https://github.com/apache/airflow/pull/36174#discussion_r1435328214 ## chart/values.yaml: ## @@ -592,6 +592,28 @@ workers: # This configuration will be ignored if PGBouncer is not enabled usePgbouncer: true + # All

Re: [PR] Move fs scheme definition from Python to YAML [airflow]

2023-12-22 Thread via GitHub
potiuk commented on PR #35972: URL: https://github.com/apache/airflow/pull/35972#issuecomment-1868025646 Yeah. yanking is a bit extreme measure, I agree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Add more info to Docs README [airflow]

2023-12-22 Thread via GitHub
potiuk commented on PR #36287: URL: https://github.com/apache/airflow/pull/36287#issuecomment-1868025036 static checks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(airflow) branch main updated: Fix problems with missing selective checks on new types of unit tests (#36372)

2023-12-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b0db1f94ed Fix problems with missing selective chec

Re: [PR] Fix problems with missing selective checks on new types of unit tests [airflow]

2023-12-22 Thread via GitHub
potiuk merged PR #36372: URL: https://github.com/apache/airflow/pull/36372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Fix problems with missing selective checks on new types of unit tests [airflow]

2023-12-22 Thread via GitHub
potiuk commented on PR #36372: URL: https://github.com/apache/airflow/pull/36372#issuecomment-1867967367 Fixes problem that https://github.com/apache/airflow/pull/36361 did not run the right tests. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Allow PythonVirtualenvOperator.skip_on_exit_code to be zero [airflow]

2023-12-22 Thread via GitHub
potiuk commented on code in PR #36361: URL: https://github.com/apache/airflow/pull/36361#discussion_r1435272061 ## tests/operators/test_python.py: ## @@ -847,31 +847,41 @@ def test_virtualenv_serializable_context_fields(self, create_task_instance): assert set(context)

[PR] Fix problems with missing selective checks on new types of unit tests [airflow]

2023-12-22 Thread via GitHub
potiuk opened a new pull request, #36372: URL: https://github.com/apache/airflow/pull/36372 When the DB/NonDB tests were introduced (#35160) new test types have been added (separating various Python test types from generic Operator test type). However we have not added matching of the pytho

Re: [PR] Fix wrong execution date in SLA alerts [airflow]

2023-12-22 Thread via GitHub
hliu-VoleonGroup commented on PR #35389: URL: https://github.com/apache/airflow/pull/35389#issuecomment-1867952839 @jedcunningham @ephraimbuddy Can I get a review on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] minor Amazon provider improvements [airflow]

2023-12-22 Thread via GitHub
dirrao commented on code in PR #36330: URL: https://github.com/apache/airflow/pull/36330#discussion_r1435247103 ## airflow/providers/amazon/aws/operators/batch.py: ## @@ -255,11 +255,16 @@ def execute(self, context: Context): return self.job_id -def execute_comp

Re: [PR] minor Amazon provider improvements [airflow]

2023-12-22 Thread via GitHub
dirrao commented on code in PR #36330: URL: https://github.com/apache/airflow/pull/36330#discussion_r1435247103 ## airflow/providers/amazon/aws/operators/batch.py: ## @@ -255,11 +255,16 @@ def execute(self, context: Context): return self.job_id -def execute_comp

Re: [PR] Move fs scheme definition from Python to YAML [airflow]

2023-12-22 Thread via GitHub
eladkal commented on PR #35972: URL: https://github.com/apache/airflow/pull/35972#issuecomment-1867919916 > and yank 2.8.0. I dont think it's right to yank 2.8.0 over this. I am OK to habdle it as bug fix but this means 2.8.1 should be created this week to reduce the effect on user

[I] Old DAGs are still available on airflow UI if the dag directory is changed [airflow]

2023-12-22 Thread via GitHub
ishitamishra13111999 opened a new issue, #36371: URL: https://github.com/apache/airflow/issues/36371 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.7.3 ### What happened? We h

Re: [I] Old DAGs are still available on airflow UI if the dag directory is changed [airflow]

2023-12-22 Thread via GitHub
boring-cyborg[bot] commented on issue #36371: URL: https://github.com/apache/airflow/issues/36371#issuecomment-1867919277 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] handle tzinfo in S3Hook.is_keys_unchanged_async [airflow]

2023-12-22 Thread via GitHub
dirrao commented on code in PR #36363: URL: https://github.com/apache/airflow/pull/36363#discussion_r1435235012 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -713,7 +713,9 @@ async def is_keys_unchanged_async( } if last_activity_time: -in

Re: [PR] fix datetime reference in DAG.is_fixed_time_schedule [airflow]

2023-12-22 Thread via GitHub
joshowen commented on PR #36370: URL: https://github.com/apache/airflow/pull/36370#issuecomment-1867899120 > @joshowen Thanks for the MR. I see this function is marked as deprecated and not being referenced anywhere in the code. Do we need to support this function? The deprecation wa

Re: [I] Implement pre-commit plugins for VSCode/PyCharm/Intellij maybe [airflow]

2023-12-22 Thread via GitHub
khushi-98 commented on issue #35253: URL: https://github.com/apache/airflow/issues/35253#issuecomment-1867892829 Good evening sir,I am a beginner. This is my first issue, so I need some of your guidance. Can you tell how to start work on this issue? Sent from Mail for Windows From: Jarek Po

Re: [PR] Remove remaining Airflow 2.5 backcompat code from Google Provider [airflow]

2023-12-22 Thread via GitHub
eladkal merged PR #36366: URL: https://github.com/apache/airflow/pull/36366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

(airflow) branch main updated: Remove remaining Airflow 2.5 backcompat code from Google Provider (#36366)

2023-12-22 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2c2763f806 Remove remaining Airflow 2.5 backcompat

(airflow) branch constraints-main updated: Updating constraints. Github run id:7301527933

2023-12-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 8ead55742f Updating con

[PR] fix datetime reference in DAG.is_fixed_time_schedule [airflow]

2023-12-22 Thread via GitHub
joshowen opened a new pull request, #36370: URL: https://github.com/apache/airflow/pull/36370 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines

Re: [I] Airflow progressive slowness [airflow]

2023-12-22 Thread via GitHub
dirrao commented on issue #32928: URL: https://github.com/apache/airflow/issues/32928#issuecomment-1867826875 @llamageddon83 We have faced a similar issue in production, identified the root cause, and provided the fix in #36240. If you are looking for an immediate fix, then you can try

(airflow) branch main updated: Return common data structure in DBApi derived classes

2023-12-22 Thread bolke
This is an automated email from the ASF dual-hosted git repository. bolke pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5fe5d31a46 Return common data structure in DBApi der

Re: [PR] Make databricks sql hook return a namedtuple [airflow]

2023-12-22 Thread via GitHub
bolkedebruin merged PR #36205: URL: https://github.com/apache/airflow/pull/36205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

  1   2   >