Re: [I] WORKER_AUTOSCALE should not allow max workers < min workers [airflow]

2024-01-01 Thread via GitHub
Bowrna commented on issue #35332: URL: https://github.com/apache/airflow/issues/35332#issuecomment-1873634703 Could i pick up this issue if it's still pending @RNHTTR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] Hook notification when you turn on/off (pause/unpause) a DAG from the UI [airflow]

2024-01-01 Thread via GitHub
Bowrna commented on issue #36516: URL: https://github.com/apache/airflow/issues/36516#issuecomment-1873626221 @potiuk how about trying this to implement it via listenerplugin? I would like to pick up this issue and see if i can work on it. -- This is an automated message from the Apach

Re: [I] Links to specific dagruns don't work when older than 25 runs [airflow]

2024-01-01 Thread via GitHub
jermaine151 commented on issue #34723: URL: https://github.com/apache/airflow/issues/34723#issuecomment-1873545771 I found a workaround to this problem in v2.7.3. If you add `&base_date=` to the URL, it will locate runs older than the latest 25. Here's an example link that is working for me:

[PR] Fix details tab not showing when using dynamic task mapping [airflow]

2024-01-01 Thread via GitHub
shohamy7 opened a new pull request, #36522: URL: https://github.com/apache/airflow/pull/36522 --- closes: #36481 This PR solves the problem of details tab is empty in the Airflow Web UI when using dynamic task mapping. -- This is an automated message

Re: [PR] Remove MSSQL support form Airflow core [airflow]

2024-01-01 Thread via GitHub
potiuk commented on PR #36514: URL: https://github.com/apache/airflow/pull/36514#issuecomment-1873483401 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(airflow) branch main updated: Announce MSSQL support end in Airflow 2.9.0, add migration script hints (#36509)

2024-01-01 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new eecb4793ab Announce MSSQL support end in Airflow

Re: [PR] Announce MSSQL support end in Airflow 2.9.0, add migration script hints [airflow]

2024-01-01 Thread via GitHub
jscheffl merged PR #36509: URL: https://github.com/apache/airflow/pull/36509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Support git-sync v4 in Helm Chart [airflow]

2024-01-01 Thread via GitHub
shohamy7 commented on code in PR #34731: URL: https://github.com/apache/airflow/pull/34731#discussion_r1439049185 ## chart/templates/_helpers.yaml: ## @@ -202,50 +202,88 @@ If release name contains chart name it will be used as a full name. {{- if .Values.dags.gitSync.sshK

(airflow) branch constraints-main updated: Updating constraints. Github run id:7377867458

2024-01-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new c20d3a4bbc Updating con

Re: [PR] openlineage, aws: add OpenLineage support for Redshift SQL. [airflow]

2024-01-01 Thread via GitHub
JDarDagran commented on code in PR #35794: URL: https://github.com/apache/airflow/pull/35794#discussion_r1439035387 ## airflow/providers/amazon/aws/hooks/redshift_sql.py: ## @@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection: conn_kwargs_dejson = self.conn.ex

Re: [PR] openlineage, aws: add OpenLineage support for Redshift SQL. [airflow]

2024-01-01 Thread via GitHub
potiuk commented on code in PR #35794: URL: https://github.com/apache/airflow/pull/35794#discussion_r1439034813 ## airflow/providers/amazon/aws/hooks/redshift_sql.py: ## @@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection: conn_kwargs_dejson = self.conn.extra_

(airflow) branch main updated: Update installation prerequisites after upgrading to Debian Bookworm (#36521)

2024-01-01 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9f90a655e8 Update installation prerequisites after

Re: [PR] Update installation prerequisites after upgrading to Debian Bookworm [airflow]

2024-01-01 Thread via GitHub
potiuk merged PR #36521: URL: https://github.com/apache/airflow/pull/36521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] openlineage, aws: add OpenLineage support for Redshift SQL. [airflow]

2024-01-01 Thread via GitHub
JDarDagran commented on code in PR #35794: URL: https://github.com/apache/airflow/pull/35794#discussion_r1439023100 ## airflow/providers/amazon/aws/hooks/redshift_sql.py: ## @@ -174,3 +175,63 @@ def get_conn(self) -> RedshiftConnection: conn_kwargs_dejson = self.conn.ex

[PR] Update installation prerequisites after upgrading to Debian Bookworm [airflow]

2024-01-01 Thread via GitHub
potiuk opened a new pull request, #36521: URL: https://github.com/apache/airflow/pull/36521 We've migrated to Debian Bookworm for our images in #31941 but our installation prerequisites and example system level dependencies mention Bullseye. Since for 2.8 we run all tests on Bookworm but we

Re: [I] Airflow installation failed with pip command on Python 3.8 [airflow]

2024-01-01 Thread via GitHub
potiuk commented on issue #36520: URL: https://github.com/apache/airflow/issues/36520#issuecomment-1873305757 This is expected. Check prerequisites. Airflow on Windows can only be installed with WSEL2: https://airflow.apache.org/docs/apache-airflow/stable/installation/prerequisites.h

Re: [I] Airflow installation failed with pip command on Python 3.8 [airflow]

2024-01-01 Thread via GitHub
potiuk closed issue #36520: Airflow installation failed with pip command on Python 3.8 URL: https://github.com/apache/airflow/issues/36520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Remove option ot set a task instance to running state in UI [airflow]

2024-01-01 Thread via GitHub
pankajastro commented on code in PR #36518: URL: https://github.com/apache/airflow/pull/36518#discussion_r1439017914 ## airflow/www/views.py: ## @@ -5727,15 +5726,6 @@ def set_task_instance_state( except Exception: flash("Failed to set state", "error") -

Re: [PR] Remove option ot set a task instance to running state in UI [airflow]

2024-01-01 Thread via GitHub
pankajkoti commented on code in PR #36518: URL: https://github.com/apache/airflow/pull/36518#discussion_r1439012653 ## airflow/www/views.py: ## @@ -5727,15 +5726,6 @@ def set_task_instance_state( except Exception: flash("Failed to set state", "error") -

Re: [PR] Remove option ot set a task instance to running state in UI [airflow]

2024-01-01 Thread via GitHub
pankajkoti commented on code in PR #36518: URL: https://github.com/apache/airflow/pull/36518#discussion_r1439012653 ## airflow/www/views.py: ## @@ -5727,15 +5726,6 @@ def set_task_instance_state( except Exception: flash("Failed to set state", "error") -

Re: [I] Airflow installation failed with pip command on Python 3.8 [airflow]

2024-01-01 Thread via GitHub
boring-cyborg[bot] commented on issue #36520: URL: https://github.com/apache/airflow/issues/36520#issuecomment-1873280385 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Airflow installation failed with pip command on Python 3.8 [airflow]

2024-01-01 Thread via GitHub
cd10anil opened a new issue, #36520: URL: https://github.com/apache/airflow/issues/36520 ### Apache Airflow version 2.8.0 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When tried to install AirFlow using pip command i

Re: [PR] Remove option ot set a task instance to running state in UI [airflow]

2024-01-01 Thread via GitHub
jscheffl commented on code in PR #36518: URL: https://github.com/apache/airflow/pull/36518#discussion_r1439004671 ## airflow/www/views.py: ## @@ -5727,15 +5726,6 @@ def set_task_instance_state( except Exception: flash("Failed to set state", "error") -

Re: [PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2024-01-01 Thread via GitHub
jscheffl commented on PR #36517: URL: https://github.com/apache/airflow/pull/36517#issuecomment-1873268073 > Once concern is backwards compatibility (and I think that's where @kaxil's solution came from). > > But yeah, I think you are right @jscheffl @dirrao - probably return value i

Re: [PR] Allow raising error if ``DagRun`` fails when running ``dag test`` [airflow]

2024-01-01 Thread via GitHub
potiuk commented on PR #36517: URL: https://github.com/apache/airflow/pull/36517#issuecomment-1873242002 Once concern is backwards compatibility (and I think that's where @kaxil's solution came from). But yeah, I think you are right @jscheffl @dirrao - probably return value is not **

Re: [I] Hook notification when you turn on/off (pause/unpause) a DAG from the UI [airflow]

2024-01-01 Thread via GitHub
potiuk commented on issue #36516: URL: https://github.com/apache/airflow/issues/36516#issuecomment-1873240412 > One possible option could be to publish the DAG state metric. Consumers can monitor the DAG's last state from the metrics and create alerts around it. However, this option doesn't

Re: [PR] Fix XSS weakness in airflow/www/views.py [airflow]

2024-01-01 Thread via GitHub
ZuhairORZaki commented on PR #36469: URL: https://github.com/apache/airflow/pull/36469#issuecomment-1873233638 > So maybe @ZuhairORZaki -> treat this one as exercise. If you can make the tool works by generating such exploitation scenario, this is probably something you can report. If you c

Re: [PR] Fix XSS weakness in airflow/www/views.py [airflow]

2024-01-01 Thread via GitHub
ZuhairORZaki closed pull request #36469: Fix XSS weakness in airflow/www/views.py URL: https://github.com/apache/airflow/pull/36469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Support git-sync v4 in Helm Chart [airflow]

2024-01-01 Thread via GitHub
Swalloow commented on code in PR #34731: URL: https://github.com/apache/airflow/pull/34731#discussion_r1438983627 ## chart/templates/_helpers.yaml: ## @@ -202,50 +202,88 @@ If release name contains chart name it will be used as a full name. {{- if .Values.dags.gitSync.sshK