Re: [PR] fix inheritance checking of security manager in FabAuthManager [airflow]

2024-01-10 Thread via GitHub
ephraimbuddy commented on PR #36343: URL: https://github.com/apache/airflow/pull/36343#issuecomment-1886492496 Moved this to 2.9.0 since FabAuthManager has been moved to providers cc @vincbeck @potiuk -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [I] S3 Task Handler doesn't use custom logging config as fallback [airflow]

2024-01-10 Thread via GitHub
eladkal commented on issue #24565: URL: https://github.com/apache/airflow/issues/24565#issuecomment-1886465286 @benbenbang are you still working on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FEAT] adds repair run functionality for databricks [airflow]

2024-01-10 Thread via GitHub
gaurav7261 commented on PR #36601: URL: https://github.com/apache/airflow/pull/36601#issuecomment-1886447691 @dirrao can you approve so that CI will start cc @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] Fix tests to adopt changes in Jinja 3.1.3 [airflow]

2024-01-10 Thread via GitHub
Taragolis opened a new pull request, #36731: URL: https://github.com/apache/airflow/pull/36731 Recently was released new version of Jinja2 (3.1.3) which seems like change some internal mechanism of load templates in `jinja2.FileSystemLoader` so our current mocking approach d

Re: [PR] metrics tagging documentation [airflow]

2024-01-10 Thread via GitHub
dirrao commented on PR #36627: URL: https://github.com/apache/airflow/pull/36627#issuecomment-1886411513 @ferruzzi Can you review this MR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Deprecate AutoMLTrainModelOperator for Vision and Video [airflow]

2024-01-10 Thread via GitHub
Lee-W commented on code in PR #36473: URL: https://github.com/apache/airflow/pull/36473#discussion_r1448363959 ## tests/system/providers/google/cloud/automl/example_automl_nl_text_classification.py: ## @@ -114,7 +112,7 @@ import_configs=DATA_CONFIG, ) -# [STA

(airflow) branch main updated: Replace the depreacted cncf-kubernetes modules in the doc and tests (#36727)

2024-01-10 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c0e2786dbf Replace the depreacted cncf-kubernetes

Re: [PR] Replace the depreacted cncf-kubernetes modules in the doc and tests [airflow]

2024-01-10 Thread via GitHub
eladkal merged PR #36727: URL: https://github.com/apache/airflow/pull/36727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Fix check on subclass for `typing.Union` in `_infer_multiple_outputs` for Python 3.10+ [airflow]

2024-01-10 Thread via GitHub
Taragolis commented on PR #36728: URL: https://github.com/apache/airflow/pull/36728#issuecomment-1886363489 During fix one problem another happen 🙄 🙄 🙄 ```console FAILED tests/models/test_mappedoperator.py::test_mapped_render_template_fields_validating_operator - TypeError: Can't

(airflow) branch main updated: check transform job status before deferring SageMakerTransformOperator (#36680)

2024-01-10 Thread phanikumv
This is an automated email from the ASF dual-hosted git repository. phanikumv pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b260367208 check transform job status before def

Re: [PR] check transform job status before deferring SageMakerTransformOperator [airflow]

2024-01-10 Thread via GitHub
phanikumv merged PR #36680: URL: https://github.com/apache/airflow/pull/36680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Add `exception` to templates ref list [airflow]

2024-01-10 Thread via GitHub
josh-fell commented on PR #36656: URL: https://github.com/apache/airflow/pull/36656#issuecomment-1886216696 Woohoo! Congrats @ngokchaoho on your first contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

(airflow) branch main updated: Add `exception` to templates ref list (#36656)

2024-01-10 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 798017886f Add `exception` to templates ref list

Re: [PR] Add `exception` to templates ref list [airflow]

2024-01-10 Thread via GitHub
boring-cyborg[bot] commented on PR #36656: URL: https://github.com/apache/airflow/pull/36656#issuecomment-1886216418 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Add `exception` to templates ref list [airflow]

2024-01-10 Thread via GitHub
josh-fell merged PR #36656: URL: https://github.com/apache/airflow/pull/36656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Correct `hatch` command for show available venvs (#36729)

2024-01-10 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 20d0a41004 Correct `hatch` command for show avail

Re: [PR] Correct `hatch` command for show available venvs [airflow]

2024-01-10 Thread via GitHub
josh-fell merged PR #36729: URL: https://github.com/apache/airflow/pull/36729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Add support for reproducible build date epoch for Airflow releases [airflow]

2024-01-10 Thread via GitHub
Lee-W commented on code in PR #36726: URL: https://github.com/apache/airflow/pull/36726#discussion_r1448236087 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -578,6 +579,45 @@ Checking apache_airflow-2.0.2rc4-py2.py3-none-any.whl.sha512 Checking apache-airflow-2.0.2rc4-source.tar.gz.

Re: [PR] Add support for reproducible build date epoch for Airflow releases [airflow]

2024-01-10 Thread via GitHub
Lee-W commented on code in PR #36726: URL: https://github.com/apache/airflow/pull/36726#discussion_r1448234755 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -210,12 +210,13 @@ class VersionedFile(NamedTuple): RICH_VERSION = "13.7.0" NODE_VERSI

Re: [I] There's no way to pass params to dag.test() [airflow]

2024-01-10 Thread via GitHub
RNHTTR closed issue #35930: There's no way to pass params to dag.test() URL: https://github.com/apache/airflow/issues/35930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] There's no way to pass params to dag.test() [airflow]

2024-01-10 Thread via GitHub
RNHTTR commented on issue #35930: URL: https://github.com/apache/airflow/issues/35930#issuecomment-1886097256 @getaaron apologies for the delayed response. It looks like @keithbentrup 's solution ought to work. With that said, Keith's point about [dag.test() docs](https://airflow.apache.org

Re: [I] There's no way to pass params to dag.test() [airflow]

2024-01-10 Thread via GitHub
keithbentrup commented on issue #35930: URL: https://github.com/apache/airflow/issues/35930#issuecomment-1886020087 @getaaron Try `dag.test(run_conf={"paramA": "valueA", "paramB": "valueB"})`. The [test() docs](https://airflow.apache.org/docs/apache-airflow/stable/_api/airflow/models/dag/in

Re: [PR] Fix check on subclass for `typing.Union` in `_infer_multiple_outputs` for Python 3.10+ [airflow]

2024-01-10 Thread via GitHub
Taragolis closed pull request #36728: Fix check on subclass for `typing.Union` in `_infer_multiple_outputs` for Python 3.10+ URL: https://github.com/apache/airflow/pull/36728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [WIP] Fix vault gcp auth [airflow]

2024-01-10 Thread via GitHub
github-actions[bot] commented on PR #35855: URL: https://github.com/apache/airflow/pull/35855#issuecomment-1885963933 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Remove elasticsearch getattr only required for Airflow < 2.6 [airflow]

2024-01-10 Thread via GitHub
github-actions[bot] closed pull request #35779: Remove elasticsearch getattr only required for Airflow < 2.6 URL: https://github.com/apache/airflow/pull/35779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [WIP] Apply best practices for SQL queries [airflow]

2024-01-10 Thread via GitHub
github-actions[bot] commented on PR #35638: URL: https://github.com/apache/airflow/pull/35638#issuecomment-1885963988 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[PR] Correct `hatch` command for show available venvs [airflow]

2024-01-10 Thread via GitHub
Taragolis opened a new pull request, #36729: URL: https://github.com/apache/airflow/pull/36729 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideline

Re: [PR] Add support of Pendulum 3 [airflow]

2024-01-10 Thread via GitHub
Taragolis commented on PR #36281: URL: https://github.com/apache/airflow/pull/36281#issuecomment-1885948891 Fortunately All failures after latest rebase not relevant to changes from this PR and should be fixed by https://github.com/apache/airflow/pull/36728 -- This is an automated message

Re: [PR] Fix check on subclass for `typing.Union` in `_infer_multiple_outputs` for Python 3.10+ [airflow]

2024-01-10 Thread via GitHub
Taragolis commented on code in PR #36728: URL: https://github.com/apache/airflow/pull/36728#discussion_r1448119525 ## tests/decorators/test_python.py: ## @@ -97,7 +97,6 @@ def identity_dict_with_decorator_call(x: int, y: int) -> resolve(annotation): assert identity_d

[PR] Fix check on subclass for `typing.Union` in `_infer_multiple_outputs` for Python 3.10+ [airflow]

2024-01-10 Thread via GitHub
Taragolis opened a new pull request, #36728: URL: https://github.com/apache/airflow/pull/36728 https://github.com/apache/airflow/pull/36652 introduced bug for Python 3.10+ when task decorated function has annotation as object and not as class This also fix broken main

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

2024-01-10 Thread via GitHub
hussein-awala commented on PR #35714: URL: https://github.com/apache/airflow/pull/35714#issuecomment-1885943230 @eladkal could you check the Google provider check? is it's complicated, I can bump the min `cncf-kubernetes` version to avoid this complexity. -- This is an automated message f

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448111020 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -1086,3 +1089,31 @@ def test_start_health_check_config(self, set_env_vars): executor

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448109036 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -943,8 +944,10 @@ def test_provided_values_override_defaults(self, assign_subnets):

Re: [I] Reduce memory usage in `S3Hook` [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on issue #35449: URL: https://github.com/apache/airflow/issues/35449#issuecomment-1885915557 @ellisms - That would be great. You can look at the newer hooks and see lots of examples of how this could be reworked to use boto3.client instead of boto3.resources, and they sh

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448098657 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor_config.py: ## @@ -60,6 +61,26 @@ def build_task_kwargs() -> dict: task_kwargs = _fetch_config_values(

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448098657 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor_config.py: ## @@ -60,6 +61,26 @@ def build_task_kwargs() -> dict: task_kwargs = _fetch_config_values(

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448091836 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor_config.py: ## @@ -60,6 +61,26 @@ def build_task_kwargs() -> dict: task_kwargs = _fetch_config_values(

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448091836 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor_config.py: ## @@ -60,6 +61,26 @@ def build_task_kwargs() -> dict: task_kwargs = _fetch_config_values(

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448088091 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -1086,3 +1089,31 @@ def test_start_health_check_config(self, set_env_vars): executor

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
o-nikolas commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448085278 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -943,8 +944,10 @@ def test_provided_values_override_defaults(self, assign_subnets):

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
o-nikolas commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448084819 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor_config.py: ## @@ -60,6 +61,26 @@ def build_task_kwargs() -> dict: task_kwargs = _fetch_config_values

Re: [PR] Generate doc for fab CLI commands [airflow]

2024-01-10 Thread via GitHub
o-nikolas commented on code in PR #36672: URL: https://github.com/apache/airflow/pull/36672#discussion_r1448065990 ## docs/apache-airflow-providers-fab/cli-ref.rst: ## @@ -0,0 +1,29 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor licen

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448050751 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -943,8 +944,10 @@ def test_provided_values_override_defaults(self, assign_subnets):

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448055721 ## airflow/providers/amazon/aws/executors/ecs/ecs_executor_config.py: ## @@ -60,6 +61,26 @@ def build_task_kwargs() -> dict: task_kwargs = _fetch_config_values(

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448050751 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -943,8 +944,10 @@ def test_provided_values_override_defaults(self, assign_subnets):

Re: [PR] Add support for reproducible build date epoch for Airflow releases [airflow]

2024-01-10 Thread via GitHub
potiuk commented on PR #36726: URL: https://github.com/apache/airflow/pull/36726#issuecomment-1885826717 Quick follow-up after https://github.com/apache/airflow/pull/36537 - adding nice, reproducible build support for Airflow packages. -- This is an automated message from the Apache Git

[PR] Add support for reproducible build date epoch for Airflow releases [airflow]

2024-01-10 Thread via GitHub
potiuk opened a new pull request, #36726: URL: https://github.com/apache/airflow/pull/36726 Hatch has built-in support for reproducible builds, however it uses a hard-coded 2020 date to generate the reproducible binaries, which produces whl, tar.gz files that contain file dates that are pre

Re: [PR] Add method from_uri and deprecate uri param in constructor [airflow]

2024-01-10 Thread via GitHub
eladkal commented on code in PR #35898: URL: https://github.com/apache/airflow/pull/35898#discussion_r1448032995 ## airflow/providers/google/cloud/hooks/cloud_sql.py: ## @@ -964,7 +964,7 @@ def create_connection(self) -> Connection: proxy, TCP, UNIX sockets, SSL.

Re: [PR] KPO write_logs does not need to use complicated pod logs reader [airflow]

2024-01-10 Thread via GitHub
eladkal commented on code in PR #36228: URL: https://github.com/apache/airflow/pull/36228#discussion_r1448031027 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -703,22 +703,21 @@ def execute_complete(self, context: Context, event: dict, **kwargs):

Re: [PR] Add extra operator links for EMR Serverless [airflow]

2024-01-10 Thread via GitHub
o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1448028145 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
o-nikolas commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1448022745 ## tests/providers/amazon/aws/executors/ecs/test_ecs_executor.py: ## @@ -943,8 +944,10 @@ def test_provided_values_override_defaults(self, assign_subnets):

[PR] WIP - Refactor dag run indexes [airflow]

2024-01-10 Thread via GitHub
dstandish opened a new pull request, #36725: URL: https://github.com/apache/airflow/pull/36725 Try consolidating some indexes on dag run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

(airflow) branch pendulum-3 updated (ab31119c9b -> 3caa58d8ca)

2024-01-10 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch pendulum-3 in repository https://gitbox.apache.org/repos/asf/airflow.git omit ab31119c9b Add newsfragments omit 98a6cf7918 Update airflow/serialization/serialized_objects.py omit 5

Re: [PR] Remove backward compatibility check for KubernetesPodOperator module [airflow]

2024-01-10 Thread via GitHub
eladkal merged PR #36724: URL: https://github.com/apache/airflow/pull/36724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

(airflow) branch main updated: Remove backward compatibility check for KubernetesPodOperator module (#36724)

2024-01-10 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4a5da8e05e Remove backward compatibility check for

(airflow) branch main updated: Make sure `multiple_outputs` is inferred correctly even when using `TypedDict` (#36652)

2024-01-10 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e11b91c8e0 Make sure `multiple_outputs` is inferr

Re: [PR] Make sure `multiple_outputs` is inferred correctly even when using `TypedDict` [airflow]

2024-01-10 Thread via GitHub
boring-cyborg[bot] commented on PR #36652: URL: https://github.com/apache/airflow/pull/36652#issuecomment-1885753492 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Make sure `multiple_outputs` is inferred correctly even when using `TypedDict` [airflow]

2024-01-10 Thread via GitHub
jscheffl merged PR #36652: URL: https://github.com/apache/airflow/pull/36652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Support encryption for triggers parameters [airflow]

2024-01-10 Thread via GitHub
jscheffl commented on PR #36492: URL: https://github.com/apache/airflow/pull/36492#issuecomment-1885745806 > https://www.postgresqltutorial.com/postgresql-tutorial/postgresql-json/ ..but I assume we don't want to implement N different dialects for all supported DBs - and anyway once w

(airflow) branch pendulum-3 updated (b08df5802e -> ab31119c9b)

2024-01-10 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch pendulum-3 in repository https://gitbox.apache.org/repos/asf/airflow.git omit b08df5802e Fix static checks annd redundand $ in workflow omit 669d9e1e7b Add newsfragments omit e6e1b

Re: [PR] Add extra operator links for EMR Serverless [airflow]

2024-01-10 Thread via GitHub
dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1447950174 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

[PR] Remove backward compatibility check for KubernetesPodOperator module [airflow]

2024-01-10 Thread via GitHub
hussein-awala opened a new pull request, #36724: URL: https://github.com/apache/airflow/pull/36724 related: #36721 I forgot to remove the same check from the operators module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] Broken installation with `--editable` flag [airflow]

2024-01-10 Thread via GitHub
potiuk closed issue #30764: Broken installation with `--editable` flag URL: https://github.com/apache/airflow/issues/30764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Standardize airflow build process and switch to Hatchling build backend [airflow]

2024-01-10 Thread via GitHub
potiuk merged PR #36537: URL: https://github.com/apache/airflow/pull/36537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Standardize airflow build process and switch to Hatchling build backend [airflow]

2024-01-10 Thread via GitHub
potiuk commented on PR #36537: URL: https://github.com/apache/airflow/pull/36537#issuecomment-1885654751 Right... Mergin then.. Let's see :D. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Remove backward compatibility check for KubernetesPodTrigger module from google provider [airflow]

2024-01-10 Thread via GitHub
potiuk merged PR #36721: URL: https://github.com/apache/airflow/pull/36721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Remove backward compatibility check for KubernetesPodTrigger module (#36721)

2024-01-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ead75286dc Remove backward compatibility check for

Re: [I] API Endpoints for Dataset Creation and Updating [airflow]

2024-01-10 Thread via GitHub
potiuk closed issue #36686: API Endpoints for Dataset Creation and Updating URL: https://github.com/apache/airflow/issues/36686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] API Endpoints for Dataset Creation and Updating [airflow]

2024-01-10 Thread via GitHub
potiuk commented on issue #36686: URL: https://github.com/apache/airflow/issues/36686#issuecomment-1885643229 I think it is far too big of a feature and should be discussed at the devlist. Currently all the objects (DAGs and Datasaets alike) are created by parsing DAG files, NOT by creating

(airflow) branch main updated: Add back FAB constant in legacy security manager (#36719)

2024-01-10 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new acdbd577ab Add back FAB constant in legacy securit

Re: [PR] Add back FAB constant in legacy security manager [airflow]

2024-01-10 Thread via GitHub
eladkal merged PR #36719: URL: https://github.com/apache/airflow/pull/36719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [I] default_webserver_config.py isn't compatible with the latest changes [airflow]

2024-01-10 Thread via GitHub
eladkal closed issue #36702: default_webserver_config.py isn't compatible with the latest changes URL: https://github.com/apache/airflow/issues/36702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Index on task instance [airflow]

2024-01-10 Thread via GitHub
dstandish commented on PR #30762: URL: https://github.com/apache/airflow/pull/30762#issuecomment-1885632718 Hi @babinos87 , I happened to be looking a bit at index utilization and noticed that this one isn't getting used on our cluster. I saw you shared a query that this benefits. Is that

Re: [I] Docker libmariadb.so.3 is missing from official Docker image [airflow]

2024-01-10 Thread via GitHub
potiuk closed issue #36715: Docker libmariadb.so.3 is missing from official Docker image URL: https://github.com/apache/airflow/issues/36715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] Docker libmariadb.so.3 is missing from official Docker image [airflow]

2024-01-10 Thread via GitHub
potiuk commented on issue #36715: URL: https://github.com/apache/airflow/issues/36715#issuecomment-1885628783 Should be fixed now when you pull latest image again. ``` docker run -it apache/airflow python -c 'import MySQLdb' ``` -- This is an automated message from the Apache

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1447898453 ## airflow/providers/amazon/provider.yaml: ## @@ -828,6 +828,19 @@ config: type: string example: "ecs_executor_cluster" default: ~ +

Re: [PR] Use `mariadb` by default when build final prod image [airflow]

2024-01-10 Thread via GitHub
potiuk commented on PR #36716: URL: https://github.com/apache/airflow/pull/36716#issuecomment-1885621547 OK. Images refreshed - they failed verification, but the verification failure was "fab" provider missing (which is expected). -- This is an automated message from the Apache Git Servi

Re: [PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
eladkal commented on code in PR #36722: URL: https://github.com/apache/airflow/pull/36722#discussion_r1447896023 ## airflow/providers/amazon/provider.yaml: ## @@ -828,6 +828,19 @@ config: type: string example: "ecs_executor_cluster" default: ~ + c

[PR] Adds support for capacity providers to ECS Executor [airflow]

2024-01-10 Thread via GitHub
ferruzzi opened a new pull request, #36722: URL: https://github.com/apache/airflow/pull/36722 Users have asked to be able to use Capacity Provider Strategies instead of the Launch Type (they are mutually exclusive) with the new ECS Executor, so this PR adds that support. Passes all s

Re: [PR] Doc: fix version to 2.8.0 [airflow]

2024-01-10 Thread via GitHub
potiuk commented on code in PR #36714: URL: https://github.com/apache/airflow/pull/36714#discussion_r1447883581 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -319,14 +319,14 @@ you should do those steps: .. code-block:: docker -#image: ${AIRFLOW_IMAGE_NAM

Re: [PR] Doc: fix version to 2.8.0 [airflow]

2024-01-10 Thread via GitHub
potiuk commented on code in PR #36714: URL: https://github.com/apache/airflow/pull/36714#discussion_r1447879302 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -319,14 +319,14 @@ you should do those steps: .. code-block:: docker -#image: ${AIRFLOW_IMAGE_NAM

Re: [PR] Add extra operator links for EMR Serverless [airflow]

2024-01-10 Thread via GitHub
o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1447874021 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

(airflow) branch main updated (11ec4100b3 -> 457bdae18e)

2024-01-10 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 11ec4100b3 Use `mariadb` by default when build final prod image (#36716) add 457bdae18e Add connection UI form a

Re: [PR] [FEAT] adds repair run functionality for databricks [airflow]

2024-01-10 Thread via GitHub
gaurav7261 commented on PR #36601: URL: https://github.com/apache/airflow/pull/36601#issuecomment-1885595361 done @potiuk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Add docs for discord webhook connection [airflow]

2024-01-10 Thread via GitHub
eladkal merged PR #36720: URL: https://github.com/apache/airflow/pull/36720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Use `mariadb` by default when build final prod image [airflow]

2024-01-10 Thread via GitHub
potiuk commented on PR #36716: URL: https://github.com/apache/airflow/pull/36716#issuecomment-1885584102 Merged. Re-building images here https://github.com/apache/airflow/actions/runs/7479928533/job/20358188520 -- This is an automated message from the Apache Git Service. To respond to th

(airflow) branch main updated (c59f8dee78 -> 11ec4100b3)

2024-01-10 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c59f8dee78 Update providers metadata 2024-01-10 (#36718) add 11ec4100b3 Use `mariadb` by default when build final

[PR] Remove backward compatibility check for KubernetesPodTrigger module from google provider [airflow]

2024-01-10 Thread via GitHub
hussein-awala opened a new pull request, #36721: URL: https://github.com/apache/airflow/pull/36721 The min cncf-kubernetes version is 7.2.0 in google provider: https://github.com/apache/airflow/blob/ecb2c9f24d1364642604c14f0deb681ab4894135/airflow/providers/google/provider.yaml#L1225-L122

Re: [PR] Use `mariadb` by default when build final prod image [airflow]

2024-01-10 Thread via GitHub
potiuk merged PR #36716: URL: https://github.com/apache/airflow/pull/36716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Use `mariadb` by default when build final prod image [airflow]

2024-01-10 Thread via GitHub
potiuk commented on code in PR #36716: URL: https://github.com/apache/airflow/pull/36716#discussion_r1447860225 ## docker_tests/test_prod_image.py: ## @@ -158,6 +158,7 @@ def test_pip_dependencies_conflict(self): "grpc": ["grpc", "google.auth", "google_auth_httplib2"],

Re: [PR] [FEAT] adds repair run functionality for databricks [airflow]

2024-01-10 Thread via GitHub
gaurav7261 commented on PR #36601: URL: https://github.com/apache/airflow/pull/36601#issuecomment-1885542783 sure @potiuk , doing that thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

2024-01-10 Thread via GitHub
eladkal commented on PR #35714: URL: https://github.com/apache/airflow/pull/35714#issuecomment-1885520418 Also doc paragraph about this new cool ability is good to have -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Doc: fix version to 2.8.0 [airflow]

2024-01-10 Thread via GitHub
hussein-awala commented on code in PR #36714: URL: https://github.com/apache/airflow/pull/36714#discussion_r1447837028 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -319,14 +319,14 @@ you should do those steps: .. code-block:: docker -#image: ${AIRFLOW_IM

[PR] Add docs for discord webhook connection [airflow]

2024-01-10 Thread via GitHub
shohamy7 opened a new pull request, #36720: URL: https://github.com/apache/airflow/pull/36720 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines

Re: [PR] Add parameter confirm to GCSToSFTPOperator [airflow]

2024-01-10 Thread via GitHub
eladkal commented on PR #35704: URL: https://github.com/apache/airflow/pull/35704#issuecomment-1885508551 I fixed the static tests but there is a failure with one of the unit tests that you need to look into @Nimo139 `FAILED tests/providers/apache/beam/operators/test_beam.py::TestBeamRu

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

2024-01-10 Thread via GitHub
hussein-awala commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1447830148 ## airflow/providers/google/cloud/triggers/kubernetes_engine.py: ## @@ -25,6 +25,7 @@ from google.cloud.container_v1.types import Operation from airflow.exc

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

2024-01-10 Thread via GitHub
eladkal commented on code in PR #35714: URL: https://github.com/apache/airflow/pull/35714#discussion_r1447825928 ## airflow/providers/google/cloud/triggers/kubernetes_engine.py: ## @@ -25,6 +25,7 @@ from google.cloud.container_v1.types import Operation from airflow.exception

Re: [I] default_webserver_config.py isn't compatible with the latest changes [airflow]

2024-01-10 Thread via GitHub
vincbeck commented on issue #36702: URL: https://github.com/apache/airflow/issues/36702#issuecomment-1885473465 See fix: #36719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] Add back FAB constant in legacy security manager [airflow]

2024-01-10 Thread via GitHub
vincbeck opened a new pull request, #36719: URL: https://github.com/apache/airflow/pull/36719 Resolves #36702 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#

Re: [PR] Use `mariadb` by default when build final prod image [airflow]

2024-01-10 Thread via GitHub
Taragolis commented on code in PR #36716: URL: https://github.com/apache/airflow/pull/36716#discussion_r1447825517 ## docker_tests/test_prod_image.py: ## @@ -158,6 +158,7 @@ def test_pip_dependencies_conflict(self): "grpc": ["grpc", "google.auth", "google_auth_httplib2"

  1   2   3   >