Re: [PR] style(providers/google): improve BigQueryInsertJobOperator type hinting [airflow]

2024-01-19 Thread via GitHub
Lee-W commented on PR #36894: URL: https://github.com/apache/airflow/pull/36894#issuecomment-1901897133 I think Mypy is not happy about annotating jobs in multiple places 樂 I Just removed that one. -- This is an automated message from the Apache Git Service. To respond to the message,

(airflow) branch constraints-main updated: Updating constraints. Github run id:7592887169

2024-01-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 9842bcee24 Updating

Re: [I] Airflow DagProcessor raise AttributeError: module 'multiprocessing' has no attribute 'connection' if dag folder is empty [airflow]

2024-01-19 Thread via GitHub
potiuk closed issue #36885: Airflow DagProcessor raise AttributeError: module 'multiprocessing' has no attribute 'connection' if dag folder is empty URL: https://github.com/apache/airflow/issues/36885 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Links to specific dagruns don't work when older than 25 runs [airflow]

2024-01-19 Thread via GitHub
potiuk commented on issue #34723: URL: https://github.com/apache/airflow/issues/34723#issuecomment-1901867882 cc: @bbovenzi @pierrejeambrun - would be cool to take a look and fix that one as it seems to be an important feature for those who complain about loosing the old grid view (see

Re: [PR] Template field support for configmaps in the KubernetesPodOperator [airflow]

2024-01-19 Thread via GitHub
eladkal commented on code in PR #36922: URL: https://github.com/apache/airflow/pull/36922#discussion_r1460281199 ## newsfragments/36922.feature.rst: ## @@ -0,0 +1 @@ +Support for configmaps in the template fields in the KubernetesPodOperator Review Comment: Please remove

Re: [I] New forced "Graph" view redirection breaks links from logs dag_run list table. [airflow]

2024-01-19 Thread via GitHub
potiuk closed issue #36884: New forced "Graph" view redirection breaks links from logs dag_run list table. URL: https://github.com/apache/airflow/issues/36884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] New forced "Graph" view redirection breaks links from logs dag_run list table. [airflow]

2024-01-19 Thread via GitHub
potiuk commented on issue #36884: URL: https://github.com/apache/airflow/issues/36884#issuecomment-1901864128 Closing as duplicate of #34723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix bug introduced by replacing spaces by + in run_id [airflow]

2024-01-19 Thread via GitHub
potiuk commented on code in PR #36877: URL: https://github.com/apache/airflow/pull/36877#discussion_r1460279029 ## tests/www/views/test_views_trigger_dag.py: ## @@ -369,6 +370,7 @@ def test_trigger_dag_params_array_value_none_render(admin_client, dag_maker, ses def

Re: [I] Marking success or failled of a single or group of tasks effects other tasks under different execution dates [airflow]

2024-01-19 Thread via GitHub
potiuk commented on issue #36879: URL: https://github.com/apache/airflow/issues/36879#issuecomment-1901852290 I recall that issue has been fixed already - can't find it easily, as we had thousands of issues fixed since 2.3.3. Please update to latest version of Airflow (2.8.1) and try again

Re: [I] Marking success or failled of a single or group of tasks effects other tasks under different execution dates [airflow]

2024-01-19 Thread via GitHub
potiuk closed issue #36879: Marking success or failled of a single or group of tasks effects other tasks under different execution dates URL: https://github.com/apache/airflow/issues/36879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Test [airflow]

2024-01-19 Thread via GitHub
potiuk commented on PR #36873: URL: https://github.com/apache/airflow/pull/36873#issuecomment-1901848092 Please @ibarrionuevo -> if you want to make your tests for security, announce your intentions to secur...@airflow.apache.org, otherwise such attempts (despite presenting yourself as

Re: [PR] Secret masker ignores passwords with special chars [airflow]

2024-01-19 Thread via GitHub
aritra24 commented on PR #36692: URL: https://github.com/apache/airflow/pull/36692#issuecomment-1901845192 @amoghrajesh made a comment on the issue. Could you take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] CSRF token to expire with session when config file exists [airflow]

2024-01-19 Thread via GitHub
potiuk closed issue #36869: CSRF token to expire with session when config file exists URL: https://github.com/apache/airflow/issues/36869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(airflow) branch main updated: fix(dagrun): copy bug (#36855)

2024-01-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6e7085be61 fix(dagrun): copy bug (#36855)

Re: [PR] Fix copy button on a DAG run's config [airflow]

2024-01-19 Thread via GitHub
boring-cyborg[bot] commented on PR #36855: URL: https://github.com/apache/airflow/pull/36855#issuecomment-1901824181 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Fix copy button on a DAG run's config [airflow]

2024-01-19 Thread via GitHub
potiuk merged PR #36855: URL: https://github.com/apache/airflow/pull/36855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Copy button on a Dag run's config copies only one run config [airflow]

2024-01-19 Thread via GitHub
potiuk closed issue #36848: Copy button on a Dag run's config copies only one run config URL: https://github.com/apache/airflow/issues/36848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] DatabricksSubmitRunDeferrableOperator runs in timeout when using AAD Token for SPN [airflow]

2024-01-19 Thread via GitHub
github-actions[bot] commented on issue #27830: URL: https://github.com/apache/airflow/issues/27830#issuecomment-1901815528 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last

Re: [PR] Add deferrable implementation in HTTPSensor [airflow]

2024-01-19 Thread via GitHub
Lee-W commented on code in PR #36904: URL: https://github.com/apache/airflow/pull/36904#discussion_r1460266199 ## airflow/providers/http/sensors/http.py: ## @@ -148,3 +158,25 @@ def poke(self, context: Context) -> bool: raise exc return True + +def

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
dirrao commented on code in PR #36882: URL: https://github.com/apache/airflow/pull/36882#discussion_r1460214073 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -434,9 +434,9 @@ def sync(self) -> None: )

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
dirrao commented on code in PR #36882: URL: https://github.com/apache/airflow/pull/36882#discussion_r1460214073 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -434,9 +434,9 @@ def sync(self) -> None: )

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
dirrao commented on code in PR #36882: URL: https://github.com/apache/airflow/pull/36882#discussion_r1460214073 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -434,9 +434,9 @@ def sync(self) -> None: )

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
dirrao commented on PR #36882: URL: https://github.com/apache/airflow/pull/36882#issuecomment-1901747231 > > It might be worth adding a note in the changelog about this behavior change, so folks can reevaluate if they need to enable/increase retries. > > Agree. @dirrao can you please

Re: [PR] Add dataset delete feature [airflow]

2024-01-19 Thread via GitHub
im-perativa commented on code in PR #36781: URL: https://github.com/apache/airflow/pull/36781#discussion_r1460153306 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -32,14 +34,42 @@ dataset_schema, ) from airflow.models.dataset import DatasetEvent,

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
hussein-awala commented on code in PR #36882: URL: https://github.com/apache/airflow/pull/36882#discussion_r1460108973 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -434,9 +434,9 @@ def sync(self) -> None: )

Re: [PR] Create a generic callbacks class for KubernetesPodOperator [airflow]

2024-01-19 Thread via GitHub
hussein-awala commented on PR #35714: URL: https://github.com/apache/airflow/pull/35714#issuecomment-1901447474 I just tested on a real cluster and found that the type I provide to the trigger is converted to a string. I even tried providing an object instance but had the same problem.

Re: [PR] Add dataset delete feature [airflow]

2024-01-19 Thread via GitHub
edumuellerFSL commented on code in PR #36781: URL: https://github.com/apache/airflow/pull/36781#discussion_r1460077363 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -32,14 +34,42 @@ dataset_schema, ) from airflow.models.dataset import DatasetEvent,

Re: [PR] Fix S3Hook get_key method by removing load extra args [airflow]

2024-01-19 Thread via GitHub
github-actions[bot] closed pull request #35951: Fix S3Hook get_key method by removing load extra args URL: https://github.com/apache/airflow/pull/35951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] UI: DAG Conf Parameters Form - Param Type of Boolean, Null converted to String for JSON config [airflow]

2024-01-19 Thread via GitHub
github-actions[bot] commented on issue #36369: URL: https://github.com/apache/airflow/issues/36369#issuecomment-1901379177 This issue has been automatically marked as stale because it has been open for 14 days with no response from the author. It will be closed in next 7 days if no further

(airflow) branch main updated: Link to release notes in the upgrade docs (#36923)

2024-01-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cad8ab31bf Link to release notes in the

Re: [PR] Link to release notes in the upgrade docs [airflow]

2024-01-19 Thread via GitHub
jedcunningham merged PR #36923: URL: https://github.com/apache/airflow/pull/36923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] ECS Executor - Overriding Additional ECS Task Properties [airflow]

2024-01-19 Thread via GitHub
syedahsn commented on issue #35490: URL: https://github.com/apache/airflow/issues/35490#issuecomment-1901325653 The difference that I was pointing out between our suggestions was that if we don't specify a key in `executor_config` which exists in `RUN_TASK_KWARGS`, that key should not be

Re: [PR] Airflow 2.8.1 has been released [airflow]

2024-01-19 Thread via GitHub
jedcunningham merged PR #36906: URL: https://github.com/apache/airflow/pull/36906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Airflow 2.8.1 has been released (#36906)

2024-01-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 32e2919420 Airflow 2.8.1 has been released

Re: [PR] Airflow 2.8.1 has been released [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on code in PR #36906: URL: https://github.com/apache/airflow/pull/36906#discussion_r1460014443 ## newsfragments/config.toml: ## @@ -16,7 +16,7 @@ # under the License. [tool.towncrier] name = "Airflow" -filename = "../RELEASE_NOTES.rst" +filename =

Re: [PR] Airflow 2.8.1 has been released [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on code in PR #36906: URL: https://github.com/apache/airflow/pull/36906#discussion_r1460013994 ## newsfragments/config.toml: ## @@ -16,7 +16,7 @@ # under the License. [tool.towncrier] name = "Airflow" -filename = "../RELEASE_NOTES.rst" +filename =

[PR] Link to release notes in the upgrade docs [airflow]

2024-01-19 Thread via GitHub
jedcunningham opened a new pull request, #36923: URL: https://github.com/apache/airflow/pull/36923 We seems to get asked "whats new between Airflow x and y?" a lot, and I noticed that our upgrade docs don't point folks to the release notes. That's at least how I always answer, so at least

(airflow) branch main updated: Fix providers validation in `check_files.py` after switch to the hatch builds (#36921)

2024-01-19 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new db767f0091 Fix providers validation in

Re: [PR] Fix providers validation in `check_files.py` after switch to the hatch builds [airflow]

2024-01-19 Thread via GitHub
hussein-awala merged PR #36921: URL: https://github.com/apache/airflow/pull/36921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Merge nowait and skip_locked into with_row_locks (#36889)

2024-01-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cabd768309 Merge nowait and skip_locked

Re: [PR] Merge nowait and skip_locked into with_row_locks [airflow]

2024-01-19 Thread via GitHub
jedcunningham merged PR #36889: URL: https://github.com/apache/airflow/pull/36889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Simplify query for orphaned tasks [airflow]

2024-01-19 Thread via GitHub
dstandish commented on PR #36566: URL: https://github.com/apache/airflow/pull/36566#issuecomment-1901209966 can i get an amen @jedcunningham @uranusjr @ephraimbuddy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
eladkal commented on PR #36882: URL: https://github.com/apache/airflow/pull/36882#issuecomment-1901194151 > It might be worth adding a note in the changelog about this behavior change, so folks can reevaluate if they need to enable/increase retries. Agree. @dirrao can you please add

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on PR #36882: URL: https://github.com/apache/airflow/pull/36882#issuecomment-1901190184 It might be worth adding a note in the changelog about this behavior change, so folks can reevaluate if they need to enable/increase retries. -- This is an automated message

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on PR #36882: URL: https://github.com/apache/airflow/pull/36882#issuecomment-1901186517 > Just to clarify this also solves #35792 ? Yes, it would. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-19 Thread via GitHub
eladkal commented on PR #36882: URL: https://github.com/apache/airflow/pull/36882#issuecomment-1901185211 Just to clarify this also solves https://github.com/apache/airflow/issues/35792 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] 36888 Template field support for configmaps [airflow]

2024-01-19 Thread via GitHub
boring-cyborg[bot] commented on PR #36922: URL: https://github.com/apache/airflow/pull/36922#issuecomment-1901165074 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] 36888 Template field support for configmaps [airflow]

2024-01-19 Thread via GitHub
vizeit opened a new pull request, #36922: URL: https://github.com/apache/airflow/pull/36922 --- Currently configmaps are not supported in the template fields in the KubernetesPodOperator. It will be helpful to add this support to dynamically attach configmaps

Re: [PR] [FEATURE] Added oauth support with snowflake sql api operator [airflow]

2024-01-19 Thread via GitHub
eladkal commented on PR #36650: URL: https://github.com/apache/airflow/pull/36650#issuecomment-1901162139 @ighoshsubho it still missing tests and docs. Can you add it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(airflow) branch main updated: Switch to `mongo_conn_id` argument into the MongoHook constructor (#36896)

2024-01-19 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 78b179f0c1 Switch to `mongo_conn_id` argument

Re: [PR] Switch to `mongo_conn_id` argument into the MongoHook constructor [airflow]

2024-01-19 Thread via GitHub
eladkal merged PR #36896: URL: https://github.com/apache/airflow/pull/36896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add extra operator links for EMR Serverless [airflow]

2024-01-19 Thread via GitHub
eladkal commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1901153627 @dacort @o-nikolas is anything else needed or can we merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] Fix providers validation in `check_files.py` after switch to the hatch builds [airflow]

2024-01-19 Thread via GitHub
Taragolis opened a new pull request, #36921: URL: https://github.com/apache/airflow/pull/36921 related: https://github.com/apache/airflow/pull/36902 Just figure out that naming also affected to providers packages ```console ❯ breeze release-management

[I] Scheduler Fails to Schedule Subsequent DagRuns Due to Persistent DAG Record Lock [airflow]

2024-01-19 Thread via GitHub
nookcreed opened a new issue, #36920: URL: https://github.com/apache/airflow/issues/36920 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.7.3 ### What happened? We are

Re: [I] Scheduler Fails to Schedule Subsequent DagRuns Due to Persistent DAG Record Lock [airflow]

2024-01-19 Thread via GitHub
boring-cyborg[bot] commented on issue #36920: URL: https://github.com/apache/airflow/issues/36920#issuecomment-1901120571 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

Re: [PR] Fix assignment of template field in `__init__` in `analyticdb_spark.py` [airflow]

2024-01-19 Thread via GitHub
eladkal merged PR #36911: URL: https://github.com/apache/airflow/pull/36911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(airflow) branch main updated: Fix assignment of template field in `__init__` in `analyticdb_spark.py` (#36911)

2024-01-19 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 98fb11b650 Fix assignment of template field in

Re: [I] RdsDeleteDbInstanceOperator sometimes does not complete when run with `deferrable=True` [airflow]

2024-01-19 Thread via GitHub
o-nikolas commented on issue #35563: URL: https://github.com/apache/airflow/issues/35563#issuecomment-1901053953 I setup your repro dag on latest main and did about 30 RDS DB creations and deferred deletions and could not repro the issue. A lot of the code has changed recently, I

Re: [PR] Improve ExternalTaskSensor Async Implementation [airflow]

2024-01-19 Thread via GitHub
Taragolis commented on code in PR #36916: URL: https://github.com/apache/airflow/pull/36916#discussion_r1459696206 ## airflow/hooks/utils.py: ## @@ -0,0 +1,120 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] Fix typos in descriptions about next release [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on code in PR #36918: URL: https://github.com/apache/airflow/pull/36918#discussion_r1459684225 ## dev/WHAT_GOES_INTO_THE_NEXT_RELEASE.md: ## @@ -50,13 +50,13 @@ The succinct form of it is described in a prominent place in our most important # How does

(airflow) branch main updated: Bump MySQL Innovation Release to 8.3 (#36893)

2024-01-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 888300fa7f Bump MySQL Innovation Release to

Re: [PR] Bump MySQL Innovation Release to 8.3 [airflow]

2024-01-19 Thread via GitHub
jedcunningham merged PR #36893: URL: https://github.com/apache/airflow/pull/36893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix typos in descriptions about next release [airflow]

2024-01-19 Thread via GitHub
jscheffl opened a new pull request, #36918: URL: https://github.com/apache/airflow/pull/36918 Actually came "late to the party" and post-merge reviewed #36858 and found a single "p" as character missing - I wanted to raise my first "single letter PR" but then stumbled about a few more typo

Re: [PR] Update statsd-mapping.yml to support Airflow 2.X pool metrics [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on PR #36305: URL: https://github.com/apache/airflow/pull/36305#issuecomment-1901029005 I fear this breaks backcompat? Am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Fix passing dags.gitSync.sshKeySecret with dags.persistence.enabled=true [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on code in PR #36628: URL: https://github.com/apache/airflow/pull/36628#discussion_r1459645537 ## chart/templates/dag-processor/dag-processor-deployment.yaml: ## Review Comment: I think this was right before. If the dag processor is on, I think it

Re: [I] Add a provider to interact with Microsoft Graph API/SDK [airflow]

2024-01-19 Thread via GitHub
dabla commented on issue #28013: URL: https://github.com/apache/airflow/issues/28013#issuecomment-1901010521 As discussed [here](https://github.com/apache/airflow/discussions/36315), I've implemented such a provider, now it's just a matter how we will proceed. -- This is an automated

Re: [PR] Add Python Virtualenv Operator Caching [airflow]

2024-01-19 Thread via GitHub
jscheffl commented on PR #33355: URL: https://github.com/apache/airflow/pull/33355#issuecomment-1901008359 > @jscheffl > > Import fcntl will cause airflow to be unable to run under windows because fcntl seems to be available only on Linux. > > I can only go back to 2.7.3 in

Re: [PR] Release notes for helm chart 1.12.0 [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on code in PR #36917: URL: https://github.com/apache/airflow/pull/36917#discussion_r1459626801 ## chart/RELEASE_NOTES.rst: ## @@ -23,6 +23,73 @@ Run ``helm repo update`` before upgrading the chart to the latest version. .. towncrier release notes

Re: [PR] Fix assignment of template field in `__init__` in `analyticdb_spark.py` [airflow]

2024-01-19 Thread via GitHub
romsharon98 commented on code in PR #36911: URL: https://github.com/apache/airflow/pull/36911#discussion_r1459619161 ## airflow/providers/alibaba/cloud/operators/analyticdb_spark.py: ## @@ -113,9 +113,6 @@ class AnalyticDBSparkSQLOperator(AnalyticDBSparkBaseOperator):

Re: [PR] Fix assignment of template field in `__init__` in `CloudDataTransferServiceCreateJobOperator` [airflow]

2024-01-19 Thread via GitHub
romsharon98 commented on code in PR #36909: URL: https://github.com/apache/airflow/pull/36909#discussion_r1459606197 ## airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py: ## @@ -236,7 +236,9 @@ def __init__( **kwargs, ) -> None:

Re: [I] Support for configmaps (as env var & volume) in the template fields in the KubernetesPodOperator [airflow]

2024-01-19 Thread via GitHub
vizeit commented on issue #36888: URL: https://github.com/apache/airflow/issues/36888#issuecomment-1900977219 Yes, the change will only be in the KubernetesPodOperator class in the Kubernetes provider package. I meant to say in my comment that if I wanted to incorporate additional template

Re: [PR] Release notes for helm chart 1.12.0 [airflow]

2024-01-19 Thread via GitHub
eladkal commented on code in PR #36917: URL: https://github.com/apache/airflow/pull/36917#discussion_r1459595531 ## chart/RELEASE_NOTES.rst: ## @@ -23,6 +23,73 @@ Run ``helm repo update`` before upgrading the chart to the latest version. .. towncrier release notes start

Re: [PR] Release notes for helm chart 1.12.0 [airflow]

2024-01-19 Thread via GitHub
jedcunningham commented on code in PR #36917: URL: https://github.com/apache/airflow/pull/36917#discussion_r1459589431 ## chart/RELEASE_NOTES.rst: ## @@ -23,6 +23,73 @@ Run ``helm repo update`` before upgrading the chart to the latest version. .. towncrier release notes

Re: [I] Support for configmaps (as env var & volume) in the template fields in the KubernetesPodOperator [airflow]

2024-01-19 Thread via GitHub
RNHTTR commented on issue #36888: URL: https://github.com/apache/airflow/issues/36888#issuecomment-1900968211 Sounds good. I assigned the Issue to you. Feel free to open a PR! The [Contributors Quickstart Guide](https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst)

Re: [I] CVE-2023-46136 Werkzeug==2.2.3 [airflow]

2024-01-19 Thread via GitHub
eladkal commented on issue #36915: URL: https://github.com/apache/airflow/issues/36915#issuecomment-1900956623 See : https://github.com/apache/airflow/blob/056118342b3c28488d20558a1fd3ff15b4934460/pyproject.toml#L151-L153 Thus it depends on completing

Re: [PR] feat: support mysql backend as keda trigger [airflow]

2024-01-19 Thread via GitHub
eladkal commented on PR #36167: URL: https://github.com/apache/airflow/pull/36167#issuecomment-1900951281 static checks are failing @claneys can you fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Release notes for helm chart 1.12.0 [airflow]

2024-01-19 Thread via GitHub
eladkal commented on code in PR #36917: URL: https://github.com/apache/airflow/pull/36917#discussion_r1459565931 ## chart/RELEASE_NOTES.rst: ## @@ -23,6 +23,73 @@ Run ``helm repo update`` before upgrading the chart to the latest version. .. towncrier release notes start

(airflow) branch main updated (66de4bdc9e -> 1119b063af)

2024-01-19 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 66de4bdc9e Update public interface doc re operators (#36767) add 1119b063af Fix assignment of template field in

Re: [PR] Standardize deprecations in providers [part1] [airflow]

2024-01-19 Thread via GitHub
o-nikolas commented on PR #36876: URL: https://github.com/apache/airflow/pull/36876#issuecomment-1900945241 I don't have time to look through this large PR in detail at the moment. But I love the goals of documentation and standardization! +1 -- This is an automated message from the

Re: [PR] Fix assignment of template field in `__init__` in `hive-stats` [airflow]

2024-01-19 Thread via GitHub
eladkal merged PR #36905: URL: https://github.com/apache/airflow/pull/36905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add back envvars for mysql and postgres version options [airflow]

2024-01-19 Thread via GitHub
potiuk commented on PR #36914: URL: https://github.com/apache/airflow/pull/36914#issuecomment-1900897512 > > Need rerun this PR after we merge #36914 > > Haha I wanted to draft and post this message into the #36893, but miss the tab in browser 臘 Yep. Figured it out :) --

[PR] Release notes for helm chart 1.12.0 [airflow]

2024-01-19 Thread via GitHub
jedcunningham opened a new pull request, #36917: URL: https://github.com/apache/airflow/pull/36917 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Improve ExternalTaskSensor Async Implementation [airflow]

2024-01-19 Thread via GitHub
pankajastro opened a new pull request, #36916: URL: https://github.com/apache/airflow/pull/36916 This pull request addresses several differences between the synchronous and asynchronous implementations of ExternalTaskSensor. The changes include: **Soft Failure Handling:** - Added

Re: [PR] Add back envvars for mysql and postgres version options [airflow]

2024-01-19 Thread via GitHub
Taragolis commented on PR #36914: URL: https://github.com/apache/airflow/pull/36914#issuecomment-1900875011 > Need rerun this PR after we merge https://github.com/apache/airflow/pull/36914 Haha I wanted to draft and post this message into the

Re: [PR] Airflow 2.8.1 has been released [airflow]

2024-01-19 Thread via GitHub
potiuk commented on code in PR #36906: URL: https://github.com/apache/airflow/pull/36906#discussion_r1459451221 ## newsfragments/config.toml: ## @@ -16,7 +16,7 @@ # under the License. [tool.towncrier] name = "Airflow" -filename = "../RELEASE_NOTES.rst" +filename =

(airflow) branch main updated: Update public interface doc re operators (#36767)

2024-01-19 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 66de4bdc9e Update public interface doc re

Re: [PR] Update public interface doc re operators [airflow]

2024-01-19 Thread via GitHub
dstandish merged PR #36767: URL: https://github.com/apache/airflow/pull/36767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add back envvars for mysql and postgres version options [airflow]

2024-01-19 Thread via GitHub
potiuk commented on PR #36914: URL: https://github.com/apache/airflow/pull/36914#issuecomment-1900841211 Luckily - nothing broken in neither of the versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(airflow) branch main updated: Add back envvars for mysql and postgres version options (#36914)

2024-01-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fba05db438 Add back envvars for mysql and postgres

Re: [PR] Add back envvars for mysql and postgres version options [airflow]

2024-01-19 Thread via GitHub
potiuk merged PR #36914: URL: https://github.com/apache/airflow/pull/36914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add back envvars for mysql and postgres version options [airflow]

2024-01-19 Thread via GitHub
potiuk commented on PR #36914: URL: https://github.com/apache/airflow/pull/36914#issuecomment-1900838662 Thanks @Taragolis for noticing it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add back envvars for mysql and postgres version options [airflow]

2024-01-19 Thread via GitHub
Taragolis commented on PR #36914: URL: https://github.com/apache/airflow/pull/36914#issuecomment-1900836640 - Need rerun this PR after we merge https://github.com/apache/airflow/pull/36914 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Airflow 2.8.1 has been released [airflow]

2024-01-19 Thread via GitHub
dirrao commented on code in PR #36906: URL: https://github.com/apache/airflow/pull/36906#discussion_r1459409994 ## newsfragments/config.toml: ## @@ -16,7 +16,7 @@ # under the License. [tool.towncrier] name = "Airflow" -filename = "../RELEASE_NOTES.rst" +filename =

Re: [PR] Fix assignment of template field in `__init__` in `CloudDataTransferServiceCreateJobOperator` [airflow]

2024-01-19 Thread via GitHub
dirrao commented on code in PR #36909: URL: https://github.com/apache/airflow/pull/36909#discussion_r1459398758 ## airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py: ## @@ -236,7 +236,9 @@ def __init__( **kwargs, ) -> None:

(airflow) branch main updated: Chart: update newsfragment pr number (#36913)

2024-01-19 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4b8646a3ec Chart: update newsfragment pr

Re: [PR] Chart: update newsfragment pr number [airflow]

2024-01-19 Thread via GitHub
jedcunningham merged PR #36913: URL: https://github.com/apache/airflow/pull/36913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Support for configmaps (as env var & volume) in the template fields in the KubernetesPodOperator [airflow]

2024-01-19 Thread via GitHub
vizeit commented on issue #36888: URL: https://github.com/apache/airflow/issues/36888#issuecomment-1900785224 @RNHTTR exisiting parameters configmaps and volumes for configmaps do not suffice. If the configmaps are dynamically created in a DAG with the name of configmaps template based, k8

Re: [I] Airflow 2.8.1 contains migration requiring SQLAlchemy 2+ [airflow]

2024-01-19 Thread via GitHub
Tenzer commented on issue #36912: URL: https://github.com/apache/airflow/issues/36912#issuecomment-1900780574 What a bizarre setup. I guess I'll have to see if I can somehow get that shoehorned into how we manage dependencies. Thank you for the pointer. -- This is an automated message

Re: [I] Airflow 2.8.1 contains migration requiring SQLAlchemy 2+ [airflow]

2024-01-19 Thread via GitHub
Taragolis closed issue #36912: Airflow 2.8.1 contains migration requiring SQLAlchemy 2+ URL: https://github.com/apache/airflow/issues/36912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Airflow 2.8.1 contains migration requiring SQLAlchemy 2+ [airflow]

2024-01-19 Thread via GitHub
Taragolis commented on issue #36912: URL: https://github.com/apache/airflow/issues/36912#issuecomment-1900772724 You need to install Airflow by provide constraints for specific Airflow and Python versions, for example in your case ```console pip install "apache-airflow==2.8.1”

  1   2   >