Re: [PR] Add dataset create endpoint [airflow]

2024-01-25 Thread via GitHub
edumuellerFSL commented on PR #36929: URL: https://github.com/apache/airflow/pull/36929#issuecomment-1911623991 > I think this one should hold before we conclude https://lists.apache.org/thread/q4sd09xymvlskxdgcb1s6gfsqwnvqs2o discussion (so I am doing "Request changes" unti it does - and

(airflow-site) branch gh-pages updated (e5ce674fea -> fa3edae353)

2024-01-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git discard e5ce674fea Rewritten history to remove past gh-pages deployments new fa3edae353 Rewritten history to

Re: [I] Add "airflow users change-user-password" [airflow]

2024-01-25 Thread via GitHub
ecerulm commented on issue #37009: URL: https://github.com/apache/airflow/issues/37009#issuecomment-1911607897 > Or you can use API or **Web UI**. I was trying to do it via the **Web UI** but I could find a way to change the password of another user. I tried via Security >

Re: [PR] Add docs for RC2 wave of providers for 2nd round of Jan 2024 [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #37019: URL: https://github.com/apache/airflow/pull/37019#issuecomment-1911607149 I will send the new wave in ~ 2 hrs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add docs for RC2 wave of providers for 2nd round of Jan 2024 [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #37019: URL: https://github.com/apache/airflow/pull/37019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add docs for RC2 wave of providers for 2nd round of Jan 2024 [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #37019: URL: https://github.com/apache/airflow/pull/37019#discussion_r1467304964 ## airflow/providers/microsoft/azure/CHANGELOG.rst: ## @@ -38,6 +38,18 @@ Breaking changes ``WasbPrefixSensorTrigger``. These params will now need to passed

[I] missing macro disable airflow variable masking [airflow]

2024-01-25 Thread via GitHub
raphaelauv opened a new issue, #37023: URL: https://github.com/apache/airflow/issues/37023 ### Apache Airflow version 2.8.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? when a macro is missing the masking is disable

(airflow-site) branch main updated: Update PMC members and Committers, sort by name as well (#943)

2024-01-25 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 33fc94532a Update PMC members and

Re: [PR] Update PMC members and Committers, sort by name as well [airflow-site]

2024-01-25 Thread via GitHub
jscheffl merged PR #943: URL: https://github.com/apache/airflow-site/pull/943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] bump: kubernetes client version [airflow]

2024-01-25 Thread via GitHub
raphaelauv commented on PR #36684: URL: https://github.com/apache/airflow/pull/36684#issuecomment-1911595484 @potiuk I'm not available to finish this PR in the next days , should I close it ? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add docs for RC2 wave of providers for 2nd round of Jan 2024 [airflow]

2024-01-25 Thread via GitHub
eladkal commented on code in PR #37019: URL: https://github.com/apache/airflow/pull/37019#discussion_r1467242588 ## airflow/providers/microsoft/azure/CHANGELOG.rst: ## @@ -38,6 +38,18 @@ Breaking changes ``WasbPrefixSensorTrigger``. These params will now need to passed

Re: [PR] Add docs for RC2 wave of providers for 2nd round of Jan 2024 [airflow]

2024-01-25 Thread via GitHub
eladkal commented on code in PR #37019: URL: https://github.com/apache/airflow/pull/37019#discussion_r1467242588 ## airflow/providers/microsoft/azure/CHANGELOG.rst: ## @@ -38,6 +38,18 @@ Breaking changes ``WasbPrefixSensorTrigger``. These params will now need to passed

Re: [PR] Added ability to enable/disable scheduler and webserver [airflow]

2024-01-25 Thread via GitHub
kajanajustin commented on PR #36991: URL: https://github.com/apache/airflow/pull/36991#issuecomment-1911437953 @hussein-awala @potiuk added additional unit tests, let me know if there's anything else you guys need to see -- This is an automated message from the Apache Git Service. To

Re: [I] Add a log callback option within Task Instances [airflow]

2024-01-25 Thread via GitHub
JamesTreap commented on issue #36964: URL: https://github.com/apache/airflow/issues/36964#issuecomment-1911369363 It does, but also forces me to expose API GET endpoints by setting the api.auth.backend to basic_auth or rolling my own API authentication. I'd rather have it block all API

Re: [PR] Enable '_enable_tcp_keepalive' functionality for GKEPodHook [airflow]

2024-01-25 Thread via GitHub
dirrao commented on code in PR #36999: URL: https://github.com/apache/airflow/pull/36999#discussion_r1467188026 ## airflow/providers/google/cloud/hooks/kubernetes_engine.py: ## @@ -352,6 +353,7 @@ def __init__( self, cluster_url: str, ssl_ca_cert:

Re: [PR] Remove superfluous `@Sentry.enrich_errors` [airflow]

2024-01-25 Thread via GitHub
dirrao commented on PR #37002: URL: https://github.com/apache/airflow/pull/37002#issuecomment-1911338131 > @dirrao Thank you for taking a look. The static and mypy failure appear completely unrelated to this change, so I'm wondering if it should fall in the scope of this PR. Also, I

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

2024-01-25 Thread via GitHub
RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467174201 ## airflow/utils/context.py: ## @@ -59,6 +59,7 @@ "inlets", "logical_date", "macros", +"map_index_template", Review Comment: If

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

2024-01-25 Thread via GitHub
RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467172568 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator:

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

2024-01-25 Thread via GitHub
RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467172568 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator:

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

2024-01-25 Thread via GitHub
RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467173302 ## airflow/models/taskinstance.py: ## @@ -2502,6 +2510,7 @@ def signal_handler(signum, frame): # Execute the task with

Re: [PR] draft for map_index_template to overwrite map_index in the UI [airflow]

2024-01-25 Thread via GitHub
RNHTTR commented on code in PR #36797: URL: https://github.com/apache/airflow/pull/36797#discussion_r1467172568 ## airflow/serialization/serialized_objects.py: ## @@ -1098,6 +1098,7 @@ def deserialize_operator(cls, encoded_op: dict[str, Any]) -> Operator:

[I] Airflow 2.7 to 2.8 upgrade failure [airflow]

2024-01-25 Thread via GitHub
AlekseiSaff opened a new issue, #37021: URL: https://github.com/apache/airflow/issues/37021 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.7.3 ### What happened? after

Re: [I] Status of testing Providers that were prepared on January 22, 2024 [airflow]

2024-01-25 Thread via GitHub
vizeit commented on issue #36948: URL: https://github.com/apache/airflow/issues/36948#issuecomment-1911286628 > > @potiuk would re-releasing RC2 include cncf.Kubernetes provider? @eladkal said in his last comment for my PR #37001 that he will not release rc2 but include it in the next

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #36969: URL: https://github.com/apache/airflow/pull/36969#issuecomment-1911263008 Addressed @jscheffl comments. I target to merge it tomorrow - more comments welcome :) -- This is an automated message from the Apache Git Service. To respond to the message, please

(airflow) branch refactor-contributing-docs updated (7c40f9b28b -> 91eaeb8194)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch refactor-contributing-docs in repository https://gitbox.apache.org/repos/asf/airflow.git discard 7c40f9b28b Apply suggestions from code review discard c486aac039 Split contributing docs to

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1467138182 ## contributing-docs/testing/unit_tests.rst: ## @@ -0,0 +1,1160 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1467137828 ## contributing-docs/testing/unit_tests.rst: ## @@ -0,0 +1,1160 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [I] Dependency Issue with apache-airflow-providers-fab [airflow]

2024-01-25 Thread via GitHub
boring-cyborg[bot] commented on issue #37020: URL: https://github.com/apache/airflow/issues/37020#issuecomment-1911257442 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[I] Dependency Issue with apache-airflow-providers-fab [airflow]

2024-01-25 Thread via GitHub
aashishshrestha09 opened a new issue, #37020: URL: https://github.com/apache/airflow/issues/37020 ### Apache Airflow Provider(s) fab ### Versions of Apache Airflow Providers `apache-airflow-providers-fab==1.0.0` ### Apache Airflow version 2.8.1 ###

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1467135204 ## contributing-docs/testing/unit_tests.rst: ## @@ -0,0 +1,1160 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1467134116 ## contributing-docs/02_how_to_communicate.rst: ## @@ -0,0 +1,152 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1467133611 ## contributing-docs/02_how_to_communicate.rst: ## @@ -0,0 +1,152 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1467133169 ## contributing-docs/02_how_to_communicate.rst: ## @@ -0,0 +1,152 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license

(airflow) branch refactor-contributing-docs updated (c486aac039 -> 7c40f9b28b)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch refactor-contributing-docs in repository https://gitbox.apache.org/repos/asf/airflow.git from c486aac039 Split contributing docs to multiple files add 7c40f9b28b Apply suggestions from

Re: [PR] Add docs for RC2 wave of providers for 2nd round of Jan 2024 [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #37019: URL: https://github.com/apache/airflow/pull/37019#issuecomment-1911225690 Smaller set of providers (because reverting : https://github.com/apache/airflow/assets/595491/e0ad0cac-f78b-4e47-b42e-d2ecc9f2fc4d;> -- This is an automated message

Re: [I] Status of testing Providers that were prepared on January 22, 2024 [airflow]

2024-01-25 Thread via GitHub
potiuk commented on issue #36948: URL: https://github.com/apache/airflow/issues/36948#issuecomment-1911225442 > @potiuk would re-releasing RC2 include cncf.Kubernetes provider? @eladkal said in his last comment for my PR #37001 that he will not release rc2 but include it in the next wave.

(airflow) branch main updated: 36888-Fix k8 configmap issue in 7.14.0rc1 (#37001)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dd627d7f46 36888-Fix k8 configmap issue in

Re: [PR] Fix dynamic configmaps as environment variable in `KubernetesPodOperator` [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #37001: URL: https://github.com/apache/airflow/pull/37001#discussion_r1467114814 ## tests/providers/cncf/kubernetes/operators/test_pod.py: ## @@ -179,7 +179,7 @@ def test_templates(self, create_task_instance_of_operator): assert dag_id ==

Re: [PR] Fix dynamic configmaps as environment variable in `KubernetesPodOperator` [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #37001: URL: https://github.com/apache/airflow/pull/37001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Add docs for RC2 wave of providers for 2nd round of Jan 2024 [airflow]

2024-01-25 Thread via GitHub
potiuk opened a new pull request, #37019: URL: https://github.com/apache/airflow/pull/37019 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [I] Status of testing Providers that were prepared on January 22, 2024 [airflow]

2024-01-25 Thread via GitHub
vizeit commented on issue #36948: URL: https://github.com/apache/airflow/issues/36948#issuecomment-1911202904 @potiuk would re-releasing RC2 include cncf.Kubernetes provider? @eladkal said in his last comment for my PR #37001 that he will not release rc2 but include it in the next wave.

Re: [PR] feat: SQLExecuteQueryOperator sql_callable [airflow]

2024-01-25 Thread via GitHub
github-actions[bot] commented on PR #35844: URL: https://github.com/apache/airflow/pull/35844#issuecomment-1911201949 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

(airflow) branch constraints-main updated: Updating constraints. Github run id:7661612528

2024-01-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new d79a182415 Updating

Re: [I] Status of testing Providers that were prepared on January 22, 2024 [airflow]

2024-01-25 Thread via GitHub
potiuk commented on issue #36948: URL: https://github.com/apache/airflow/issues/36948#issuecomment-1911145363 @eladkal asked me to take over from here as he is flying tonight. I thought a bit about it and agree with @Taragolis that reverting #36675 is the best way to approach this -

(airflow) branch main updated: Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" (#37015)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0b680c9492 Revert "Provide the logger_name param

Re: [PR] Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #37015: URL: https://github.com/apache/airflow/pull/37015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #37015: URL: https://github.com/apache/airflow/pull/37015#issuecomment-1911143165 Yeah. I thought a bit about it and I think reverting is the fastest and most secure way. This way we can release RC2 now, and properly get it implemented and tested. There are a bit

(airflow) branch refactor-contributing-docs updated (1d0a3d2d8e -> c486aac039)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch refactor-contributing-docs in repository https://gitbox.apache.org/repos/asf/airflow.git omit 1d0a3d2d8e Split contributing docs to multiple files add 6a210c65a0 Add a note to also

Re: [I] Bold and increase font-size of graph task headers [airflow]

2024-01-25 Thread via GitHub
bbovenzi commented on issue #36557: URL: https://github.com/apache/airflow/issues/36557#issuecomment-1911035783 Yes it would be fun to be able to display more useful info like that while also having a simpler view too. Rough WIP:

(airflow) branch main updated: Add a cross reference to security policy (#37004)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fc2271a469 Add a cross reference to security

Re: [PR] Add a cross reference to security policy [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #37004: URL: https://github.com/apache/airflow/pull/37004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add a cross reference to security policy [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #37004: URL: https://github.com/apache/airflow/pull/37004#issuecomment-1911034583 Let me merge it now. I will rebase mine and make sure to move it around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

(airflow) branch main updated: Add a note to also update committers list in airflow-site repo (#37017)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6a210c65a0 Add a note to also update committers

Re: [PR] Add a note to also update committers list in airflow-site repo [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #37017: URL: https://github.com/apache/airflow/pull/37017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Bold and increase font-size of graph task headers [airflow]

2024-01-25 Thread via GitHub
NilsJPWerner commented on issue #36557: URL: https://github.com/apache/airflow/issues/36557#issuecomment-1911033285 That's a good idea! I was thinking that running tasks could dynamically display their current run time as well. You could also have some sort of progress indicator that

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466984316 ## generated/PYPI_README.md: ## @@ -163,11 +163,20 @@ release provided they have access to the appropriate platform and tools. ## Contributing -Want to help

(airflow) branch refactor-contributing-docs updated (b1bb62d350 -> 1d0a3d2d8e)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch refactor-contributing-docs in repository https://gitbox.apache.org/repos/asf/airflow.git discard b1bb62d350 Split contributing docs to multiple files add 1d0a3d2d8e Split contributing docs

Re: [I] Add "airflow users change-user-password" [airflow]

2024-01-25 Thread via GitHub
potiuk commented on issue #37009: URL: https://github.com/apache/airflow/issues/37009#issuecomment-1911017541 Or you can use API or Web UI. But yes CLI command would be useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
jscheffl commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466962083 ## generated/PYPI_README.md: ## @@ -163,11 +163,20 @@ release provided they have access to the appropriate platform and tools. ## Contributing -Want to help

Re: [I] Bold and increase font-size of graph task headers [airflow]

2024-01-25 Thread via GitHub
bbovenzi commented on issue #36557: URL: https://github.com/apache/airflow/issues/36557#issuecomment-1910996926 We got rid of most of graph.css. It's all in https://github.com/apache/airflow/tree/main/airflow/www/static/js/dag/details/graph now. We can definitely make the name

[PR] Use execution_date= param as a backup to base date for grid view [airflow]

2024-01-25 Thread via GitHub
bbovenzi opened a new pull request, #37018: URL: https://github.com/apache/airflow/pull/37018 Helps to fix https://github.com/apache/airflow/issues/34723 and can coexist with #34887 Use the execution_date param, already sent as a link in the browse -> dagruns / task instances, as a

Re: [PR] Handle SystemExit raised in the task. [airflow]

2024-01-25 Thread via GitHub
avkirilishin commented on code in PR #36986: URL: https://github.com/apache/airflow/pull/36986#discussion_r1466938501 ## airflow/models/taskinstance.py: ## @@ -2393,6 +2393,12 @@ def _run_raw_task( self.handle_failure(e, test_mode, context, session=session)

(airflow) branch refactor-contributing-docs updated (480e886f3c -> b1bb62d350)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch refactor-contributing-docs in repository https://gitbox.apache.org/repos/asf/airflow.git omit 480e886f3c Split contributing docs to multiple files add e9a4bcaa16 Improve

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466935091 ## COMMITTERS.rst: ## @@ -15,14 +15,39 @@ specific language governing permissions and limitations under the License. +Committers and PMC members

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466932570 ## generated/PYPI_README.md: ## @@ -163,11 +163,20 @@ release provided they have access to the appropriate platform and tools. ## Contributing -Want to help

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466931569 ## generated/PYPI_README.md: ## @@ -163,11 +163,20 @@ release provided they have access to the appropriate platform and tools. ## Contributing -Want to help

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466931569 ## generated/PYPI_README.md: ## @@ -163,11 +163,20 @@ release provided they have access to the appropriate platform and tools. ## Contributing -Want to help

Re: [PR] k8s spark operator compatibility [airflow]

2024-01-25 Thread via GitHub
blcksrx commented on PR #36268: URL: https://github.com/apache/airflow/pull/36268#issuecomment-1910942786 @potiuk I see a lot of changes, It gonna check it during the weekened -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466918029 ## RELEASE_NOTES.rst: ## @@ -8279,7 +8279,7 @@ Doc only changes - [AIRFLOW-] Add Updating.md section for 1.10.9 (#7385) - [AIRFLOW-] Remove duplication in

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
jscheffl commented on code in PR #36969: URL: https://github.com/apache/airflow/pull/36969#discussion_r1466910031 ## COMMITTERS.rst: ## @@ -15,14 +15,39 @@ specific language governing permissions and limitations under the License. +Committers and PMC members

[PR] Add a note to also update committers list in airflow-site repo [airflow]

2024-01-25 Thread via GitHub
jscheffl opened a new pull request, #37017: URL: https://github.com/apache/airflow/pull/37017 As I was missing to update airflow-site repo after getting a comitter and nobody else did this... adding a note such that it is not forgotten for new committers. -- This is an automated message

[PR] DRAFT Add conditional logic for dataset triggering [airflow]

2024-01-25 Thread via GitHub
dstandish opened a new pull request, #37016: URL: https://github.com/apache/airflow/pull/37016 draft -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Update PMC members and Committers, sort by name as well [airflow-site]

2024-01-25 Thread via GitHub
jscheffl opened a new pull request, #943: URL: https://github.com/apache/airflow-site/pull/943 I realized that my name is missing in committers list. Double checked the list of PMC members and committers from / via https://home.apache.org/committers-by-project.html#airflow Also I

Re: [PR] Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" [airflow]

2024-01-25 Thread via GitHub
hussein-awala commented on PR #37015: URL: https://github.com/apache/airflow/pull/37015#issuecomment-1910890170 I know it's faster, but with a simple reset soft for the revert commit, we can easily exclude the classes where it's not provided explicitly, wdyt? -- This is an automated

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-25 Thread via GitHub
jedcunningham commented on code in PR #36882: URL: https://github.com/apache/airflow/pull/36882#discussion_r1466816732 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -434,9 +434,9 @@ def sync(self) -> None: )

Re: [PR] The task is stuck in a queued state forever in case of pod launch errors [airflow]

2024-01-25 Thread via GitHub
jedcunningham commented on code in PR #36882: URL: https://github.com/apache/airflow/pull/36882#discussion_r1466816732 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -434,9 +434,9 @@ def sync(self) -> None: )

[PR] Revert "Provide the logger_name param in providers hooks in order to override the logger name (#36675)" [airflow]

2024-01-25 Thread via GitHub
Taragolis opened a new pull request, #37015: URL: https://github.com/apache/airflow/pull/37015 related: https://github.com/apache/airflow/issues/36948#issuecomment-1910279616 We need to properly sanitise `logger_name` from hook `kwargs` in case of if Airflow < 2.8

Re: [PR] Remove superfluous `@Sentry.enrich_errors` [airflow]

2024-01-25 Thread via GitHub
jkramer-ginkgo commented on PR #37002: URL: https://github.com/apache/airflow/pull/37002#issuecomment-1910775939 @dirrao Thank you for taking a look. The static and mypy failure appear completely unrelated to this change, so I'm wondering if it should fall in the scope of this PR. Also, I

Re: [I] Status of testing Providers that were prepared on January 22, 2024 [airflow]

2024-01-25 Thread via GitHub
Taragolis commented on issue #36948: URL: https://github.com/apache/airflow/issues/36948#issuecomment-1910768076 Then we need to add this fix into the all providers affected by https://github.com/apache/airflow/pull/36675 (all?) or revert it for now. Depend on what is faster. In any cases

Re: [PR] ECS Executor - add support to adopt orphaned tasks. [airflow]

2024-01-25 Thread via GitHub
ferruzzi commented on code in PR #36803: URL: https://github.com/apache/airflow/pull/36803#discussion_r1466752754 ## airflow/jobs/scheduler_job_runner.py: ## @@ -721,6 +721,7 @@ def _process_executor_events(self, session: Session) -> int: if state ==

(airflow) branch main updated: Making links in task logs as hyperlinks by preventing HTML injection (#36829)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6629e2bf7b Making links in task logs as hyperlinks

Re: [PR] Making links in task logs as hyperlinks by preventing HTML injection [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #36829: URL: https://github.com/apache/airflow/pull/36829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #36969: URL: https://github.com/apache/airflow/pull/36969#issuecomment-1910726777 > You know... I've usually done the build-docs to verify the formatting and stuff, then used those generated docs to verify the links I don't think it has occurred to me to try them

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
ferruzzi commented on PR #36969: URL: https://github.com/apache/airflow/pull/36969#issuecomment-1910722652 You know... I've usually done the build-docs to verify the formatting and stuff, then used those generated docs to verify the links I don't think it has occurred to me to try

(airflow) branch main updated (10ad8d9e38 -> 8fd9fdb812)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 10ad8d9e38 Add operator to diagnose cluster (#36899) add 8fd9fdb812 Updated config.yml for environment variable

Re: [PR] Updated config.yml for environment variable sql_alchemy_connect_args [airflow]

2024-01-25 Thread via GitHub
boring-cyborg[bot] commented on PR #36526: URL: https://github.com/apache/airflow/pull/36526#issuecomment-1910719851 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Updated config.yml for environment variable sql_alchemy_connect_args [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #36526: URL: https://github.com/apache/airflow/pull/36526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Updated config.yml for environment variable sql_alchemy_connect_args [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36526: URL: https://github.com/apache/airflow/pull/36526#discussion_r1466743415 ## airflow/config_templates/config.yml: ## @@ -583,11 +583,15 @@ database: description: | Import path for connect args in SqlAlchemy. Defaults to an

Re: [PR] Split contributing docs to multiple files [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #36969: URL: https://github.com/apache/airflow/pull/36969#issuecomment-1910702781 > I did not try to generate the docs and click through all the links to verify them; they look good in code but has anyone tried that yet? They do not need generation @ferruzzi

Re: [I] Kubernetes Executor Task Leak [airflow]

2024-01-25 Thread via GitHub
smhood commented on issue #36998: URL: https://github.com/apache/airflow/issues/36998#issuecomment-1910695514 Also we are creating our own airflow image off and importing our dags there: Dockerfile: ``` FROM apache/airflow:2.8.1-python3.11 USER root RUN apt-get update &&

Re: [PR] Fix assignment of template field in `__init__` in `KubernetesPodOperator` [airflow]

2024-01-25 Thread via GitHub
romsharon98 commented on code in PR #37010: URL: https://github.com/apache/airflow/pull/37010#discussion_r1466723684 ## airflow/providers/cncf/kubernetes/operators/pod.py: ## @@ -245,9 +245,9 @@ def __init__( cmds: list[str] | None = None, arguments: list[str]

Re: [PR] Fix pre-mature evaluation of tasks in mapped task group [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #36462: URL: https://github.com/apache/airflow/pull/36462#issuecomment-1910689533 cc: @uranusjr - following discussion in #35541 - do you think that one should fix the problem ? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] bump: kubernetes client version [airflow]

2024-01-25 Thread via GitHub
dirrao commented on code in PR #36684: URL: https://github.com/apache/airflow/pull/36684#discussion_r1466714225 ## generated/provider_dependencies.json: ## @@ -280,8 +280,8 @@ "asgiref>=3.5.2", "cryptography>=2.0.0", "google-re2>=1.0", -

Re: [PR] Handle SystemExit raised in the task. [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36986: URL: https://github.com/apache/airflow/pull/36986#discussion_r1466708415 ## airflow/models/taskinstance.py: ## @@ -2393,6 +2393,12 @@ def _run_raw_task( self.handle_failure(e, test_mode, context, session=session)

Re: [PR] Handle SystemExit raised in the task. [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36986: URL: https://github.com/apache/airflow/pull/36986#discussion_r1466708415 ## airflow/models/taskinstance.py: ## @@ -2393,6 +2393,12 @@ def _run_raw_task( self.handle_failure(e, test_mode, context, session=session)

Re: [PR] Handle SystemExit raised in the task. [airflow]

2024-01-25 Thread via GitHub
potiuk commented on code in PR #36986: URL: https://github.com/apache/airflow/pull/36986#discussion_r1466708415 ## airflow/models/taskinstance.py: ## @@ -2393,6 +2393,12 @@ def _run_raw_task( self.handle_failure(e, test_mode, context, session=session)

Re: [PR] bump: kubernetes client version [airflow]

2024-01-25 Thread via GitHub
potiuk commented on PR #36684: URL: https://github.com/apache/airflow/pull/36684#issuecomment-1910646122 Hmm @raphaelauv - are you planning to update it ? Seems that we do need to bump min-version of the k8s client - see #37008 -- This is an automated message from the Apache Git

(airflow) branch main updated: Add operator to diagnose cluster (#36899)

2024-01-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 10ad8d9e38 Add operator to diagnose cluster

Re: [PR] Add operator to collect diagnostic tarball for Dataproc cluster [airflow]

2024-01-25 Thread via GitHub
boring-cyborg[bot] commented on PR #36899: URL: https://github.com/apache/airflow/pull/36899#issuecomment-1910634242 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [PR] Add operator to collect diagnostic tarball for Dataproc cluster [airflow]

2024-01-25 Thread via GitHub
potiuk merged PR #36899: URL: https://github.com/apache/airflow/pull/36899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >