Re: [PR] fix spark-kubernetes-operator compatibility [airflow]

2024-02-16 Thread via GitHub
sudohainguyen commented on PR #31798: URL: https://github.com/apache/airflow/pull/31798#issuecomment-1947943882 hey @blcksrx I just got an issue when my SparkApp completed but never reached `SparkApplicationCompleted` reason, the airflow task is stuck into infinite loop until it gets 410 er

[PR] Prepare docs 1st wave (RC2) of Providers February 2024 [airflow]

2024-02-16 Thread via GitHub
eladkal opened a new pull request, #37471: URL: https://github.com/apache/airflow/pull/37471 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Introduce new config variable to control whether DAG processor outputs to stdout [airflow]

2024-02-16 Thread via GitHub
Owen-CH-Leung commented on code in PR #37439: URL: https://github.com/apache/airflow/pull/37439#discussion_r1492152298 ## tests/dag_processing/test_job_runner.py: ## @@ -1460,3 +1460,20 @@ def test_launch_process(self): processor_agent._process.join() assert

Re: [PR] Update overview.rst [airflow]

2024-02-16 Thread via GitHub
boring-cyborg[bot] commented on PR #37472: URL: https://github.com/apache/airflow/pull/37472#issuecomment-1947993320 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Update overview.rst [airflow]

2024-02-16 Thread via GitHub
dinesh-venkata opened a new pull request, #37472: URL: https://github.com/apache/airflow/pull/37472 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests

Re: [PR] Add Python Virtualenv Operator Caching [airflow]

2024-02-16 Thread via GitHub
mullenpaul commented on PR #33355: URL: https://github.com/apache/airflow/pull/33355#issuecomment-1948007866 This PR uses the fcntl package which is simply not supported on Windows. Before 2.8 I could run pytest on my code and now it fails as it can't find the library. I was also abl

Re: [I] Kubernetes executor pod reconcilation is slow due to recurssive deep copy [airflow]

2024-02-16 Thread via GitHub
dirrao commented on issue #37131: URL: https://github.com/apache/airflow/issues/37131#issuecomment-1948010409 Can you share any python utilities that we can use to try out the copy-on-write and see if that works? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Fix Airflow serialization for namedtuple [airflow]

2024-02-16 Thread via GitHub
bolkedebruin commented on PR #37168: URL: https://github.com/apache/airflow/pull/37168#issuecomment-1948021295 > We do need to specify the classname, which should be "builtins.tuple": > > The `serialize` method (in [airflow/serialization/serializers/builtin.py](https://github.com/apac

[PR] Replace usage of `datetime.utcnow` and `datetime.utcfromtimestamp` in dev [airflow]

2024-02-16 Thread via GitHub
Taragolis opened a new pull request, #37473: URL: https://github.com/apache/airflow/pull/37473 closes: https://github.com/apache/airflow/issues/32344 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/air

Re: [PR] Replace usage of `datetime.utcnow` and `datetime.utcfromtimestamp` in dev [airflow]

2024-02-16 Thread via GitHub
pankajkoti commented on code in PR #37473: URL: https://github.com/apache/airflow/pull/37473#discussion_r1492188899 ## pyproject.toml: ## @@ -1468,6 +1468,9 @@ banned-module-level-imports = ["numpy", "pandas"] "airflow.AirflowException".msg = "Use airflow.exceptions.AirflowExce

Re: [PR] Replace usage of `datetime.utcnow` and `datetime.utcfromtimestamp` in dev [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on code in PR #37473: URL: https://github.com/apache/airflow/pull/37473#discussion_r1492192259 ## pyproject.toml: ## @@ -1468,6 +1468,9 @@ banned-module-level-imports = ["numpy", "pandas"] "airflow.AirflowException".msg = "Use airflow.exceptions.AirflowExcep

Re: [PR] Add Python Virtualenv Operator Caching [airflow]

2024-02-16 Thread via GitHub
potiuk commented on PR #33355: URL: https://github.com/apache/airflow/pull/33355#issuecomment-1948115779 > This PR uses the fcntl package which is simply not supported on Windows. Before 2.8 I could run pytest on my code and now it fails as it can't find the library. > > I was also a

Re: [PR] starting triggerer for system-tests [airflow]

2024-02-16 Thread via GitHub
Bowrna commented on PR #36236: URL: https://github.com/apache/airflow/pull/36236#issuecomment-1948136087 i will reopen the issue after adding simple test with free tier of AWS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Kubernetes executor pod reconcilation is slow due to recurssive deep copy [airflow]

2024-02-16 Thread via GitHub
potiuk commented on issue #37131: URL: https://github.com/apache/airflow/issues/37131#issuecomment-1948137100 We are talking unix/posix/os fork here - not any python-level library - same as we do in DagFileProcessor to parse DAGs and TaskRunner already to run our tasks - for very similar r

[PR] add reuse_existing_run for allowing DbtCloudRunJobOperator to reuse existing run [airflow]

2024-02-16 Thread via GitHub
Lee-W opened a new pull request, #37474: URL: https://github.com/apache/airflow/pull/37474 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#

Re: [PR] Update overview.rst [airflow]

2024-02-16 Thread via GitHub
boring-cyborg[bot] commented on PR #37472: URL: https://github.com/apache/airflow/pull/37472#issuecomment-1948146248 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

(airflow) branch main updated (9f4f8b3553 -> 5ad1e7801f)

2024-02-16 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 9f4f8b3553 Add environment var example to mssql.rst (#37418) add 5ad1e7801f Update overview.rst (#37472) No new r

Re: [PR] Update overview.rst [airflow]

2024-02-16 Thread via GitHub
potiuk merged PR #37472: URL: https://github.com/apache/airflow/pull/37472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Fix GCSSynchronizeBucketsOperator timeout error [airflow]

2024-02-16 Thread via GitHub
potiuk merged PR #37237: URL: https://github.com/apache/airflow/pull/37237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] GCSSynchronizeBucketsOperator fails on 30-second timeout on large files [airflow]

2024-02-16 Thread via GitHub
potiuk closed issue #27488: GCSSynchronizeBucketsOperator fails on 30-second timeout on large files URL: https://github.com/apache/airflow/issues/27488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Fix GCSSynchronizeBucketsOperator timeout error [airflow]

2024-02-16 Thread via GitHub
potiuk commented on code in PR #37237: URL: https://github.com/apache/airflow/pull/37237#discussion_r1492285015 ## airflow/providers/google/cloud/hooks/gcs.py: ## @@ -1295,37 +1300,45 @@ def _prepare_sync_plan( destination_object: str | None, recursive: bool,

(airflow) branch main updated: Fix GCSSynchronizeBucketsOperator timeout error (#37237)

2024-02-16 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 123b656151 Fix GCSSynchronizeBucketsOperator timeou

Re: [PR] add type annotations to Amazon provider "execute_coplete" methods [airflow]

2024-02-16 Thread via GitHub
potiuk merged PR #36330: URL: https://github.com/apache/airflow/pull/36330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: add type annotations to Amazon provider "execute_coplete" methods (#36330)

2024-02-16 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c75a105935 add type annotations to Amazon provider

[I] Alert / sound when a task or a dag completes [airflow]

2024-02-16 Thread via GitHub
tim-habitat opened a new issue, #37475: URL: https://github.com/apache/airflow/issues/37475 ### Description it would be nice to have the web app play a sound notification when a task or a dag completes ### Use case/motivation sometime we would start a dag manually and wo

Re: [I] Airflow Python 3.12 support [airflow]

2024-02-16 Thread via GitHub
Froskekongen commented on issue #36546: URL: https://github.com/apache/airflow/issues/36546#issuecomment-1948208989 Any progress on this @dirrao? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

(airflow) 01/01: Check providers packages

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch validate-sdist-to-wheel in repository https://gitbox.apache.org/repos/asf/airflow.git commit bca5e859af2ec87b09ed78dcdaee69a594125bad Author: Andrey Anshin AuthorDate: Fri Feb 16 15:17:52 2024

(airflow) branch validate-sdist-to-wheel created (now bca5e859af)

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch validate-sdist-to-wheel in repository https://gitbox.apache.org/repos/asf/airflow.git at bca5e859af Check providers packages This branch includes the following new commits: new bc

(airflow) branch validate-sdist-to-wheel-2 created (now 53bb574732)

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch validate-sdist-to-wheel-2 in repository https://gitbox.apache.org/repos/asf/airflow.git at 53bb574732 Check providers packages also This branch includes the following new commits:

(airflow) 02/02: Check providers packages also

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch validate-sdist-to-wheel-2 in repository https://gitbox.apache.org/repos/asf/airflow.git commit 53bb574732ba8acfb067bab1183d63ea61210529 Author: Andrey Anshin AuthorDate: Fri Feb 16 15:17:52 20

(airflow) 01/02: Validate is it possible to build wheel from sdist distribution

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch validate-sdist-to-wheel-2 in repository https://gitbox.apache.org/repos/asf/airflow.git commit 7986fe800fb327fbd823b3201858f064f4632782 Author: Andrey Anshin AuthorDate: Thu Feb 15 16:53:25 20

[PR] Validate is it possible to build wheel from sdist distribution [airflow]

2024-02-16 Thread via GitHub
Taragolis opened a new pull request, #37476: URL: https://github.com/apache/airflow/pull/37476 continuation of: #37444 Check sdist packages during cli commands: - `breeze release-management prepare-airflow-package` - `breeze release-management prepare-provider-pac

Re: [PR] [POC] Validate is it possible to build wheel from sdist distribution [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on PR #37444: URL: https://github.com/apache/airflow/pull/37444#issuecomment-1948213727 closed in favor of https://github.com/apache/airflow/pull/37476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [POC] Validate is it possible to build wheel from sdist distribution [airflow]

2024-02-16 Thread via GitHub
Taragolis closed pull request #37444: [POC] Validate is it possible to build wheel from sdist distribution URL: https://github.com/apache/airflow/pull/37444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(airflow) branch validate-sdist-to-wheel deleted (was bca5e859af)

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch validate-sdist-to-wheel in repository https://gitbox.apache.org/repos/asf/airflow.git was bca5e859af Check providers packages This change permanently discards the following revisions:

(airflow) branch fix-default-mysql-client-for-prod deleted (was d59dfa31bb)

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch fix-default-mysql-client-for-prod in repository https://gitbox.apache.org/repos/asf/airflow.git was d59dfa31bb Validate import MySQLdb (mysqlclient) in prod image test The revisions that

Re: [I] Airflow Python 3.12 support [airflow]

2024-02-16 Thread via GitHub
potiuk commented on issue #36546: URL: https://github.com/apache/airflow/issues/36546#issuecomment-1948215321 > Any progress on this @dirrao? Python 3.12 is currently being worked on in https://github.com/apache/airflow/pull/36755 . There is one thing left in order to merge it - name

(airflow) branch validate-sdist-to-wheel-2 updated (53bb574732 -> 460f694359)

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch validate-sdist-to-wheel-2 in repository https://gitbox.apache.org/repos/asf/airflow.git from 53bb574732 Check providers packages also add 460f694359 Fixup: check=False for pip wheel

Re: [I] apache-airflow-providers-amazon/8.7.1 uses wrong log group for fargate container [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on issue #37278: URL: https://github.com/apache/airflow/issues/37278#issuecomment-1948236458 > Python DAG file defines EcsRunTaskOperator.awslogs_group="my-loggroup". And we got error in logs >Issue that fargate task is created with another log group and value from

(airflow) branch validate-sdist-to-wheel-2 updated (460f694359 -> 28b3ba6fe2)

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch validate-sdist-to-wheel-2 in repository https://gitbox.apache.org/repos/asf/airflow.git from 460f694359 Fixup: check=False for pip wheel add 28b3ba6fe2 Install venv from subprocess N

Re: [PR] Base date for fetching dag grid view must include selected run_id [airflow]

2024-02-16 Thread via GitHub
eladkal commented on PR #34887: URL: https://github.com/apache/airflow/pull/34887#issuecomment-1948287425 @hterik Can you handle the rebase and resolve conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Validate is it possible to build wheel from sdist distribution [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on code in PR #37476: URL: https://github.com/apache/airflow/pull/37476#discussion_r1492390429 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -374,6 +403,99 @@ def _build_airflow_packages_with_hatch( ) +def _dist_pack

[PR] Create GKEStartKueueJobOperator operator [airflow]

2024-02-16 Thread via GitHub
MaksYermak opened a new pull request, #37477: URL: https://github.com/apache/airflow/pull/37477 --- In this PR I have created an operator which starts a k8s Job inside a GKE cluster with Kueue enabled. **^ Add meaningful description above** Read t

Re: [I] TypeError: SqlAlchemySessionInterface.__init__() missing 6 required positional arguments [airflow]

2024-02-16 Thread via GitHub
SaadTPTW commented on issue #36883: URL: https://github.com/apache/airflow/issues/36883#issuecomment-1948323165 the use of the installation on the official website using the constraints.txt + the command airflow standalone solve the problem -- This is an automated message from the Apa

(airflow) branch validate-sdist-to-wheel-2 updated (28b3ba6fe2 -> 7169c68675)

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch validate-sdist-to-wheel-2 in repository https://gitbox.apache.org/repos/asf/airflow.git from 28b3ba6fe2 Install venv from subprocess add 7169c68675 Simplify collect packages and beaut

Re: [PR] Replace usage of `datetime.utcnow` and `datetime.utcfromtimestamp` in dev [airflow]

2024-02-16 Thread via GitHub
Taragolis merged PR #37473: URL: https://github.com/apache/airflow/pull/37473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [I] datetime.utcnow and datetime.utcfromtimestamp are deprecated in Python 3.12 [airflow]

2024-02-16 Thread via GitHub
Taragolis closed issue #32344: datetime.utcnow and datetime.utcfromtimestamp are deprecated in Python 3.12 URL: https://github.com/apache/airflow/issues/32344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(airflow) branch main updated (c75a105935 -> a3e939f22f)

2024-02-16 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c75a105935 add type annotations to Amazon provider "execute_coplete" methods (#36330) add a3e939f22f Replace u

[PR] Replace other Python 3.11 and 3.12 deprecations [airflow]

2024-02-16 Thread via GitHub
Taragolis opened a new pull request, #37478: URL: https://github.com/apache/airflow/pull/37478 This PR only bans parts which we already use in codebase. There are also some [ssl constants](https://docs.python.org/3/library/ssl.html#constants) also uses in our tests, i

(airflow) branch constraints-main updated: Updating constraints. Github run id:7930738584

2024-02-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new ba86b1c191 Updating con

Re: [PR] Update statsd-mappings.yml [airflow]

2024-02-16 Thread via GitHub
boring-cyborg[bot] commented on PR #37480: URL: https://github.com/apache/airflow/pull/37480#issuecomment-1948452203 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] Update statsd-mappings.yml [airflow]

2024-02-16 Thread via GitHub
stuart23 opened a new pull request, #37480: URL: https://github.com/apache/airflow/pull/37480 For tasks that belong to task groups, the emitted metric format is `airflow.dagduration` and therefore it is not being picked up by the existing airflow_task_dur

Re: [PR] Add Yandex Query support from Yandex.Cloud [airflow]

2024-02-16 Thread via GitHub
uzhastik commented on code in PR #37458: URL: https://github.com/apache/airflow/pull/37458#discussion_r1492377851 ## airflow/providers/yandex/hooks/http_client.py: ## @@ -0,0 +1,321 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

Re: [PR] Add PSRP connection type [airflow]

2024-02-16 Thread via GitHub
malthe merged PR #34766: URL: https://github.com/apache/airflow/pull/34766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Add PSRP connection type (#34766)

2024-02-16 Thread malthe
This is an automated email from the ASF dual-hosted git repository. malthe pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new bcf26733af Add PSRP connection type (#34766) bcf267

[PR] Fix construct `docker.TLSConfig` for `docker>=7` [airflow]

2024-02-16 Thread via GitHub
Taragolis opened a new pull request, #37481: URL: https://github.com/apache/airflow/pull/37481 Docker 7 remove legacy fields from the TLSConfig (https://github.com/docker/docker-py/pull/3185), this changes should fix in case if end users use custom TLS configuration

Re: [PR] Fix construct `docker.TLSConfig` for `docker>=7` [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on code in PR #37481: URL: https://github.com/apache/airflow/pull/37481#discussion_r1492617788 ## airflow/providers/docker/provider.yaml: ## @@ -63,7 +63,7 @@ versions: dependencies: - apache-airflow>=2.6.0 - - docker>=5.0.3 + - docker>=6 Review Comm

Re: [PR] Update statsd-mappings.yml [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on PR #37480: URL: https://github.com/apache/airflow/pull/37480#issuecomment-1948601359 https://github.com/apache/airflow/blob/35c1a1a024e652c001930bf42416e06d3c20cf95/chart/files/statsd-mappings.yml#L18-L23 -- This is an automated message from the Apache Git Service.

(airflow) branch constraints-main updated: Updating constraints. Github run id:7932201928

2024-02-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 01be7f4159 Updating con

[PR] feat: Add queues for triggerers. [airflow]

2024-02-16 Thread via GitHub
avkirilishin opened a new pull request, #36338: URL: https://github.com/apache/airflow/pull/36338 Closes: #33818 Pull Request for discussing the approach. If this approach is acceptable, I will add queue support for more triggers, add tests, update the documentation, and assess the d

Re: [PR] feat: Add queues for triggerers. [airflow]

2024-02-16 Thread via GitHub
avkirilishin closed pull request #36338: feat: Add queues for triggerers. URL: https://github.com/apache/airflow/pull/36338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[I] `get_parsing_context().dag_id` is not set when using `airflow dags test` command [airflow]

2024-02-16 Thread via GitHub
hterik opened a new issue, #37483: URL: https://github.com/apache/airflow/issues/37483 ### Apache Airflow version Other Airflow 2 version (please specify below) ### If "Other Airflow 2 version" selected, which one? 2.7.1 ### What happened? When trying to use

Re: [PR] Update statsd-mappings.yml [airflow]

2024-02-16 Thread via GitHub
stuart23 commented on PR #37480: URL: https://github.com/apache/airflow/pull/37480#issuecomment-1948807283 > https://github.com/apache/airflow/blob/35c1a1a024e652c001930bf42416e06d3c20cf95/chart/files/statsd-mappings.yml#L18-L23 This is fully backwards compatible, it will ship more me

[I] `_airflow_parsing_context_manager` writes to os.environ after program has started [airflow]

2024-02-16 Thread via GitHub
hterik opened a new issue, #37484: URL: https://github.com/apache/airflow/issues/37484 ### Apache Airflow version 2.8.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? After observing `_airflow_parsing_context_manager`

[PR] Combine coverage databases to include output from multiprocessing [airflow]

2024-02-16 Thread via GitHub
drajguru opened a new pull request, #37485: URL: https://github.com/apache/airflow/pull/37485 Combine coverage databases to include output from multiprocessing Call the combine() method to allow results from different processes to be reported on. Results in some coverage increases in

Re: [I] `_airflow_parsing_context_manager` writes to os.environ after program has started [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on issue #37484: URL: https://github.com/apache/airflow/issues/37484#issuecomment-1948864595 Feel free to raise a PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] feat(GKEPodAsyncHook): use async credentials token implementation [airflow]

2024-02-16 Thread via GitHub
m1racoli opened a new pull request, #37486: URL: https://github.com/apache/airflow/pull/37486 We utilize the existing implementation of `_CredentialsToken` by using the async hook's `get_token` method. This implementation allows us to leverage several features of the Google connection from

[PR] Bring back installing airflow with constraints (--use-airflow-version) [airflow]

2024-02-16 Thread via GitHub
potiuk opened a new pull request, #37487: URL: https://github.com/apache/airflow/pull/37487 The #37362 introduced --install-airflow-with-constraints flag to be able to check FAB provider installation in CI, but the value of that flag was falee for `shell` and `start-airlfow` command - and t

Re: [PR] Add Yandex Query support from Yandex.Cloud [airflow]

2024-02-16 Thread via GitHub
uzhastik commented on PR #37458: URL: https://github.com/apache/airflow/pull/37458#issuecomment-1948914923 > I'm not familiar with Yandex cloud and their API, but is any chance that Yandex Query supported by [`yandexcloud`](https://pypi.org/project/yandexcloud/) > > cc: @Piatachock @I

(airflow) branch python3.12 updated (a845abbf18 -> 56642a8549)

2024-02-16 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch python3.12 in repository https://gitbox.apache.org/repos/asf/airflow.git discard a845abbf18 Add Python 3.12 support add a15a3274af Uninstall twine before installing it in CI (#37415) a

[PR] Add comment about versions updated by release manager [airflow]

2024-02-16 Thread via GitHub
potiuk opened a new pull request, #37488: URL: https://github.com/apache/airflow/pull/37488 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

[I] User is able to see dag code even if user doesn't have access to view. [airflow]

2024-02-16 Thread via GitHub
sreenusuuda opened a new issue, #37489: URL: https://github.com/apache/airflow/issues/37489 ### Apache Airflow version 2.8.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? User is able to see dag’s code from the task d

Re: [PR] Add comment about versions updated by release manager [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on PR #37488: URL: https://github.com/apache/airflow/pull/37488#issuecomment-1948959944 Maybe also add small note into the template? https://github.com/apache/airflow/blob/bcf26733af8eb869142a08ca1146b561bfe299bf/dev/breeze/src/airflow_breeze/templates/PROVIDER__I

[PR] Possibility to set labels specific to migrateDatabaseJob objects and pods [airflow]

2024-02-16 Thread via GitHub
cylabr opened a new pull request, #37490: URL: https://github.com/apache/airflow/pull/37490 This PR adds the possibility to set labels specific to the `migrateDatabaseJob` objects and pods, the same way as it is already implemented for the `createUserJob`. ---

Re: [PR] Possibility to set labels specific to migrateDatabaseJob objects and pods [airflow]

2024-02-16 Thread via GitHub
boring-cyborg[bot] commented on PR #37490: URL: https://github.com/apache/airflow/pull/37490#issuecomment-1948965521 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

Re: [PR] feat: Fall back to datasets' "extra" if arg extra is empty [airflow]

2024-02-16 Thread via GitHub
boring-cyborg[bot] commented on PR #37491: URL: https://github.com/apache/airflow/pull/37491#issuecomment-1948966828 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] feat: Fall back to datasets' "extra" if arg extra is empty [airflow]

2024-02-16 Thread via GitHub
ZhengLin-Li opened a new pull request, #37491: URL: https://github.com/apache/airflow/pull/37491 fix: https://github.com/apache/airflow/issues/37006 Fall back to datasets' "extra" if arg extra is empty --- **^ Add meaningful description above** Read the

Re: [PR] Validate is it possible to build wheel from sdist distribution [airflow]

2024-02-16 Thread via GitHub
potiuk commented on code in PR #37476: URL: https://github.com/apache/airflow/pull/37476#discussion_r1492797768 ## dev/breeze/src/airflow_breeze/commands/release_management_commands.py: ## @@ -374,6 +403,99 @@ def _build_airflow_packages_with_hatch( ) +def _dist_package

[I] Forbidden error when user who doesn’t have access to deployment.airflow.importError.get [airflow]

2024-02-16 Thread via GitHub
sreenusuuda opened a new issue, #37492: URL: https://github.com/apache/airflow/issues/37492 ### Apache Airflow version 2.8.1 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? we are not returning Forbidden error when user

Re: [PR] Add comment about versions updated by release manager [airflow]

2024-02-16 Thread via GitHub
potiuk commented on PR #37488: URL: https://github.com/apache/airflow/pull/37488#issuecomment-1948978178 > Maybe also add small note into the template? > > https://github.com/apache/airflow/blob/bcf26733af8eb869142a08ca1146b561bfe299bf/dev/breeze/src/airflow_breeze/templates/PROVIDER_

Re: [PR] Replace usage of `datetime.utcnow` and `datetime.utcfromtimestamp` in providers [airflow]

2024-02-16 Thread via GitHub
m1racoli commented on code in PR #37138: URL: https://github.com/apache/airflow/pull/37138#discussion_r1492804415 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -670,7 +670,7 @@ async def acquire_access_token(self, timeout: int = 10) -> None: self.acc

Re: [PR] Replace usage of `datetime.utcnow` and `datetime.utcfromtimestamp` in providers [airflow]

2024-02-16 Thread via GitHub
m1racoli commented on code in PR #37138: URL: https://github.com/apache/airflow/pull/37138#discussion_r1492804415 ## airflow/providers/google/common/hooks/base_google.py: ## @@ -670,7 +670,7 @@ async def acquire_access_token(self, timeout: int = 10) -> None: self.acc

Re: [PR] Combine coverage databases to include output from multiprocessing [airflow]

2024-02-16 Thread via GitHub
potiuk commented on PR #37485: URL: https://github.com/apache/airflow/pull/37485#issuecomment-1948988862 Ah nice catch! That was for the local coverage running. Note - we also have the remote coverage report and there the reports are combined automatetically. -- This is an automat

[PR] Bump undici from 5.26.3 to 5.28.3 in /airflow/www [airflow]

2024-02-16 Thread via GitHub
dependabot[bot] opened a new pull request, #37493: URL: https://github.com/apache/airflow/pull/37493 Bumps [undici](https://github.com/nodejs/undici) from 5.26.3 to 5.28.3. Release notes Sourced from https://github.com/nodejs/undici/releases";>undici's releases. v5.28.3 ⚠️

(airflow) branch dependabot/npm_and_yarn/airflow/www/undici-5.28.3 created (now 0d2b501309)

2024-02-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/airflow/www/undici-5.28.3 in repository https://gitbox.apache.org/repos/asf/airflow.git at 0d2b501309 Bump undici from 5.26.3 to 5.28.3 in /airflow/www No new

Re: [PR] Combine coverage databases to include output from multiprocessing [airflow]

2024-02-16 Thread via GitHub
potiuk merged PR #37485: URL: https://github.com/apache/airflow/pull/37485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Combine coverage databases to include output from multiprocessing [airflow]

2024-02-16 Thread via GitHub
boring-cyborg[bot] commented on PR #37485: URL: https://github.com/apache/airflow/pull/37485#issuecomment-1949019107 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

(airflow) branch main updated: Combine coverage databases to include output from multiprocessing (#37485)

2024-02-16 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6ede4d3208 Combine coverage databases to include ou

Re: [PR] Add comment about versions updated by release manager [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on PR #37488: URL: https://github.com/apache/airflow/pull/37488#issuecomment-1949125353 > We have this note there in the generated init.py files., Isn't that enough? I want to believe that in most cases it enough, but maybe developers do not always read comments or

[PR] Add Code of Conduct to Airflow Site [airflow-site]

2024-02-16 Thread via GitHub
Briana-Okyere opened a new pull request, #957: URL: https://github.com/apache/airflow-site/pull/957 Currently, the Airflow website does not link out to the Code of Conduct. I propose we add a link to the Code of Conduct from the footer of the website where the "license, donate, privacy poli

Re: [PR] Add comment about versions updated by release manager [airflow]

2024-02-16 Thread via GitHub
potiuk commented on PR #37488: URL: https://github.com/apache/airflow/pull/37488#issuecomment-1949146093 > I want to believe that in most cases it enough, but maybe first-time contributors do not always read comments or think this is a part of licence or some sort of that. This is gr

Re: [PR] Support location for BigQueryInsertJobOperator in deferrable mode [airflow]

2024-02-16 Thread via GitHub
spencertollefson commented on PR #37282: URL: https://github.com/apache/airflow/pull/37282#issuecomment-1949168267 A little late here - but gcloud-aio released today the inclusion of a `location` parameter: https://github.com/talkiq/gcloud-aio/releases/tag/bigquery-7.1.0 Perhaps wi

Re: [I] BigQueryInsertJobOperator doesn't include BigQuery region/location in deferrable mode [airflow]

2024-02-16 Thread via GitHub
spencertollefson commented on issue #35833: URL: https://github.com/apache/airflow/issues/35833#issuecomment-1949178430 That PR was merged in today and now the 7.1.0 release of gcloud-aio accepts a location param. Seems like with your recent [PR](https://github.com/apache/airflow/pull/37282

Re: [PR] Bump undici from 5.26.3 to 5.28.3 in /airflow/www [airflow]

2024-02-16 Thread via GitHub
hussein-awala merged PR #37493: URL: https://github.com/apache/airflow/pull/37493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

(airflow) branch main updated: Bump undici from 5.26.3 to 5.28.3 in /airflow/www (#37493)

2024-02-16 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 137687651e Bump undici from 5.26.3 to 5.28.3

Re: [PR] Add comment about versions updated by release manager [airflow]

2024-02-16 Thread via GitHub
Taragolis commented on PR #37488: URL: https://github.com/apache/airflow/pull/37488#issuecomment-1949195094 ```python __version__ = 'x.y.z' # If you would like to change the version, please scroll up a bit ``` 🤣 Or some additional indents for notes, but need to check how it

(airflow) branch dependabot/npm_and_yarn/airflow/www/undici-5.28.3 deleted (was 0d2b501309)

2024-02-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/airflow/www/undici-5.28.3 in repository https://gitbox.apache.org/repos/asf/airflow.git was 0d2b501309 Bump undici from 5.26.3 to 5.28.3 in /airflow/www The rev

Re: [PR] Possibility to set labels specific to the migrateDatabaseJob objects and pods [airflow]

2024-02-16 Thread via GitHub
hussein-awala commented on code in PR #37490: URL: https://github.com/apache/airflow/pull/37490#discussion_r1492903126 ## helm_tests/airflow_aux/test_migrate_database_job.py: ## @@ -60,6 +60,18 @@ def test_should_support_annotations(self): assert "fiz" in job_annotation

(airflow) branch constraints-main updated: Updating constraints. Github run id:7935304547

2024-02-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 1f36de1e89 Updating con

[PR] Update to newer version of pre-commit and build tools [airflow]

2024-02-16 Thread via GitHub
potiuk opened a new pull request, #37494: URL: https://github.com/apache/airflow/pull/37494 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pul

  1   2   >