Re: [PR] Rename build arg for upgrade-to-newer-dependencies to include hash [airflow]

2024-03-30 Thread via GitHub
Lee-W commented on code in PR #38637: URL: https://github.com/apache/airflow/pull/38637#discussion_r1545524920 ## .github/workflows/prod-image-build.yml: ## @@ -104,7 +104,7 @@ on: # yamllint disable-line rule:truthy required: true type: string

Re: [PR] Add dagrun first task scheduling delay, dag processing duration [airflow]

2024-03-30 Thread via GitHub
github-actions[bot] commented on PR #36399: URL: https://github.com/apache/airflow/pull/36399#issuecomment-2028505239 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

Re: [PR] FIX: Update Airflow Airbyte Provider to use the new Airbyte API [airflow]

2024-03-30 Thread via GitHub
github-actions[bot] closed pull request #37244: FIX: Update Airflow Airbyte Provider to use the new Airbyte API URL: https://github.com/apache/airflow/pull/37244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Helm: Add namespace to all namespace-scoped resources [airflow]

2024-03-30 Thread via GitHub
github-actions[bot] closed pull request #33177: Helm: Add namespace to all namespace-scoped resources URL: https://github.com/apache/airflow/pull/33177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Chart: Allow AWS ECS Executor [airflow]

2024-03-30 Thread via GitHub
hussein-awala commented on code in PR #38524: URL: https://github.com/apache/airflow/pull/38524#discussion_r1545513039 ## chart/values.schema.json: ## @@ -521,7 +521,8 @@ "LocalKubernetesExecutor", "CeleryExecutor",

Re: [PR] Replace dill package to use cloudpickle [airflow]

2024-03-30 Thread via GitHub
hussein-awala commented on code in PR #38531: URL: https://github.com/apache/airflow/pull/38531#discussion_r1545512710 ## airflow/models/dagpickle.py: ## @@ -42,7 +42,7 @@ class DagPickle(Base): """ id = Column(Integer, primary_key=True) -pickle =

Re: [I] [Backfill] Support Partial DAG Backfills while still honoring dependencies [airflow]

2024-03-30 Thread via GitHub
AryaMoghaddam commented on issue #38407: URL: https://github.com/apache/airflow/issues/38407#issuecomment-2028486413 I've read through the issue, since there hasn't been a clear wanted solution I thought I would ask here, or open a discussion post to narrow it. I could think of three

[PR] Switch building images for ARM to public GitHub macos-14 runners [airflow]

2024-03-30 Thread via GitHub
potiuk opened a new pull request, #38640: URL: https://github.com/apache/airflow/pull/38640 GitHub recently added a possibility for OSS projects to run the macos-14 runners for ARM building. We are switching to build cache images using those runners. Depends on #38601

(airflow) 01/01: Switch building images for ARM to public GitHub macos-14 runners

2024-03-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git commit af971f08943451ef8150db8b851a50f9b73d3883 Author: Jarek Potiuk AuthorDate: Sat

(airflow) branch switch-cache-building-to-public-macos-runners created (now af971f0894)

2024-03-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch switch-cache-building-to-public-macos-runners in repository https://gitbox.apache.org/repos/asf/airflow.git at af971f0894 Switch building images for ARM to public GitHub macos-14 runners

Re: [PR] Switch cache building to public macos runners [airflow]

2024-03-30 Thread via GitHub
potiuk closed pull request #38639: Switch cache building to public macos runners URL: https://github.com/apache/airflow/pull/38639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Switch cache building to public macos runners [airflow]

2024-03-30 Thread via GitHub
potiuk commented on PR #38639: URL: https://github.com/apache/airflow/pull/38639#issuecomment-2028483100 Needs #38601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Switch cache building to public macos runners [airflow]

2024-03-30 Thread via GitHub
potiuk opened a new pull request, #38639: URL: https://github.com/apache/airflow/pull/38639 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-03-30 Thread via GitHub
idantepper commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2028476360 i changed a little bit more, i don't want this to be a huge PR, after doing this changes i will continue to change also the other ones -- This is an automated message from the

Re: [PR] removed usage of deprecated function for naming the pod in provider k8s pod.py [airflow]

2024-03-30 Thread via GitHub
idantepper commented on PR #38638: URL: https://github.com/apache/airflow/pull/38638#issuecomment-2028469294 i am goin over all of them right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] changed usage of deprecated function in provider k8s pod.py [airflow]

2024-03-30 Thread via GitHub
idantepper opened a new pull request, #38638: URL: https://github.com/apache/airflow/pull/38638 (k8s/operator/pod.py): changed the function used to create pod name, before used a deprecated one and now using add_uniqu_suffix() when executing this command `pytest

Re: [PR] Hide internals of some groupped workflows [airflow]

2024-03-30 Thread via GitHub
potiuk commented on code in PR #38604: URL: https://github.com/apache/airflow/pull/38604#discussion_r1545495168 ## .github/workflows/special-tests.yml: ## @@ -134,7 +134,7 @@ jobs: contents: read packages: read secrets: inherit -if: inputs.canary-run ==

[PR] Rename build arg for upgrade-to-newer-dependencies to include hash [airflow]

2024-03-30 Thread via GitHub
potiuk opened a new pull request, #38637: URL: https://github.com/apache/airflow/pull/38637 The "UPGRADE_TO_NEWER_DEPENDENCIES" build arg was a bit misleading as it was not a true/false value but rather "random hash"/"false". This PR makes it a bit more explicit: * the arg is

(airflow) branch main updated: Rename `allowed_filter_attrs` to `allowed_sort_attrs` (#38626)

2024-03-30 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e700f4150a Rename `allowed_filter_attrs` to

Re: [PR] Rename `allowed_filter_attrs` to `allowed_sort_attrs` [airflow]

2024-03-30 Thread via GitHub
hussein-awala merged PR #38626: URL: https://github.com/apache/airflow/pull/38626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-03-30 Thread via GitHub
hussein-awala commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2028424604 > @hussein-awala > > Hello, I'm waiting for your answer. > > Could you recommend how to deal with this? > > Or If this issue is resolved by other PR, let me

Re: [PR] Remove select_column option in TaskInstance.get_task_instance [airflow]

2024-03-30 Thread via GitHub
dstandish commented on PR #38571: URL: https://github.com/apache/airflow/pull/38571#issuecomment-2028378771 figured out what was going on here. it was a very confusing one. not obvious. basically, when switching it back to just query the TI, this had the effect of incrementing

Re: [PR] Remove select_column option in TaskInstance.get_task_instance [airflow]

2024-03-30 Thread via GitHub
dstandish commented on PR #38571: URL: https://github.com/apache/airflow/pull/38571#issuecomment-2028255533 oh -- I thought you merged it @jedcunningham -- sorry i was confused  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] `BigQueryInsertJobOperator` sometimes fails to acquire impersonated credentials when in deferred mode [airflow]

2024-03-30 Thread via GitHub
shahar1 commented on issue #38532: URL: https://github.com/apache/airflow/issues/38532#issuecomment-2028185966 What `location` do you provide as an input? (checking if it might be related to #37282) -- This is an automated message from the Apache Git Service. To respond to the message,

[I] Adjust AutoML docs and system tests to working with AutoML Translation [airflow]

2024-03-30 Thread via GitHub
shahar1 opened a new issue, #38636: URL: https://github.com/apache/airflow/issues/38636 ### What do you see as an issue? As GCP shutdowns most of the AutoML domains except for the AutoML Translation, documentation and system tests should reflect better how to work properly with the

[PR] Deprecate specific AutoML operators and hooks [airflow]

2024-03-30 Thread via GitHub
shahar1 opened a new pull request, #38635: URL: https://github.com/apache/airflow/pull/38635 depends on: #38633 As some of the AutoML operators and hooks become practically unusable due to the shutdown of all AutoML domains but AutoML Translation, this PR deprecates them

Re: [PR] Fix inital value for _batch_id attribute in livy operator [airflow]

2024-03-30 Thread via GitHub
alizademhdi commented on PR #38628: URL: https://github.com/apache/airflow/pull/38628#issuecomment-2028073596 Fixed static tests :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Delete deprecated AutoML operators (inc. 'google-cloud-automl' dep.) and deprecate hook and links [airflow]

2024-03-30 Thread via GitHub
shahar1 commented on PR #38418: URL: https://github.com/apache/airflow/pull/38418#issuecomment-2028053180 > I will be reverting the commit > > We want to take a bit of a different approach for depreciation since we did not include depreciation for most of the operators. Removing them

Re: [PR] Fix default behaviour for init function in `AppriseNotifier` [airflow]

2024-03-30 Thread via GitHub
dirrao commented on code in PR #38593: URL: https://github.com/apache/airflow/pull/38593#discussion_r1545289958 ## airflow/providers/apprise/hooks/apprise.py: ## @@ -71,7 +72,7 @@ def notify( title: str | None = None, notify_type: NotifyType = NotifyType.INFO,

Re: [PR] inherit key "verify" from env into session so that kv_client can read it properly [airflow]

2024-03-30 Thread via GitHub
dirrao commented on code in PR #38614: URL: https://github.com/apache/airflow/pull/38614#discussion_r1545282969 ## airflow/providers/hashicorp/_internal_client/vault_client.py: ## @@ -207,6 +207,9 @@ def _client(self) -> hvac.Client: session = Session()

Re: [PR] Revert "Delete deprecated AutoML operators and deprecate AutoML hook and links (#38418)" [airflow]

2024-03-30 Thread via GitHub
eladkal commented on PR #38633: URL: https://github.com/apache/airflow/pull/38633#issuecomment-2027989278 tests are failing due to merging https://github.com/apache/airflow/pull/38504 you will need to add commit to add the needed files to the ignore yaml -- This is an automated message

Re: [I] S3 Task Handler doesn't use custom logging config as fallback [airflow]

2024-03-30 Thread via GitHub
eladkal commented on issue #24565: URL: https://github.com/apache/airflow/issues/24565#issuecomment-2027986079 @benbenbang are you still working on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Reflect breaking changes in Azure Data Factory operator, sensor and triggerer [airflow]

2024-03-30 Thread via GitHub
eladkal commented on issue #35566: URL: https://github.com/apache/airflow/issues/35566#issuecomment-2027985597 @cesar-vermeulen if you have idea how to address the issue feel free to open a PR -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] Add SKIP process in addition to occurring ERROR in SQLCheckOperator [airflow]

2024-03-30 Thread via GitHub
eladkal closed issue #22907: Add SKIP process in addition to occurring ERROR in SQLCheckOperator URL: https://github.com/apache/airflow/issues/22907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Revert "Delete deprecated AutoML operators and deprecate AutoML hook and links (#38418)" [airflow]

2024-03-30 Thread via GitHub
shahar1 commented on PR #38633: URL: https://github.com/apache/airflow/pull/38633#issuecomment-2027981006 > I assume this is due to [#38418 (comment)](https://github.com/apache/airflow/pull/38418#issuecomment-2025027673) ? > > Can you please clarify what APIs are not going to be

(airflow) branch main updated: Introduce Amazon Bedrock service (#38602)

2024-03-30 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0723a8f01d Introduce Amazon Bedrock service

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-30 Thread via GitHub
eladkal merged PR #38602: URL: https://github.com/apache/airflow/pull/38602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Revert "Delete deprecated AutoML operators and deprecate AutoML hook and links (#38418)" [airflow]

2024-03-30 Thread via GitHub
eladkal commented on PR #38633: URL: https://github.com/apache/airflow/pull/38633#issuecomment-2027980101 I assume this is due to https://github.com/apache/airflow/pull/38418#issuecomment-2025027673 ? Can you please clarify what APIs are not going to be useful after Mar 31? Because

[PR] Revert "Delete deprecated AutoML operators and deprecate AutoML hook and links (#38418)" [airflow]

2024-03-30 Thread via GitHub
shahar1 opened a new pull request, #38633: URL: https://github.com/apache/airflow/pull/38633 This reverts commit 4a4eee11 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-30 Thread via GitHub
eladkal commented on code in PR #38602: URL: https://github.com/apache/airflow/pull/38602#discussion_r1545232259 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

(airflow) branch main updated: Add `impersonation_scopes` to BigQuery (#38169)

2024-03-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0f513472a7 Add `impersonation_scopes` to BigQuery

Re: [PR] Add `impersonation_scopes` to BigQuery [airflow]

2024-03-30 Thread via GitHub
potiuk merged PR #38169: URL: https://github.com/apache/airflow/pull/38169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix default behaviour for init function in `AppriseNotifier` [airflow]

2024-03-30 Thread via GitHub
eladkal commented on PR #38593: URL: https://github.com/apache/airflow/pull/38593#issuecomment-2027959962 Tests are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-30 Thread via GitHub
ferruzzi commented on code in PR #38602: URL: https://github.com/apache/airflow/pull/38602#discussion_r1545175558 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-30 Thread via GitHub
ferruzzi commented on code in PR #38602: URL: https://github.com/apache/airflow/pull/38602#discussion_r1545167180 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Introduce Amazon Bedrock service [airflow]

2024-03-30 Thread via GitHub
ferruzzi commented on code in PR #38602: URL: https://github.com/apache/airflow/pull/38602#discussion_r1545167180 ## airflow/providers/amazon/aws/operators/bedrock.py: ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-03-30 Thread via GitHub
Xiroo commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2027940307 @hussein-awala Hello, I'm waiting for your answer. Can you recommend how to deal with this? Or If this issue is resolved by other PR, let me know if I can close this PR. --

(airflow) branch main updated: Fix `total_entries` count on the event logs endpoint (#38625)

2024-03-30 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 90e7b3fd05 Fix `total_entries` count on the event

Re: [PR] Fix `total_entries` count on the event logs endpoint [airflow]

2024-03-30 Thread via GitHub
eladkal merged PR #38625: URL: https://github.com/apache/airflow/pull/38625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: