Re: [PR] inherit key "verify" from env into session so that kv_client can read it properly [airflow]

[via GitHub]

dirrao commented on code in PR #38614:
URL: https://github.com/apache/airflow/pull/38614#discussion_r1545282969


##########
airflow/providers/hashicorp/_internal_client/vault_client.py:
##########
@@ -207,6 +207,9 @@ def _client(self) -> hvac.Client:
             session = Session()
             session.mount("http://";, adapter)
             session.mount("https://";, adapter)
+            if self.kwargs is not None and "verify" in self.kwargs:
+                if self.kwargs["verify"] is not None:

Review Comment:
   ```suggestion
                   if self.kwargs["verify"]:
   ```



##########
airflow/providers/hashicorp/_internal_client/vault_client.py:
##########
@@ -207,6 +207,9 @@ def _client(self) -> hvac.Client:
             session = Session()
             session.mount("http://";, adapter)
             session.mount("https://";, adapter)
+            if self.kwargs is not None and "verify" in self.kwargs:

Review Comment:
   ```suggestion
               if self.kwargs and "verify" in self.kwargs:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org