(airflow) branch main updated: Replace pod_manager.read_pod_logs with client.read_namespaced_pod_log in KubernetesPodOperator._write_logs (#39112)

2024-05-04 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0e6c0ab252 Replace pod_manager.read_pod_logs with

Re: [PR] Replace pod_manager.read_pod_logs with client.read_namespaced_pod_log in KubernetesPodOperator._write_logs [airflow]

2024-05-04 Thread via GitHub
eladkal merged PR #39112: URL: https://github.com/apache/airflow/pull/39112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

(airflow) branch main updated: Pass SSL arg to all requests in DruidOperator (#39066)

2024-05-04 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e396f06041 Pass SSL arg to all requests in DruidOp

Re: [PR] Pass SSL arg to all requests in DruidOperator [airflow]

2024-05-04 Thread via GitHub
eladkal merged PR #39066: URL: https://github.com/apache/airflow/pull/39066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [I] Status of testing of Apache Airflow 2.9.1rc2 [airflow]

2024-05-04 Thread via GitHub
ephraimbuddy commented on issue #39326: URL: https://github.com/apache/airflow/issues/39326#issuecomment-2094648406 > #38882 and #39246 look good. > > #39167, I'm not sure if I made a mistake when cherry-picking it, but that doesn't work with the latest FAB rc 😞. I'll investigate a bi

Re: [PR] Avoid resetting adopted task instances when retrying for kubernetes executor [airflow]

2024-05-04 Thread via GitHub
tanvn commented on PR #39406: URL: https://github.com/apache/airflow/pull/39406#issuecomment-2094636124 @jedcunningham @hussein-awala Please take a look at your convenience. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] add dirrao to committer list [airflow]

2024-05-04 Thread via GitHub
dirrao opened a new pull request, #39412: URL: https://github.com/apache/airflow/pull/39412 **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more i

Re: [PR] Avoid resetting adopted task instances when retrying for kubernetes executor [airflow]

2024-05-04 Thread via GitHub
dirrao commented on code in PR #39406: URL: https://github.com/apache/airflow/pull/39406#discussion_r1590205811 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -599,6 +599,17 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequ

Re: [PR] Avoid resetting adopted task instances when retrying for kubernetes executor [airflow]

2024-05-04 Thread via GitHub
dirrao commented on code in PR #39406: URL: https://github.com/apache/airflow/pull/39406#discussion_r1590205811 ## airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py: ## @@ -599,6 +599,17 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequ

Re: [I] Airflow Triggerer facing frequent restarts [airflow]

2024-05-04 Thread via GitHub
arunravimv commented on issue #33647: URL: https://github.com/apache/airflow/issues/33647#issuecomment-2094577106 Hi Airflow Community, we faced the same issue on Airflow 2.7.3 (using AWS RDS MySql 8.0.35). For large airflow deployments with 1000s of active dags and large volume of records

Re: [PR] Implement `CloudDataTransferServiceRunJobOperator` [airflow]

2024-05-04 Thread via GitHub
josh-fell commented on code in PR #39154: URL: https://github.com/apache/airflow/pull/39154#discussion_r1590188472 ## airflow/providers/google/cloud/operators/cloud_storage_transfer_service.py: ## @@ -434,6 +434,82 @@ def execute(self, context: Context) -> None: hook.de

Re: [I] Status of testing of Apache Airflow 2.9.1rc2 [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on issue #39326: URL: https://github.com/apache/airflow/issues/39326#issuecomment-2094523074 Checked my changes, all looking good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Sqlalchemy dependency update [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-2094514322 Already fixed in https://github.com/apache/airflow/pull/38362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Sqlalchemy dependency update [airflow]

2024-05-04 Thread via GitHub
Taragolis closed pull request #38066: Sqlalchemy dependency update URL: https://github.com/apache/airflow/pull/38066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] Move prohibited warnings detection in deferrable pytest plugin [airflow]

2024-05-04 Thread via GitHub
Taragolis opened a new pull request, #39411: URL: https://github.com/apache/airflow/pull/39411 related: https://github.com/apache/airflow/issues/38642 Move all logic around existed functionality into the separate plugin, which allow to do additional things without turn

Re: [PR] Sqlalchemy dependency update [airflow]

2024-05-04 Thread via GitHub
github-actions[bot] commented on PR #38066: URL: https://github.com/apache/airflow/pull/38066#issuecomment-2094510233 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] fix: dag_run_dag_id_execution_date_key [airflow]

2024-05-04 Thread via GitHub
github-actions[bot] closed pull request #38179: fix: dag_run_dag_id_execution_date_key URL: https://github.com/apache/airflow/pull/38179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(airflow) branch main updated: Make driver version consistent in ODBC Connection (#39108)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 54e8376887 Make driver version consistent in ODB

Re: [PR] Make driver version consistent in ODBC Connection [airflow]

2024-05-04 Thread via GitHub
boring-cyborg[bot] commented on PR #39108: URL: https://github.com/apache/airflow/pull/39108#issuecomment-2094492494 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Make driver version consistent in ODBC Connection [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39108: URL: https://github.com/apache/airflow/pull/39108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Configure `back_populates` between `DagScheduleDatasetReference.dag` and `DagModel.schedule_dataset_references` (#39392)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 575c11e02d Configure `back_populates` between `

Re: [PR] Configure `back_populates` between `DagScheduleDatasetReference.dag` and `DagModel.schedule_dataset_references` [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39392: URL: https://github.com/apache/airflow/pull/39392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Make driver version consistent in ODBC Connection [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on PR #39108: URL: https://github.com/apache/airflow/pull/39108#issuecomment-2094468265 @Xtema you don't need to update this PR every time as main updated, since it is your first commit every time I need to re-approve workflow again and wait until it pass CI before I cou

Re: [PR] add recursive lookup for list of dirs [airflow]

2024-05-04 Thread via GitHub
boring-cyborg[bot] commented on PR #39410: URL: https://github.com/apache/airflow/pull/39410#issuecomment-2094407312 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

[PR] add recursive lookup for list of dirs [airflow]

2024-05-04 Thread via GitHub
hg1112 opened a new pull request, #39410: URL: https://github.com/apache/airflow/pull/39410 We have been intending to use the AzureFileShareToGCSOperator to transfer files from azure file share to gcs. Problem being we to transfer whole bucket and this operator does not support recursiv

Re: [PR] Fetch intermediate log async GKEStartPod [airflow]

2024-05-04 Thread via GitHub
hussein-awala commented on code in PR #39348: URL: https://github.com/apache/airflow/pull/39348#discussion_r1590163001 ## airflow/providers/google/cloud/operators/kubernetes_engine.py: ## @@ -785,16 +786,16 @@ def fetch_cluster_info(self) -> tuple[str, str | None]: self

Re: [PR] Fix HTTP 500 Internal Server Error if DAG is triggered with bad params [airflow]

2024-05-04 Thread via GitHub
jscheffl commented on PR #39409: URL: https://github.com/apache/airflow/pull/39409#issuecomment-2094403063 Wow, 30min from PR to merge - thanks for the fast review @Taragolis + @hussein-awala ! -- This is an automated message from the Apache Git Service. To respond to the message, please

(airflow) branch main updated: Fix HTTP 500 Internal Server Error if DAG is triggered with bad params (#39409)

2024-05-04 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1d234aa2ab Fix HTTP 500 Internal Server Error if

Re: [PR] Fix HTTP 500 Internal Server Error if DAG is triggered with bad params [airflow]

2024-05-04 Thread via GitHub
jscheffl merged PR #39409: URL: https://github.com/apache/airflow/pull/39409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] retry for failure in the queue [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39398: URL: https://github.com/apache/airflow/pull/39398#discussion_r1590159486 ## airflow/providers/celery/executors/celery_executor.py: ## @@ -469,7 +469,7 @@ def cleanup_stuck_queued_tasks(self, tis: list[TaskInstance]) -> list[str]:

Re: [PR] Add task failed dependencies to details page. [airflow]

2024-05-04 Thread via GitHub
jscheffl commented on code in PR #38449: URL: https://github.com/apache/airflow/pull/38449#discussion_r1590149970 ## airflow/api_connexion/openapi/v1.yaml: ## @@ -679,6 +679,71 @@ paths: "404": $ref: "#/components/responses/NotFound" + /dags/{dag_id}/dagRu

[PR] Fix HTTP 500 Internal Server Error if DAG is triggered with bad params [airflow]

2024-05-04 Thread via GitHub
jscheffl opened a new pull request, #39409: URL: https://github.com/apache/airflow/pull/39409 We have noticed that if you attempt to trigger a DAG via stable API with invalid parameters (e.g. bad values not mathcing to model/schema, missing required fields) that a HTTP 500 with "Uuups" text

Re: [PR] ADD prototype version dark mode for Airflow UI [airflow]

2024-05-04 Thread via GitHub
jscheffl commented on PR #39355: URL: https://github.com/apache/airflow/pull/39355#issuecomment-2094366079 I am 80% okay with this interim. Anyway when moving to full-React we need to rework this thing. Found no problem on all existing pages with Firefox+Chromium on Ubuntu. What irri

(airflow) branch main updated: Fix static file caching is disabled in Airflow Webserver. (#39345)

2024-05-04 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d396533cfd Fix static file caching is disabled in

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-04 Thread via GitHub
boring-cyborg[bot] commented on PR #39345: URL: https://github.com/apache/airflow/pull/39345#issuecomment-2094360099 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [I] webserver static file caching is disabled above 2.3.0 version. [airflow]

2024-05-04 Thread via GitHub
jscheffl closed issue #39344: webserver static file caching is disabled above 2.3.0 version. URL: https://github.com/apache/airflow/issues/39344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-04 Thread via GitHub
jscheffl merged PR #39345: URL: https://github.com/apache/airflow/pull/39345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Fix static file caching is disabled in Airflow Webserver. [airflow]

2024-05-04 Thread via GitHub
jscheffl commented on PR #39345: URL: https://github.com/apache/airflow/pull/39345#issuecomment-2094360029 Really cool catch. I can immediately see it locally and the UI feels immediately faster with this PR! THANKS! (I think we could debate about the time, 12h sounds reasonable for m

Re: [PR] fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #38831: URL: https://github.com/apache/airflow/pull/38831#discussion_r1590101404 ## airflow/providers/postgres/hooks/postgres.py: ## @@ -159,6 +172,10 @@ def get_conn(self) -> connection: ]: conn_args[arg_name] = ar

(airflow) branch main updated: Remove deprecation warnings in endpoints.py (#39389)

2024-05-04 Thread jscheffl
This is an automated email from the ASF dual-hosted git repository. jscheffl pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c5cd0a8008 Remove deprecation warnings in endpoin

Re: [PR] Update endpoints.py [airflow]

2024-05-04 Thread via GitHub
jscheffl merged PR #39389: URL: https://github.com/apache/airflow/pull/39389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Update endpoints.py [airflow]

2024-05-04 Thread via GitHub
jscheffl commented on PR #39389: URL: https://github.com/apache/airflow/pull/39389#issuecomment-2094355506 Thanks for the fix! Just keep in mind that the experimental API itself is deprecated. If you found it because you are using it, please switch to stable API soon. -- This is an autom

Re: [PR] Update endpoints.py [airflow]

2024-05-04 Thread via GitHub
boring-cyborg[bot] commented on PR #39389: URL: https://github.com/apache/airflow/pull/39389#issuecomment-2094355633 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Fix SFTPSensor.newer_than not working with jinja logical ds/ts expression [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39056: URL: https://github.com/apache/airflow/pull/39056#discussion_r1590099031 ## tests/providers/sftp/sensors/test_sftp.py: ## @@ -97,11 +97,24 @@ def test_file_not_new_enough(self, sftp_hook_mock): sftp_hook_mock.return_value.get_m

(airflow) branch main updated: Rename "dataset event" in context to use "outlet" (#39397)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 66d68db536 Rename "dataset event" in context to

Re: [PR] Rename "dataset event" in context to use "outlet" [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39397: URL: https://github.com/apache/airflow/pull/39397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Task info dag 37564 [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39074: URL: https://github.com/apache/airflow/pull/39074#discussion_r1590095563 ## airflow/api_connexion/schemas/task_schema.py: ## @@ -26,14 +26,16 @@ TimeDeltaSchema, WeightRuleField, ) -from airflow.api_connexion.schemas.dag_schem

Re: [PR] Add Iceberg provider [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39155: URL: https://github.com/apache/airflow/pull/39155#discussion_r1590081812 ## airflow/providers/tabular/CHANGELOG.rst: ## @@ -26,6 +26,13 @@ Changelog - +1.5.0 +. + + +.. warning:: This is the last release for jira provider

Re: [PR] Remove unused replace boolean parameter in insert_rows function of Or… [airflow]

2024-05-04 Thread via GitHub
RichieSK commented on code in PR #39408: URL: https://github.com/apache/airflow/pull/39408#discussion_r1590080737 ## airflow/providers/oracle/hooks/oracle.py: ## @@ -251,8 +251,7 @@ def insert_rows( table: str, rows: list[tuple], target_fields=None, -

Re: [PR] feat: soft_fail TriggerDagRunOperator [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on PR #39173: URL: https://github.com/apache/airflow/pull/39173#issuecomment-2094343552 @raphaelauv could you resolve conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix: sqa deprecations for airflow task cmd [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39244: URL: https://github.com/apache/airflow/pull/39244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Resolve `RemovedIn20Warning` in `airflow task` command (#39244)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dbdf743589 Resolve `RemovedIn20Warning` in `airf

(airflow) branch main updated: Determine fail_stop on client side when db isolated (#39258)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3d14213ebf Determine fail_stop on client side wh

Re: [PR] Determine fail_stop on client side when db isolated [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39258: URL: https://github.com/apache/airflow/pull/39258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: fix: sqa deprecations for airflow test (#39299)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8d29a96dd8 fix: sqa deprecations for airflow tes

Re: [PR] fix: sqa deprecations for airflow tests [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39299: URL: https://github.com/apache/airflow/pull/39299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Refactor cloudpickle support in Python operators/decorators [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39270: URL: https://github.com/apache/airflow/pull/39270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Refactor cloudpickle support in Python operators/decorators (#39270)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7b5962e747 Refactor cloudpickle support in Pytho

Re: [I] Status of testing Providers that were prepared on May 01, 2024 [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on issue #39346: URL: https://github.com/apache/airflow/issues/39346#issuecomment-2094340201 Tests my changes (most of them just cosmetic), look good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Remove unused replace boolean parameter in insert_rows function of Or… [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39408: URL: https://github.com/apache/airflow/pull/39408#discussion_r1590071500 ## airflow/providers/oracle/hooks/oracle.py: ## @@ -251,8 +251,7 @@ def insert_rows( table: str, rows: list[tuple], target_fields=None, -

(airflow) branch main updated (b3a8bfaaee -> 377a915cdc)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b3a8bfaaee Resolve testSchedulerJob internal warning (#39090) add 377a915cdc Add support to define Resources on

Re: [PR] Add support to define Resources on DockerSwarmOperator [airflow]

2024-05-04 Thread via GitHub
boring-cyborg[bot] commented on PR #39027: URL: https://github.com/apache/airflow/pull/39027#issuecomment-2094338013 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Add support to define Resources on DockerSwarmOperator [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39027: URL: https://github.com/apache/airflow/pull/39027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[PR] Remove unused replace boolean parameter in insert_rows function of Or… [airflow]

2024-05-04 Thread via GitHub
RichieSK opened a new pull request, #39408: URL: https://github.com/apache/airflow/pull/39408 Following changes made to OracleHook class. The replace boolean parameter claims to replace rows instead of insert, but this functionality has not been implemented and the documentation claim

Re: [PR] Fix oraclehook replace [airflow]

2024-05-04 Thread via GitHub
RichieSK closed pull request #39407: Fix oraclehook replace URL: https://github.com/apache/airflow/pull/39407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Fix oraclehook replace [airflow]

2024-05-04 Thread via GitHub
RichieSK commented on PR #39407: URL: https://github.com/apache/airflow/pull/39407#issuecomment-2094328446 This commit introduces a new function, merge_rows, which implements an upsert operation for Oracle databases in OracleHook class(this function inserts a row if it doesn't exist and upd

[PR] Fix oraclehook replace [airflow]

2024-05-04 Thread via GitHub
RichieSK opened a new pull request, #39407: URL: https://github.com/apache/airflow/pull/39407 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#p

Re: [PR] Fix oraclehook replace [airflow]

2024-05-04 Thread via GitHub
boring-cyborg[bot] commented on PR #39407: URL: https://github.com/apache/airflow/pull/39407#issuecomment-2094325486 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors'

(airflow) branch constraints-main updated: Updating constraints. Github run id:8951323542

2024-05-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new ed03b854be Updating con

Re: [PR] `S3DeleteObjectsOperator` Added ability to filter keys by last modified time [airflow]

2024-05-04 Thread via GitHub
idantepper commented on code in PR #39151: URL: https://github.com/apache/airflow/pull/39151#discussion_r1590013300 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -503,23 +510,36 @@ def __init__( self.bucket = bucket self.keys = keys self.prefi

Re: [PR] `S3DeleteObjectsOperator` Added ability to filter keys by last modified time [airflow]

2024-05-04 Thread via GitHub
idantepper commented on code in PR #39151: URL: https://github.com/apache/airflow/pull/39151#discussion_r1590013148 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -503,23 +510,36 @@ def __init__( self.bucket = bucket self.keys = keys self.prefi

Re: [PR] `S3DeleteObjectsOperator` Added ability to filter keys by last modified time [airflow]

2024-05-04 Thread via GitHub
romsharon98 commented on code in PR #39151: URL: https://github.com/apache/airflow/pull/39151#discussion_r1590012390 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -503,23 +510,36 @@ def __init__( self.bucket = bucket self.keys = keys self.pref

Re: [PR] `S3DeleteObjectsOperator` Added ability to filter keys by last modified time [airflow]

2024-05-04 Thread via GitHub
romsharon98 commented on code in PR #39151: URL: https://github.com/apache/airflow/pull/39151#discussion_r1590012390 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -503,23 +510,36 @@ def __init__( self.bucket = bucket self.keys = keys self.pref

Re: [PR] Update dataproc.rst [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39395: URL: https://github.com/apache/airflow/pull/39395#discussion_r1590005702 ## docs/apache-airflow-providers-google/operators/cloud/dataproc.rst: ## @@ -416,8 +415,8 @@ A batch can be created using: :end-before: [END how_to_cloud_datap

(airflow) branch main updated: Resolve testSchedulerJob internal warning (#39090)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new b3a8bfaaee Resolve testSchedulerJob internal war

Re: [PR] Resolve testSchedulerJob internal warning [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39090: URL: https://github.com/apache/airflow/pull/39090 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Resolve deprecations in core sensors tests (#39404)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4abb134e48 Resolve deprecations in core sensors

Re: [PR] Resolve deprecations in core sensors tests [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39404: URL: https://github.com/apache/airflow/pull/39404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

(airflow) branch main updated: Add Kalyan to triage team (#39393)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5d93f95da8 Add Kalyan to triage team (#39393) 5d

Re: [PR] Add Kalyan to triage team [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39393: URL: https://github.com/apache/airflow/pull/39393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Avoid resetting adopted task instances when retrying for kubernetes executor [airflow]

2024-05-04 Thread via GitHub
tanvn commented on PR #39406: URL: https://github.com/apache/airflow/pull/39406#issuecomment-2094161119 Tested on my environment, confirmed that in the second attempt, the task instances whose pods have been adopted are not flushed anymore ``` [2024-05-04T13:03:12.681+] {scheduler_

Re: [I] Many running task instances are cleared by the new scheduler when an old scheduler is terminated and its health check server is periodically requested [airflow]

2024-05-04 Thread via GitHub
tanvn commented on issue #39088: URL: https://github.com/apache/airflow/issues/39088#issuecomment-2094155454 @RNHTTR Hi, I created a PR to fix this issue: https://github.com/apache/airflow/pull/39406 PTAL at your convenience. -- This is an automated message from the Apache Git Serv

Re: [I] `TriggerDagRunOperator` not working as expected in defer with `wait_for_completion` [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on issue #38353: URL: https://github.com/apache/airflow/issues/38353#issuecomment-2094154342 @thanhtrung5763 No one proposed a fix yet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] Avoid resetting adopted task instances when retrying [airflow]

2024-05-04 Thread via GitHub
tanvn opened a new pull request, #39406: URL: https://github.com/apache/airflow/pull/39406 Closes: https://github.com/apache/airflow/issues/39088 As described in https://github.com/apache/airflow/issues/39088#issuecomment-2093473579, when an OperationalError happens (in my case, it

Re: [PR] Resolve deprecations in core sensors tests [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39404: URL: https://github.com/apache/airflow/pull/39404#discussion_r1589979944 ## tests/sensors/test_timeout_sensor.py: ## Review Comment: This test module was added years ago in https://github.com/apache/airflow/pull/2875, and it is onl

[PR] Resolve deprecations in core sensors tests [airflow]

2024-05-04 Thread via GitHub
Taragolis opened a new pull request, #39404: URL: https://github.com/apache/airflow/pull/39404 related: https://github.com/apache/airflow/issues/38642 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/ai

Re: [PR] Resolve testSchedulerJob internal warning [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39090: URL: https://github.com/apache/airflow/pull/39090#discussion_r1589973452 ## tests/conftest.py: ## @@ -905,6 +906,12 @@ def __call__( else: DEFAULT_DATE = timezone.datetime(2016, 1, 1)

Re: [I] AirFlow Unit Testing not working as described in the documentation: [airflow]

2024-05-04 Thread via GitHub
Taragolis closed issue #39402: AirFlow Unit Testing not working as described in the documentation: URL: https://github.com/apache/airflow/issues/39402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Resolve testSchedulerJob internal warning [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39090: URL: https://github.com/apache/airflow/pull/39090#discussion_r1589968745 ## tests/conftest.py: ## @@ -905,6 +906,12 @@ def __call__( else: DEFAULT_DATE = timezone.datetime(2016, 1, 1)

Re: [I] AirFlow Unit Testing not working as described in the documentation: [airflow]

2024-05-04 Thread via GitHub
boring-cyborg[bot] commented on issue #39402: URL: https://github.com/apache/airflow/issues/39402#issuecomment-2094127978 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] AirFlow Unit Testing not working as described in the documentation: [airflow]

2024-05-04 Thread via GitHub
camilla-storytel opened a new issue, #39402: URL: https://github.com/apache/airflow/issues/39402 ### What do you see as an issue? Hi! I am trying to unit test my DAGs by following [this link in the AirFlow docs](https://airflow.apache.org/docs/apache-airflow/stable/best-practices.h

Re: [PR] Resolve testSchedulerJob internal warning [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39090: URL: https://github.com/apache/airflow/pull/39090#discussion_r1589966005 ## tests/conftest.py: ## @@ -905,6 +906,12 @@ def __call__( else: DEFAULT_DATE = timezone.datetime(2016, 1, 1)

Re: [PR] Resolve testSchedulerJob internal warning [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on code in PR #39090: URL: https://github.com/apache/airflow/pull/39090#discussion_r1589966005 ## tests/conftest.py: ## @@ -905,6 +906,12 @@ def __call__( else: DEFAULT_DATE = timezone.datetime(2016, 1, 1)

Re: [I] Bad rendering of an inline code in the documentation [airflow]

2024-05-04 Thread via GitHub
hussein-awala closed issue #39396: Bad rendering of an inline code in the documentation URL: https://github.com/apache/airflow/issues/39396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

(airflow) branch main updated (378fd6f0db -> a1c873cfb8)

2024-05-04 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 378fd6f0db Adding new precommit to avoid faulty changelog format (#39388) add a1c873cfb8 Add whitespace aft

Re: [PR] Add whitespace after inline literal in docs [airflow]

2024-05-04 Thread via GitHub
hussein-awala merged PR #39401: URL: https://github.com/apache/airflow/pull/39401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[PR] Add whitespace after inline literal in docs [airflow]

2024-05-04 Thread via GitHub
Taragolis opened a new pull request, #39401: URL: https://github.com/apache/airflow/pull/39401 **DagRun UI after the changes** ![image](https://github.com/apache/airflow/assets/3998685/f6a9e0e9-a01f-47d6-b889-8a3b31ea5ed1) closes: #39396 --- `p

Re: [I] Bad rendering of an inline code in the documentation [airflow]

2024-05-04 Thread via GitHub
Taragolis commented on issue #39396: URL: https://github.com/apache/airflow/issues/39396#issuecomment-2094112273 Missing whitespace after the ` ``params`` ` https://github.com/apache/airflow/blob/d3e922910518e0b7c771888fbbafc0f6bcc19439/docs/apache-airflow/core-concepts/dag-run.rst?plain=1#L

(airflow) branch main updated (00f096918d -> 378fd6f0db)

2024-05-04 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 00f096918d Fix alembic autogeneration and rename mismatching constraints (#39032) add 378fd6f0db Adding new pr

Re: [PR] Adding new precommit to avoid faulty changelog format [airflow]

2024-05-04 Thread via GitHub
Taragolis merged PR #39388: URL: https://github.com/apache/airflow/pull/39388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

  1   2   >