[GitHub] [airflow] Joffreybvn commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-04 Thread via GitHub
Joffreybvn commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1252228253 ## tests/providers/odbc/hooks/test_odbc.py: ## @@ -235,3 +259,15 @@ def test_sqlalchemy_scheme_extra(self): hook = self.get_hook(conn_params=dict(extra=j

[GitHub] [airflow] Joffreybvn commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-04 Thread via GitHub
Joffreybvn commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1252223599 ## airflow/providers/odbc/hooks/odbc.py: ## @@ -211,3 +215,9 @@ def get_sqlalchemy_connection( engine = self.get_sqlalchemy_engine(engine_kwargs=engine_kw

[GitHub] [airflow] Joffreybvn commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-04 Thread via GitHub
Joffreybvn commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1252224880 ## airflow/providers/common/sql/hooks/sql.py: ## @@ -372,6 +372,15 @@ def run( else: return results +def _make_serializable(self, resul

[GitHub] [airflow] Joffreybvn commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-04 Thread via GitHub
Joffreybvn commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1252223599 ## airflow/providers/odbc/hooks/odbc.py: ## @@ -211,3 +215,9 @@ def get_sqlalchemy_connection( engine = self.get_sqlalchemy_engine(engine_kwargs=engine_kw

[GitHub] [airflow] Joffreybvn commented on a diff in pull request #32319: Make ODBCHook result JSON-serializable

2023-07-03 Thread via GitHub
Joffreybvn commented on code in PR #32319: URL: https://github.com/apache/airflow/pull/32319#discussion_r1251241162 ## airflow/providers/odbc/hooks/odbc.py: ## @@ -211,3 +211,10 @@ def get_sqlalchemy_connection( engine = self.get_sqlalchemy_engine(engine_kwargs=engine_k