[GitHub] [airflow] john-jac commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-15 Thread GitBox
john-jac commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-969432414 > but my point is, airflow does not try secrets backend for configs in general. it's only when you explicitly configure it to do so, for a specific config keys. Intere

[GitHub] [airflow] john-jac commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-15 Thread GitBox
john-jac commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-969417889 > > Maybe so, but even without the above export, when secrets manager backend is set, and a condition or resource constraint is applied, Airflow will fail to start with multi

[GitHub] [airflow] john-jac commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-15 Thread GitBox
john-jac commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-969383922 > > The fundamental way that a secrets backend works is to try all connections, variables, and configurations there first and, if it returns None, try the OS environment vari

[GitHub] [airflow] john-jac commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-14 Thread GitBox
john-jac commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-968327100 > > The boto3 secrets manager library will fail with ResourceNotFoundException if there are no restrictions in the IAM role, i.e. it has full access to secrets manager. That

[GitHub] [airflow] john-jac commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-12 Thread GitBox
john-jac commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-967559744 > > this is already implemented in the gcp secret_manager -> > > https://github.com/apache/airflow/blob/4f1e66d0227fba7a1378e895b9186711c03ead61/airflow/providers/google/cl

[GitHub] [airflow] john-jac commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-02 Thread GitBox
john-jac commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-956325118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [airflow] john-jac commented on pull request #19324: Catch AccessDeniedException in AWS Secrets Manager Backend

2021-11-01 Thread GitBox
john-jac commented on pull request #19324: URL: https://github.com/apache/airflow/pull/19324#issuecomment-956325118 > > Today, this causes a failure with the Scheduler as an uncaught exception > > What do you mean with the scheduler? Perhaps most commonly one retrieves a connection f