kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r750906779
##
File path: tests/kubernetes/test_pod_generator.py
##
@@ -658,11 +658,12 @@ def test_deserialize_model_file(self):
def
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r750906688
##
File path: tests/kubernetes/test_pod_generator.py
##
@@ -658,11 +658,12 @@ def test_deserialize_model_file(self):
def
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r750906589
##
File path: tests/kubernetes/test_pod_generator.py
##
@@ -658,11 +658,12 @@ def test_deserialize_model_file(self):
def
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r747674223
##
File path: tests/kubernetes/test_pod_generator.py
##
@@ -684,7 +684,7 @@ def test_pod_name_is_valid(self, pod_id,
expected_starts_with):
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r747202513
##
File path: tests/kubernetes/test_pod_generator.py
##
@@ -684,7 +684,7 @@ def test_pod_name_is_valid(self, pod_id,
expected_starts_with):
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r747201088
##
File path: tests/kubernetes/test_pod_generator.py
##
@@ -684,7 +684,7 @@ def test_pod_name_is_valid(self, pod_id,
expected_starts_with):
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r747197691
##
File path: tests/kubernetes/test_pod_generator.py
##
@@ -684,7 +684,7 @@ def test_pod_name_is_valid(self, pod_id,
expected_starts_with):
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r747197319
##
File path: tests/kubernetes/test_pod_generator.py
##
@@ -658,8 +658,8 @@ def test_deserialize_model_file(self):
def
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r733802715
##
File path: airflow/kubernetes/pod_generator.py
##
@@ -459,10 +459,14 @@ def make_unique_pod_id(pod_id: str) -> str:
return None
kd2718 commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r731487808
##
File path: airflow/kubernetes/pod_generator.py
##
@@ -460,9 +460,9 @@ def make_unique_pod_id(pod_id: str) -> str:
safe_uuid =
10 matches
Mail list logo