[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r441918574 ## File path: airflow/api_connexion/endpoints/variable_endpoint.py ## @@ -14,41 +14,83 @@ # KIND, either express or implied. See the License for the #

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r441916241 ## File path: airflow/www/extensions/init_views.py ## @@ -92,15 +93,16 @@ def init_error_handlers(app: Flask): app.register_error_handler(404,

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-17 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r441915601 ## File path: tests/api_connexion/endpoints/test_variable_endpoint.py ## @@ -29,38 +31,142 @@ def setUpClass(cls) -> None: def setUp(self) ->

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-16 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r440965043 ## File path: tests/api_connexion/endpoints/test_variable_endpoint.py ## @@ -29,38 +31,142 @@ def setUpClass(cls) -> None: def setUp(self) ->

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-16 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r440955054 ## File path: airflow/api_connexion/endpoints/variable_endpoint.py ## @@ -14,41 +14,76 @@ # KIND, either express or implied. See the License for the #

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-16 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r440949309 ## File path: airflow/api_connexion/endpoints/variable_endpoint.py ## @@ -14,41 +14,76 @@ # KIND, either express or implied. See the License for the #

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-16 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r440946856 ## File path: tests/api_connexion/endpoints/test_variable_endpoint.py ## @@ -29,38 +30,133 @@ def setUpClass(cls) -> None: def setUp(self) ->

[GitHub] [airflow] mik-laj commented on a change in pull request #9273: implement api v1 for variables

2020-06-13 Thread GitBox
mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r439719672 ## File path: airflow/api_connexion/endpoints/variable_endpoint.py ## @@ -14,41 +14,77 @@ # KIND, either express or implied. See the License for the #