[GitHub] [airflow] patgarz commented on a diff in pull request #34051: AIP-56: Change FAB username identifier

2023-09-12 Thread via GitHub
patgarz commented on code in PR #34051: URL: https://github.com/apache/airflow/pull/34051#discussion_r1323639441 ## airflow/migrations/versions/0129_2_8_0_add_owner_display_name_to_audit_log_table.py: ## @@ -0,0 +1,50 @@ +# +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] [airflow] patgarz commented on a diff in pull request #34051: AIP-56: Change FAB username identifier

2023-09-09 Thread via GitHub
patgarz commented on code in PR #34051: URL: https://github.com/apache/airflow/pull/34051#discussion_r1320598248 ## airflow/www/decorators.py: ## @@ -88,8 +88,10 @@ def wrapper(*args, **kwargs): with create_session() as session: if not get_auth_mana

[GitHub] [airflow] patgarz commented on a diff in pull request #34051: AIP-56: Change FAB username identifier

2023-09-09 Thread via GitHub
patgarz commented on code in PR #34051: URL: https://github.com/apache/airflow/pull/34051#discussion_r1320598248 ## airflow/www/decorators.py: ## @@ -88,8 +88,10 @@ def wrapper(*args, **kwargs): with create_session() as session: if not get_auth_mana

[GitHub] [airflow] patgarz commented on a diff in pull request #34051: AIP-56: Change FAB username identifier

2023-09-05 Thread via GitHub
patgarz commented on code in PR #34051: URL: https://github.com/apache/airflow/pull/34051#discussion_r1316503648 ## airflow/auth/managers/fab/fab_auth_manager.py: ## @@ -61,17 +61,27 @@ def get_cli_commands() -> list[CLICommand]: SYNC_PERM_COMMAND, # not in a comma

[GitHub] [airflow] patgarz commented on a diff in pull request #34051: AIP-56: Change FAB username identifier

2023-09-05 Thread via GitHub
patgarz commented on code in PR #34051: URL: https://github.com/apache/airflow/pull/34051#discussion_r1316499155 ## airflow/models/log.py: ## @@ -37,6 +37,7 @@ class Log(Base): event = Column(String(30)) execution_date = Column(UtcDateTime) owner = Column(String(5

[GitHub] [airflow] patgarz commented on a diff in pull request #34051: AIP-56: Change FAB username identifier

2023-09-05 Thread via GitHub
patgarz commented on code in PR #34051: URL: https://github.com/apache/airflow/pull/34051#discussion_r1316493843 ## airflow/auth/managers/fab/fab_auth_manager.py: ## @@ -61,17 +61,27 @@ def get_cli_commands() -> list[CLICommand]: SYNC_PERM_COMMAND, # not in a comma