[GitHub] [airflow] uranusjr commented on issue #27399: CronTriggerTimetable lost one task occasionally

2023-07-18 Thread via GitHub
uranusjr commented on issue #27399: URL: https://github.com/apache/airflow/issues/27399#issuecomment-1640983709 ```python elif last_automated_data_interval.end == self._align_to_prev(current_time): # The last run is the same as the previously scheduled run. Everything is working fi

[GitHub] [airflow] uranusjr commented on issue #27399: CronTriggerTimetable lost one task occasionally

2023-07-18 Thread via GitHub
uranusjr commented on issue #27399: URL: https://github.com/apache/airflow/issues/27399#issuecomment-1639846860 Yeah. Or maybe we can addd a flag for this? Not sure what it should be called though. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [airflow] uranusjr commented on issue #27399: CronTriggerTimetable lost one task occasionally

2023-07-17 Thread via GitHub
uranusjr commented on issue #27399: URL: https://github.com/apache/airflow/issues/27399#issuecomment-1638156248 Forgot to mentioned the one-line change. This line https://github.com/apache/airflow/blob/4a44343731144a7a7dc7fff7e3ed01663d4dd2e1/airflow/timetables/trigger.py#L92 s

[GitHub] [airflow] uranusjr commented on issue #27399: CronTriggerTimetable lost one task occasionally

2023-07-17 Thread via GitHub
uranusjr commented on issue #27399: URL: https://github.com/apache/airflow/issues/27399#issuecomment-1638152940 I spent some time to take a closer look at the implementation. The problem with > I think the reason is because CronDataIntervalTimetable runs a last DAG run if it missed e

[GitHub] [airflow] uranusjr commented on issue #27399: CronTriggerTimetable lost one task occasionally

2023-05-03 Thread via GitHub
uranusjr commented on issue #27399: URL: https://github.com/apache/airflow/issues/27399#issuecomment-1533666824 This is the logic to calculate the next run for `catchup=False`, for reference: ```python start_time_candidates = [self._align_to_next(DateTime.utcnow())] if last_auto

[GitHub] [airflow] uranusjr commented on issue #27399: CronTriggerTimetable lost one task occasionally

2023-05-03 Thread via GitHub
uranusjr commented on issue #27399: URL: https://github.com/apache/airflow/issues/27399#issuecomment-1533649073 I don’t _think_ the interval is relevant; the scheduler never looks at it, but only pass it directly into a run’s context. -- This is an automated message from the Apache Git Se

[GitHub] [airflow] uranusjr commented on issue #27399: CronTriggerTimetable lost one task occasionally

2022-11-10 Thread GitBox
uranusjr commented on issue #27399: URL: https://github.com/apache/airflow/issues/27399#issuecomment-1310067158 Hmm, this and #27582 seems to be the same issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a