[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1323594607 ## airflow/models/taskinstance.py: ## @@ -1583,14 +2334,22 @@ def _run_raw_task( # Recording SKIPPED or SUCCESS self.clear_next_method_ar

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1311990437 ## airflow/models/taskinstance.py: ## @@ -1978,257 +2668,88 @@ def handle_failure( task: BaseOperator | None = None try: -if getattr(

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1311990437 ## airflow/models/taskinstance.py: ## @@ -1978,257 +2668,88 @@ def handle_failure( task: BaseOperator | None = None try: -if getattr(

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1309075951 ## airflow/models/taskinstance.py: ## @@ -371,6 +373,802 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance, cont

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1309045128 ## airflow/models/taskinstance.py: ## @@ -371,6 +373,802 @@ def _creator_note(val): return TaskInstanceNote(*val) +def _execute_task(task_instance, cont

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1308992469 ## airflow/models/taskinstance.py: ## @@ -186,23 +188,23 @@ def set_current_context(context: Context) -> Generator[Context, None, None]: ) -def _st

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1273682456 ## airflow/api/common/experimental/__init__.py: ## @@ -41,7 +41,7 @@ def check_and_get_dag(dag_id: str, task_id: str | None = None) -> DagModel: return dag

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1272322945 ## airflow/models/dag.py: ## @@ -1465,11 +1510,22 @@ def get_dagrun( raise TypeError("You must provide either the execution_date or the run_id")

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1270805170 ## airflow/models/dag.py: ## @@ -1465,11 +1510,22 @@ def get_dagrun( raise TypeError("You must provide either the execution_date or the run_id")

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1270714310 ## airflow/models/dag.py: ## @@ -1465,11 +1510,22 @@ def get_dagrun( raise TypeError("You must provide either the execution_date or the run_id")

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1266885738 ## airflow/models/dagrun.py: ## @@ -100,6 +102,29 @@ def _creator_note(val): return DagRunNote(*val) +def _get_task_instance( Review Comment: Oh got

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1265453160 ## airflow/models/dagrun.py: ## @@ -100,6 +102,29 @@ def _creator_note(val): return DagRunNote(*val) +def _get_task_instance( Review Comment: You ar

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1264140862 ## airflow/utils/context.pyi: ## @@ -37,11 +37,13 @@ from airflow.models.dagrun import DagRun from airflow.models.dataset import DatasetEvent from airflow.models.p

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1264133945 ## pyproject.toml: ## @@ -145,7 +145,7 @@ known-third-party = [ # The Pydantic representations of SqlAlchemy Models are not parsed well with Pydantic # when __f

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1262749790 ## airflow/models/dag.py: ## @@ -1378,6 +1379,37 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_inte

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1262679496 ## airflow/models/baseoperator.py: ## @@ -907,7 +907,7 @@ def __init__( max_active_tis_per_dag = task_concurrency self.max_active_tis_per_dag:

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1262678233 ## airflow/models/dag.py: ## @@ -1378,6 +1379,37 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_inte

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1261113735 ## airflow/models/dag.py: ## @@ -1378,6 +1379,33 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_inte

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1247182262 ## airflow/serialization/pydantic/dag_run.py: ## @@ -14,38 +14,80 @@ # KIND, either express or implied. See the License for the # specific language governing perm

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1247177551 ## airflow/serialization/pydantic/dag_run.py: ## @@ -14,38 +14,80 @@ # KIND, either express or implied. See the License for the # specific language governing perm

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1131355676 ## airflow/models/pydantic/dag_run.py: ## @@ -42,7 +39,6 @@ class DagRunPydantic(BaseModelPydantic): last_scheduling_decision: Optional[datetime] dag_hash:

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1131330638 ## airflow/models/pydantic/dagrun.py: ## @@ -14,35 +14,32 @@ # KIND, either express or implied. See the License for the # specific language governing permissions

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1131328929 ## airflow/models/pydantic/dagrun.py: ## @@ -14,35 +14,32 @@ # KIND, either express or implied. See the License for the Review Comment: I renamed this one to m

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1131330638 ## airflow/models/pydantic/dagrun.py: ## @@ -14,35 +14,32 @@ # KIND, either express or implied. See the License for the # specific language governing permissions

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1131330638 ## airflow/models/pydantic/dagrun.py: ## @@ -14,35 +14,32 @@ # KIND, either express or implied. See the License for the # specific language governing permissions

[GitHub] [airflow] vincbeck commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1131330638 ## airflow/models/pydantic/dagrun.py: ## @@ -14,35 +14,32 @@ # KIND, either express or implied. See the License for the # specific language governing permissions