[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r258947600 ## File path: airflow/hooks/oracle_hook.py ## @@ -48,22 +48,65 @@ def get_conn(self): that

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r250978334 ## File path: airflow/hooks/oracle_hook.py ## @@ -50,20 +50,61 @@ def get_conn(self): as in ``{

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r250979010 ## File path: airflow/hooks/oracle_hook.py ## @@ -128,13 +181,33 @@ def bulk_insert_rows(self, table, row

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r250979887 ## File path: tests/hooks/test_oracle_hook.py ## @@ -0,0 +1,248 @@ +# -*- coding: utf-8 -*- +# +# License

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r250978615 ## File path: airflow/hooks/oracle_hook.py ## @@ -50,20 +50,61 @@ def get_conn(self): as in ``{

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r250978852 ## File path: airflow/hooks/oracle_hook.py ## @@ -50,20 +50,61 @@ def get_conn(self): as in ``{

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r251025326 ## File path: airflow/hooks/oracle_hook.py ## @@ -50,20 +50,61 @@ def get_conn(self): as in ``{

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r251025721 ## File path: airflow/hooks/oracle_hook.py ## @@ -128,13 +181,33 @@ def bulk_insert_rows(self, table, row

[GitHub] ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook

ashb commented on a change in pull request #4584: [AIRFLOW-3741] Add extra config to Oracle hook URL: https://github.com/apache/airflow/pull/4584#discussion_r251028815 ## File path: airflow/hooks/oracle_hook.py ## @@ -50,20 +50,61 @@ def get_conn(self): as in ``{