[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259644013 ## File path: airflow/www/views.py ## @@ -49,12 +48,12 @@ from wtforms import SelectField, validators imp

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259594132 ## File path: airflow/models/__init__.py ## @@ -688,6 +632,57 @@ def __init__(self, task, execution_date, sta

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259594107 ## File path: airflow/models/__init__.py ## @@ -688,6 +632,57 @@ def __init__(self, task, execution_date, sta

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259595324 ## File path: airflow/models/__init__.py ## @@ -3988,7 +4042,7 @@ def cli(self): def create_dagrun(self,

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259596610 ## File path: tests/test_jobs.py ## @@ -502,7 +516,9 @@ def test_backfill_depends_on_past(self): """

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259592898 ## File path: airflow/models/__init__.py ## @@ -356,6 +293,9 @@ def process_file(self, filepath, only_if_upda

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259595813 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259596518 ## File path: airflow/www/views.py ## @@ -49,12 +48,12 @@ from wtforms import SelectField, validators imp

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259595286 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259596415 ## File path: airflow/www/views.py ## @@ -1293,50 +1302,72 @@ def set_duration(tid): def graph(self, ses

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259595643 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259596086 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259596352 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,53 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the A

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259596360 ## File path: airflow/www/templates/airflow/graph.html ## @@ -53,7 +53,7 @@ {% for op in operators %}

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259592528 ## File path: airflow/jobs.py ## @@ -39,7 +39,7 @@ from sqlalchemy.exc import OperationalError from sqlalch

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259594132 ## File path: airflow/models/__init__.py ## @@ -688,6 +632,57 @@ def __init__(self, task, execution_date, sta

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259594249 ## File path: airflow/models/__init__.py ## @@ -2771,6 +2766,8 @@ class DagModel(Base): is_subdag = Colu

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259592849 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,81 @@ +# +# Licensed

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259595509 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-23 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259595315 ## File path: airflow/models/__init__.py ## @@ -3750,8 +3802,10 @@ def __deepcopy__(self, memo): res

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256946287 ## File path: airflow/models/__init__.py ## @@ -519,7 +459,6 @@ def bag_dag(self, dag, parent_dag, root_dag):

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256952832 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the A

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256946641 ## File path: airflow/models/__init__.py ## @@ -679,6 +620,9 @@ def __init__(self, task, execution_date, stat

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256957133 ## File path: airflow/www/views.py ## @@ -1319,24 +1335,20 @@ def graph(self, session=None):

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256950610 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256957942 ## File path: tests/core.py ## @@ -2878,13 +2903,6 @@ def test_get_connections_env_var(self): assert

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256945081 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,63 @@ +# +# Licensed

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256958070 ## File path: tests/sensors/test_base_sensor.py ## @@ -60,12 +61,12 @@ def setUp(self): 'start_d

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256951023 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256945433 ## File path: airflow/models/__init__.py ## @@ -96,7 +97,7 @@ from airflow.utils import timezone from airfl

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256948569 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self):

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256954379 ## File path: airflow/operators/subdag_operator.py ## @@ -91,6 +91,8 @@ def __init__( )

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256945759 ## File path: airflow/models/__init__.py ## @@ -356,6 +293,9 @@ def process_file(self, filepath, only_if_upda

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256948963 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self):

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256944362 ## File path: airflow/jobs.py ## @@ -1869,7 +1869,7 @@ def __init__( start_date=None,

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256954139 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the A

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256951924 ## File path: airflow/models/__init__.py ## @@ -4050,8 +4164,14 @@ def sync_to_db(self, owner=None, sync_time

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256950777 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256957621 ## File path: airflow/www/views.py ## @@ -1349,21 +1361,26 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsF

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256951322 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256946287 ## File path: airflow/models/__init__.py ## @@ -519,7 +459,6 @@ def bag_dag(self, dag, parent_dag, root_dag):

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256947078 ## File path: airflow/models/__init__.py ## @@ -688,6 +632,57 @@ def __init__(self, task, execution_date, sta

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256952152 ## File path: airflow/models/__init__.py ## @@ -4050,8 +4164,14 @@ def sync_to_db(self, owner=None, sync_time

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256952957 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the A

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256951071 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256953447 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the A

[GitHub] feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
feng-tao commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256950346 ## File path: airflow/models/__init__.py ## @@ -3238,9 +3314,10 @@ def normalize_schedule(self, dttm):