[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259637268 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259611471 ## File path: tests/test_jobs.py ## @@ -502,7 +516,9 @@ def test_backfill_depends_on_past(self): """

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259611099 ## File path: airflow/www/views.py ## @@ -49,12 +48,12 @@ from wtforms import SelectField, validators impor

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259610934 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259610682 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259610125 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609953 ## File path: airflow/www/views.py ## @@ -1293,50 +1302,72 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609863 ## File path: airflow/www/templates/airflow/graph.html ## @@ -53,7 +53,7 @@ {% for op in operators %} -

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609805 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,53 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apa

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609694 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609529 ## File path: airflow/models/__init__.py ## @@ -4019,17 +4073,50 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609504 ## File path: airflow/models/__init__.py ## @@ -3988,7 +4042,7 @@ def cli(self): def create_dagrun(self,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609425 ## File path: airflow/models/__init__.py ## @@ -3750,8 +3802,10 @@ def __deepcopy__(self, memo): resul

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609323 ## File path: airflow/models/__init__.py ## @@ -2771,6 +2766,8 @@ class DagModel(Base): is_subdag = Column

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259609030 ## File path: airflow/models/__init__.py ## @@ -688,6 +632,57 @@ def __init__(self, task, execution_date, state

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-24 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r259608591 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,81 @@ +# +# Licensed t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-20 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258456287 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,63 @@ +# +# Licensed t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-20 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258456287 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,63 @@ +# +# Licensed t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-20 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258372104 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,81 @@ +# +# Licensed t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-19 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258290411 ## File path: airflow/www/views.py ## @@ -49,12 +48,13 @@ from wtforms import SelectField, validators impor

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-19 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258289148 ## File path: airflow/models/__init__.py ## @@ -688,6 +632,57 @@ def __init__(self, task, execution_date, state

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-19 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258288620 ## File path: airflow/jobs.py ## @@ -2383,9 +2371,8 @@ def _collect_errors(self, ti_status, session=None):

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-19 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258288190 ## File path: airflow/jobs.py ## @@ -39,7 +39,7 @@ from sqlalchemy.exc import OperationalError from sqlalchem

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-19 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258287086 ## File path: airflow/jobs.py ## @@ -1869,7 +1869,7 @@ def __init__( start_date=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-19 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r258285725 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,81 @@ +# +# Licensed t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257482340 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257468194 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257468194 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257463331 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257460129 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257454787 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257454601 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257452961 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257452038 ## File path: airflow/www/views.py ## @@ -92,7 +93,10 @@ def get_date_time_num_runs_dag_runs_form_data(request,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257451904 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257451826 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apa

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257451845 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apa

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257451709 ## File path: airflow/models/__init__.py ## @@ -4293,6 +4413,7 @@ class DagRun(Base, LoggingMixin): run_id

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257451687 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257451680 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257451649 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-16 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257451639 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257424502 ## File path: airflow/models/__init__.py ## @@ -193,70 +194,6 @@ def get_fernet(): _CONTEXT_MANAGER_DAG = None

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257423876 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257423430 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apa

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257422882 ## File path: tests/core.py ## @@ -166,6 +176,7 @@ def test_schedule_dag_relativedelta(self): task

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257422195 ## File path: airflow/models/__init__.py ## @@ -1856,6 +1851,13 @@ def init_run_context(self, raw=False):

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257421945 ## File path: tests/test_models.py ## @@ -2811,7 +2889,7 @@ def test_email_alert(self, mock_send_email):

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257421397 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self): re

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257421017 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257420675 ## File path: airflow/www/views.py ## @@ -920,10 +924,16 @@ def clear(self): dag_id = request.args.get

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257420364 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257420386 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257419474 ## File path: airflow/models/__init__.py ## @@ -3118,6 +3150,50 @@ def date_range(self, start_date, num=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257418251 ## File path: airflow/models/dag_edge.py ## @@ -0,0 +1,60 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apa

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257418066 ## File path: airflow/models/__init__.py ## @@ -4050,8 +4164,14 @@ def sync_to_db(self, owner=None, sync_time=N

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257417466 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257417594 ## File path: airflow/www/views.py ## @@ -920,10 +924,16 @@ def clear(self): dag_id = request.args.get

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257416396 ## File path: airflow/www/views.py ## @@ -1349,21 +1357,26 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsFor

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257207222 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self): re

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257207006 ## File path: airflow/www/views.py ## @@ -1349,21 +1361,26 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsFor

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-15 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257205891 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257134031 ## File path: airflow/models/__init__.py ## @@ -4050,8 +4164,14 @@ def sync_to_db(self, owner=None, sync_time=N

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133602 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133588 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133366 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257133187 ## File path: airflow/models/__init__.py ## @@ -4012,17 +4088,55 @@ def create_dagrun(self, conf=c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257132913 ## File path: airflow/models/__init__.py ## @@ -3238,9 +3314,10 @@ def normalize_schedule(self, dttm):

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257132348 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self): re

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257131721 ## File path: airflow/models/__init__.py ## @@ -688,6 +632,57 @@ def __init__(self, task, execution_date, state

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257120300 ## File path: tests/sensors/test_base_sensor.py ## @@ -60,12 +61,12 @@ def setUp(self): 'start_dat

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257120183 ## File path: tests/core.py ## @@ -2878,13 +2903,6 @@ def test_get_connections_env_var(self): assert c

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257119817 ## File path: airflow/models/__init__.py ## @@ -679,6 +620,9 @@ def __init__(self, task, execution_date, state=

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257117183 ## File path: airflow/models/__init__.py ## @@ -96,7 +97,7 @@ from airflow.utils import timezone from airflow

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257116801 ## File path: airflow/jobs.py ## @@ -1869,7 +1869,7 @@ def __init__( start_date=None,

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257115977 ## File path: airflow/www/views.py ## @@ -1319,24 +1335,20 @@ def graph(self, session=None):

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257115832 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257115465 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257115006 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257114786 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257114230 ## File path: airflow/www/views.py ## @@ -1293,24 +1303,30 @@ def set_duration(tid): def graph(self, sessi

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257113954 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self): re

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257113428 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,63 @@ +# +# Licensed t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257113381 ## File path: airflow/models/__init__.py ## @@ -356,6 +293,9 @@ def process_file(self, filepath, only_if_update

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r257112910 ## File path: airflow/migrations/versions/10aab8d908d0_adding_dag_edges.py ## @@ -0,0 +1,63 @@ +# +# Licensed t

[GitHub] ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database

2019-02-14 Thread GitBox
ffinfo commented on a change in pull request #4396: [AIRFLOW-3585] - Add edges to database URL: https://github.com/apache/airflow/pull/4396#discussion_r256826877 ## File path: airflow/models/__init__.py ## @@ -2812,16 +2821,39 @@ def get_default_view(self): re