ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-466786813
@feng-tao and @astahlman As far possible I did resolved all comments again.
This i
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-466743180
@astahlman
I did assume `airflow upgraded ` was already in the docs, if not we should
take a look at this. Shall I do this in the same PR?
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-465679605
Just an extra comment for @astahlman
First, thank you for testing. You found an issue I didn't think about. So
thanks for that.
My latest co
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-465554935
@feng-tao: I do understand your concerns, I'm also happy to look into issues
en look at solutions.
Although I must say giving a `-1` is a bit d
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-465255343
@feng-tao This change has nothing to do with the scheduler or running tasks,
so testing scheduler, backfill is not required here. Only place where
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-465012099
@feng-tao I see you did use python 2.7. I have now tested it on a clean
conda env with python 2.7 and seems to run fine. Also running on a Mac. Tra
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464994353
This is how is looks like, this is the default page when there is no DagRun
yet.
https://user-images.githubusercontent.com/2419555/52992848-5add
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464613750
@astahlman Can you check it again? I have added a new button to the graph
view to explicitly says `Read from file`. This way seeing the content of
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464607372
I do agree, then I will make something that still reads the dag file. This
is the only place where this information lives. Give me a few hours to l
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464601517
@astahlman I do see your point but I don't really have a good solution for
that. If we take dynamic dags into account viewing a (correct) dag is ra
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464401502
@BasPH, @Fokko, @ashb, @feng-tao, @astahlman
All comments are resolved and all tests seems to succeed.
Can all of you take a last look at it i
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464392789
@feng-tao Yes it has but was not aware that the npm recompile was needed. It
does also work here now.
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464308526
Small comment on the screenshots. As you can see the edges itself are not
visible but this also happens on master. Can take a look at this but let'
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464307752
@feng-tao and @astahlman I think I have the a solution. I created a fall
back on the graph view on the last known graph in de database. With this a
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464302726
@feng-tao option 2 is already implemented. Maybe it's better to keep is like
this.
The problem here is that this changes makes historical graphs
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464247441
@feng-tao I will add this to the migration. Only bad thing is that this
migration step then requires to parse all dag files. But I can see this is
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-464238403
@feng-tao I think the scheduler does not have a lot to do with this. Only
place where the scheduler does something more is on create_dagrun.
-
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-463929201
@astahlman I have seen the same thing. This happens when you generated a
dagrun on master and try to view this on this branch. This is because some
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-456689922
@ashb: I was thinking about this but the problem are dynamic dags. In some
causes each run of a dag can have a different graph. In the current stru
ffinfo commented on issue #4396: [AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-455764359
@feng-tao In the end this is part of this bigger issue:
https://jira.apache.org/jira/browse/AIRFLOW-3562
In the end this would solve the o
20 matches
Mail list logo
