moiseenkov commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1801376901
> > > Also after this comment @vincbeck @jedcunningham - I think we should
re-evaluate the result of our discussion whether Auth Mnagers should return
FlaskApi from #34349 - bec
potiuk commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1801824400
> I assume that it should be done as soon as possible because it blocks
upgrade of Werkzeug up to version 3.0.1 that patches [vulnerability
issue](https://nvd.nist.gov/vuln/detail/C
RobbeSneyders commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1801857315
I assume that what is urgent, is not blocking the migration path to
Connexion 3 in the future, by now releasing the auth managers with an interface
that expects them to retur
vincbeck commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1802181398
> I assume that what is urgent, is not blocking the migration path to
Connexion 3 in the future, by now releasing the auth managers with an interface
that expects them to return a
vincbeck commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1802183437
But I agree, the sooner, the better so if you (or someone else) is
interested into that change, it is very welcome. If you go down that path feel
free to tag, I'll be happy to rev
potiuk commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1802184641
> Auth manager interface is not public, yet. It will take some time before
having the interface considered as public so we will be able to change the
interface
> But I agree,
RobbeSneyders commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1784040026
Hi, Connexion maintainer here :wave:
Thanks for testing version 3 and submitting the PR. Let us know if you run
into any other issues and we're happy to help fix them.
potiuk commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1784124748
> Hi, Connexion maintainer here 👋
>
> Thanks for testing version 3 and submitting the PR. Let us know if you run
into any other issues and we're happy to help fix them. Your f
RobbeSneyders commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1793398241
> The usage was added in https://github.com/apache/airflow/pull/30596,
seemingly only to override and improve the default error message.
> Either revert that change or find
RobbeSneyders commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1793404192
> The usage was added in https://github.com/apache/airflow/pull/30596,
seemingly only to override and improve the default error message.
> Either revert that change or find
potiuk commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1793418752
Many thanks @RobbeSneyders -> those are super valuable comments and great
ground-work for somoene who will pick up the task. Thanks for your offer to
help with reviews. Yeah, defin
potiuk commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1793419488
Also after this comment @vincbeck @jedcunningham - I think we should
re-evaluatethe result of our discussion whether Auth Mnagers should return
FlaskApi from https://github.com/apac
RobbeSneyders commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1793449425
Yes ideally, the following logic would be followed:
1) The app is instantiated using Connexion. Using a Flask app with Connexion
APIs instead will lose most of Connexio
RobbeSneyders commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1793450394
Also happy to merge functionality upstream if it would be valuable for more
Connexion users.
- The
[_CustomErrorRequestBodyValidator](https://github.com/apache/airflow/blo
vincbeck commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1795184365
> Also after this comment @vincbeck @jedcunningham - I think we should
re-evaluate the result of our discussion whether Auth Mnagers should return
FlaskApi from #34349 - because t
potiuk commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1795205341
> > Also after this comment @vincbeck @jedcunningham - I think we should
re-evaluate the result of our discussion whether Auth Mnagers should return
FlaskApi from #34349 - because t
RobbeSneyders commented on issue #35234:
URL: https://github.com/apache/airflow/issues/35234#issuecomment-1795739085
> 5. You should run the Connexion app instead of the Flask app, using an
ASGI server. If you run the Flask app directly, the Connexion middleware would
not be called.
>
17 matches
Mail list logo
