Re: [I] Simplify metrics handling [airflow]

2024-04-29 Thread via GitHub
ferruzzi commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2083222778 hmmm. yeah, I think maybe you are right. As of 3.8, dicts are guaranteed to retain the order they were inserted and we require 3.8+ for Airflow so yeah, that should wo

Re: [I] Simplify metrics handling [airflow]

2024-04-28 Thread via GitHub
Jack-R-lantern commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2081455313 @ferruzzi Hi. I came across this [article](https://mail.python.org/pipermail/python-dev/2017-December/151283.html) while troubleshooting an issue. It looks like it's

Re: [I] Simplify metrics handling [airflow]

2024-04-06 Thread via GitHub
Ibrahim-Mukherjee commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2041105131 Hi I would be willing to work on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Simplify metrics handling [airflow]

2024-04-03 Thread via GitHub
ferruzzi commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2036209180 I think the easiest answer would be to convert the existing metrics tags dicts to ordereddicts, then in the stated_logger module you can join them and know they'll always be the s

Re: [I] Simplify metrics handling [airflow]

2024-04-03 Thread via GitHub
Jack-R-lantern commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2036137372 please assign me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Simplify metrics handling [airflow]

2024-04-01 Thread via GitHub
ferruzzi commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2030691835 Not sure it really qualifies as a bug, but it didn't really feel like a "feature request" either. Feel free to adjust my tagging. I've added "good first issue" because this

Re: [I] Simplify metrics handling [airflow]

2024-04-01 Thread via GitHub
potiuk commented on issue #38655: URL: https://github.com/apache/airflow/issues/38655#issuecomment-2030566237 Yes. Good idea. Let's do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[I] Simplify metrics handling [airflow]

2024-04-01 Thread via GitHub
ferruzzi opened a new issue, #38655: URL: https://github.com/apache/airflow/issues/38655 ### Apache Airflow version 2.9.0b2 ### If "Other Airflow 2 version" selected, which one? _No response_ ### What happened? When OTel support was added, it enabled adding