jscheffl commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2189689733
Oh, no just another small static check glitch. Else finally looks OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
YounHS commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1650226923
##
airflow/www/static/js/toggle_theme.js:
##
@@ -0,0 +1,44 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agree
bbovenzi commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1629775357
##
airflow/www/templates/appbuilder/navbar.html:
##
@@ -50,6 +50,16 @@
{% include 'appbuilder/navbar_menu.html' %}
+
+
Re
bbovenzi commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1629774464
##
airflow/www/static/js/toggle_theme.js:
##
@@ -0,0 +1,52 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agr
YounHS commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1626787988
##
airflow/www/templates/appbuilder/navbar.html:
##
@@ -50,6 +50,13 @@
{% include 'appbuilder/navbar_menu.html' %}
+
+
+
bbovenzi commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1626129551
##
airflow/www/templates/appbuilder/navbar.html:
##
@@ -50,6 +50,13 @@
{% include 'appbuilder/navbar_menu.html' %}
+
+
+
YounHS commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2118778829
> @bbovenzi looking for a second reviewer, you also had an opinion on the PR?
@jscheffl Thank you. I don't have any other opinion. I just want you to know
that I'm releasing this f
jscheffl commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2118735747
@bbovenzi looking for a second reviewer, you also had an opinion on the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
YounHS commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2116405180
> I did manual tests... cool: No flickering, consistent UI. Good to be
merged.
Oh... I'm so glad to hear that! :)
--
This is an automated message from the Apache Git Service.
To
YounHS commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2106407163
@jscheffl
I realized that fixing flickering is quite a tricky task. In order to fix
this properly, i need to modify the html on the flask_appbuilder side.
However, i realized t
YounHS commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1597732861
##
airflow/www/views.py:
##
@@ -105,7 +105,7 @@
from airflow.models.dag import get_dataset_triggered_next_run_info
from airflow.models.dagrun import RUN_ID_REGEX, Da
jscheffl commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1597654641
##
airflow/www/views.py:
##
@@ -105,7 +105,7 @@
from airflow.models.dag import get_dataset_triggered_next_run_info
from airflow.models.dagrun import RUN_ID_REGEX,
YounHS commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2106116615
@jscheffl
sry, I checked this prob!
I initially thought that I would only need to modify the airflow/www side,
but for "security", "browse", and "admin", modifying views.py wou
YounHS commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1597388058
##
airflow/www/templates/appbuilder/navbar.html:
##
@@ -50,6 +50,13 @@
{% include 'appbuilder/navbar_menu.html' %}
+
Review Comment:
YounHS commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1597386702
##
airflow/www/views.py:
##
@@ -719,8 +719,17 @@ def render_template(self, *args, **kwargs):
**kwargs,
)
+class CustomAirflow(AirflowBaseView):
jscheffl commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1595836314
##
airflow/www/templates/appbuilder/navbar.html:
##
@@ -50,6 +50,13 @@
{% include 'appbuilder/navbar_menu.html' %}
+
Review Comment:
YounHS commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2102087153
Hello, @jscheffl I fix the flickering problem. for this solution, I add
custom function in views.py. It just a prototype, so please excuse the messy
code.
--
This is an automated mess
jscheffl commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2094366079
I am 80% okay with this interim. Anyway when moving to full-React we need to
rework this thing. Found no problem on all existing pages with Firefox+Chromium
on Ubuntu.
What irri
YounHS commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2093368449
hi @uranusjr. I removed the mosaicked part and created a test DAG to
recapture it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ryanahamilton commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2092804548
The screenshots illustrate that this will certainly be an appealing
feature—I really wish the execution were as easy as this… The path that we
should take (IMO) to enabling color
uranusjr commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2092378547
So in the dark mode screenshot, text is actually white (like in the nav bar)
and it being very extremely low contrast is just a side effect of the mosaic?
It would be helpful if there’
YounHS commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2089675859
> Nice to see dark mode feature. The screen shot that you shared doesn't
show the text properly. is it during switch mode. are there any other
screenshots?
Hi @dirrao The capture
boring-cyborg[bot] commented on PR #39355:
URL: https://github.com/apache/airflow/pull/39355#issuecomment-2089360402
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contributors'
YounHS opened a new pull request, #39355:
URL: https://github.com/apache/airflow/pull/39355
related: #11334
We've been seeing requests for a dark mode feature in the Airflow UI for a
while now.
I tested it using docker-compose.yaml.
After testing, I was able to set dar
24 matches
Mail list logo
