potiuk merged PR #40034:
URL: https://github.com/apache/airflow/pull/40034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uranusjr commented on PR #40034:
URL: https://github.com/apache/airflow/pull/40034#issuecomment-2167196651
Please rebase first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dstandish commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1639128433
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -5499,7 +5517,14 @@ components:
items:
type: string
description: The value can be
syedahsn commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1639097200
##
airflow/www/static/js/dag/details/taskInstance/Details.tsx:
##
@@ -53,6 +53,7 @@ const Details = ({ gridInstance, taskInstance, group }:
Props) => {
const
syedahsn commented on PR #40034:
URL: https://github.com/apache/airflow/pull/40034#issuecomment-2167037850
It looks like the failing test was resolved in #39899. This should be good
to merge @o-nikolas?
--
This is an automated message from the Apache Git Service.
To respond to the
potiuk commented on PR #40034:
URL: https://github.com/apache/airflow/pull/40034#issuecomment-2164398685
Looks good - with one NIT - we should at least discuss if we need an index,
as per discussion in
https://lists.apache.org/thread/sg08mcdmvvtrwpd5cccpkl198do0xlc6
--
This is an
potiuk commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1637555167
##
airflow/www/static/js/dag/details/taskInstance/Details.tsx:
##
@@ -53,6 +53,7 @@ const Details = ({ gridInstance, taskInstance, group }:
Props) => {
const
potiuk commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1637555167
##
airflow/www/static/js/dag/details/taskInstance/Details.tsx:
##
@@ -53,6 +53,7 @@ const Details = ({ gridInstance, taskInstance, group }:
Props) => {
const
potiuk commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1637553183
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -5499,7 +5517,14 @@ components:
items:
type: string
description: The value can be repeated
potiuk commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1637548693
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3751,6 +3753,13 @@ components:
pid:
type: integer
nullable: true
+executor:
+
syedahsn commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1628168153
##
airflow/www/static/js/dag/details/taskInstance/Details.tsx:
##
@@ -53,6 +53,7 @@ const Details = ({ gridInstance, taskInstance, group }:
Props) => {
const
syedahsn commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1628168153
##
airflow/www/static/js/dag/details/taskInstance/Details.tsx:
##
@@ -53,6 +53,7 @@ const Details = ({ gridInstance, taskInstance, group }:
Props) => {
const
syedahsn commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1628168153
##
airflow/www/static/js/dag/details/taskInstance/Details.tsx:
##
@@ -53,6 +53,7 @@ const Details = ({ gridInstance, taskInstance, group }:
Props) => {
const
vincbeck commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1626395283
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3751,6 +3753,13 @@ components:
pid:
type: integer
nullable: true
+executor:
vincbeck commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1626395283
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3751,6 +3753,13 @@ components:
pid:
type: integer
nullable: true
+executor:
uranusjr commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1625666218
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3751,6 +3753,13 @@ components:
pid:
type: integer
nullable: true
+executor:
o-nikolas commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1625337858
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -4943,6 +4956,11 @@ components:
items:
type: string
description: The value can
o-nikolas commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1625337246
##
tests/api_connexion/endpoints/test_task_instance_endpoint.py:
##
@@ -667,6 +672,31 @@ class TestGetTaskInstances(TestTaskInstanceEndpoint):
2,
o-nikolas commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1625336137
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3751,6 +3753,13 @@ components:
pid:
type: integer
nullable: true
+executor:
shubham22 commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1625250272
##
tests/api_connexion/endpoints/test_task_instance_endpoint.py:
##
@@ -667,6 +672,31 @@ class TestGetTaskInstances(TestTaskInstanceEndpoint):
2,
o-nikolas commented on PR #40034:
URL: https://github.com/apache/airflow/pull/40034#issuecomment-2146399933
I'm not sure why some provider tests are failing around fab imports/tests. I
didn't modify anything around there. But this is my first API changes so
perhaps someone else knows?
uranusjr commented on code in PR #40034:
URL: https://github.com/apache/airflow/pull/40034#discussion_r1625209024
##
airflow/api_connexion/openapi/v1.yaml:
##
@@ -3751,6 +3753,13 @@ components:
pid:
type: integer
nullable: true
+executor:
22 matches
Mail list logo
