Taragolis opened a new pull request, #35360:
URL: https://github.com/apache/airflow/pull/35360
Make DAG as [final
classe](https://docs.python.org/3/library/typing.html#typing.final), it is just
helper decorator for static checks and IDE and could be use for inform end
users
Taragolis commented on PR #35360:
URL: https://github.com/apache/airflow/pull/35360#issuecomment-1789693925
A SerializedDAG 🙄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Taragolis commented on PR #35360:
URL: https://github.com/apache/airflow/pull/35360#issuecomment-1789695369
Better luck next time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Taragolis closed pull request #35360: Add `@final` decorator to DAG class
URL: https://github.com/apache/airflow/pull/35360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
Taragolis commented on PR #35360:
URL: https://github.com/apache/airflow/pull/35360#issuecomment-1789716824
> This is a breaking change where it could fail the Mypy test for the users
who already subclass the DAG class.
Not sure that static check could be counted as breaking change, r
potiuk commented on PR #35360:
URL: https://github.com/apache/airflow/pull/35360#issuecomment-1789737980
See my follow-up in
https://github.com/apache/airflow/discussions/31974#discussioncomment-6203057
My point is not that DAG should be final, but when you extend it you need to
unde