eladkal merged PR #35397:
URL: https://github.com/apache/airflow/pull/35397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
pubudu91 commented on PR #35397:
URL: https://github.com/apache/airflow/pull/35397#issuecomment-1811777632
A kind reminder on this. Are we good to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pubudu91 commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1388950665
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation (A
eladkal commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1388924796
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation (AS
eladkal commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1388924796
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation (AS
Taragolis commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1385706929
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation (
pubudu91 commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1384405364
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation (A
eladkal commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1384389827
##
docs/apache-airflow-providers-atlassian-jira/notifications/jira-notifier-howto-guide.rst:
##
@@ -0,0 +1,65 @@
+
+ .. Licensed to the Apache Software Foundation (AS
Taragolis commented on PR #35397:
URL: https://github.com/apache/airflow/pull/35397#issuecomment-1793866976
> the left navigation the version says 2.2.0?
That is provider version. Providers release cycle are different then Airflow
itself
--
This is an automated message from the Ap
pubudu91 commented on PR #35397:
URL: https://github.com/apache/airflow/pull/35397#issuecomment-1793790042
Locally built docs:
![image](https://github.com/apache/airflow/assets/6260009/4e5e4bab-350a-4b6c-ad23-f9dc4aa59cba)
![image](https://github.com/apache/airflow/assets/6260009/edfe
pubudu91 commented on PR #35397:
URL: https://github.com/apache/airflow/pull/35397#issuecomment-1793782902
> Some NIT which might make it better
>
> In general looks good, also check documentation locally
Built and checked the new docs locally. There weren't any issues. Will che
pubudu91 commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1382605196
##
airflow/providers/atlassian/jira/notifications/jira.py:
##
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
Taragolis commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1382547115
##
airflow/providers/atlassian/jira/notifications/jira.py:
##
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
Taragolis commented on PR #35397:
URL: https://github.com/apache/airflow/pull/35397#issuecomment-1793580399
Documentation should be pretty simple: copy from one of existed provider,
replace by new example (you have in description of PR), change reference to the
Notifier classes, build it lo
pubudu91 commented on PR #35397:
URL: https://github.com/apache/airflow/pull/35397#issuecomment-1793318243
@Taragolis Addressed the above mentioned suggestions. Still working on the
tests and the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message
Taragolis commented on code in PR #35397:
URL: https://github.com/apache/airflow/pull/35397#discussion_r1381531187
##
airflow/providers/atlassian/jira/notifications/jira.py:
##
@@ -0,0 +1,80 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
pubudu91 opened a new pull request, #35397:
URL: https://github.com/apache/airflow/pull/35397
Fixes #35261
Sample usage:
```python
from datetime import datetime
from airflow import DAG
from airflow.operators.bash import BashOperator
from airflow.provider
17 matches
Mail list logo