hduong-mwam opened a new pull request, #35719:
URL: https://github.com/apache/airflow/pull/35719
related: [26905](https://github.com/apache/airflow/issues/26905)
## Overview
Added XCom tab on Grid view which uses the XCom
[endpoints](https://airflow.apache.org/d
boring-cyborg[bot] commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1817495016
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1399254518
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -138,6 +146,7 @@ const Details = ({
const isGroupOrMappedTaskSummary = isGroup || isMappedTaskSummary;
co
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1399260330
##
airflow/www/static/js/dag/details/taskInstance/Xcom/XcomEntry.tsx:
##
@@ -0,0 +1,82 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
bbovenzi commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1819150225
Thanks so much for doing it. I just have a few comments, but overall looks
good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1399266549
##
airflow/www/static/js/dag/details/taskInstance/Xcom/index.tsx:
##
@@ -0,0 +1,110 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1399502342
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -138,6 +146,7 @@ const Details = ({
const isGroupOrMappedTaskSummary = isGroup || isMappedTaskSummary;
bbovenzi commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1819952836
> I really _love_ the UI changes gradually migrating from legacy to new.
>
> When I tested locally I saw still the old link pointing to the old XCom
page in the second row of Tas
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1405478899
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -138,6 +146,7 @@ const Details = ({
const isGroupOrMappedTaskSummary = isGroup || isMappedTaskSummary;
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1405479106
##
airflow/www/static/js/dag/details/taskInstance/Xcom/index.tsx:
##
@@ -0,0 +1,110 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
hduong-mwam commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1826912752
> I really _love_ the UI changes gradually migrating from legacy to new.
>
> When I tested locally I saw still the old link pointing to the old XCom
page in the second row of
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1405490868
##
airflow/www/static/js/dag/details/taskInstance/Xcom/XcomEntry.tsx:
##
@@ -0,0 +1,82 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
jscheffl commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1826935842
> > I really _love_ the UI changes gradually migrating from legacy to new.
> > When I tested locally I saw still the old link pointing to the old XCom
page in the second row of Task
bbovenzi commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1828073276
We can keep the old xcom page for now. I think we can have separate PRs to
update the grid task instance details to match the legacy page and then add a
rendered template tab. Once we
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1406357926
##
airflow/www/static/js/dag/details/taskInstance/Xcom/XcomEntry.tsx:
##
@@ -0,0 +1,82 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1406374935
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -136,7 +144,11 @@ const Details = ({
const isMappedTaskSummary = isMapped && mapIndex === undefined && taskI
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1406374935
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -136,7 +144,11 @@ const Details = ({
const isMappedTaskSummary = isMapped && mapIndex === undefined && taskI
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1406380334
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -136,7 +144,11 @@ const Details = ({
const isMappedTaskSummary = isMapped && mapIndex === undefined && taskI
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1406380985
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -336,6 +362,17 @@ const Details = ({
/>
)}
+ {showXcom && run
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1412785989
##
airflow/www/static/js/dag/details/index.tsx:
##
@@ -136,7 +144,11 @@ const Details = ({
const isMappedTaskSummary = isMapped && mapIndex === undefined && ta
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1412787254
##
airflow/www/static/js/dag/details/taskInstance/Xcom/XcomEntry.tsx:
##
@@ -0,0 +1,82 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
bbovenzi commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1414070730
##
airflow/www/static/js/dag/details/taskInstance/Xcom/XcomEntry.tsx:
##
@@ -0,0 +1,82 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
bbovenzi merged PR #35719:
URL: https://github.com/apache/airflow/pull/35719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow
boring-cyborg[bot] commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1838949814
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
hduong-mwam commented on code in PR #35719:
URL: https://github.com/apache/airflow/pull/35719#discussion_r1414133575
##
airflow/www/static/js/dag/details/taskInstance/Xcom/XcomEntry.tsx:
##
@@ -0,0 +1,82 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
hduong-mwam commented on PR #35719:
URL: https://github.com/apache/airflow/pull/35719#issuecomment-1838972624
Thank you for approving and merging. It is my first PR so I am very grateful
for the comments and the warm reception. Was a blast working on the PR, can't
wait for it to be in the n
26 matches
Mail list logo
