[PR] Add a fuzzy match for metric allow and block list [airflow]

2023-12-15 Thread via GitHub
ferruzzi opened a new pull request, #36250: URL: https://github.com/apache/airflow/pull/36250 Current metric allow and block lists allow the user to set which metric names to emit, but they only match on `startswith()`. This PR adds two new Validators - FuzzyAllow and FuzzyBlock, which mat

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2023-12-15 Thread via GitHub
shubham22 commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1428627753 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opt

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2023-12-15 Thread via GitHub
shubham22 commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1428629011 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opt

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2023-12-16 Thread via GitHub
hussein-awala commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1428787680 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings.

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2023-12-18 Thread via GitHub
ferruzzi commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1430777847 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opti

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2023-12-19 Thread via GitHub
ferruzzi commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1431749360 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opti

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2023-12-19 Thread via GitHub
ferruzzi commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1430777847 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opti

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2024-01-02 Thread via GitHub
shubham22 commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1439775839 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opt

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2024-01-08 Thread via GitHub
o-nikolas commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1445117071 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opt

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2024-01-08 Thread via GitHub
ferruzzi commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1445258589 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opti

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2024-01-08 Thread via GitHub
o-nikolas commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1445439794 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opt

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2024-01-11 Thread via GitHub
ferruzzi commented on PR #36250: URL: https://github.com/apache/airflow/pull/36250#issuecomment-1887938252 Alright, based on feedback above, I am going to add a warning (once on launch) if `metrics_use_fuzzy_match` is false stating that the basic matching will be deprecated in the future an

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2024-01-11 Thread via GitHub
ferruzzi commented on code in PR #36250: URL: https://github.com/apache/airflow/pull/36250#discussion_r1449533923 ## airflow/config_templates/config.yml: ## @@ -944,6 +944,14 @@ metrics: description: | StatsD (https://github.com/etsy/statsd) integration settings. opti

Re: [PR] Add a fuzzy match for metric allow and block list [airflow]

2024-01-11 Thread via GitHub
ferruzzi commented on PR #36250: URL: https://github.com/apache/airflow/pull/36250#issuecomment-1888134215 Slight git goof, sorry for the rebase and force push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a