vincbeck opened a new pull request, #34786:
URL: https://github.com/apache/airflow/pull/34786
See [comment
thread](https://github.com/apache/airflow/pull/33213#discussion_r1343788762).
`has_access` decorator seems to be used by many plugins. Hence, in order to
avoid breaking them. Ad
jens-scheffler-bosch commented on code in PR #34786:
URL: https://github.com/apache/airflow/pull/34786#discussion_r1349770592
##
airflow/www/auth.py:
##
@@ -44,6 +46,27 @@ def get_access_denied_message():
return conf.get("webserver", "access_denied_message")
+def has_ac
jens-scheffler-bosch commented on code in PR #34786:
URL: https://github.com/apache/airflow/pull/34786#discussion_r1349771522
##
airflow/www/auth.py:
##
@@ -44,6 +46,27 @@ def get_access_denied_message():
return conf.get("webserver", "access_denied_message")
+def has_ac
vincbeck commented on code in PR #34786:
URL: https://github.com/apache/airflow/pull/34786#discussion_r1352934435
##
airflow/www/auth.py:
##
@@ -44,6 +46,27 @@ def get_access_denied_message():
return conf.get("webserver", "access_denied_message")
+def has_access(permiss
vincbeck commented on code in PR #34786:
URL: https://github.com/apache/airflow/pull/34786#discussion_r1352939249
##
airflow/www/auth.py:
##
@@ -44,6 +46,27 @@ def get_access_denied_message():
return conf.get("webserver", "access_denied_message")
+def has_access(permiss
vincbeck commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1755910306
> What I did not fully get with the new API methods are, these are specific
to the UI areas. If I add a `MyPlugin` then I would need to add a
`has_access_my_plugin()` decorator, the on
jens-scheffler-bosch commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1755949965
> > So besides public API would be good to add some hints into the plugin
authoring docs - If you don't want to raise a PR I could if you help me in
understanding.
>
vincbeck commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1756037969
@utkarsharma2, @ashb, @hussein-awala Any comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
utkarsharma2 commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1756075151
@vincbeck Thanks for adding it back :) changes look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
potiuk merged PR #34786:
URL: https://github.com/apache/airflow/pull/34786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
ashb commented on code in PR #34786:
URL: https://github.com/apache/airflow/pull/34786#discussion_r1347908652
##
airflow/www/auth.py:
##
@@ -44,6 +46,25 @@ def get_access_denied_message():
return conf.get("webserver", "access_denied_message")
+def has_access(permissions
utkarsharma2 commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1749572624
@vincbeck @ashb Should we also update the [public interface
document](https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html)?
Maybe as a separate PR?
hussein-awala commented on code in PR #34786:
URL: https://github.com/apache/airflow/pull/34786#discussion_r1347951190
##
airflow/auth/managers/fab/decorators/auth.py:
##
@@ -0,0 +1,89 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lic
vincbeck commented on code in PR #34786:
URL: https://github.com/apache/airflow/pull/34786#discussion_r1347954018
##
airflow/www/auth.py:
##
@@ -44,6 +46,25 @@ def get_access_denied_message():
return conf.get("webserver", "access_denied_message")
+def has_access(permiss
vincbeck commented on code in PR #34786:
URL: https://github.com/apache/airflow/pull/34786#discussion_r1347955338
##
airflow/auth/managers/fab/decorators/auth.py:
##
@@ -0,0 +1,89 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
vincbeck commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1749629977
> @vincbeck @ashb Should we also update the [public interface
document](https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html)
to include `has_access`? Ma
hussein-awala commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1749636013
> > @vincbeck @ashb Should we also update the [public interface
document](https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html)
to include `has_acce
vincbeck commented on PR #34786:
URL: https://github.com/apache/airflow/pull/34786#issuecomment-1750735846
> > > @vincbeck @ashb Should we also update the [public interface
document](https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html)
to include `has_access`
18 matches
Mail list logo
