[PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

karakanb opened a new pull request, #36630: URL: https://github.com/apache/airflow/pull/36630 This PR introduces two new variables in the DAGRun create API endpoint to enable creating runs that cover a specific span. This allows triggering runs that span multiple interfaces in case of backf

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

pankajastro commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1443739164 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -319,11 +320,38 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

karakanb commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1444299962 ## tests/api_connexion/endpoints/test_dag_run_endpoint.py: ## @@ -1076,32 +1076,62 @@ def test_end_date_gte_lte(self, payload, expected_dag_run_ids): class TestPos

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

karakanb commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1444302507 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -319,11 +320,38 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

uranusjr commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1446939845 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -319,11 +320,34 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

karakanb commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1447391125 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -319,11 +320,34 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

jscheffl commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1451457407 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -319,11 +320,34 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

karakanb commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1451569366 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -319,11 +320,34 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

uranusjr commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1451981136 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -319,11 +320,34 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

karakanb commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1460516288 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -319,11 +320,34 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

uranusjr commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1462835969 ## airflow/api_connexion/schemas/dag_run_schema.py: ## @@ -121,6 +121,18 @@ def autofill(self, data, **kwargs): return ret_data +@validates_schema +

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

uranusjr commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1462839478 ## airflow/api_connexion/schemas/dag_run_schema.py: ## @@ -121,6 +121,18 @@ def autofill(self, data, **kwargs): return ret_data +@validates_schema +

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

uranusjr commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1462840871 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -336,11 +337,21 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

uranusjr commented on code in PR #36630: URL: https://github.com/apache/airflow/pull/36630#discussion_r1462840871 ## airflow/api_connexion/endpoints/dag_run_endpoint.py: ## @@ -336,11 +337,21 @@ def post_dag_run(*, dag_id: str, session: Session = NEW_SESSION) -> APIResponse:

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

uranusjr commented on PR #36630: URL: https://github.com/apache/airflow/pull/36630#issuecomment-1905466939 Some minor suggestions, the overall logic looks good to me. Test code needs some cleanup, and a rebase is also needed. -- This is an automated message from the Apache Git Service. To

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

karakanb commented on PR #36630: URL: https://github.com/apache/airflow/pull/36630#issuecomment-1905852345 @uranusjr addressed all of them, could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add data_interval_start and data_interval_end in dagrun create API endpoint [airflow]

potiuk merged PR #36630: URL: https://github.com/apache/airflow/pull/36630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a