Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-05-31 Thread via GitHub
Xiroo closed pull request #34715: Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger URL: https://github.com/apache/airflow/pull/34715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-05-31 Thread via GitHub
Xiroo commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2141315700 There has been no feedback or response for several weeks. Therefore, I will close this PR. This content may be addressed in a different PR. Thank you. -- This is an automated

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-04-22 Thread via GitHub
Xiroo commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2068677298 @hussein-awala Hello, I hope this message finds you well. I wanted to follow up regarding the pull request I submitted. It has been a few weeks since I last mentioned it, and I

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-04-01 Thread via GitHub
Xiroo commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2031097434 @hussein-awala Hello, I hope this message finds you well. I understand you have a busy schedule, and I just wanted to gently remind you about the review of my pull request. You

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-03-30 Thread via GitHub
hussein-awala commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2028424604 > @hussein-awala > > Hello, I'm waiting for your answer. > > Could you recommend how to deal with this? > > Or If this issue is resolved by other PR, let me

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-03-30 Thread via GitHub
Xiroo commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2027940307 @hussein-awala Hello, I'm waiting for your answer. Can you recommend how to deal with this? Or If this issue is resolved by other PR, let me know if I can close this PR. --

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-03-19 Thread via GitHub
Xiroo commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-2007580451 @hussein-awala From the behavior you mentioned, it seems that whether I use execution_timeout or timeout to set _timeout_sec, they both lead to the same termination conditions.

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2024-01-11 Thread via GitHub
nathadfield commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-1886952539 This might be slightly off topic for this PR but, when talking about the behaviour of sensors in general, I feel like there's a discrepancy between what a timeout does in normal

Re: [PR] Add deferrable_timeout to inntialize _timeout_sec of TaskStateTrigger [airflow]

2023-12-06 Thread via GitHub
itstalmeez commented on PR #34715: URL: https://github.com/apache/airflow/pull/34715#issuecomment-1843640604 Implemented execution_timeout in place of a fixed 60-second timeout (self._timeout_sec) for checking dag run existence in the ExternalTaskSensor. The previous fixed timeout caused