Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1397907473 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1397908394 ## tests/providers/amazon/aws/operators/test_emr_serverless.py: ## Review Comment: Yea, adding some tests for the branching logic would be nice. It gets a little

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1400966603 ## tests/providers/amazon/aws/operators/test_emr_serverless.py: ## Review Comment: Fair, so just to be clear are you planning to add some or is this PR reading

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1401403023 ## tests/providers/amazon/aws/operators/test_emr_serverless.py: ## Review Comment: Planning to add some. Just need to figure that out. :) -- This is an autom

Re: [PR] Add extra operator links for EMR Serverless [airflow]

github-actions[bot] commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1879887804 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1881910404 Hey @dacort, this one looks like it was close but is getting marked as stale. Do you still have time to finish it off? -- This is an automated message from the Apache Git Service. T

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1881911573 Yes, let me try to resolve existing conflicts and get it over the finish line. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1445426340 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1446763520 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1447874021 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1447950174 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1448028145 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1449197109 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1449340179 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1449589393 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1450895098 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1896255911 > How does this work in deferrable mode? `persist_links` is called before the `self.defer` call is triggered for `EmrServerlessStartJobTrigger`. I'm not too familiar with deferrabl

Re: [PR] Add extra operator links for EMR Serverless [airflow]

eladkal commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1901153627 @dacort @o-nikolas is anything else needed or can we merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1904461267 > @dacort @o-nikolas is anything else needed or can we merge this PR? @eladkal, the last remaining item is adding some unit testing for this code (thread [here](https://github.

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1904494351 > adding some unit testing ack - will see if I can get that pushed up today! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1904648643 @eladkal @o-nikolas Added some additional unit tests to cover the various cases and merge in latest main. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1904864765 > Several of the DB tests are failing, but seem unrelated to my changes. Main is broken right now, you'll at least need to wait for [this PR](https://github.com/apache/airflow/p

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1905137328 Sweet, rebased and all checks have passed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1465379421 ## tests/providers/amazon/aws/operators/test_emr_serverless.py: ## Review Comment: tests were added -- This is an automated message from the Apache Git Ser

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1465381768 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -1352,6 +1391,101 @@ def on_kill(self) -> None: check_interval_seconds=self.waiter_delay,

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1908698764 Only one conversation left open that needs resolution and then I think we're ready to merge! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Add extra operator links for EMR Serverless [airflow]

eladkal commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1484602843 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -1352,6 +1391,101 @@ def on_kill(self) -> None: check_interval_seconds=self.waiter_delay,

Re: [PR] Add extra operator links for EMR Serverless [airflow]

eladkal commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1485030295 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -1352,6 +1391,101 @@ def on_kill(self) -> None: check_interval_seconds=self.waiter_delay,

Re: [PR] Add extra operator links for EMR Serverless [airflow]

eladkal commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1936951698 @dacort can you rebase and resolve conflicts? I'll merge after -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Add extra operator links for EMR Serverless [airflow]

eladkal commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1938167893 @dacort static checks are failing due to adding D401 validation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1938822867 @eladkal Ah, thank you, had missed that failure reason. Will get that addressed today! -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Add extra operator links for EMR Serverless [airflow]

Taragolis commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486613157 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"]

Re: [PR] Add extra operator links for EMR Serverless [airflow]

Taragolis commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486618553 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"]

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486626608 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486816359 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486816359 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486944603 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

Taragolis commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486953910 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"]

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486955811 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

Taragolis commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1486962552 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"]

Re: [PR] Add extra operator links for EMR Serverless [airflow]

Taragolis commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1487018557 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,111 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"]

Re: [PR] Add extra operator links for EMR Serverless [airflow]

Taragolis merged PR #34225: URL: https://github.com/apache/airflow/pull/34225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

Re: [PR] Add extra operator links for EMR Serverless [airflow]

eladkal commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1776568909 @dacort are you still working on it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1777400410 @eladkal Yes, let me check out the failing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on PR #34225: URL: https://github.com/apache/airflow/pull/34225#issuecomment-1777496523 @eladkal Ah yes, that's right, I was trying to figure out a better way to pass the operator in, but I think I'll just pass in the `aws_conn_id` as a string instead. -- This is an auto

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1370895671 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +81,100 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

Taragolis commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1371397419 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1371855339 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1371857665 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -1173,13 +1184,35 @@ class EmrServerlessStartJobOperator(BaseOperator): "execution_role_arn",

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1371859865 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -1352,6 +1391,101 @@ def on_kill(self) -> None: check_interval_seconds=self.waiter_delay,

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1371878861 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1377947406 ## airflow/providers/amazon/aws/operators/emr.py: ## @@ -1173,13 +1184,35 @@ class EmrServerlessStartJobOperator(BaseOperator): "execution_role_arn",

Re: [PR] Add extra operator links for EMR Serverless [airflow]

o-nikolas commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1378208805 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1379221966 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])

Re: [PR] Add extra operator links for EMR Serverless [airflow]

dacort commented on code in PR #34225: URL: https://github.com/apache/airflow/pull/34225#discussion_r1379278127 ## airflow/providers/amazon/aws/links/emr.py: ## @@ -66,3 +82,98 @@ def get_log_uri( return None log_uri = S3Hook.parse_s3_url(cluster_info["LogUri"])