github-actions[bot] closed pull request #34735: Add k8s recommended labels
URL: https://github.com/apache/airflow/pull/34735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-2027836374
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1924928004
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1858993645
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1788933112
> > I think you should also have to consider `Label selectors`.
>
> This means replacing the previous labels with the K8S recommended labels
in `label selector`s. There may
kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1784790148
> I think you should also have to consider Label selectors.
This means replacing the previous labels with the K8S recommended labels in
label selectors.
There may be proble
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1783689269
> I think you should also have to consider `Label selectors`.
You mean add the newly created labels inside `label selector` ? I think
`label selector` should continue to wor
kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1783677924
I think you should also have to consider Label selectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1782188337
@jedcunningham @hussein-awala Can I seek your feedback for this PR also ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1773860191
I've applied the fix here to truncate `airflow.fullname` to return at most
40 chars.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1772292764
If airflow.fullname is longer than 63 chars, then
app.kubernetes.io/name is longer than 63 chars.
(For example, {{ include "airflow.fullname" . }}-dag-processor
should not longer
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1768322831
Thanks @kimminw00. Yes it makes sense to me. Different apps should have
different names for differentiation. I've customized the yaml files to have
different `app.kubernetes.io/na
kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1763290879
Prometheus and alertmanager are different apps. So they have different
app.kubernetes.io/name
https://github.com/prometheus-community/helm-charts/blob/f57ff6651817b23c21daa7d5c
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1755387465
Hi @kimminw00, thank you for your comments. I've gone through the Prometheus
helm chart as you suggested. While I tried to grasp the key points, I'm keen to
ensure I address your
kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1753271296
And please take a close look at how each object(secret, pv, ingress etc.) is
labeled in prometheus helm chart.
--
This is an automated message from the Apache Git Service.
To respon
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1753105429
@kimminw00 Thanks. I've examined the 6 k8s recommended labels in the
prometheus chart and I find that there's a difference for the labels
`app.kubernetes.io/name` and `app.kuberne
kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1752000485
I think it would be helpful to refer to the prometheus helm chart.
https://github.com/prometheus-community/helm-charts/blob/f57ff6651817b23c21daa7d5cd087649add5836e/charts/prome
Owen-CH-Leung commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1749902752
> I think it is necessary to differentiate `app.kubernetes.io/name` of each
object.
How about we name each resource like `airflow-{name of the component}-{type
of the resou
kimminw00 commented on PR #34735:
URL: https://github.com/apache/airflow/pull/34735#issuecomment-1749085126
I think it is necessary to differentiate app.kubernetes.io/name
of each object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Owen-CH-Leung opened a new pull request, #34735:
URL: https://github.com/apache/airflow/pull/34735
fixes #34048
As per the discussion, this PR modifes all existing yaml files inside
airflow helm chart to include the recommended k8s labels. See
[this](https://kubernetes.io/docs/conce
20 matches
Mail list logo