Taragolis merged PR #35091:
URL: https://github.com/apache/airflow/pull/35091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
boring-cyborg[bot] commented on PR #35091:
URL: https://github.com/apache/airflow/pull/35091#issuecomment-1814113925
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional
ambika-garg commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1391462983
##
airflow/providers/microsoft/azure/hooks/synapse_pipeline.py:
##
Review Comment:
I went through the #20139 , understood the general protocols followed in
eladkal commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1391424179
##
airflow/providers/microsoft/azure/hooks/synapse_pipeline.py:
##
Review Comment:
In Airflow we use [mixed governance model for
ambika-garg commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1390604894
##
airflow/providers/microsoft/azure/hooks/synapse_pipeline.py:
##
Review Comment:
My motivation is to keep code modular and easy to maintain. The
eladkal commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1390493251
##
airflow/providers/microsoft/azure/hooks/synapse_pipeline.py:
##
Review Comment:
What is the motivation for a new file?
can't the hook be in the existed
Taragolis commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1390385985
##
tests/providers/microsoft/azure/hooks/test_azure_synapse_pipeline.py:
##
Review Comment:
Need to rename this module to
utkarsharma2 commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1385006407
##
INSTALL:
##
@@ -1,3 +1,7 @@
+<<< HEAD
+<<< HEAD
Review Comment:
Same as - https://github.com/apache/airflow/pull/35091/files#r1385005407
--
utkarsharma2 commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1385005407
##
CONTRIBUTING.rst:
##
@@ -671,6 +671,7 @@ aiobotocore, airbyte, alibaba, all, all_dbs, amazon,
apache.atlas, apache.beam,
apache.drill, apache.druid,
ambika-garg commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1375530876
##
CONTRIBUTING.rst:
##
Review Comment:
Hi, after configuring git client to handle line endings, I am unable to
start Breeze, it is exists with the error
Taragolis commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1370965788
##
CONTRIBUTING.rst:
##
Review Comment:
Seems like you use Windows. As I could see there is LF (common posix line
ending character) changes to CRLF
utkarsharma2 commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1367506829
##
.pre-commit-config.yaml:
##
@@ -992,14 +992,14 @@ repos:
exclude:
utkarsharma2 commented on code in PR #35091:
URL: https://github.com/apache/airflow/pull/35091#discussion_r1367506102
##
.pre-commit-config.yaml:
##
@@ -39,7 +39,7 @@ repos:
- "--maxlevel"
- "2"
- repo: https://github.com/Lucas-C/pre-commit-hooks
-
ambika-garg opened a new pull request, #35091:
URL: https://github.com/apache/airflow/pull/35091
---
**^ Add meaningful description above**
Read the **[Pull Request
14 matches
Mail list logo
