Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-25 Thread via GitHub
uranusjr merged PR #37570: URL: https://github.com/apache/airflow/pull/37570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-25 Thread via GitHub
uranusjr commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1502109846 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { so

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-25 Thread via GitHub
uranusjr commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1502109846 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { so

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-25 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1501958196 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { sourc

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-23 Thread via GitHub
bbovenzi commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1500877439 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { so

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-23 Thread via GitHub
edumuellerFSL commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1500430412 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -301,3 +312,37 @@ def delete_dataset_queued_events( "Queue event not found", det

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1500277317 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { sourc

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1500277317 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { sourc

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1500255255 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -311,3 +323,37 @@ def delete_dataset_queued_events( "Queue event not found", detail=f"Qu

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1500254709 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -311,3 +323,37 @@ def delete_dataset_queued_events( "Queue event not found", detail=f"Qu

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
dstandish commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1499630671 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { s

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
ephraimbuddy commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1499201237 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -311,3 +323,37 @@ def delete_dataset_queued_events( "Queue event not found", deta

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1499158375 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { sourc

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1499158375 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { sourc

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1499149920 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -301,3 +312,37 @@ def delete_dataset_queued_events( "Queue event not found", detail=f"Qu

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1499134237 ## airflow/datasets/manager.py: ## @@ -72,16 +72,20 @@ def register_dataset_change( if not dataset_model: self.log.warning("DatasetModel %s not fo

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-22 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1499116204 ## tests/api_connexion/schemas/test_dataset_schema.py: ## @@ -162,6 +162,37 @@ def test_serialize(self, session): } +class TestDatasetEventCreateSchema(Tes

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1498585177 ## tests/api_connexion/schemas/test_dataset_schema.py: ## @@ -162,6 +162,37 @@ def test_serialize(self, session): } +class TestDatasetEventCreateSchema(Tes

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1498585057 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -301,3 +312,37 @@ def delete_dataset_queued_events( "Queue event not found", detail=f"Qu

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-21 Thread via GitHub
Lee-W commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1497229772 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -301,3 +312,37 @@ def delete_dataset_queued_events( "Queue event not found", detail=f"Qu

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-20 Thread via GitHub
pankajkoti commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1496979912 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -301,3 +312,37 @@ def delete_dataset_queued_events( "Queue event not found", detail

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-20 Thread via GitHub
uranusjr commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1496977576 ## tests/api_connexion/schemas/test_dataset_schema.py: ## @@ -162,6 +162,37 @@ def test_serialize(self, session): } +class TestDatasetEventCreateSchema(

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-20 Thread via GitHub
uranusjr commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1496976628 ## airflow/datasets/manager.py: ## @@ -56,8 +56,8 @@ def create_datasets(self, dataset_models: list[DatasetModel], session: Session) self.notify_datase

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-20 Thread via GitHub
uranusjr commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1496975306 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -301,3 +312,37 @@ def delete_dataset_queued_events( "Queue event not found", detail=f

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-20 Thread via GitHub
uranusjr commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1496972515 ## airflow/api_connexion/endpoints/dataset_endpoint.py: ## @@ -301,3 +312,37 @@ def delete_dataset_queued_events( "Queue event not found", detail=f

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-20 Thread via GitHub
bbovenzi commented on code in PR #37570: URL: https://github.com/apache/airflow/pull/37570#discussion_r1496548285 ## airflow/www/static/js/components/Table/Cells.tsx: ## @@ -150,6 +150,9 @@ export const TaskInstanceLink = ({ cell: { value, row } }: CellProps) => { const { so

Re: [PR] Add post endpoint for dataset events [airflow]

2024-02-20 Thread via GitHub
cmarteepants commented on PR #37570: URL: https://github.com/apache/airflow/pull/37570#issuecomment-1954979860 @Lee-W @pankajkoti -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] Add post endpoint for dataset events [airflow]

2024-02-20 Thread via GitHub
edumuellerFSL opened a new pull request, #37570: URL: https://github.com/apache/airflow/pull/37570 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.