Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-17 Thread via GitHub
Lee-W merged PR #37693: URL: https://github.com/apache/airflow/pull/37693 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-17 Thread via GitHub
e-galan commented on PR #37693: URL: https://github.com/apache/airflow/pull/37693#issuecomment-2060692451 Hi @Lee-W and @potiuk ! Could anyone merge this PR please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-16 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1567161787 ## tests/providers/google/cloud/triggers/test_dataflow.py: ## @@ -108,33 +167,569 @@ async def test_run_loop_return_failed_event(self, mock_job_status, trigger):

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-16 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1567149945 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -357,4 +500,45 @@ def poke(self, context: Context) -> bool: location=self.location, )

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-16 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1567026413 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -357,4 +500,45 @@ def poke(self, context: Context) -> bool: location=self.location,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-12 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1562813483 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -357,4 +500,45 @@ def poke(self, context: Context) -> bool: location=self.location,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-12 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1562755723 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -194,27 +246,72 @@ def poke(self, context: Context) -> bool: project_id=self.project_id,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-12 Thread via GitHub
VladaZakharova commented on PR #37693: URL: https://github.com/apache/airflow/pull/37693#issuecomment-2051361228 Hi @Lee-W @potiuk ! Can we please merge the changes? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-10 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1559455022 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -357,4 +498,45 @@ def poke(self, context: Context) -> bool: location=self.location,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-10 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1559452315 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -115,10 +124,50 @@ def poke(self, context: Context) -> bool: return False +def execute(s

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-10 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1559455629 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -276,26 +371,72 @@ def poke(self, context: Context) -> bool: location=self.location,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-10 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1559454158 ## airflow/providers/google/cloud/triggers/dataflow.py: ## @@ -142,3 +152,508 @@ def _get_async_hook(self) -> AsyncDataflowHook: impersonation_chain=self

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-10 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1559301512 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -276,26 +371,72 @@ def poke(self, context: Context) -> bool: location=self.location,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-10 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1559298831 ## airflow/providers/google/cloud/triggers/dataflow.py: ## @@ -142,3 +152,508 @@ def _get_async_hook(self) -> AsyncDataflowHook: impersonation_chain=self.i

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-09 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1557674106 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -276,26 +371,72 @@ def poke(self, context: Context) -> bool: location=self.location,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-09 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1557657222 ## airflow/providers/google/cloud/triggers/dataflow.py: ## @@ -142,3 +152,508 @@ def _get_async_hook(self) -> AsyncDataflowHook: impersonation_chain=self

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-08 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1556794107 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -194,27 +244,72 @@ def poke(self, context: Context) -> bool: project_id=self.project_id,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-08 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1556763479 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -151,12 +205,14 @@ def __init__( self, *, job_id: str, -callback: Callab

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-08 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1555475918 ## airflow/providers/google/cloud/triggers/dataflow.py: ## @@ -142,3 +152,496 @@ def _get_async_hook(self) -> AsyncDataflowHook: impersonation_chain=self

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-08 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r167629 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -115,10 +124,52 @@ def poke(self, context: Context) -> bool: return False +def execute(s

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-08 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1555475918 ## airflow/providers/google/cloud/triggers/dataflow.py: ## @@ -142,3 +152,496 @@ def _get_async_hook(self) -> AsyncDataflowHook: impersonation_chain=self

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-05 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1553622795 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -151,12 +205,14 @@ def __init__( self, *, job_id: str, -callback: Call

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-05 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1553641057 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -357,4 +500,45 @@ def poke(self, context: Context) -> bool: location=self.location,

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-05 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1553622795 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -151,12 +205,14 @@ def __init__( self, *, job_id: str, -callback: Call

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-05 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1553622795 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -151,12 +205,14 @@ def __init__( self, *, job_id: str, -callback: Call

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-05 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1553611284 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -143,6 +194,9 @@ class DataflowJobMetricsSensor(BaseSensorOperator): If set as a sequence, the i

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-04-03 Thread via GitHub
Lee-W commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1550835906 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -115,10 +124,52 @@ def poke(self, context: Context) -> bool: return False +def execute(sel

Re: [PR] Add the deferrable mode to the Dataflow sensors [airflow]

2024-03-28 Thread via GitHub
e-galan commented on code in PR #37693: URL: https://github.com/apache/airflow/pull/37693#discussion_r1542570551 ## airflow/providers/google/cloud/sensors/dataflow.py: ## @@ -275,26 +286,64 @@ def poke(self, context: Context) -> bool: location=self.location,