kajanajustin opened a new pull request, #36991:
URL: https://github.com/apache/airflow/pull/36991
Adding the ability to enable and disable the scheduler and webserver if you
just want to run workers in the install
---
**^ Add meaningful description above**
Re
boring-cyborg[bot] commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1907375420
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
potiuk commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1907880496
I am not sure we want it. If you reallly want to do worker-only deployment,
you should create your own helm/resources -that will be way simpler and our
chart is not meant to be as versat
jedcunningham commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908397607
@potiuk I've actually come around to this idea over time. You can sorta do
it today with scaling those components to 0, but you end up with all that stuff
in k8s anyways. Plus it
potiuk commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908412000
> @potiuk I've actually come around to this idea over time. You can sorta do
it today with scaling those components to 0, but you end up with all that stuff
in k8s anyways. Plus it also
jedcunningham commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908415574
We also need test coverage for this 👍.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kajanajustin commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908729539
@potiuk @jedcunningham Let me know what you guys think about the doc edits I
made. Let me know if I need to add any additional descriptions
--
This is an automated message from t
potiuk commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908762897
Minimal, but good enough for me :) . Still a few tests would be needed to
approve that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
kajanajustin commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908795831
@potiuk anything else needed from me at this time? I assume you guys have
the testing handled from here
--
This is an automated message from the Apache Git Service.
To respond to
potiuk commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908828287
> @potiuk anything else needed from me at this time? I assume you guys have
the testing handled from here
No - unit tests are always part of the PRs. We have separately run tests f
potiuk commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1908830072
also you have static checks failing and you should fix them. For that you
can take a look at this split doc in my PR
https://github.com/apache/airflow/blob/refactor-contributing-docs/con
kajanajustin commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1910575820
@hussein-awala how do we go about testing that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
potiuk commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1910602151
> No - unit tests are always part of the PRs. We have separately run tests
for the helm chart in `helm_tests` folder which are basically testing that when
you set the right parameter, th
kajanajustin commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1911437953
@hussein-awala @potiuk added additional unit tests, let me know if there's
anything else you guys need to see
--
This is an automated message from the Apache Git Service.
To resp
kajanajustin commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1915007044
@potiuk static checks and the test_can_be_disabled for the scheduler were
failing so I added a new class for the function. Let me know if you think
everything looks good so we can
eladkal commented on code in PR #36991:
URL: https://github.com/apache/airflow/pull/36991#discussion_r1469989502
##
helm_tests/airflow_core/test_scheduler.py:
##
@@ -901,3 +902,19 @@ def test_overridden_automount_service_account_token(self):
show_only=["templates/sc
eladkal commented on code in PR #36991:
URL: https://github.com/apache/airflow/pull/36991#discussion_r1469990838
##
helm_tests/airflow_core/test_scheduler.py:
##
@@ -901,3 +902,18 @@ def test_overridden_automount_service_account_token(self):
show_only=["templates/sc
jedcunningham commented on code in PR #36991:
URL: https://github.com/apache/airflow/pull/36991#discussion_r1470539324
##
helm_tests/airflow_core/test_scheduler.py:
##
@@ -901,3 +902,19 @@ def test_overridden_automount_service_account_token(self):
show_only=["templa
amoghrajesh commented on code in PR #36991:
URL: https://github.com/apache/airflow/pull/36991#discussion_r1470577903
##
chart/templates/scheduler/scheduler-deployment.yaml:
##
@@ -20,7 +20,8 @@
## Airflow Scheduler Deployment/StatefulSet
#
jedcunningham commented on code in PR #36991:
URL: https://github.com/apache/airflow/pull/36991#discussion_r1470591576
##
chart/templates/scheduler/scheduler-deployment.yaml:
##
@@ -20,7 +20,8 @@
## Airflow Scheduler Deployment/StatefulSet
###
jedcunningham commented on code in PR #36991:
URL: https://github.com/apache/airflow/pull/36991#discussion_r1472906202
##
chart/templates/scheduler/scheduler-deployment.yaml:
##
@@ -20,7 +20,8 @@
## Airflow Scheduler Deployment/StatefulSet
###
amoghrajesh commented on code in PR #36991:
URL: https://github.com/apache/airflow/pull/36991#discussion_r1473780038
##
chart/templates/scheduler/scheduler-deployment.yaml:
##
@@ -20,7 +20,8 @@
## Airflow Scheduler Deployment/StatefulSet
#
kajanajustin commented on code in PR #36991:
URL: https://github.com/apache/airflow/pull/36991#discussion_r1473789435
##
chart/templates/scheduler/scheduler-deployment.yaml:
##
@@ -20,7 +20,8 @@
## Airflow Scheduler Deployment/StatefulSet
kajanajustin commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1921512317
@jedcunningham comment has been removed can we merge this in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kajanajustin commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1926247738
@potiuk @jedcunningham dont want this to get stale and want to use this on
the next helm chart release.
Can we merge this in? Looks like everyone has approved who had commen
potiuk merged PR #36991:
URL: https://github.com/apache/airflow/pull/36991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
boring-cyborg[bot] commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1926965199
Awesome work, congrats on your first merged pull request! You are invited to
check our [Issue Tracker](https://github.com/apache/airflow/issues) for
additional contributions.
jedcunningham commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1927260888
Thanks @kajanajustin! Congrats on your first commit 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kajanajustin commented on PR #36991:
URL: https://github.com/apache/airflow/pull/36991#issuecomment-1928072608
@jedcunningham thank you for all your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
29 matches
Mail list logo
